Jump to content
  • Checkout
  • Login
  • Get in touch

osCommerce

The e-commerce.

douglaswalker

Members
  • Posts

    446
  • Joined

  • Last visited

  • Days Won

    7

Everything posted by douglaswalker

  1. @BrockleyJohn Doh... yes of course.. anyway they are creating correctly I just checked,,, also now not getting the CHARSET error.. but the error below is still there when using afterpay and afterpay then returns the customer to the site after payment ..successful or otherwise... that error has always been there and is not to do with the php version... ahh sigh... This is the line in the seo class function InsertID() { return mysqli_insert_id($this->link_id); } PHP Warning: mysqli_insert_id() expects parameter 1 to be mysqli, null given
  2. Hi there... yes the urls are all being created perfectly elsewhere with the cache either on or off and i get no errors unless one of the payment modules are called I did wonder why the seo class was being called on the checkout pages as it is not needed there . I wondered like a module if there was a way to turn it off for those pages.
  3. @ecartz @Jack_mcsIt is still in my installation but as a define not a const ...can that be the issue? the only other one is also to do with a payment module when it calls back to the site. These are the only 2 warnings I now receive on php7.3 and both involve the seo.class.php The payment modules all work correctly so it is more something i am interested to find out why the mysqli warning happen. I have discovered it has always been there with the particular payment module and i just picked it up during the upgrade. PHP Warning: mysqli_insert_id() expects parameter 1 to be mysqli, null given in /home/***/public_html/includes/classes/seo.class.php on line 147
  4. Hi @Jack_mcs I have recently upgraded a bootstrap Gold/Frozen/Edge site to php 7.3 all is functioning well. I do however get a few warnings about the seo.class.php. Seems mostly to happen during checkout.. which is interesting because seo urls are not used during the checkout but I guess the class is still be called. Anyway the warning is Use of undefined constant CHARSET - assumed 'CHARSET' (this will throw an Error in a future version of PHP) in /home/woodtoys/public_html/includes/classes/seo.class.php on line 1831 I know this is not a big deal but would like to know what the issue might be. Doug
  5. @BrockleyJohn not sure what i am doing wrong here. I will go through the steps again and write them here to see if anyone can spot the issue https://www.site.com.au/product_info.php?cPath=28& &(space here)products_id=71 is a link that google has picked up somewhere on the web. It has a space wrongly placed between cPath=28&(space here) products_id=71 This is creating the page to fail and try to redirect over and over. It ultimately needs to go to https://www.mysite.com.au/product-product--toy-p-71.html once it has passed through SEO urls program So I am trying to strip the space out of cPath=28&(space here) products_id=71 using htaccess RewriteRule ^([^\s%20]*)(?:\s|%20)+(.*)$ $1$2 [L,R] then send it on its way. However the htaccess is not working
  6. The htaccecss file works for urls like https://www.site.com/name-of-product(accidentalspace)-p-1000.html but not https://www.site.com/product_info?cPath=28&(spaceishere)products_id=1000 I thought it should remove the incorrect space and then the program takes over and redirects to the properly formed url
  7. The htaccess bit I couldnt get to work. i placed it above all the other code. It goes to page not working. could it be this bit as i don't want to add just remove # replace spaces by - in between RewriteRule ^([^\s%20]*)(?:\s|%20)+(.*)$ $1-$2 [L,R]
  8. Thanks so much for this I re-coded the shopping cart header module using the code from the column box module so avoided sprintf public function getOutput() { GLOBAL $cart, $currencies, $PHP_SELF; $cart_contents_string = ''; if ($cart->count_contents() > 0) { $cart_contents_string = NULL; $products = $cart->get_products(); for ($i=0, $n=sizeof($products); $i<$n; $i++) { $cart_contents_string .= '<li>'; $cart_contents_string .= '<a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $products[$i]['id']) . '">'; $cart_contents_string .= $products[$i]['quantity'] . '&nbsp;x&nbsp;'; $cart_contents_string .= $products[$i]['name']; $cart_contents_string .= '</a></li>'; } } and then called <?php echo $cart_contents_string; ?> in the template file will sort out the htaccess part you have offered when the site is a bit quieter
  9. The other question I have is over the years a few people have linked to the site incorrectly leaving a white space in the url which becomes %20 is there a way to use htaccess or any other method to strip out any whitespaces before any other redirects happen. The url in question is https://www.site.com/product_info?cPath=28&(spaceishere)products_id=1000
  10. Hi there I did as suggested and the name disappeared from the drop down and was not replaced by the word test. Url was a typo but the link that currently shows is https://www.site.com.au/-p-700.html
  11. Hi there I found a curious issue when this addon is used with a navbar drop down cart in the header. The urls of the products in the cart drop down look like this https://www.site.com.au/-p-700.html instead of https://www.site.com.au/name-of-product/-p-700.html The code to create the cart in the navbar is standard <?php $products = $cart->get_products(); foreach ($products as $k => $v) { echo '<li>' . sprintf(MODULE_NAVBAR_SHOPPING_CART_PRODUCT, $v['id'], $v['quantity'], $v['name']) . '</li>'; } ?> and the language file define('MODULE_NAVBAR_SHOPPING_CART_PRODUCT', '<a href="' . tep_href_link('product_info.php', 'products_id=%s') . '">%s x %s</a>'); Just wondered why this is?
  12. I got around the checking product numbers by creating an on / off in the categories listing using this addon. https://www.oscommerce.com/forums/topic/318434-contribution-hide-categories-products/?page=1 It means I have to manually turn the category on and off but that is ok Then all I had to do was in the category class was check if the category was 1 or 0 if anyone is interested more than happy to share the code.
  13. Hi there @kymation I use you modular navigation code.. and use the simple drop down categories module. I am trying to find a way to not show a category in the drop down if there are no products in the category. I thought that the way to do this must be somewhere in the category class... Would you know how to do this (can it be done) or give me an idea of how. i know there are contributions for it but they deal with very different code. many thanks Doug
  14. Please ignore the post above @Jack_mcs solution is absolutely right. I made a mistake with the URL. Thanks all for your help
  15. @Jack_mcs I tried the above(with my site details) but it goes to a page not found.. i tried turning off your header redirect still goes to stock page not found.. reset seo cache still page not found.. It is ignoring the 301... weird
  16. @Hotclutch the redirect does not work if the product is in the database and turned off or deleted from the database. I have tested all possibilities. it just appends the product_info part to the end of the url deeply annoying
  17. @Hotclutch hi there unfortunately it results in this... name-of-product-p-40.html?products_id=33 A similar issue is here https://www.oscommerce.com/forums/topic/408028-301-redirects-and-seo-urls/ to do with category redirects
  18. Hi there in the pages part of this addon I see you can disallow a page so my question is On my site index.php is re-directed to home https://www.mysite.com.au/ index.php is in my sitemap but google rightly has chosen https://www.mysite/ as the canonical tag. Is there a way instead of having index.php in the sitemap have https://www.mysite.com.au/ or should I just add index.php to the disallow list.
  19. Hi there I am using this contribution and I am trying to 301 redirect an old product I no longer stock to a new one. like this in htaccess redirect 301 /product-p-800.html https://www.site.com/product-p-900.html however i am finding that it will not work anymore. Is there a different way i have to do a permanent redirect on a product when SEO urls is implemented or have I totally missed something
  20. @Jack_Mcs thank-you that certainly worked. Should I also place cpath lowercase for google to ignore?
  21. Hi there I tried the above in application top and then tested the incorrect link eg cpath instead of cPath I still just got the page trying to redirect and finally fail.
  22. @Jack_mcs thank-you so would i just add cpath I can see in the console that cPath is already listed as not changing content (this was google that put that there not me) There are warnings everywhere about changing things How would i do this @BrockleyJohn Do you mean you are working out a way to stop the issue Really appreciate all the help guys
×
×
  • Create New...