Jump to content

douglaswalker

Members
  • Content count

    439
  • Joined

  • Last visited

  • Days Won

    7

douglaswalker last won the day on July 21

douglaswalker had the most liked content!

2 Followers

About douglaswalker

  • Birthday 04/30/1967

Profile Information

  • Real Name
    Doug
  • Gender
    Male
  • Location
    Western Australia

Recent Profile Visitors

18,030 profile views
  1. douglaswalker

    adding Url parameters and the Oscid

    Hi there Sorry I did not explain it very well I pass this URL https://www.asite.com.au/aurl.html?review=review This works fine and as expected but if the page load is the first in a session then the Oscid is added and the url doesn't work. I need to know how to code it so it will handle the Oscid if it is the first page load
  2. douglaswalker

    adding Url parameters and the Oscid

    Hi there doing some work on my site and want to pass a parameter in the URL ?review=review or something like that. When some one clicks from a product review link the URL parameter is present and links to the product page.,. I can then manipulate the product page to show reviews at the top etc . I am just playing around seeing what is possible and having some fun with it. I can pass the parameter no problem and is all works however I am running into an issue with the Oscid if it is present then everything screws up. Is there a way to code this so if the link is clicked and the Oscid is present then we get something like https://www.url?Oscid&review=review or even if the Oscid is present don't add the review parameter. All help very greatfully appreciated.
  3. douglaswalker

    [CONTRIBUTION] Ultimate SEO URLs v2.1 - by Chemo

    @BrockleyJohn Doh... yes of course.. anyway they are creating correctly I just checked,,, also now not getting the CHARSET error.. but the error below is still there when using afterpay and afterpay then returns the customer to the site after payment ..successful or otherwise... that error has always been there and is not to do with the php version... ahh sigh... This is the line in the seo class function InsertID() { return mysqli_insert_id($this->link_id); } PHP Warning: mysqli_insert_id() expects parameter 1 to be mysqli, null given
  4. douglaswalker

    [CONTRIBUTION] Ultimate SEO URLs v2.1 - by Chemo

    Hi there... yes the urls are all being created perfectly elsewhere with the cache either on or off and i get no errors unless one of the payment modules are called I did wonder why the seo class was being called on the checkout pages as it is not needed there . I wondered like a module if there was a way to turn it off for those pages.
  5. douglaswalker

    [CONTRIBUTION] Ultimate SEO URLs v2.1 - by Chemo

    @ecartz @Jack_mcsIt is still in my installation but as a define not a const ...can that be the issue? the only other one is also to do with a payment module when it calls back to the site. These are the only 2 warnings I now receive on php7.3 and both involve the seo.class.php The payment modules all work correctly so it is more something i am interested to find out why the mysqli warning happen. I have discovered it has always been there with the particular payment module and i just picked it up during the upgrade. PHP Warning: mysqli_insert_id() expects parameter 1 to be mysqli, null given in /home/***/public_html/includes/classes/seo.class.php on line 147
  6. douglaswalker

    [CONTRIBUTION] Ultimate SEO URLs v2.1 - by Chemo

    Hi @Jack_mcs I have recently upgraded a bootstrap Gold/Frozen/Edge site to php 7.3 all is functioning well. I do however get a few warnings about the seo.class.php. Seems mostly to happen during checkout.. which is interesting because seo urls are not used during the checkout but I guess the class is still be called. Anyway the warning is Use of undefined constant CHARSET - assumed 'CHARSET' (this will throw an Error in a future version of PHP) in /home/woodtoys/public_html/includes/classes/seo.class.php on line 1831 I know this is not a big deal but would like to know what the issue might be. Doug
  7. douglaswalker

    [CONTRIBUTION] Ultimate SEO URLs v2.1 - by Chemo

    Thank-you that did the trick
  8. douglaswalker

    [CONTRIBUTION] Ultimate SEO URLs v2.1 - by Chemo

    @BrockleyJohn not sure what i am doing wrong here. I will go through the steps again and write them here to see if anyone can spot the issue https://www.site.com.au/product_info.php?cPath=28& &(space here)products_id=71 is a link that google has picked up somewhere on the web. It has a space wrongly placed between cPath=28&(space here) products_id=71 This is creating the page to fail and try to redirect over and over. It ultimately needs to go to https://www.mysite.com.au/product-product--toy-p-71.html once it has passed through SEO urls program So I am trying to strip the space out of cPath=28&(space here) products_id=71 using htaccess RewriteRule ^([^\s%20]*)(?:\s|%20)+(.*)$ $1$2 [L,R] then send it on its way. However the htaccess is not working
  9. douglaswalker

    [CONTRIBUTION] Ultimate SEO URLs v2.1 - by Chemo

    The htaccecss file works for urls like https://www.site.com/name-of-product(accidentalspace)-p-1000.html but not https://www.site.com/product_info?cPath=28&(spaceishere)products_id=1000 I thought it should remove the incorrect space and then the program takes over and redirects to the properly formed url
  10. douglaswalker

    [CONTRIBUTION] Ultimate SEO URLs v2.1 - by Chemo

    The htaccess bit I couldnt get to work. i placed it above all the other code. It goes to page not working. could it be this bit as i don't want to add just remove # replace spaces by - in between RewriteRule ^([^\s%20]*)(?:\s|%20)+(.*)$ $1-$2 [L,R]
  11. douglaswalker

    [CONTRIBUTION] Ultimate SEO URLs v2.1 - by Chemo

    Thanks so much for this I re-coded the shopping cart header module using the code from the column box module so avoided sprintf public function getOutput() { GLOBAL $cart, $currencies, $PHP_SELF; $cart_contents_string = ''; if ($cart->count_contents() > 0) { $cart_contents_string = NULL; $products = $cart->get_products(); for ($i=0, $n=sizeof($products); $i<$n; $i++) { $cart_contents_string .= '<li>'; $cart_contents_string .= '<a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $products[$i]['id']) . '">'; $cart_contents_string .= $products[$i]['quantity'] . '&nbsp;x&nbsp;'; $cart_contents_string .= $products[$i]['name']; $cart_contents_string .= '</a></li>'; } } and then called <?php echo $cart_contents_string; ?> in the template file will sort out the htaccess part you have offered when the site is a bit quieter
  12. douglaswalker

    [CONTRIBUTION] Ultimate SEO URLs v2.1 - by Chemo

    The other question I have is over the years a few people have linked to the site incorrectly leaving a white space in the url which becomes %20 is there a way to use htaccess or any other method to strip out any whitespaces before any other redirects happen. The url in question is https://www.site.com/product_info?cPath=28&(spaceishere)products_id=1000
  13. douglaswalker

    [CONTRIBUTION] Ultimate SEO URLs v2.1 - by Chemo

    Hi there I did as suggested and the name disappeared from the drop down and was not replaced by the word test. Url was a typo but the link that currently shows is https://www.site.com.au/-p-700.html
  14. douglaswalker

    [CONTRIBUTION] Ultimate SEO URLs v2.1 - by Chemo

    Hi there I found a curious issue when this addon is used with a navbar drop down cart in the header. The urls of the products in the cart drop down look like this https://www.site.com.au/-p-700.html instead of https://www.site.com.au/name-of-product/-p-700.html The code to create the cart in the navbar is standard <?php $products = $cart->get_products(); foreach ($products as $k => $v) { echo '<li>' . sprintf(MODULE_NAVBAR_SHOPPING_CART_PRODUCT, $v['id'], $v['quantity'], $v['name']) . '</li>'; } ?> and the language file define('MODULE_NAVBAR_SHOPPING_CART_PRODUCT', '<a href="' . tep_href_link('product_info.php', 'products_id=%s') . '">%s x %s</a>'); Just wondered why this is?
×