Jump to content

Hotclutch

Members
  • Content count

    2,092
  • Joined

  • Last visited

  • Days Won

    11

Reputation Activity

  1. Confused
    Hotclutch reacted to Dan Cole in Google Bot reports and User Friendliness   
    Exactly!
    I think he said he installed 2.3.4 but it's a moot point.  Both are out of date and if end users don't push back and alert their ISP's nothing is likely to change.
    Dan
  2. Confused
    Hotclutch reacted to Dan Cole in Google Bot reports and User Friendliness   
    @Garret Krampe
    And be sure to read your ISP the riot act for allowing you to install a badly outdated version of osC and wasting your time.
    Dan
  3. Like
    Hotclutch reacted to JcMagpie in Google Bot reports and User Friendliness   
    😊 Simply not true and you should know this. For it to be out of date would require a more upto date official version to be available! none is, 2.3.4.1 is still the official and latest version of the software and is the version available to down load from the official osC page. I would imagine that when HPDL releases V3.0 that will become the next official version available from ISP's.
    Any change of what is offerd by ISP's will need to be driven by HDLP not we poor users. Try asking your host and see how far you get 😂 would love to know what they say.
  4. Like
    Hotclutch got a reaction from Smoky Barnable in Optional Related Products, Version 4.0   
    $optional_rel_prods_content .= ' <div class="card" itemprop="isRelatedTo" itemscope itemtype="http://schema.org/Product">'; $optional_rel_prods_content .= ' <meta itemprop="url" content="' . tep_href_link('product_info.php', 'products_id=' . $optional_rel_prods_values['pop_products_id_slave']) . '" />'; switch (MODULE_CONTENT_PRODUCT_INFO_RELATED_PRODUCTS_HEIGHT_MODE) { case 'Equal Height': $optional_rel_prods_content .= ' <div class="card-body text-center">'; break; case 'Fixed Height': $optional_rel_prods_content .= ' <div class="card" style = "height:' . MODULE_CONTENT_PRODUCT_INFO_RELATED_PRODUCTS_HEIGHT_VALUE . 'em;">'; break; case 'None': $optional_rel_prods_content .= ' <div class="card">'; break; } Can't be right.
    You already have:
    $optional_rel_prods_content .= ' <div class="card" itemprop="isRelatedTo" itemscope itemtype="http://schema.org/Product">'; then you have a case where;
    case 'None': $optional_rel_prods_content .= ' <div class="card">'; break; which means somewhere in your output you could end up with 
    <div class="card" itemprop="isRelatedTo" itemscope itemtype="http://schema.org/Product"><div class="card">
  5. Haha
    Hotclutch got a reaction from Dan Cole in Naming Convention   
    @Harald Ponce de Leon Please keep the demo product set of the 2-series in V3 - those are classic.
  6. Haha
    Hotclutch got a reaction from Dan Cole in Naming Convention   
    @Harald Ponce de Leon Please keep the demo product set of the 2-series in V3 - those are classic.
  7. Like
    Hotclutch got a reaction from valquiria23 in Osc BS Edge Product Info   
    I would change the card design. I would build the card without class="card-header" i.e only with a body and footer if necessary. You can use class="card-title" inside the body for product names if you want to. Also i would put the image first in the card, followed by the product name. Then the varying name lengths become less visible. Have a look at the other ecommerce platforms most of them do it this way
  8. Like
    Hotclutch got a reaction from JcMagpie in Official osCommerce 2.3.4.1 made responsive in 60 min using Unsemantic and w3.css   
    html_output.php
    I have not tested this, but you can try replacing tep_draw_button function
    with:
    //// // Output a jQuery UI Button function tep_draw_button($title = null, $icon = null, $link = null, $priority = null, $params = null, $style = null) { static $button_counter = 1; $types = array('submit', 'button', 'reset'); if ( !isset($params['type']) ) { $params = array('type' => ''); $params['type'] = 'submit'; } if ( !in_array($params['type'], $types) ) { $params['type'] = 'submit'; } if ( ($params['type'] == 'submit') && isset($link) ) { $params['type'] = 'button'; } if (!isset($priority)) { $priority = 'secondary'; } $button = NULL; if ( ($params['type'] == 'button') && isset($link) ) { $button .= '<a id="btn' . $button_counter . '" href="' . $link . '"'; if ( isset($params['newwindow']) ) { $button .= ' target="_blank" rel="noopener"'; } } else { $button .= '<button '; $button .= 'type="' . tep_output_string($params['type']) . '"'; } if ( isset($params['params']) ) { $button .= ' ' . $params['params']; } $button .= ' class="w3-btn '; $button .= (isset($style)) ? $style : 'w3-border w3-white'; $button .= '">'; if (isset($icon) && tep_not_null($icon)) { $button .= '<span class="' . $icon . '" aria-hidden="true"></span> '; } $button .= $title; if ( ($params['type'] == 'button') && isset($link) ) { $button .= '</a>'; } else { $button .= '</button>'; } $button_counter++; return $button; }  
  9. Like
    Hotclutch got a reaction from valquiria23 in Official osCommerce 2.3.4.1 made responsive in 60 min using Unsemantic and w3.css   
    My mistake, in the other post i did not put the <p> tags: so
    function execute() { global $PHP_SELF, $oscTemplate; if ( (substr(basename($PHP_SELF), 0, 8) != 'checkout') && tep_not_null(MODULE_BOXES_CARD_ACCEPTANCE_LOGOS) ) { $output = '<div class="w3-card w3-margin-bottom">' . ' <header class="w3-container w3-blue"><h6>' . MODULE_BOXES_CARD_ACCEPTANCE_BOX_TITLE . '</h6></header>' . ' <div class="w3-container w3-center"><p>'; foreach ( explode(';', MODULE_BOXES_CARD_ACCEPTANCE_LOGOS) as $logo ) { $output .= tep_image(DIR_WS_IMAGES . 'card_acceptance/' . basename($logo)); } $output .= ' </p></div>' . '</div>'; $oscTemplate->addBlock($output, $this->group); } }  
  10. Like
    Hotclutch got a reaction from LeeFoster in Got SSL and using HTTPS but site showing not Secure   
    fix your configure files.
  11. Like
    Hotclutch got a reaction from Smoky Barnable in Marketplace Category/Version Cleanup   
    Not bad for 30mins. W3CSS is another framework i like working with:
    https://www.w3schools.com/w3css/
    Easier to learn than Bootstrap, and much lighter, no javascript to load.
    Although BS4 is still the best option IMO.
  12. Like
    Hotclutch got a reaction from Smoky Barnable in Marketplace Category/Version Cleanup   
    Not bad for 30mins. W3CSS is another framework i like working with:
    https://www.w3schools.com/w3css/
    Easier to learn than Bootstrap, and much lighter, no javascript to load.
    Although BS4 is still the best option IMO.
  13. Sad
    Hotclutch reacted to Dan Cole in Curious find in Edge/Frozen regarding definitions   
    It would be nice to sort out any issues beforehand.
    Dan
  14. Like
    Hotclutch reacted to peterbuzzin in Curious find in Edge/Frozen regarding definitions   
    Hi,
    I've had an opportunity today to start having a look around the code (I wanted to start contributing to it at some point) and noticed that there are a lot (if not all) hardcoded table and filenames.  Is this intentional or something on the to-do list to change back to defined constants?
    If it's intentional it seems like a step backwards/devolution to me.  This question may have come up before but does anyone know the thinking/reason behind this?  I'm trying to get my head around it.  It will make table prefixes and changing filenames so difficult in the future, changing something that gave it flexibility to something inflexible.  
     
  15. Like
    Hotclutch got a reaction from Smoky Barnable in Categories different rows   
    You can also consider upgrading to the bootstrap 4 version, then there will be no need for equal height div modules.
     
  16. Like
    Hotclutch reacted to valquiria23 in Domain change, SEO and new oscommerce site version   
    Dear  @peterbuzzin,  @MrPhil , @Hotclutch  
    thank you very much for your help.
    The RewriteRule :
    RewriteEngine On 
    RewriteBase /catalog/
    RewriteRule !^admin($|/) https://www. newdomain.com%{REQUEST_URI} [L,R=301]
    did the magic impeccably.  
    The problem I had was that the other RewriteRule in the old domain (on the old hosting) they were interfering.
    I deactivate the old RewriteRule and voilà!!!
    Best regards.
    Valqui
  17. Like
    Hotclutch got a reaction from valquiria23 in Domain change, SEO and new oscommerce site version   
    so how did you put it down in htaccess that it throws the error ?
    I think it could be like this, but not 100% sure:
    RewriteEngine On RewriteBase /catalog/ RewriteRule ^(.*)-p-(.*).html$ product_info.php?products_id=$2&%{QUERY_STRING} RewriteRule ^(.*)-c-(.*).html$ index.php?cPath=$2&%{QUERY_STRING} RewriteRule ^(.*)-m-([0-9]+).html$ index.php?manufacturers_id=$2&%{QUERY_STRING} RewriteRule ^(.*)-pi-([0-9]+).html$ popup_image.php?pID=$2&%{QUERY_STRING} RewriteRule ^(.*)-t-([0-9]+).html$ articles.php?tPath=$2&%{QUERY_STRING} RewriteRule ^(.*)-a-([0-9]+).html$ article_info.php?articles_id=$2&%{QUERY_STRING} RewriteRule ^(.*)-pr-([0-9]+).html$ product_reviews.php?products_id=$2&%{QUERY_STRING} RewriteRule ^(.*)-pri-([0-9]+).html$ product_reviews_info.php?products_id=$2&%{QUERY_STRING} RewriteRule ^(.*)-i-([0-9]+).html$ information.php?info_id=$2&%{QUERY_STRING} RewriteRule !^catalog/admin($|/) https://www.newdomain.com%{REQUEST_URI} [L,R=301] Rewrite ^(.*)$ https://www.newdomain.com/$1 [R=301,L]  
  18. Like
    Hotclutch got a reaction from alex121121 in I have no "main_page.tpl.php" file   
    I see the addon was submitted under Ver 2.2, not sure if that was a mistake, but Neither Bootstrap nor official osC has a file called main_page.tpl.php
    Also note that the bootstrap version removes these kind of definitions:
    <?php require(DIR_WS_INCLUDES . 'cur_update.php'); ?> So you should use instead:
    <?php require('includes/cur_update.php'); ?>  
  19. Like
    Hotclutch got a reaction from alix32 in 2nd Product Image replaces main image   
    Here is the demo of last official osC:
    https://demo.oscommerce.com/product_info.php?products_id=28
    You already have a small image gallery. The bootstrap code is the same as the last official osC in this respect.
  20. Like
    Hotclutch got a reaction from valquiria23 in Domain change, SEO and new oscommerce site version   
    It should be RewriteRule
    Note those tags on the rule that MrPhil gave - and how i put it in my post above
    Rewrite ^(.*)$ https://<www.newdomain.com>/$1 [R=301,L] Rewrite ^(.*)$ https://www.newdomain.com/$1 [R=301,L]  
  21. Like
    Hotclutch got a reaction from valquiria23 in Domain change, SEO and new oscommerce site version   
    I just checked what i wrote above - Rewrite - but it should be RewriteRule 
  22. Like
    Hotclutch got a reaction from valquiria23 in Domain change, SEO and new oscommerce site version   
    Does this rule work when you have it on its own - the one MrPhil gave ?
    RewriteRule ^(.*)$ https://www.newdomain.com/$1 [R=301,L] Try to get that one to work first, then you can add the admin exclusion rule afterwards. 
  23. Like
    Hotclutch got a reaction from valquiria23 in Domain change, SEO and new oscommerce site version   
    Hang on ...
    The rule that Pete gave excludes and redirects, so you only need that one rule. That one works confirm ?
    Then you don't need to add anything else.
  24. Like
    Hotclutch got a reaction from valquiria23 in Domain change, SEO and new oscommerce site version   
    ok, then i advise you to turn it off, until somone can post the htaccess that you need. the rules are complex and can mess up your SEO.
     
  25. Like
    Hotclutch reacted to 241 in Illegal string offset 'type'   
    change to
    if ( !isset($params['type']) ) { $params = array('type' => ''); $params['type'] = 'submit'; } the addition is
    $params = array('type' => '');  
×