Jump to content

BrockleyJohn

♥Ambassador
  • Content count

    1,311
  • Joined

  • Last visited

  • Days Won

    32

Reputation Activity

  1. Like
    BrockleyJohn got a reaction from ArtcoInc in NEW! Complete Order Editing Tool!   
    PS I have already begun a further update with a lot more php7 fixes in it... plus a fix for not populating the order content-type which makes some payment & shipping modules complain
  2. Thanks
    BrockleyJohn got a reaction from valquiria23 in Quick Product Updates for osc 2.3+   
    I have just uploaded v3.1.2 to the addons area - https://apps.oscommerce.com/XpKWd&quick-update-bs
    This version, sponsored by @drusky, introduces coloured radio buttons for product and special status:
    It also includes the image fix by @dreumel and a bunch of fixes for php7.2 compatibility.
    Tested against CE Phoenix v1.0.1.2

  3. Thanks
    BrockleyJohn got a reaction from valquiria23 in Quick Product Updates for osc 2.3+   
    I have just uploaded v3.1.2 to the addons area - https://apps.oscommerce.com/XpKWd&quick-update-bs
    This version, sponsored by @drusky, introduces coloured radio buttons for product and special status:
    It also includes the image fix by @dreumel and a bunch of fixes for php7.2 compatibility.
    Tested against CE Phoenix v1.0.1.2

  4. Thanks
    BrockleyJohn got a reaction from Dnj1964 in SourceTree Setup   
    Yes, that's right. After doing that you will see in Sourcetree a lot of Unstaged files that show the differences between your files and Gary's. It's worth going through them to check that they are real differences and not just a bit of formatting - you can discard individual lines and groups of lines, to keep the amount of change to a minimum. This is worth doing because it will reduce the number of conflicts you get in the future. You can use the list as a work list and 'stage' each file when you've checked it.
    NB if your github repository is public, it's best not to copy your configure and htaccess files into it. Just make sure that the ones in your site are read-only so you don't overwrite them by mistake sometime. If you have already copied them, discard the changes to these files instead of staging them.
    When you've been all through them, check that Sourcetree is pointed at your branch (highlighted on the left as it is in your screenshot) and then do a Commit which saves the changes in your branch in your local repo and do a push which copies the branch to your github fork.
  5. Thanks
    BrockleyJohn got a reaction from Dnj1964 in SourceTree Setup   
    Sorry I just read your post a bit better and I see it's the first that you're trying to do.
    You should make a branch at the version of Gary's that you downloaded - so if that's what you did, then great.
    Then copy your site files over the top of the filestore of your local repo where sourcetree is looking. The exact method will depend on where your modified files are - you could be using ftp or just copying them. It's not something you do in Sourcetree, you just use your normal tools for copying files from one place to another.
    For example, if I was working on a site that started with the 'Frozen' release, I would:
    create a fork of Gary's repo on github decide where I'm putting the files on my local laptop, eg. a folder called 'dev' in sourcetree on my laptop, clone the new fork with the repo set to the dev folder - this should download all the files in the master branch from the fork into the dev folder on my laptop then I create the new branch at the 'Frozen' release I gather that you've done all this already
    My next step would be to use an ftp program to download the whole site into the local dev folder on top of the master files.
  6. Thanks
    BrockleyJohn got a reaction from Dnj1964 in SourceTree Setup   
    If you want to copy files that are not in a repository into your branch, you just drop them on the local directories in file explorer.
    If you want to get files from another branch in a repository you have to pull that branch into your repository and merge it into the branch.
    Are you trying to do one of these, or something else I haven't thought of?
  7. Like
    BrockleyJohn got a reaction from ArtcoInc in [Addon] Product Sort Within Category   
    There is every possibility
    It's one of the things on the list...
  8. Like
    BrockleyJohn got a reaction from peterpil19 in New Phoenix Install - No product pages   
    A new install of Phoenix will make sure you have all the database structure you need and will pre-install a default set of modules including those that are missing in your new shop.
    If you have upgraded/reused an existing database from another version of osc then it may just be that it has not pre-installed these content modules and you'll just need to install them. If there are other differences you'll likely come across them soon enough!
    Have a look in the modules section in admin and you'll see some new bits - mostly in Content. These are split into different content areas - some apply to all pages (eg. header, footer) some to specific pages (eg. product_info) and the index page is a bit more complicated: index is the top, index_nested shows a category containing categories and index_products shows a category containing products.
    Spend a bit of time getting your head around these modules and seeing what other ones there are to install. For example you can add login etc to any of navbar, header and footer, or even all of them.
    The specific ones  you're missing are those outlined by Zahid above.
  9. Like
    BrockleyJohn got a reaction from raiwa in NEW! Complete Order Editing Tool!   
    I have just uploaded v1.2.6 for CE Phoenix to
    https://apps.oscommerce.com/wwEZ9&order-editor-for2-3-v1-0
    It includes some bug fixes to edit_orders.php and the header_tags.php module.
    Bug fixes include those reported by @artfulweb and some of the php7.3 compatibility issues that I came across in a quick fire-up
    The thrust of the changes is that the hooks system is slightly different in Phoenix so the modified orders.php is different, some more constants have been hard-coded and checking if variables are set has been added before checking if they are arrays.
     
  10. Like
    BrockleyJohn got a reaction from Denkster in NEW! Complete Order Editing Tool!   
    @Denkster, @freakystreak
    Sorry to have been so slow in picking up on this. The cannot redeclare... error is due to a change in the hooks system in phoenix. I'm guessing your admin orders.php file has as the second line
    $OSCOM_Hooks->register('orders'); Delete or comment out this line.
     
  11. Like
    BrockleyJohn got a reaction from ArtcoInc in NEW! Complete Order Editing Tool!   
    PS I have already begun a further update with a lot more php7 fixes in it... plus a fix for not populating the order content-type which makes some payment & shipping modules complain
  12. Like
    BrockleyJohn got a reaction from raiwa in NEW! Complete Order Editing Tool!   
    I have just uploaded v1.2.6 for CE Phoenix to
    https://apps.oscommerce.com/wwEZ9&order-editor-for2-3-v1-0
    It includes some bug fixes to edit_orders.php and the header_tags.php module.
    Bug fixes include those reported by @artfulweb and some of the php7.3 compatibility issues that I came across in a quick fire-up
    The thrust of the changes is that the hooks system is slightly different in Phoenix so the modified orders.php is different, some more constants have been hard-coded and checking if variables are set has been added before checking if they are arrays.
     
  13. Like
    BrockleyJohn got a reaction from raiwa in NEW! Complete Order Editing Tool!   
    I have just uploaded v1.2.6 for CE Phoenix to
    https://apps.oscommerce.com/wwEZ9&order-editor-for2-3-v1-0
    It includes some bug fixes to edit_orders.php and the header_tags.php module.
    Bug fixes include those reported by @artfulweb and some of the php7.3 compatibility issues that I came across in a quick fire-up
    The thrust of the changes is that the hooks system is slightly different in Phoenix so the modified orders.php is different, some more constants have been hard-coded and checking if variables are set has been added before checking if they are arrays.
     
  14. Like
    BrockleyJohn got a reaction from raiwa in NEW! Complete Order Editing Tool!   
    I have just uploaded v1.2.6 for CE Phoenix to
    https://apps.oscommerce.com/wwEZ9&order-editor-for2-3-v1-0
    It includes some bug fixes to edit_orders.php and the header_tags.php module.
    Bug fixes include those reported by @artfulweb and some of the php7.3 compatibility issues that I came across in a quick fire-up
    The thrust of the changes is that the hooks system is slightly different in Phoenix so the modified orders.php is different, some more constants have been hard-coded and checking if variables are set has been added before checking if they are arrays.
     
  15. Like
    BrockleyJohn got a reaction from peterpil19 in Install new OSC Shop Version 2.3.4.1 CE   
    I recommend using Firefox or Chrome browser on windows, not internet explorer.
    I get occasional reports from my clients that their users sometimes report that ie thinks cookies or script is blocked when the settings are not set like that. This is not confined to oscommerce sites so it seems likely they are due to ie bugs.
    If you really want to use a microsoft browser, use edge instead you'll probably have fewer problems.
  16. Like
    BrockleyJohn got a reaction from peterpil19 in Install new OSC Shop Version 2.3.4.1 CE   
    I recommend using Firefox or Chrome browser on windows, not internet explorer.
    I get occasional reports from my clients that their users sometimes report that ie thinks cookies or script is blocked when the settings are not set like that. This is not confined to oscommerce sites so it seems likely they are due to ie bugs.
    If you really want to use a microsoft browser, use edge instead you'll probably have fewer problems.
  17. Like
    BrockleyJohn got a reaction from trier in Customer Orders Tab in Admin Orders (hook)   
    This uses the hooks system and tabbed display of admin / orders implemented by the Paypal App.

    It adds a tab to admin / orders which lists all orders from the customer of the current order.
    The current order is highlighted. Clicking on one of the other orders will load it instead.
    Works for all orders, not just those paid by Paypal.

    COMPATIBILITY
    Compatible with the tabbed admin orders page of the Paypal App in any version of osCommerce (2.2RC2, 2.3.x).
    FILENAMES DEPRECATED - if your admin / orders page is not called orders.php you'll have to change the hard-coded name in the module.
    Not compatible with BS EDGE Hooks of 2016-10-03 (which don't cover admin).
    Uses tradition language defines, not Paypal App-style.

    INSTALLATION
    Just copy the 3 files to your store.
    No code changes and no admin install - it just works.
     
    DOWNLOAD
    from the addons area http://addons.oscommerce.com/info/9511
    GITHUB
    also available in a branch on its own in a fork of gburton/Responsive-osCommerce at:
    https://github.com/BrockleyJohn/Responsive-osCommerce/tree/addon_customer_orders_tab
     
  18. Like
    BrockleyJohn got a reaction from Portman in PHP error upgrading to 7.3   
    It's throwing that warning because the order instance it's trying to process has no products in it. That doesn't sound like a valid order to me, and could well indicate a problem with the construction of the order instance. If it's an existing order read from the database, check the database order to make sure it was created properly.
     
  19. Like
    BrockleyJohn got a reaction from peterpil19 in fatal error in all version of Phoenix ¡¡¡ all website crash   
    This is the module, but instead of Edit, you should Remove and then Install again

  20. Like
    BrockleyJohn got a reaction from peterpil19 in PHP error upgrading to 7.3   
    The easy answer is: turn off displaying warnings.
    It's a warning not an error until some future version of php.
    in includes/application_top.php find:
    error_reporting(E_ALL & ~E_NOTICE & ~E_DEPRECATED & ~E_STRICT); ini_set('display_errors',1); on a live site you may not want to display any error messages to the public, in which case in the second line change 1 to 0 (zero) or if you want only to suppress warnings, change the first line to
    error_reporting(E_ALL & ~E_NOTICE & ~E_DEPRECATED & ~E_STRICT & ~E_WARNING);  
  21. Like
    BrockleyJohn got a reaction from Heatherbell in Trouble with user.css on Phoenix   
    ...or more precisely, when the stylesheets are in the right order and user.css comes last, it is required to override some styling if it is marked important in bootstrap
    The situation with the stylesheets in the wrong order for some people has been confusing; when it's like that you need to mark things important in user.css to get them to override bootstrap styles coming afterwards, and if bootstrap marks those style definitions important it does nothing.
    I feel your frustration! The developer tools in your browser are really useful for checking where style definitions are coming from but it is much easier to attach new styles to the specific element you're looking at than it is to simulate adding them to user.css. In the normal run of things this doesn't matter much but in this situation it just adds to the angst.
    The fix was to includes/classes/hooks.php so make sure you got the new version of that file.
  22. Like
    BrockleyJohn got a reaction from peterpil19 in PHP error upgrading to 7.3   
    The easy answer is: turn off displaying warnings.
    It's a warning not an error until some future version of php.
    in includes/application_top.php find:
    error_reporting(E_ALL & ~E_NOTICE & ~E_DEPRECATED & ~E_STRICT); ini_set('display_errors',1); on a live site you may not want to display any error messages to the public, in which case in the second line change 1 to 0 (zero) or if you want only to suppress warnings, change the first line to
    error_reporting(E_ALL & ~E_NOTICE & ~E_DEPRECATED & ~E_STRICT & ~E_WARNING);  
  23. Thanks
    BrockleyJohn got a reaction from Moxamint in Changing Server & Database Timezones   
    I'd put it in the connect function...
  24. Like
    BrockleyJohn got a reaction from ArtcoInc in Script syntax error   
    The problem here is the way that what I guess was a template file in a content module has been changed into inline code in an execute function in a header tags module.
    It's using a heredoc string definition (the bit with the <<<) but still has the previous html/javascript with <?php echo...;?> bits. To get these to work in this context you would have to set them up in variables up front and then substitute them in the string. If that's all a bit complicated then an alternative is the grunt work of changing the code to lots of bits of quoted (and appropriately escaped) bits of string and concatenating them.
    By far the easiest approach to a conversion like this without much programming is to keep a separate template file. Header tags modules don't usually have a template file but that doesn't mean you can't have one!
  25. Thanks
    BrockleyJohn got a reaction from Heatherbell in [Addon] Simple Master Password v 3.1 on...   
    OK, I'll try it on a Phoenix install myself & see what happens... did you check that you've updated the catalog password_funcs file not admin?
×