Jump to content

BrockleyJohn

♥Ambassador
  • Content count

    1,311
  • Joined

  • Last visited

  • Days Won

    32

Reputation Activity

  1. Like
    BrockleyJohn got a reaction from mhsuffolk in Paypal Standard Payments Failing   
    Thanks Martin, that fixed it for my customer's site.
    @saxcbr @Cary @cdetdi @Mac Fly please try copying the above file into your shops.
    You can then try resending an IPN from your Paypal account (finding it is tortuous):
    log in to PP, hit cog > Account settings
    scroll down to website payments on left menu
    choose Update next to Instant Payment Notifications
    in the middle of the first line of text, hit the link IPN History page
    This shows you a list of IPNs, defaulting to the last 24 hours - change the period if necessary and select one to resend
    [fingers crossed]
     
  2. Like
    BrockleyJohn got a reaction from mhsuffolk in Paypal Standard Payments Failing   
    Thanks Martin, that fixed it for my customer's site.
    @saxcbr @Cary @cdetdi @Mac Fly please try copying the above file into your shops.
    You can then try resending an IPN from your Paypal account (finding it is tortuous):
    log in to PP, hit cog > Account settings
    scroll down to website payments on left menu
    choose Update next to Instant Payment Notifications
    in the middle of the first line of text, hit the link IPN History page
    This shows you a list of IPNs, defaulting to the last 24 hours - change the period if necessary and select one to resend
    [fingers crossed]
     
  3. Like
    BrockleyJohn got a reaction from mhsuffolk in Paypal Standard Payments Failing   
    @ecartz it already is - that is the one from core; I have checked since. The failing sites are using an older cert that doesn't have the root and intermediate certs in.
  4. Like
    BrockleyJohn got a reaction from mhsuffolk in Paypal Standard Payments Failing   
    Thanks Martin, that fixed it for my customer's site.
    @saxcbr @Cary @cdetdi @Mac Fly please try copying the above file into your shops.
    You can then try resending an IPN from your Paypal account (finding it is tortuous):
    log in to PP, hit cog > Account settings
    scroll down to website payments on left menu
    choose Update next to Instant Payment Notifications
    in the middle of the first line of text, hit the link IPN History page
    This shows you a list of IPNs, defaulting to the last 24 hours - change the period if necessary and select one to resend
    [fingers crossed]
     
  5. Like
    BrockleyJohn got a reaction from mhsuffolk in Paypal Standard Payments Failing   
    Thanks Martin, that fixed it for my customer's site.
    @saxcbr @Cary @cdetdi @Mac Fly please try copying the above file into your shops.
    You can then try resending an IPN from your Paypal account (finding it is tortuous):
    log in to PP, hit cog > Account settings
    scroll down to website payments on left menu
    choose Update next to Instant Payment Notifications
    in the middle of the first line of text, hit the link IPN History page
    This shows you a list of IPNs, defaulting to the last 24 hours - change the period if necessary and select one to resend
    [fingers crossed]
     
  6. Like
    BrockleyJohn got a reaction from burt in Paypal Standard Payments Failing   
    You get that failure because paypal's ssltest subdomain no longer exists - everyone gets it whether their integration works or not.
    It could however be related to cypher suites.
    The getting details on an order that worked before - that will help narrow down the issue. I reckon a failure there is strongly indicative of a communication problem, so perhaps it's something else
  7. Like
    BrockleyJohn got a reaction from Fredi in Moving to Phoenix   
    https://apps.oscommerce.com/Profile&220375-brockleyjohn
    😉
  8. Thanks
    BrockleyJohn got a reaction from Kurre in Default country in create account   
    The usual approach is to edit the field definition in create_account and make it default to the country of the store
    echo tep_get_country_list('country', STORE_COUNTRY, 'required aria-required="true" aria-describedby="atCountry" id="inputCountry"'); If you want to use a different country, substitute the country_id for STORE_COUNTRY
  9. Like
    BrockleyJohn got a reaction from ArtcoInc in NEW! Complete Order Editing Tool!   
    Sorry that was not the problem at all - it was an issue with the indexing of the products in the cart and nothing to do with the order totals. The cart class in catalog and the original admin version in this addon do not cope with more than one order line for the same product. In the catalog they automatically get combined when you add the same product again.
    I updated the cart class in this addon so that it copes with the same product on multiple lines, allowing you to 'get one free', give another half price and other such real life situations that you want to show on the invoice.
  10. Like
    BrockleyJohn got a reaction from TomB01 in NEW! Complete Order Editing Tool!   
    That should show up in the configuration group - I guess it means that your original settings didn't have it and you've left it with the second config group id. When you did the update did you get a redirect with a message telling you there were new settings and to check them? It checks for a pre-existing install by looking for one of the settings being defined. I've just put in a change to test a different config (ORDER_EDITOR_USE_AJAX) which should be present in any existing installation of any age.
    I confess I'd not looked at the uninstall sql since updating the addon. I've now redone it to take out any and all configs and groups for the editor.
  11. Like
    BrockleyJohn got a reaction from mhsuffolk in NEW! Complete Order Editing Tool!   
    It seems unlikely that the tab opening is dependent on the list setting as it's hard-coded always to do it (that's how it was before). I could make it optional...
  12. Like
    BrockleyJohn got a reaction from kgtee in NEW! Complete Order Editing Tool!   
    ok - new version 1.2.8 just uploaded which installs on Phoenix 1.0.4.0 with no core changes.
    https://apps.oscommerce.com/Apps&wwEZ9&order-editor-for2-3-v1-0
    Functionally the same as 1.2.7 but with an extra option that allows you choose whether to change the Edit button in the order list info panel or not. Extra option self-installs when you run the editor.
    If you already made core changes on Phoenix 1.0.4.0 you'll need to reverse them or you'll get errors.
  13. Like
    BrockleyJohn got a reaction from radhavallabh in NEW! Complete Order Editing Tool!   
    good stuff - 1.2.8 will be along very soon with no core changes for phoenix 1.0.4.0 (just testing now)
  14. Thanks
    BrockleyJohn got a reaction from mhsuffolk in NEW! Complete Order Editing Tool!   
    pah, I knew I was going to regret upgrading office 2010
    They're landscape but it didn't pdf them so in word 2020. Try the attached instead
    Order Editor Readme.pdf
  15. Thanks
    BrockleyJohn got a reaction from mhsuffolk in NEW! Complete Order Editing Tool!   
    pah, I knew I was going to regret upgrading office 2010
    They're landscape but it didn't pdf them so in word 2020. Try the attached instead
    Order Editor Readme.pdf
  16. Thanks
    BrockleyJohn got a reaction from ArtcoInc in NEW! Complete Order Editing Tool!   
    So, adding the same product on two different order lines was messing up the shipping calculations (even if with different options). I reckon that shipping modules based on price didn't get the right results either. This is fixed (cart products are now indexed on uprid and the restore checks for existing key), along with the Edit button issue and also the redirect error on a fresh install.
    Uploaded to https://apps.oscommerce.com/Apps&wwEZ9&order-editor-for2-3-v1-0
    @ArtcoInc @TomB01
    Tested on 2.3.4 classic, Phoenix 1.0.4.0 and a bunch of bs versions in between but please flag up any issues.
  17. Thanks
    BrockleyJohn got a reaction from ArtcoInc in NEW! Complete Order Editing Tool!   
    So, adding the same product on two different order lines was messing up the shipping calculations (even if with different options). I reckon that shipping modules based on price didn't get the right results either. This is fixed (cart products are now indexed on uprid and the restore checks for existing key), along with the Edit button issue and also the redirect error on a fresh install.
    Uploaded to https://apps.oscommerce.com/Apps&wwEZ9&order-editor-for2-3-v1-0
    @ArtcoInc @TomB01
    Tested on 2.3.4 classic, Phoenix 1.0.4.0 and a bunch of bs versions in between but please flag up any issues.
  18. Thanks
    BrockleyJohn got a reaction from ArtcoInc in NEW! Complete Order Editing Tool!   
    @ArtcoInc and anyone else using shipping weights:
    I can confirm that there still IS a bug with shipping weights - specifically when you add a product that's already in the order, it trashes the calculated order weight (possibly overwriting instead of adding for that product, but definitely making it wrong!)
  19. Thanks
    BrockleyJohn got a reaction from Philo2005 in Header Tag Product Schema JSON-LD and Google   
    First off, a warning on the schema checker is not an issue unless you have data which is useful for SEO and not output.
    You can test a specific url online here
    https://search.google.com/structured-data/testing-tool
    Your example shows 3 warnings - lack of review information and no end date for the price. This is entirely to be expected if you have no reviews and don't have a special price with an end date set.
    Everything looks good to me.
  20. Like
    BrockleyJohn got a reaction from astecme in PayPal App for osCommerce Online Merchant   
    highly recommended
  21. Like
    BrockleyJohn got a reaction from ArtcoInc in SSL duplicate domain   
    Having the http and https server versions in the config dates back to a time when sites would only use ssl for some pages - account and checkout and not the whole thing. Nowadays you probably want ssl across the whole site so set them both to https
  22. Thanks
    BrockleyJohn got a reaction from cables24h in PayPal App for osCommerce Online Merchant   
    @azpro
    He's agreeing (mostly), just not with the reason for creating the order on checkout_payment.
    Actually in the current system the order gets created when checkout_payment is confirmed, at the top of checkout_confirmation, and if you go back to checkout_payment the order gets deleted again. Which is where this whole discussion started...
  23. Thanks
    BrockleyJohn got a reaction from altoid in Discount Code BS   
    Yes. Be sure to use my addon instead of the worldpay module delivered with Phoenix because that still has an unfixed bug in it and you'll get blank order emails. The addon also brings people who cancel back into the checkout process, and records more info on the order history.
    addon: https://apps.oscommerce.com/brAIY&worldpay-hosted-payments-extended
  24. Like
    BrockleyJohn got a reaction from Dan Cole in osCommerce 2.3.4.1 - 'reviews_id' SQL Vulnerabilities   
    @vanzantz those two exploit reports are from the same bloke and they are not verified. I think they are wrong, he doesn't understand what a boolean-based sql injection attack is or for that matter how to test for a sql injection vulnerability of any kind.
    FWIW I am confident your tool is reporting a false positive and the code is perfectly safe. I can find no report anywhere that integer casting is not proof against injection. You always end up with an integer, so you can never get anything but found or not found for a match to the review_id and you can't add anything to the sql statement.
    Of course it's possible he's just a better hacker than I am a coder 😉
  25. Like
    BrockleyJohn got a reaction from Dan Cole in osCommerce 2.3.4.1 - 'reviews_id' SQL Vulnerabilities   
    @vanzantz those two exploit reports are from the same bloke and they are not verified. I think they are wrong, he doesn't understand what a boolean-based sql injection attack is or for that matter how to test for a sql injection vulnerability of any kind.
    FWIW I am confident your tool is reporting a false positive and the code is perfectly safe. I can find no report anywhere that integer casting is not proof against injection. You always end up with an integer, so you can never get anything but found or not found for a match to the review_id and you can't add anything to the sql statement.
    Of course it's possible he's just a better hacker than I am a coder 😉
×