Jump to content

BrockleyJohn

♥Ambassador
  • Content count

    1,415
  • Joined

  • Last visited

  • Days Won

    34

Reputation Activity

  1. Like
    BrockleyJohn got a reaction from Omar_one in NEW! Complete Order Editing Tool!   
    Long overdue - I have uploaded a new version of the addon to
    https://apps.oscommerce.com/Apps&wwEZ9&order-editor-for2-3-v1-0
    which includes all the fixes posted to the thread through this year. It installs on Phoenix 1.0.7.10 offering full functionality without core modifications. Many of the php notices and warnings have been fixed.
    A little adaptation for customer data modules has been applied so that it doesn't throw warnings or offer the fields if you don't have modules like suburb installed but not all are handled (eg. state) - you can extend along the same lines if required.
    A future version could use the new modules properly, along with the rationalisation and autoloading of classes but that will involve an extensive redesign that might end up being a different addon altogether.
  2. Like
    BrockleyJohn got a reaction from ebarrett in SSL check breaking Paypal payments   
    Ignore the ssl test in paypal app it has not worked for anyone for a couple of years.
    First thing to check is whether your paypal certificate is up to date - see this:
     
  3. Thanks
    BrockleyJohn got a reaction from ejsolutions in USPS Rate V4, Intl Rate V2 (official support thread)   
    need sense of humour
  4. Thanks
    BrockleyJohn got a reaction from ArtcoInc in NEW! Complete Order Editing Tool!   
    @ArtcoInc I guess you're talking about the buttons on the selected order in the list view. IIRC it just overrides the link of the first button - or the first yellow one, or something along those lines. There's a config setting for this which you can turn off instead of clobbering the hook. If you want it to pick a different button we'd need to work out a different jquery selector - if you copy the source code of the buttons section from your browser I can figure what it could be.
    I believe order editor does nothing with customers, addresses and so on, it simply manipulates the fields on an existing order and allows you to change the order products and totals. The place to do what you're asking would be the Order Maker addon which must be where the default address is getting pulled into all three when the order is created.
  5. Thanks
    BrockleyJohn got a reaction from ArtcoInc in When is /ext/.../standard_ipn used?   
    In case you don't know, IPN (instant payment notification) is a feature so paypal automatically contacts your site to tell it about things that happen with payments in paypal - like it's been paid, if it was an echeque that it's cleared, it's been refunded and so on. It's a security feature making it harder for hackers to steal from you by faking paymennts. If you also run an ebay account and you look at your paypal logs in osc you'll see that it tells your site about those payments too!
    All of these IPNs trigger the ipn listener in /ext/... if the listener can find a related order it will write a history record that you can see in admin.
    Now, sometimes when people pay with paypal they don't come back to your site - maybe they don't wait long enough after hitting pay and rush back to looking at porn or their connection drops or whatever. So if the ipn listener gets notified that the payment is there and the order is in the Preparing status, it will go ahead and complete the order, do the stock adjustments, send the emails and so on. If the order is already in the later status (eg Pending), it will just log the history record.
    For the people that do come back to your site and get there before the IPN, when they go through checkout_process that executes the code in the paypal_standard module and changes the order status, stock levels and sends out emails.
    So... both files handle setting an order to paid, the stock and so on - but for any given order it was one or the other. If you want to know which it was, you can tell from the history records (if IPN handled it the change of status history is nearly simultaneous with the IPN email).
    The IPN listener file always handles processing the IPN notification but it may only write a history if the other got there first
    The standard module always handles the user going through checkout_process to checkout_success but it may not do anything for the order if the other got there first
    Both routes need to work properly and if you're changing one for some reason you also need to change the other.
  6. Thanks
    BrockleyJohn got a reaction from ArtcoInc in When is /ext/.../standard_ipn used?   
    In case you don't know, IPN (instant payment notification) is a feature so paypal automatically contacts your site to tell it about things that happen with payments in paypal - like it's been paid, if it was an echeque that it's cleared, it's been refunded and so on. It's a security feature making it harder for hackers to steal from you by faking paymennts. If you also run an ebay account and you look at your paypal logs in osc you'll see that it tells your site about those payments too!
    All of these IPNs trigger the ipn listener in /ext/... if the listener can find a related order it will write a history record that you can see in admin.
    Now, sometimes when people pay with paypal they don't come back to your site - maybe they don't wait long enough after hitting pay and rush back to looking at porn or their connection drops or whatever. So if the ipn listener gets notified that the payment is there and the order is in the Preparing status, it will go ahead and complete the order, do the stock adjustments, send the emails and so on. If the order is already in the later status (eg Pending), it will just log the history record.
    For the people that do come back to your site and get there before the IPN, when they go through checkout_process that executes the code in the paypal_standard module and changes the order status, stock levels and sends out emails.
    So... both files handle setting an order to paid, the stock and so on - but for any given order it was one or the other. If you want to know which it was, you can tell from the history records (if IPN handled it the change of status history is nearly simultaneous with the IPN email).
    The IPN listener file always handles processing the IPN notification but it may only write a history if the other got there first
    The standard module always handles the user going through checkout_process to checkout_success but it may not do anything for the order if the other got there first
    Both routes need to work properly and if you're changing one for some reason you also need to change the other.
  7. Like
    BrockleyJohn got a reaction from radhavallabh in NEW! Complete Order Editing Tool!   
    @radhavallabh it needs a lot of changes to get rid of warnings and notices - you should turn them off by changing admin/includes/application_top.php
    error_reporting(E_ALL & ~E_STRICT & ~E_NOTICE & ~E_WARNING & ~E_DEPRECATED); It's my hope to get a lot more of them eliminated by the next release which will be to go with 1.0.6.0
  8. Thanks
    BrockleyJohn got a reaction from rupruprup in NEW! Complete Order Editing Tool!   
    Here is a version of includes/modules/hooks/admin/orders_edit_order.php that works on 1.0.5.9 as well, but you are also going to have to deal with includes/database.php not being there - either add an include into edit_orders.php and edit_orders_ajax.php or go through and edit all the sql statements.
    orders_edit_order.php
  9. Like
    BrockleyJohn got a reaction from hungryfrank in NEW! Complete Order Editing Tool!   
    @SCH_001
     This appears to be a bug at all versions - perhaps it never worked! I'll have a look into it.
  10. Like
    BrockleyJohn got a reaction from hungryfrank in NEW! Complete Order Editing Tool!   
    You should be using the shipping modules in catalog. If you are not, you are using a different addon!
  11. Thanks
    BrockleyJohn got a reaction from hungryfrank in NEW! Complete Order Editing Tool!   
    These notices are telling you that it cannot calculate the shipping order total because it can't find a match between the shipping quote stored in the session variable and the shipping classes stored in the global variable.
    The delivered code, fixed as suggested, doesn't do this. If you are running it in a test store you can put some debugging into ot_shipping so you can see what's not properly set. Check what $module gets set to in line 48 and if it doesn't look right, check the value of $_SESSION['shipping']['id']
  12. Like
    BrockleyJohn got a reaction from hungryfrank in NEW! Complete Order Editing Tool!   
    it should be
    function __construct() {
  13. Like
    BrockleyJohn got a reaction from PiLLaO in NEW! Complete Order Editing Tool!   
    @PiLLaO yes, as long as you remove the includes in both edit_orders.php and edit_orders_ajax.php, the class itself is not used and the file can be removed.
    @artfulweb when an order disappears from the site it is usually because the order status id has been set to zero. This is something that happens occasionally with the core orders screen as well. An easy workaround to prevent orders disappearing is to manually add to the database an additional order status with status id = 0 and a description like 'status error - please reset' or whatever makes better sense to you. This is an addition to the orders_status table with orders_status_id = 0, language_id set to your admin language id, and the description set to what you want.
    For the error itself, what is reported?
  14. Like
    BrockleyJohn got a reaction from PiLLaO in [Addon] Store Times BS   
    backwards compatibility with the settings of an old addon (but not with bs gold by the look of it)
  15. Like
    BrockleyJohn got a reaction from valquiria23 in [Addon] Simple Master Password v 3.1 on...   
    It's because the function to draw password fields has been removed. Replace the file admin/includes/boxes/master_password.php with this one
    master_password.php
  16. Like
    BrockleyJohn got a reaction from Mac2256 in NEW! Complete Order Editing Tool!   
    Do you mean you have tried and it failed - or are you just asking about the previous comment? I believe the install is ok but the Edit button on the orders page has disappeared.
    @artfulweb replace the file includes/hooks/admin/siteWide/listOrders.php with the attached and the edit button will appear in the list view (if the setting says do it). I need to design a solution for the single order view that will also work for all phoenix versions to keep installation simple.
    listOrders.php
  17. Like
    BrockleyJohn got a reaction from rmandiga in Quick Product Updates for osc 2.3+   
    I am uploading a new version of the addon and since the original support thread is dead, here is a new one.
    The new version is compatible with all 2.3+ versions of osCommerce including 2.3.4BS Edge and requires no file changes or separate SQL on installation.
    Download link to follow shortly.
  18. Like
    BrockleyJohn got a reaction from Mac2256 in NEW! Complete Order Editing Tool!   
    @artfulweb  that's a bug, change the line to
    $value_id = sew_get_products_options_values_id($option_id,$attributes['products_options_values'],0,$products['products_id']); ie. $products['products_id'] not $orders_products['products_id']
     
  19. Like
    BrockleyJohn got a reaction from TomB01 in NEW! Complete Order Editing Tool!   
    The code checks which config group ORDER_EDITOR_USE_AJAX is in but it doesn't check if there's more than one occurrence of it (hence my original question).
  20. Like
    BrockleyJohn got a reaction from TomB01 in NEW! Complete Order Editing Tool!   
    I guess you have been installing and uninstalling. You have somehow added the new settings to config group 18 instead of 19.  Simply edit the config group for the second and last rows to 19.
  21. Like
    BrockleyJohn got a reaction from radhavallabh in NEW! Complete Order Editing Tool!   
    The instructions predate some of the hooks changes in admin so it's possible this one is no longer needed as all orders hooked may now load automatically. The setting is highlighted here:
     

  22. Like
    BrockleyJohn got a reaction from Fredi in NEW! Complete Order Editing Tool!   
    @Fredi you don't need to fix the order_total errors directly, you need to comment out the requires in edit_orders.php and edit_orders_ajax.php:
    edit_orders line 595, edit_orders_ajax 298
    //this is where we call the order total modules // require( 'order_editor/order_total.php'); $order_total_modules = new order_total(); and to show what is happening you can delete the file admin/order_editor/order_total.php
    - you are actually using the class file for order_total from the catalog side of your shop (new Phoenix class autoloader)
  23. Like
    BrockleyJohn got a reaction from Fredi in NEW! Complete Order Editing Tool!   
    @Fredi as you have been testing on 1.0.5.1 please post any actual errors - either messages that start Error, or things that don't seem to work properly.
    You are going to be getting notices about constants not being defined because of the customer data work in 1.0.5.1 which has removed some of the old style language definitions, but apart from that it seems to me to be doing what it's supposed to do.
    You can temporarily fix these notices by adding the defines to the order editor language file for the language you are supporting: ENTRY_COMPANY ENTRY_SUBURB ENTRY_TELEPHONE_NUMBER - I guess you already know how to do this.
    I have yet to get into the customer data work so I don't know why only some defines have been removed but I guess the rest of them will be going soon too; maybe there are core admin pages still using the old defs.
  24. Like
    BrockleyJohn got a reaction from saxcbr in Paypal Standard Payments Failing   
    Thanks Martin, that fixed it for my customer's site.
    @saxcbr @Cary @cdetdi @Mac Fly please try copying the above file into your shops.
    You can then try resending an IPN from your Paypal account (finding it is tortuous):
    log in to PP, hit cog > Account settings
    scroll down to website payments on left menu
    choose Update next to Instant Payment Notifications
    in the middle of the first line of text, hit the link IPN History page
    This shows you a list of IPNs, defaulting to the last 24 hours - change the period if necessary and select one to resend
    [fingers crossed]
     
  25. Like
    BrockleyJohn got a reaction from saxcbr in Paypal Standard Payments Failing   
    Thanks Martin, that fixed it for my customer's site.
    @saxcbr @Cary @cdetdi @Mac Fly please try copying the above file into your shops.
    You can then try resending an IPN from your Paypal account (finding it is tortuous):
    log in to PP, hit cog > Account settings
    scroll down to website payments on left menu
    choose Update next to Instant Payment Notifications
    in the middle of the first line of text, hit the link IPN History page
    This shows you a list of IPNs, defaulting to the last 24 hours - change the period if necessary and select one to resend
    [fingers crossed]
     
×