Jump to content
Latest News: (loading..)


  • Content count

  • Joined

  • Last visited

  • Days Won


Everything posted by BrockleyJohn

  1. BrockleyJohn

    NEW! Complete Order Editing Tool!

    @joe122joe they aren't errors, just notices which you shouldn't be displaying in production. Some are things that didn't get noticed in earlier versions of php, some are just lazy coding but you can ignore them.
  2. I think core code only offers you the logoff option when you're logged in - whether in the navbar account menu or the header buttons. Not so sure about the footer menus as I've barely used them.
  3. BrockleyJohn

    PHP 7

    @ArtcoInc generally speaking, it shouldn't be a problem. There is syntax on 7-7.2 that isn't supported on 5.6 but you're probably not going to be using any of it in your new version... spaceships <=>, null coalescing ($action = $_GET['action'] ?? 'default'), anonymous classes, constant arrays and a bunch of other things that don't spring straight to mind. The only bit of code I can think of that doesn't work across versions is something to do with error-handling on evals but you probably haven't got any of that anyway. The evaluation order in statements is the other way round (eg. when working out what $$class->$method($param[$$key]) means but that should have been fixed by putting in curly braces to make it expllicit in the statement. The approach would be - get a set of code running without issue on 7 and then turn the version back down to 5.6 for a test. hth
  4. BrockleyJohn

    NEW! Complete Order Editing Tool!

    @joe122joe You have extra stuff in the beginning of includes/languages/english/modules/shipping/flat4.php before the <?php
  5. BrockleyJohn

    NEW! Complete Order Editing Tool!

    The blank page is likely a php error, presumably after the order is created. My guess is that it's due to something not compatible with php7.2 If you make sure that errors are being displayed you should find out what it is, eg by having in admin/includes/application_top.php error_reporting(E_ALL & ~E_NOTICE); ini_set("display_errors", 1);
  6. BrockleyJohn

    Quickpay payment module for 2.3

    AFAIK Quickpay are mostly relevant to Scandinavia and I don't think they support any US acquirers. Being UK-based myself I don't have much experience of US merchant gateways.
  7. BrockleyJohn

    Quickpay payment module for 2.3

    osCommerce payment module for Quickpay payment gateway. Supports Quickpay Form (and link) for payment authorisation, with capture and refund available within osC admin. At the time of writing, compatible with Quickpay API v10 and osC 2.3.4 variants. The initial release has language files and installation instructions in both English and Danish. It can be installed without code changes on: 2.3.4BS Edge version of Community Responsive osC Project (which is Paypal App-ready) 2.3.4 osCommerce with Paypal App already installed 2.3.4BS Gold version of Community Responsive osC Project with Paypal App already installed when osCommerce 2.3.5 is released, an installation without code change will be possible to check compatibility of future releases, follow download link for the module in the osCommerce apps area In stores without the Paypal App, simple modifications to three files in admin are required (to enable the admin orders hooks). This module is a restructuring of existing code (most recently added to by BLKOM) to minimise install effort by exploiting the new hooks feature and properly using existing interactions of payment modules with the checkout process. Full credit to authors of previous versions. Thanks to @boelle for Danish translation, testing and usage advice Download from the apps area: [link to follow soon] Also available via github: https://github.com/BrockleyJohn/quickpay-osc-module
  8. I was keeping a branch up to date ready for people to download but the link was removed from my signature - it may be a little behind now.
  9. Use 'inspect' in your browser to check which elements the spaces belong to, and that will tell you where you should attach extra rules. As you move the mouse over the lines of code it highlights the corresponding areas on the page, with different colours for the contents and the margins and padding. You can edit the rules directly in the browser to see the effect before you update your stylesheet.
  10. it's in includes/configure.php define('STORE_SESSIONS', ''); // leave empty '' for default handler or set to 'mysql'
  11. That could be a problem with session hijacking, where sessions aren't really working properly and you get multiple people (and in this case probably spiders too) sharing the same session id. Make sure sessions are set to mysql, spider sessions false, and if your database has been brought forward from a previous version check that the session id field is long enough (128 chars) Also check that when you navigate around the site there isn't a session id showing at the end of the url
  12. BrockleyJohn

    paypay module failed

    so what do you get for this?
  13. hate to tell you this Shaun but I believe php7 compliance went into edge in May 2017 so I think it's even older than that The basic approach, however you set about it, is to do a file compare between your version and CE frozen and make a judgement what to do with each change you might like to think about hiring a dev to do it for you - it could save you a lot of grief and certainly a lot of time
  14. Careful - don't do exactly what you've said here. Where you see function __something that's a magic method if you want to know about magic methods and how classes work, you could try this https://www.culttt.com/2014/04/16/php-magic-methods/ but all you really need to know is that there's a special method that gets called when an object of the class is created - it's known as the constructor. In the php4 syntax for classes, the constructor had the same name as the class. From php5 there's the magic method __construct for the constructor but php4 classname methods still work silently as constructors. From php7, the classname methods still get executed when a new object is created but if you have one and no __construct method you get a warning because the php parser is telling you you're running old code on borrowed time that won't behave as expected at some point in the future. If you don't want to understand or think about any of this and just want a general rule you can always apply for your changes it is this: if you have a class throwing the warning, then it will be like this: class exampleclass { function exampleclass($param1, $param2) { .... and a change that will always work and behave the same as the old code is this class exampleclass { function __construct($param1,$param2) { return $this->exampleclass($param1,$param2); } function exampleclass($param1,$param2) { .... by doing them all this way they will all work, but you are making more changes than are actually needed because most of the time you can get away with renaming the function exampleclass to __construct There are some places where the code behaves differently in php7 than it did in php5 because the order of evaluation of things in a statement is different. I think one of them is in the admin security checks but I don't recall them exactly - you'll need to check through that commit.
  15. BrockleyJohn

    ship2pay for 2.3.x

    No existing support thread that I can find... I just uploaded an updated version of this addon: - php7 compliant - doesn't use filenames.php - minimal core changes (one file) Addon is http://addons.oscommerce.com/info/8419 Also on github in a branch of Edge at https://github.com/BrockleyJohn/Responsive-osCommerce/tree/addon_ship2pay
  16. The easiest workaround is to create (via phpmyadmin) an extra order status with status id set to 0 and a description something like 'status error - needs resetting'. Then the order doesn't disappear
  17. BrockleyJohn

    ship2pay for 2.3.x

    @Omar_one I can't see any problem with your change, it should be fine
  18. BrockleyJohn

    ship2pay for 2.3.x

    @Omar_one that would be a fatal error at any php level How have you got two class declarations in the file? That usually occurs with modules when people upload the class file to the language directory, so I'm struggling to guess how you managed it.
  19. I'm sure you're not
  20. BrockleyJohn

    PayPal App for osCommerce Online Merchant

    sorry Bobbee this is wrong and won't help anyone who uses it. If you do this then it will always use a value of 0 even when the setting is set. So you will get rid of the warning but you won't be able to see any paypal orders in admin because there's no matching status value. If you put quotes round it then it's a string and not a constant (defined or otherwise). The post you quoted was correct.
  21. If your code is from March 2018 then it shouldn't be throwing class constructor warnings - Edge was php7-compatible mid 2017. However, you may have introduced them when applying addons.
  22. only multi-language support
  23. BrockleyJohn

    PHP 7.2 Errors

    The workaround: in catalog/includes/application_top.php change error_reporting(E_ALL & ~E_NOTICE & ~E_DEPRECATED & ~E_STRICT & ~E_USER_DEPRECATED); to error_reporting(E_ALL & ~E_NOTICE & ~E_DEPRECATED & ~E_STRICT & ~E_USER_DEPRECATED & ~E_WARNING);
  24. The configurability of php and what directives work in .htaccess varies widely between hosts. You can turn the display of errors on by editing includes/application_top.php and changing ini_set('display_errors','0'); to ini_set('display_errors','1'); You can also set up logging to a file instead here. You haven't got errors in the page or included code or you'd get a white screen but you might have them in a class (eg module) that's being used
  25. Ok, so it turns out that I only can't sign in using Firefox developer edition. On everything else I tried; Chrome, Opera or regular Firefox I can sign in fine. ...so clearing the cache, it now works there too. I guess I must have been on that site before!