Jump to content
Latest News: (loading..)


  • Content count

  • Joined

  • Last visited

  • Days Won


Everything posted by BrockleyJohn

  1. There's a minimum length, not a maximum. Since they are stored hashed, the length required for storage depends on the algorithm. Some encryption mechanisms truncate passwords - I think the 72 character thing is php's BCRYPT. The DoS limits are much bigger - like 4096 bytes for example.
  2. Yes, there's no bug unless you introduce one by making the suggested change
  3. @CGhoST with this change you will also need to change the definition of MODULE_CONTENT_PI_PRICE_DISPLAY_SPECIAL which is in includes/languages/english/modules/content/product_info/cm_pi_price.php
  4. @burt I guess it looks even sillier if you've got one on the last row! Bootstrap docs says which makes it look like they're always going to do that unless you give them a fixed width, eg .card-deck .card { max-width: calc(25% - 30px); } https://stackoverflow.com/questions/49095075/how-make-bootstrap-4-card-decks-same-width-each-row but if you have different numbers per row at different sizes, that's a bunch of style rules...
  5. I can't see anyone liking cards less, but I suppose there's always one...
  6. Not getting Order Process mail if Total Mismatch of $0.01

    I am sorry but I too can't see how your change could affect the processing. That section of code does not change the order status at all! It might be called verifyTransaction but all it actually does is write an order status history record. In the log, you should get a _notify-validate [IPN] and if the customer returns, a _notify-sync too. Check the responses of these - my money is on their not being VERIFIED.
  7. Not getting Order Process mail if Total Mismatch of $0.01

    and what does the log say for that order?
  8. Not getting Order Process mail if Total Mismatch of $0.01

    You're changing the comment here depending on the order value discrepancy size but I don't think it's going to make any difference to the email - this verify method doesn't return anything. I think you're always going to get an order status change and email if Paypal sends through a VERIFIED result. Have a look in the log in admin and see what happened for the order with the discrepancy.
  9. I would not be surprised if earlier php versions do not work on your hosting with a curl version that supports TLS1.2 - I have come across that before. To check if you are getting php errors you can log them by adding near the top of catalog/includes/application_top.php after the inclusion of configure.php: ini_set("log_errors", 1); ini_set("error_log", DIR_FS_CATALOG . "tmp/php-error.log"); where you should choose where you want the log file to go on the second line.
  10. My best guess on this is that pp ec is returning to checkout_shipping because a shipping method isn't set, and checkout_shipping is forwarding to checkout_payment for its own reasons. However, it needs more diagnostic information. I suggest opening up the network tab in developer tools and setting the persist option (that's what they're called in firefox anyway). It shows you the pages that you're being routed through and the variables set - the persist opion keeps previous information because otherwise you miss the pages that get forwarded. If you do another test with this on, things might become clearer.
  11. I am uploading a new version of the addon and since the original support thread is dead, here is a new one. The new version is compatible with all 2.3+ versions of osCommerce including 2.3.4BS Edge and requires no file changes or separate SQL on installation. Download link to follow shortly.
  12. Quick Product Updates for osc 2.3+

    I don't know that it's actually been tried on CE but it's a stand-alone admin page so it should be fine. It is running in sites with code only a month or so older than that. You can't break anything else by installing it.
  13. When the app hits an error it redirects to checkout_payment but mostly with some sort of failure message. Check the log on the paypal menu in admin and see if there's any more information on the error there. There are several configuration settings that need to be right, but I guess if your setup was working before then they should be ok.
  14. @raiwa Rainer is that the right one?
  15. I think you want this one https://apps.oscommerce.com/iIUE4&discount-codes-bs
  16. @mhsuffolk some things are impossible without core changes (like changing the queries) but if different behaviour is required in a module you can offer an alternative module to be installed instead of the core one, then that at least won't get overwritten by other changes. Core changes best avoided when possible but not anathema. If people recognise that they make future upgrades harder by changing their core code, that's their decision.
  17. 1062 - Duplicate entry '0' for key 'PRIMARY'

    Check in phpmyadmin that your orders table has orders_id defined as auto increment
  18. What if the last time they visited your site was 40 days ago or longer? With the core design they can just look at however many new products interest them, one page at a time.
  19. Yes, but not if it's paged which is the default view. If you set view=all as the canonical url it will limit how many are shown to a search engine, but that won't help Andrea... and it will affect all product listings, not just the new products page.
  20. Social bookmarks Facebook Like doesn't work on a site with SSL in includes/modules/social_bookmarks/fb_facebook_like.php change line 39 by taking out http: so that it reads return '<iframe src="//www.facebook.com/plugins/like.php?href=' . urlencode(tep_href_link('product_info.php', 'products_id=' . $_GET['products_id'], 'NONSSL', false)) . '&amp;layout=' . $style . '&amp;show_faces=' . $faces . '&amp;width=' . $width . '&amp;action=' . $action . '&amp;colorscheme=' . $scheme . '&amp;height=35" scrolling="no" frameborder="0" style="border:none; overflow:hidden; width:' . $width . 'px; height:35px;" allowTransparency="true"></iframe>'; if you want to use the module.
  21. is it BS?

    Have you got a tax zone set up in admin and your store zone set?
  22. I'm afraid you guys are chasing a red herring here. The variable MAX_RANDOM_SELECT_NEW governs the number of most recent new things from which one is chosen for the box. If it's 10, you get one of the 10 newest things. The page products_new does show all the site's products in reverse order of products_id ie. newest first, a page at a time. You can choose how many you see in a page, but you get all of them. This is true of both classic and and I think it's always been the core design.
  23. You are right, the delivered code does it when placed there. I'll investigate
  24. Use your browser's Inspect to check the style is actually being applied to the element. If it is, try increasing the z index. For specific help in getting your layout to work, it would be better to start your own thread. It will make it easier to find for other people trying to solve a similar problem. It could even be that one button is on top of the other, which will need a more complex solution.
  25. in your user.css add .cm_pi_buy_button, .cm-pi-review-button { z-index: 1; }