Jump to content
Latest News: (loading..)


  • Content count

  • Joined

  • Last visited

  • Days Won


BrockleyJohn last won the day on December 7

BrockleyJohn had the most liked content!


Profile Information

Recent Profile Visitors

The recent visitors block is disabled and is not being shown to other users.

  1. BrockleyJohn

    NEW! Complete Order Editing Tool!

    @joe122joe they aren't errors, just notices which you shouldn't be displaying in production. Some are things that didn't get noticed in earlier versions of php, some are just lazy coding but you can ignore them.
  2. I think core code only offers you the logoff option when you're logged in - whether in the navbar account menu or the header buttons. Not so sure about the footer menus as I've barely used them.
  3. BrockleyJohn

    PHP 7

    @ArtcoInc generally speaking, it shouldn't be a problem. There is syntax on 7-7.2 that isn't supported on 5.6 but you're probably not going to be using any of it in your new version... spaceships <=>, null coalescing ($action = $_GET['action'] ?? 'default'), anonymous classes, constant arrays and a bunch of other things that don't spring straight to mind. The only bit of code I can think of that doesn't work across versions is something to do with error-handling on evals but you probably haven't got any of that anyway. The evaluation order in statements is the other way round (eg. when working out what $$class->$method($param[$$key]) means but that should have been fixed by putting in curly braces to make it expllicit in the statement. The approach would be - get a set of code running without issue on 7 and then turn the version back down to 5.6 for a test. hth
  4. BrockleyJohn

    NEW! Complete Order Editing Tool!

    @joe122joe You have extra stuff in the beginning of includes/languages/english/modules/shipping/flat4.php before the <?php
  5. BrockleyJohn

    NEW! Complete Order Editing Tool!

    The blank page is likely a php error, presumably after the order is created. My guess is that it's due to something not compatible with php7.2 If you make sure that errors are being displayed you should find out what it is, eg by having in admin/includes/application_top.php error_reporting(E_ALL & ~E_NOTICE); ini_set("display_errors", 1);
  6. BrockleyJohn

    Quickpay payment module for 2.3

    AFAIK Quickpay are mostly relevant to Scandinavia and I don't think they support any US acquirers. Being UK-based myself I don't have much experience of US merchant gateways.
  7. I was keeping a branch up to date ready for people to download but the link was removed from my signature - it may be a little behind now.
  8. Use 'inspect' in your browser to check which elements the spaces belong to, and that will tell you where you should attach extra rules. As you move the mouse over the lines of code it highlights the corresponding areas on the page, with different colours for the contents and the margins and padding. You can edit the rules directly in the browser to see the effect before you update your stylesheet.
  9. it's in includes/configure.php define('STORE_SESSIONS', ''); // leave empty '' for default handler or set to 'mysql'
  10. That could be a problem with session hijacking, where sessions aren't really working properly and you get multiple people (and in this case probably spiders too) sharing the same session id. Make sure sessions are set to mysql, spider sessions false, and if your database has been brought forward from a previous version check that the session id field is long enough (128 chars) Also check that when you navigate around the site there isn't a session id showing at the end of the url
  11. BrockleyJohn

    paypay module failed

    so what do you get for this?
  12. hate to tell you this Shaun but I believe php7 compliance went into edge in May 2017 so I think it's even older than that The basic approach, however you set about it, is to do a file compare between your version and CE frozen and make a judgement what to do with each change you might like to think about hiring a dev to do it for you - it could save you a lot of grief and certainly a lot of time
  13. Careful - don't do exactly what you've said here. Where you see function __something that's a magic method if you want to know about magic methods and how classes work, you could try this https://www.culttt.com/2014/04/16/php-magic-methods/ but all you really need to know is that there's a special method that gets called when an object of the class is created - it's known as the constructor. In the php4 syntax for classes, the constructor had the same name as the class. From php5 there's the magic method __construct for the constructor but php4 classname methods still work silently as constructors. From php7, the classname methods still get executed when a new object is created but if you have one and no __construct method you get a warning because the php parser is telling you you're running old code on borrowed time that won't behave as expected at some point in the future. If you don't want to understand or think about any of this and just want a general rule you can always apply for your changes it is this: if you have a class throwing the warning, then it will be like this: class exampleclass { function exampleclass($param1, $param2) { .... and a change that will always work and behave the same as the old code is this class exampleclass { function __construct($param1,$param2) { return $this->exampleclass($param1,$param2); } function exampleclass($param1,$param2) { .... by doing them all this way they will all work, but you are making more changes than are actually needed because most of the time you can get away with renaming the function exampleclass to __construct There are some places where the code behaves differently in php7 than it did in php5 because the order of evaluation of things in a statement is different. I think one of them is in the admin security checks but I don't recall them exactly - you'll need to check through that commit.
  14. The easiest workaround is to create (via phpmyadmin) an extra order status with status id set to 0 and a description something like 'status error - needs resetting'. Then the order doesn't disappear
  15. BrockleyJohn

    ship2pay for 2.3.x

    @Omar_one I can't see any problem with your change, it should be fine