Jump to content
  • Checkout
  • Login
  • Get in touch

osCommerce

The e-commerce.

BrockleyJohn

Members
  • Posts

    1,427
  • Joined

  • Last visited

  • Days Won

    37

Everything posted by BrockleyJohn

  1. @@radhavallabh go into the SEO settings in admin and set 'Enable automatic redirects?' to false Incidentally, I suspect you could have played with these settings and maybe the special character conversion to avoid making any changes to the code.
  2. I just tried it out on a test system for a customer with this addon but who doesn't use attributes. It looks like what you're experiencing is the default behaviour of the addon - you get the same as a site without the curly braces issue. I dare say it's fixable, but will take a little looking into.
  3. ok - they're not double-encoded. In that case they probably need escaping after the rewrite. Try RewriteRule ^(.*)-p-(.*).html$ product_info.php?products_id=$2&%{QUERY_STRING} [B] B is for escape backreferences
  4. one final one, if you revert your .htaccess to the one without [NE] and use the SEO URL?
  5. and with the non-SEO url? [catalog...]/products_info.php?products_id=3014%7B2%7D15
  6. if you put <?php var_dump($_REQUEST); exit(); ?> at the top of product_info.php and then put the SEO url in your browser [catalog...]/blah-p-3014%7B2%7D15.html what output do you get?
  7. @@radhavallabh perhaps you are getting your urls double-encoded. Try RewriteRule ^(.*)-p-(.*).html$ product_info.php?products_id=$2&%{QUERY_STRING} [NE] The No Escape parameter should prevent that
  8. I think from your posts elsewhere that you (also) mean: ....../sparkle-curves-deity-metal-earrings-p-3014%7B2%7D15.html doesn't work, but ....../products_info.php?products_id=3014%7B2%7D15 does. If so, I would infer trouble with the rule in your .htaccess file or with the way the query string substitution works.
  9. @@GlenPig Please let me know how you get on - the code's been live for a while now without showing any major problems but the installation's only been tested by Steve.
  10. I'm going to use the app, I was testing something else and wanted to quickly pay for a test order - the assumption was that I could just turn on pp standard, put in the sandbox email address and go... the idea was not to get distracted setting up the pp app so instead I got distracted on pp standard! I'm going to find it hard not to keep looking at it, it's still bugging me that I can't see how values could get in there. I can see what you're talking about on the params for the process button on the way out to pp, but this is afterwards and it only seems to look at orders->products Anyway, it's not important. Thanks for the pointers cheers, John
  11. I have been doing some testing at what is presumably a currently unsupported php version (5.5.26) since I've not found any other reports of this problem. When coming back to osC from making a payment in Paypal, checkout_process.php is throwing up these notices: Notice: Undefined variable: total_weight in /<snip>/oscommerce/includes/modules/payment/paypal_standard.php on line 627 Notice: Undefined variable: total_products_price in /<snip>/oscommerce/includes/modules/payment/paypal_standard.php on line 628 Notice: Undefined variable: products_tax in /<snip>/oscommerce/includes/modules/payment/paypal_standard.php on line 628 Notice: Undefined variable: total_products_price in /<snip>/oscommerce/includes/modules/payment/paypal_standard.php on line 629 Notice: Undefined variable: total_cost in /<snip>/oscommerce/includes/modules/payment/paypal_standard.php on line 629 from these lines in the before_process function: $total_weight += ($order->products[$i]['qty'] * $order->products[$i]['weight']); $total_tax += tep_calculate_tax($total_products_price, $products_tax) * $order->products[$i]['qty']; $total_cost += $total_products_price; I've checked and pertinent parts of the module seem to be identical in 2.3.4, BS and the latest versions on github in both resposive & osc2 repositories. Now, I could declare the variables first to make the notice go away, but I couldn't find anywhere they actually get used... and I couldn't even find that $total_products_price and $products_tax get set anywhere. Am I missing something or are these lines perhaps a left-over from some previous processing that can safely be pruned? Anyone recognise them? TIA
  12. The wording comes from osc: define('MODULE_PAYMENT_SAGE_PAY_FORM_ERROR_TITLE', 'There has been an error processing your order transaction'); define('MODULE_PAYMENT_SAGE_PAY_FORM_ERROR_GENERAL', 'Please try again and if problems persist, please try another payment method.'); It's set in the error handling in the module. It looks like you're coming back to checkout_payment.php with no error code set. Is there nothing at the sagepay end? If you're getting the same thing against the Sagepay test environment and you're not getting any debug emails, try setting the failure url to checkout_process.php instead... it should still catch an error response and you might get told the code that way. Clearly this is a temporary change for debugging - don't forget to put it back later!
  13. Which Sagepay module are you using? If the interface is taking two payments it's not the same problem at all! The above was with Sagepay Form which transfers you to sp to do the payment.
  14. After you overwrite the old module with the new one, you have to go to admin/modules, select Sage Pay Form, click edit, then click save at the bottom. This creates some additional settings that are needed for the new version. Did you do that?
  15. I have completed preliminary testing on a version of the addon for 2.3.4 Bootstrap Gold. I am not going to upload it to the addons section until it's thoroughly tested and fit for use on a live install. If anyone would like to try it out on a test or development store, pm me for a download link.
  16. @@14steve14, I have bundled this up but don't have a suitable database ready to test it on, so it's going to be several more days till it's properly ready: I've reapplied the changes to the BS Gold release files so these really need testing from the ground up before public release. However, if you're keen for a play in the meantime let me know and I'll zip it up and stick it somewhere so you can download it... and tell me what you think of the install instructions!
  17. @@14steve14 I have a working version that I haven't bundled yet. It does proper caching for the product listing page so involves updates to several core files in admin... but that's probably overkill for most stores so I was thinking of making a stripped-down version without caching and a much easier install. Plus, with the other addons I ported since, my validation design has developed a bit and I was going to revisit and stick the latest into xsell. How urgently do you need it and would you prefer to wait a couple more days for a much easier job?
  18. Joe, you've got a mixture of page files and include files in that list. The change I gave will eliminate one source of 'headers already sent' errors but it may not be the only place they're coming from. The error arises when a php file has already sent some output and then the page headers are sent. This can happen if you include a file in the wrong place, as we've been discussing. It can also happen if there's an extra space or lines at the end of a file that's included, like this ?> There may well be other problems like this in the code editing that's been done. In fact there's one in the code that I copied and posted back, because there are blank lines before the head of the html page: if($session->logged_in) { header('Location: index.php'); } else { ?> <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> should be if($session->logged_in) { header('Location: index.php'); } else { ?><!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> Whenever you get this error, it does tell you in which file the headers were already sent, so you just need to check: - if it's a file that's supposed to output html, it must have been included too early - if it's just supposed to be code, it may have spaces, new lines or invisible characters at the end. You can get rid of this problem by omitting the closing ?> altogether - sometimes people leave debugging "echo"s in their code by mistake, so search a code file for these if you've already checked the above
  19. @@paoraosc before you change anything else, replace the first file you posted (either login.php or another file based on it) with this: <?php // login.php include("includes/db.php"); include("includes/functions.php"); include("includes/session.php"); LoadLangFiles($lang); /** * User has already logged in, so display relavent links, including * a link to the admin center if the user is an administrator. */ if($session->logged_in) { header('Location: index.php'); } else { ?> <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> <head> <title><?php echo($POSName) . ': ' . TITLE; ?></title> <link rel="Stylesheet" href="css/style.css"> </head> <body onload="document.Login.user.focus()";> <?php /* include("includes/header.php"); */ include("includes/custom_header.php");?> <?php /** * User not logged in, display the login form. * If user has already tried to login, but errors were * found, display the total number of errors. * If errors occurred, they will be displayed. */ ?> <form action="process.php" method="POST" name=Login> <center><br><br> <table align="middle" border="1" cellspacing="0" cellpadding="3" width="500px"> <tr><td class="tdBlue" align="middle"> <h1><?php echo LOGIN; ?></h1> <?php if($form->num_errors > 0) echo('Login Error. Please try again.'); ?> </td></tr> <tr height="150px"><td width="50%" align="middle"> Username:<input type="text" name="user" maxlength="30" value="<?php echo $form->value("user"); ?>" onkeydown="if (event.keyCode == 13) document.Login.submit();"> <br><br> Password:<input type="password" name="pass" maxlength="30" value="<?php echo $form->value("pass"); ?>" onkeydown="if (event.keyCode == 13) document.Login.submit();"> <br><br> <?php echo $form->error("user"); ?> <br> <?php echo $form->error("pass"); ?> <br><br> <?php /* <tr><td colspan="2" align="left"><input type="checkbox" name="remember" <?php if($form->value("remember") != ""){ echo "checked"; } ?>> <font size="2">Remember me next time */ ?> <input type="hidden" name="sublogin" value="1"> <a class="button" title="<?php echo LOGIN; ?>" href="#" onclick="this.blur(); document.Login.submit();"><span><?php echo LOGIN_BUTTON_TEXT; ?></span></a> <font size="2"> <a href="forgotpass.php"><?php echo FORGOT_PASSWORD; ?></a></font> </td></tr> </table> </form> <?php } ?> <?php include("includes/footer.php"); ?> </body> </html> I can't guarantee you have no other problems, but this will clear the one you posted.
  20. Except that I wasn't very clear. The problem is in the edit you made to login.php - that's where you need to apply my advice.
  21. Assuming you just posted the contents of includes/custom_header.php the line include("includes/custom_header.php"); is too high in the file, it should be lower down: <?php /* include("includes/header.php"); */ include("includes/custom_header.php"); ?>
  22. Your problem is not actually in this file. The most likely cause is that you have included it twice. First, lets check that you didn't upload the page file for checkout_success.php to the language directory, which would produce this error. Upload includes/languages/english/checkout_success.php again just to be sure. If that doesn't fix it, you can temporarily add some code to the top of the class file to find out where the duplication is happening. See this thread: http://www.oscommerce.com/forums/topic/376532-cannot-redeclare/
  23. Hi Amanda. I've never implemented this but it looks like a user interface change to the price options on advanced search. The advanced search pages didn't change between 2.3.1 and 2.3.4 so that part of things is safe. I don't know if the jquery version has changed, but I guess you'll soon find out ;) It should be worth having a shot with the addon as it stands - if it worked alright then, it probably will now. ...but if you want to understand the javascript, you'll need to brush up on your French
  24. @@Mikepo, I've just been reading about the web module http://www.oneapplications.com/epos-excel/help/1.4.0.0/help_12.html - does that work ok for you? I'm not sure about having to choose which set up of updates to overwrite when you haven't had a connection... seems too easy to foul up, but maybe you're less error-prone!
  25. I've worked with a couple, of which Easify is the better - lots of bells & whistles and much better than trying to do stock control on a spreadsheet. Basic per seat licence quite cheap but web integration pricier. Out-of-box osC integration wouldn't support an existing store and was too simplistic to be reliable on virgin broadband so I wrote a whole set of middleware to support migration and queueing online orders to pass back when a connection is available. I can go on about this at great length if you're interested!
×
×
  • Create New...