Jump to content


  • Content count

  • Joined

  • Last visited

  • Days Won


BrockleyJohn last won the day on May 8 2021

BrockleyJohn had the most liked content!

Profile Information

Recent Profile Visitors

The recent visitors block is disabled and is not being shown to other users.

  1. BrockleyJohn

    worldpay payment gateway 403 forbidden hosted integration

    I agree that returning a different schema in the error message is weird but may not be meaningful. The 403 return usually means an authentication problem but may also relate to trying to do something that's not permitted. Try submitting an order value in GBP - maybe the account doesn't handle euros. I have found the worldpay technical team quite helpful in the past, though remote working has made them harder to get hold of.
  2. BrockleyJohn

    [CONTRIBUTION] Ultimate SEO URLs v2.1 - by Chemo

    The problem is that output has already started at line 26! try editing to public function listen_injectRedirects() { instead. Looks like there's a new hook for exactly this purpose
  3. BrockleyJohn

    [CONTRIBUTION] Ultimate SEO URLs v2.1 - by Chemo

    I wonder if $seo_urls isn't getting instantiated until the first call to href_link and that is now after the page output has started in template_top. Try editing catalog/includes/hooks/shop/siteWide/seoUrl.php and changing public function listen_injectinjectAppTop() { to public function listen_injectAppTop() { and see if that helps
  4. BrockleyJohn

    [Addon] Store Times BS

    The stuff you are discussing is in the installation routine for this addon. There is (potentially) a lot of setup involved in configuring all the store times when you first want to use the addon. The previous addon 8044 worked with much older versions of oscommerce and was not compatible with the boostrap ce versions. It held the store times in a text file and not in the configuration settings. This addon is a replacement of the old addon (commissioned by someone upgrading an old site). The installation checks to see if the old addon settings file was present on the site and copies the store times into the settings for the new addon. That is all. Having the old addon is not required to run or install the new one. This is mentioned in the documentation but I didn't think it needed labouring: - On installation, picks up opening times and holidays from addon 8044 Store Open/Closed if available
  5. BrockleyJohn

    Square Payments Plugin for osCommerce

    The javascript library on which this addon is based has been announced end-of-life July 2022. I have built a payment module based on the new SDKs and APIs for phoenix. Let me know if you are interested in having it back-ported to osc 2.3....
  6. BrockleyJohn

    NEW! Complete Order Editing Tool!

    @bigplusmart This is the error for which Omar posted a fix on Sunday; the workaround is comment out line 153 (put // at the beginning)
  7. BrockleyJohn

    NEW! Complete Order Editing Tool!

    @Omar_one Yes, I do intend to update asap (plan would be putting it a bit strongly 🙂 I have just had to send my dev machine off under warranty as it's making a horrible grinding noise so have just lost a week's productivity and am wading through a backlog of communications and trying to claw back progress on jobs. I'll be aiming for but the chances are it should work on 7.18 too In the short term you can suppress notices and deprecated. @bigplusmart I think I've had it working on 7.14 but can't swear to it. Assuming you've a white page, turn on display errors and report back exactly what the issue is: ini_set('display_errors', 1); in admin/includes/application_top.php
  8. BrockleyJohn

    NEW! Complete Order Editing Tool!

    @plamastus it looks like yours has application_top included twice
  9. BrockleyJohn

    NEW! Complete Order Editing Tool!

    Apologies to the discounters - I've been completely snowed under. It's going to need some investigation - I rewrote the classes it uses as extensions of the catalog ones last year, so I would hope that they would behave the same. The totals are calculated with the call to order_totals->process - if the tax is coming out wrongly the modules may be being processed in the wrong order. In the meantime I have added artfulweb's bug fix into the addons area or folks can just apply the attached admin/includes/order_editor/functions.php functions.php
  10. BrockleyJohn

    AIM and SIM have reached End of Life

    I am canvassing the support (as opposed to demand) for a phoenix module and have done some preliminary scoping. It is pencilled on this year's list of things to do if I think it's worth it (ie if I'll get paid for them:) AIM is still only deprecated with no end of life date announced, so no need to panic just yet.
  11. That's only a bug if the order is recorded in your store but the payment is not taken. Otherwise it's just how it works.
  12. BrockleyJohn

    OSC 2.3.1 how to fix paypal express checkout

    Lets start with: what exactly are the errors it shows?
  13. BrockleyJohn

    NEW! Complete Order Editing Tool!

    I am afraid that I don't know! We did do some bug fixing around shipping calculations and their tax in the spring. This may have had some impact on other order total modules such as discounts, but I didn't investigate the behaviour. If you can try the latest version and report back specifically what doesn't work if it's still wrong, I can have a look for the cause.
  14. BrockleyJohn

    NEW! Complete Order Editing Tool!

    yeah, probably v1.2.8 which is when core changes were no longer required
  15. BrockleyJohn

    NEW! Complete Order Editing Tool!

    Long overdue - I have uploaded a new version of the addon to https://apps.oscommerce.com/Apps&wwEZ9&order-editor-for2-3-v1-0 which includes all the fixes posted to the thread through this year. It installs on Phoenix offering full functionality without core modifications. Many of the php notices and warnings have been fixed. A little adaptation for customer data modules has been applied so that it doesn't throw warnings or offer the fields if you don't have modules like suburb installed but not all are handled (eg. state) - you can extend along the same lines if required. A future version could use the new modules properly, along with the rationalisation and autoloading of classes but that will involve an extensive redesign that might end up being a different addon altogether.