Jump to content

doing

Members
  • Content count

    36
  • Joined

  • Last visited

1 Follower

Profile Information

  1. doing

    RMA Returns error for 2.2 MS2

    Hi again, just to let you know - I am alive and well ;-))) This forum kicks you out of the posting notification function if you have not been here for a couple of days (weeks?) and I haven't - I am terribly busy :( / :) @CatDadRick - I love cat's ;) this is why I will come back to your question als soon as possible ! Sebastian
  2. doing

    RMA Returns error for 2.2 MS2

    @ Tom Hmmm - I am sorry if this does not work for you. You can test it out on my Demo Shop (German) if you click on the www button below - it works 100% there. I posted a corrected returns_track.php on page 16 of this thread: http://forums.oscommerce.com/index.php?sho...ic=61077&st=150 So give this one a try ... OR (better) have a look for the changes to your file with a program like WinMerge to compare the codes. Basicly - it is again changing the form button in returns_track.php to an osC Button using the tep function. The problem using the form button is that it is not passing the osCsid which you need. My code change is asking for the osCsid - this is the code again: // redirect to confirmation header('Location: return_product.php?osCsid='.$_GET['osCsid'].'&action=sent&rma_value='. $rma_value . '&return_id=' . $ticket_id); exit(); osCsid='.$_GET['osCsid']. - this is where the code is asking for the correct session id (osCsid). I've checked your site again an it is NOT working the way it should :( If you post your return_product.php code I'll have a look at it ... Sebastian
  3. doing

    RMA Returns error for 2.2 MS2

    @ Tom I just had a short test on your site ... it looks like you are still using the form button instead of the tep function in file return_product.php. I've posted a change to an osC Button using tep a while ago but I did not check if was added to the current version 2.3. Backup your file ! Have a look for the following code in return_product.php <td colspan="2" class="main" valign="top" nowrap align="center"><input type=submit value=Request Returns Number></td> and replace it with this one <td colspan="2" align="right"><?php echo tep_image_submit('button_continue.gif', IMAGE_BUTTON_CONTINUE, 'NONSSL'); ?></td> Make shure you have my // redirect to confirmation code built in (few postings ago) an give it a try ... Sebastian
  4. doing

    RMA Returns error for 2.2 MS2

    This is a sollution to the anoying 're-login' after posting a RMA on the return_product.php page to get your RMA Nr ... First Step - Backup your file ! Second Step - open up your retun_product.php file and look for the following lines: // redirect to confirmation tep_redirect(tep_href_link(FILENAME_RETURN . '?action=sent&rma_value='. $rma_value . '&return_id=' . $ticket_id)); should be at lines 208 / 209 in the current RMA system v2.3 Change this code to the following : // redirect to confirmation header('Location: return_product.php?osCsid='.$_GET['osCsid'].'&action=sent&rma_value='. $rma_value . '&return_id=' . $ticket_id); exit(); Third Step - save your file and test it. I've tested it on my System and it works fine. :) @Cathy This is simple but very nice change to the RMA System. ATTENTION: It may cause happy users of the upcoming RMA v 2.3b in the near future :D @ kkkqqq Did you try my code change to solve your problem with the listed product models ? There was no reply within the last days :( Sebastian
  5. doing

    RMA Returns error for 2.2 MS2

    @kkkqqq It's simple - I've just tested it Open up /admin/includes/classes/order.php and look for the following line: $orders_products_query = tep_db_query("select orders_products_id, products_name, products_model, products_price, products_tax, products_quantity, final_price from " . TABLE_ORDERS_PRODUCTS . " where orders_id = '" . (int)$order_id . "'"); should be at line 84 ... change it to the following code: $orders_products_query = tep_db_query("select orders_products_id, products_name, products_model, products_price, products_tax, products_quantity, final_price from " . TABLE_ORDERS_PRODUCTS . " where orders_id = '" . (int)$order_id . "' order by products_model"); That should be it - it works on my system :) Sebastian
  6. doing

    RMA Returns error for 2.2 MS2

    @kkkqqq Did I get you right - you would like to sort the items on your invoice by model nr. ? This is not a RMA question :) It should be something like 'order by products_model' within the sql query collecting the order details from the table 'oders_products' ... I don't have the correct file and line in mind but I will have a look at it. @cathy Thanks again for your work on this contribution and for the credit :) Sebastian
  7. doing

    RMA Returns error for 2.2 MS2

    100% correct ;) - this would be the best way to end with these ALTER TABLE changes ... This would be the correct INSERT for 'returned_products' table # # Table structure for table `returned_products` # DROP TABLE IF EXISTS returned_products; CREATE TABLE returned_products ( returns_id int(11) NOT NULL auto_increment, customers_id int(11) NOT NULL default '0', rma_value varchar(15) NOT NULL default '0', order_id int(11) NOT NULL default '0', customers_name varchar(64) NOT NULL default '', customers_acct varchar(32) default NULL, customers_company varchar(32) default NULL, customers_street_address varchar(64) NOT NULL default '', customers_suburb varchar(32) default NULL, customers_city varchar(32) NOT NULL default '', customers_postcode varchar(10) NOT NULL default '', customers_state varchar(32) default NULL, customers_country varchar(32) NOT NULL default '', customers_telephone varchar(32) NOT NULL default '', customers_fax varchar(32) NOT NULL default '', customers_email_address varchar(96) NOT NULL default '', customers_address_format_id int(5) NOT NULL default '0', delivery_name varchar(64) NOT NULL default '', delivery_company varchar(32) default NULL, delivery_street_address varchar(64) NOT NULL default '', delivery_suburb varchar(32) default NULL, delivery_city varchar(32) NOT NULL default '', delivery_postcode varchar(10) NOT NULL default '', delivery_state varchar(32) default NULL, delivery_country varchar(32) NOT NULL default '', delivery_address_format_id int(5) NOT NULL default '0', billing_name varchar(64) NOT NULL default '', billing_acct varchar(32) default NULL, billing_company varchar(32) default NULL, billing_street_address varchar(64) NOT NULL default '', billing_suburb varchar(32) default NULL, billing_city varchar(32) NOT NULL default '', billing_postcode varchar(10) NOT NULL default '', billing_state varchar(32) default NULL, billing_country varchar(32) NOT NULL default '', billing_address_format_id int(5) NOT NULL default '0', payment_method varchar(64) NOT NULL default '', cc_type varchar(20) default NULL, cc_owner varchar(64) default NULL, cc_number varchar(32) default NULL, cc_expires varchar(4) default NULL, cvvnumber char(3) default NULL, last_modified datetime default NULL, date_purchased datetime default NULL, returns_status int(5) NOT NULL default '0', returns_date_finished datetime NOT NULL default '0000-00-00 00:00:00', comments text, currency char(3) default NULL, currency_value decimal(14,6) default NULL, account_name varchar(32) NOT NULL default '', account_number varchar(20) default NULL, po_number varchar(12) default NULL, date_finished datetime NOT NULL default '0000-00-00 00:00:00', returns_reason tinyint(5) unsigned default '0', PRIMARY KEY (returns_id) ) TYPE=MyISAM; And again AFTER these changes you MUST EDIT your returns.php - corrections are four postings above ... look for and apply the following changes to returns.php. @cathy - if you put this in the next version it should be save :) Sebastian
  8. doing

    RMA Returns error for 2.2 MS2

    I forgot this one which is NOT in any install text's but needed to correct the values of date_finished (00-00-00 00:00:00) posted above: ALTER TABLE returned_products CHANGE date_finished date_finished DATETIME DEFAULT "0000-00-00 00:00:00"; There are two corrections for this table - sorry Sebastian
  9. doing

    RMA Returns error for 2.2 MS2

    In the sql file coming with the package(2.2b-2.2f), there is the following definition for table 'returned_products' in your database There are ERRORS in ! and The ADDED line in the install text is trying to correct this error : BUT even in this correction coming with the install text, there is an ERROR ! The correct entry is : Just watch for the date format - it can't be 00-00-00 ... it MUST be 0000-00-00 (2004-07-11). This is the reason why you should ALSO correct the returns.php - corrections : 1.) Open up catalog/admin/returns.php 2.) Search for if ($HTTP_POST_VARS['complete'] == 'on') { $notify_comments = ''; tep_db_query("UPDATE " . TABLE_RETURNS . " set returns_date_finished = '1' where returns_id = '" . $oID . "'"); $order_update = true; $return_complete = true; at line 150 in the original file Change this to the following code if ($HTTP_POST_VARS['complete'] == 'on') { $notify_comments = ''; tep_db_query("UPDATE " . TABLE_RETURNS . " set returns_date_finished = now(), date_finished = now() where returns_id = '" . $oID . "'"); $order_update = true; $return_complete = true; } these lines will store the actual DateTime in the DB - you simply CAN'T write a '1' in a DateTime field ! 3.) Search for if ($return_complete['returns_date_finished'] == '1') { within the same file (returns.php) - at line 266 Change this to the following code if ($return_complete['returns_date_finished'] != '0000-00-00 00:00:00') { This correction is now looking for an entry which is NOT 0000-00-00 00:00:00 in the DateTime field. Sebastian P.S. What about calling it 2.3 in near future ? - just instead of z :)
  10. doing

    RMA Returns error for 2.2 MS2

    @cathy ... I AM sorry - you still have this SQL bug in 2.2f :huh: The corrected SQL line is 8 postings ago - it should read: Sebastian
  11. doing

    RMA Returns error for 2.2 MS2

    The page now known as 'RMA page after clicking return on account_history_info' is return_product.php :) I am using 2.2b with german language files created. I based all my mod's on this version and posted the changes I made (exept some design changes). I did not try 2.2e so I can't really say what's going on in your system - sorry. There should be no problems running the RMA system in the root directory if your shop is installed there and configure.php files are ok with their path's Sebastian
  12. doing

    RMA Returns error for 2.2 MS2

    @kkkqqq You are right - RMA / ccGV is NOT installed on my demo shop. I've got both of them installed on my testsystem (local server). As I like contributions which work the way they are supposed to work I am testing my system to find out if there are any bugs left (better me than any customer). There will be a major update to my demo shop within the next weeks. This update will include a combination of Multi Store WITH B2B suite, RMA, ccgV AND Master Products ... checking this and correcting takes time :) Here are some screenshots: 1.) RMA page after clicking return on account_history_info 2.) admin page of an open RMA (part1) 3.) admin admin page of an open RMA (part2) 4.) admin page showing a closed (finished) RMA 5.) admin overview Sebastian
  13. doing

    RMA Returns error for 2.2 MS2

    Additional: If you would like to finish (close) a RMA you should got back to page 15 of this thread - all changes I posted there (Posted: Jun 25 2004, 12:57 PM) are working with the correct entries in this DateTime field ...
  14. doing

    RMA Returns error for 2.2 MS2

    Aha - now I know what the error is (and where it came from): Have a look at the install instructions - there is ONE step missing. Install instructions in 2.2b read like the following: This part is missing in the install instructions of Version 2.2e but is VERY important! AND even there is a BUG in - the correct sql line should read: A DateTime field has to have the correct DEFAUT value - it CAN'T BE 00-00-00 00:00:00 - it HAS to be 0000-00-00 00:00:00 This is the reason for your error case - my code correction is looking for an entry in this field - if it does not match - there is your error ... Hope everything is fine now Sebastian P.S. Cathy - If you do another update - please not this and put it in the install instructions. My modifications will ONLY work with this sql line !
  15. doing

    RMA Returns error for 2.2 MS2

    Hi again David, my very first suggestion would be - try the returns.php which came with the 2.2e package Cathy made (thanks again Cathy for updating again and again). Just to make shure that it is not my modifications causing your error. I would love to post my returns.php file but I think it is useless because of my heavy modified admin area :( Sebastian
×