Jump to content

pbor1234

Members
  • Content count

    86
  • Joined

  • Last visited

Everything posted by pbor1234

  1. I'm actually still running the basic oscommerce (advanced) search scripts on my webshop. Up till now i only excluded some features i didn't want to offer (like search on date) and i had to make an improvement to the raw query when my hoster started to complain ;) Anyway, i wanted to '''upgrade''' the search functionality with the following: - search suggest while typing - did you mean... function on 0 hits on a per keyword basis - offer additional filters as search results (for example indicate number of hits per categorie in a link as part of the results). I believe the more expensive word to this function is: Faceted Search - Misspellings (aspell integration using custom dictionary) I started investigating what tools are available (without the need for a deamon) and ended up with Sphider. Currently i'm integrating the Sphider solution in terms of queries/tables and logic into oscommerce. I'm planning to first build an admin only solution to be able to 'play' with the functions (index, search, reindex, ...). Only then the catalog side will be build. Who is interested in giving advise, performing code review and alike? Expecting first admin version in about 2 weeks time. Paul
  2. I was looking at the sql modifications and have doubts. It seems to be possible to filter on gifts without the additional column to products: select count(distinct p.products_id) as total from products p left join (specials s) on (p.products_id = s.products_id) left join (products_description pd) on (p.products_id = pd.products_id and pd.language_id = '4') <...> left join (`free_gifts` f) on (p.products_id = f.products_id) where p.products_status = '1' and f.products_id IS NULL Anyone thoughts on this? Paul
  3. Hoi Wiljo, Might be that i was seeing the tax on giftwrap + tax on shipping (iso tax on products). It's wrong anyway,,,, I guess i need to refactor simply the workings on discount_coupons the class + integration into the order. Thing is that each ot-contribution is hacked differently into the codebase :( It's a mess :( BTW: Have you tried to use the order_editor (contribution) icw added ot's? Try to update the order-total items and see what happens.... Paul
  4. Found another issue; display prices with tax = 'true', then create an order of 5$ + shipping of 3$ (for example), include discount coupon fixed 10$, in the total/confirmation page you will notice that the total price isn't 0 but equal to the tax of products + shipping. It's the ot_'s that add the tax to the $info['total']. I'm working on a hack to correct the 'total' from the ot_discount_coupon::process(); moving finalize_discount here seems to do the trick but i have no clue what impact of such change may be; since the modules are also used by admin...!? Paul
  5. Wiljo, If i want give EUR 5 discount (incl tax), i may need to enter 4,20 (excl 19% tax) or 4,72; or anything in between since customer may order 19% tax'ed items and/or 6% items. So it doesn't work on the base price...? Regarding the $tax_address; if i die/print_r, i see its simply not defined, even when i declare it global, it's not defined. I do have it in classes/order.php but there its a local as well. See also php.net Paul
  6. Customers expect discount to be incl. tax; or in fact customers are only interrested in nett. prices incl tax, since that is what they need to pay. It's rather strange to give a customer 5$ discount while in fact its 5,95$ discount incl tax...!? Regarding the $tax_address, yes it's in order.php but shouldn't it be declared global in the total_valid_products function? Paul
  7. Think i found a bug, in discount_coupon.php, function total_valid_products, there tax is calculated when DISPLAY_PRICE_WITH_TAX = true but an unknown array $tax_address is used causing tax to be always 0. So while the whole shop may be displaying prices with tax, the coupon-codes modules is calculating discounts always based on prices without tax (and then optionally adding tax again for displaying). All very confusing ... Paul
  8. Did you merge the bottom section in applicationtop.php?
  9. I've uploaded an update that should work at once on vanilla osc2.2ms2 Remarks are highly appreciated! Paul
  10. Jim, Carine, Thanks for the response; i'll try to complete a first working contribution based on 2.2ms2. Meanwhile you can see it in action on my webshop (see link in my profile). It's only in dutch but i guess it will be no problem to understand the logic ;) Paul
  11. Just being curious; is there really no interest in a faceted search function to osc? Actually i had expected more replies on this subject.... Paul
  12. I've just uploaded a first working (admin only) version of the contribution. See http://addons.oscommerce.com/info/7192
  13. pbor1234

    [Contribution] Additional Images Module

    Maybe you did not understand me correct; or i explained it the wrong way; Let me try to give my opinion on this contribution with +/-'s: + ability to add additional images to the product (although i have doubts that this is the best way to do it....) + the very nice thumb-menu (i missed that one you are correct...) - The fact that it creates the scaled images for you in a fixed size to be changed in admin. On this point i prefer the thumbs-on-the-fly contribution since there the code simply requests for the image in a given size (aspect ratio and alike are taken care of), much more user-friendly, you are not restricted to only 3 sizes, simply take what is best for the application, no changes in admin required when you want to change the sizes, the images are generated implicitly (and offcourse automatically). - Also why add 2 columns to the products table for the 2nd and 3rd image AND add a new table for additional images??? The second solution alone would have been much better.... Paul
  14. pbor1234

    [Contribution] Additional Images Module

    Ellicit, It took me actually some time to get rid of the 2 (additional) images,,,, it's much better to my opinion to install "thumbs of the fly" if you want to scale images.... The only usefull feature of this contribution is the option to add extra images to the product, but i guess there will be other contributions that can do the same (better). Paul
  15. I've encountered a problem where a registered customer can see the order of the previous customer that did not create an account in the account_history.php. The reason of this is simple: the guest account is deleted after completion of the order, then the customer_id is reused for the next customer and the script account_history does not take pwa into account. Fix:account_history.php line 59: Add o.customers_dummy_account <> '1' to the query, giving the following code: //BOF PWA $history_query_raw = "select o.orders_id, o.date_purchased, o.delivery_name, o.billing_name, ot.text as order_total, s.orders_status_name from " . TABLE_ORDERS . " o, " . TABLE_ORDERS_TOTAL . " ot, " . TABLE_ORDERS_STATUS . " s where o.customers_id = '" . (int)$customer_id . "' and o.customers_dummy_account <> '1' and o.orders_id = ot.orders_id and ot.class = 'ot_total' and o.orders_status = s.orders_status_id and s.language_id = '" . (int)$languages_id . "' and s.public_flag = '1' order by orders_id DESC"; //EOF PWA
  16. pbor1234

    [Contribution] STS v4

    This would make the 'replacePngTags' function available to STS yes, good idea. But question remains; from where to actually call this function that requires the page content as input argument? (or am i missing something about the sts_inc modules?) The $sts->Replace sounded like a good idea? Paul
  17. pbor1234

    [Contribution] STS v4

    Bill, I would like to add png24 support in my index-page and then to the product-pages as well (sts template pages offcourse). I found a solution written in php (link). What i basically need to do is perform a preg_replace on the complete page to search/replace png images for msie6. Since i'm using sts i'm looking for the best place to do this, i found function replace in the sts object. Is this a good place to do it? Or are there other better ways to do it? Thanks, Paul
  18. pbor1234

    Header Tags SEO

    Open extra_info_pages.php in your browser, then rightclick, view source (or similar function depending on your browser) and post the first few lines (everything between <head> and </head>. That should give us details where to fix the problem. Paul
  19. pbor1234

    Header Tags SEO

    Solan, The page that you post has the header and footer included which is where STS is included. I agree with jack, when you have added the page in pagecontrol it should work. Can you otherwise post the headertags that you get now? My guess is that htc is actually there but the tags are empty (because you have not defined content yet) Paul
  20. pbor1234

    Header Tags SEO

    Solan, For all your sts-template files (the .html's) make sure you have the headcontent defined. So it looke like this: <head> <!--$headcontent--> Then (as i posted) you might want to consider to add the require(... only in header.php and not on each individual page. This should give you tags on every webpage in your shop. Paul
  21. pbor1234

    Header Tags SEO

    Sorry, me again, found a small bug causing pageload fails when generating kw's: $pageName = 'product_info.php' .'?products_id=' . $products_tags['products_id'] . '?language='. $languages[$i]['code']; should be $pageName = 'product_info.php' .'?products_id=' . $products_tags['products_id'] . '&language='. $languages[$i]['code']; Paul
  22. pbor1234

    Header Tags SEO

    Jack, First thanks for the great contribution! I'm playing with it locally, so not live yet but it looks promising! In an attempt to make it better .... ;) ;) i have some remarks that you might want to take along. I have STS and noticed when i follow the manual directions the queries from includes/headertags are done twice on a single page load. This is due to the require statements in the index.php page (for example) AND the header.php which needs to be added for sts!? I have now removed all but the header.php and it seems to work. So additional remark in the manual: choose 1 method only (or make it a require_once). Second thing to mention in the manual is to fill the exclusionlist before auto-detecting the files, took me a while before i got it ;) Ok, continuing now,,,, maybe i have some more remarks later on, thanks again, great work! Paul
  23. First of all i have to say i'm only familiar with osc 2.2 (i downloaded osc 3 but did not yet look into detail). What i think is a large disadvantage of any script language is that it is very hard to test (for regression) and find those bugs giving a white-screen, parse errors or other wrong behavior. Currently the only test-methods applicable to osc that are known to me are: - prepare the same shop offline under xampp for example and click you way through it before uploading any changes. - simply upload the updates and test your way through when there are few customers online. This is far to time consuming and very errorprone, if i may estimate that 10% of my uploaded changes requires a fix afterwards (given the fact that i'm a sw engineer with 10+ years of experience). What i would really like is to have an automated test environment that enables us to verify correct working of the core functionality in a matter of seconds before changes are put online. In order to make this happen one important thing that needs to be done (this is my vision remember) is to seperate the business logic (which we are mainly interested in to test) from the presentation (for which other tools are available that test for valid html). I guess a script will then be able to invoke the core functions using a test-database and see if all the functions work as they should. Another subject is to introduce peer-reviews for contributions but i'll save that for a new thread ;) Paul
  24. pbor1234

    Recover Cart Sales

    I couldn't resist to try it on a fresh 2.2rc2a, it works but only after: - i copied the 2 language files from dutch to english - i added the filename definiitions to filenames.php I think this is all written down in the manual, sorry i did not complete the language files for other than dutch. Afterall it's something every shopowner must do for himself! Sorry again, Paul
  25. pbor1234

    Recover Cart Sales

    I'm kind of puzzled what went wrong. 2.30 is working in my store without any problems. What ambishop did is restore the original implementation leaving the new logic for the cronjob only. Must be a simple bug because the exact same logic is parsed, so if your cronjob works, so should the admin page.... I guess my shop is to modified to extract it for a contribution, ambishop, or anyone else, maybe you which to debug some more because it's not nice to have the original admin page while the cronjob does something different (well, it should not but when different code is parsed you never know....). Sorry for the inconvenience, Paul
×