Jump to content

Demitry

Members
  • Content count

    311
  • Joined

  • Last visited

  • Days Won

    8

Everything posted by Demitry

  1. Demitry

    Get 1 Free

    @Tsimi Thank you Lambros. One last thing,.. there was a conditional statement you added based on status ..a post from March 3rd and 4th of 2015 (page 17). This one: if (($free_product['get_1_free_expires_date'] > date('Y-m-d H:i:s')) || ($free_product['status'] == 1)) { I don't see it in /includes/modules/content/get_1_free/cm_pi_get_1_free.php You said prior that it fixed an issue, so should it be added?
  2. Demitry

    Get 1 Free

    cool, thanks!
  3. Demitry

    Get 1 Free

    @Tsimi Wow! That was fast man! I uninstalled the other one and am installing this one. One thing,.. in the install.txt there is mention of a new file: catalog/includes/functions/get_1_free.php but it is not in the package.
  4. Demitry

    Get 1 Free

    @Tsimi hey Lambros, If you do an update release, please don't forget to include that product_info.php page bug fix that you and David (Roaddoctor) worked on. I only found it on this forum after installing the addon. It's on page 17. Thanks. Demitry
  5. Demitry

    Get 1 Free

    this one from Sept 20th, 2015: Hi tsimi, I have installed get 1 free on oscommerce bootstrap master. Now I have to do an adjustment in shoppingcart.php on line 102. $products_name .= '<br>' . tep_draw_input_field('cart_quantity[]', $products[$i]['quantity'], 'style="width: 45px;"') . tep_draw_hidden_field('products_id[]', $products[$i]['id']) . tep_draw_hidden_field('free[]', $products[$i]['free']) . ' ' . tep_draw_button(NULL, 'glyphicon glyphicon-refresh', NULL, NULL, NULL, 'btn-info btn-xs') . ' ' . tep_draw_button(NULL, 'glyphicon glyphicon-remove', tep_href_link(FILENAME_SHOPPING_CART, 'products_id=' . $products[$i]['id'] . '&action=remove_product'), NULL, NULL, 'btn-danger btn-xs'); it comes to glyphicon. it is removed in master ???? should it be adjusted or not ???? because it works properly I think. and there are also instructions for $HTTP_POST_VARS and $HTTP_GET_VARS, which don't exist in BS Edge. And another line that was re-coded for BS Edge, which does not match the instructions. I cannot remember what file it's in at the moment. Like I said, not a big deal, but would be for someone less technical.
  6. Demitry

    Get 1 Free

    @Tsimi Hey Lambros, I installed this addon and just wanted to let you know that the latest release has instructions that do not fit the BS Edge install. For one thing, there are no file name definitions, or a files for /admin/includes/filesnames.php or /includes/filenames.php And, there are code changes like what Will (dinopacha) mentioned above for shopping_cart.php, ..plus other instructions. That's not a big deal for me, because I can work my way around code, but it would be a for a non-technical user.
  7. Demitry

    KissIT Image Thumnailer

    @raiwa Thanks Rainer, ..great contribution!
  8. Demitry

    Multi_Vendor_Shipping new thread

    @kymation Jim, Do you have a code patch to make this BS Edge compatible? Thanks.
  9. Demitry

    Multi_Vendor_Shipping new thread

    @kymation hi Jim, Is there a version of this MVS addon for BS Edge?
  10. Demitry

    KissIT Image Thumnailer

    @raiwa Hi Rainer, I'm about to install the BootStrap version of this addon into a BS Edge set-up. I have not yet looked through the files in the package, but I did search this entire forum for the following. I noticed that BS Edge adds the img-responsive class to tep_image() and this BootStrap class has the height set to auto. The same thing with the thumbnail class. So, ..does this addon address this image responsive resizing?
  11. @241 Thanks Steve, I did not know about that either.
  12. @kymation hey Jim, Thanks, ..I didn't know that. I actually thought that the following setting was responsible for the session not expiring. However, I did not move to test it because it would have to be the same setting for both the admin panel and the catalog sessions,.. and that was not the case. session.cookie_lifetime = 0 Instead, I took what Carl Nordstrom did improved on it, and made it into an addon that can controlled from Admin>Configuration>Sessions. I tested it and it works great. The screenshot is below. Please take a look and see if it can be improved. https://apps.oscommerce.com/Apps&2MAEV&session-expiration-control @burt hey Burt, You're probably right and this is not a bug with osC, but the point here is that if this problem occurs over various hosting set-ups, then shouldn't the store owner have control over it from the application side?
  13. @burt My hosting company right now is webhostinghub.com and I have the latest PHP version for this BS Edge install. I did however, look in the php.ini file after you said it is a configuration issue on my end. And I did find the following code in it. Though, if this is a configuration piece that can be controlled from the application admin area, then it probably should be, right? [Session] ; Handler used to store/retrieve data. session.save_handler = files ; Argument passed to save_handler. In the case of files, this is the path ; where data files are stored. Note: Windows users have to change this ; variable in order to use PHP's session functions. ; As of PHP 4.0.1, you can define the path as: ; session.save_path = "N;/path" ; where N is an integer. Instead of storing all the session files in ; /path, what this will do is use subdirectories N-levels deep, and ; store the session data in those directories. This is useful if you ; or your OS have problems with lots of files in one directory, and is ; a more efficient layout for servers that handle lots of sessions. ; NOTE 1: PHP will not create this directory structure automatically. ; You can use the script in the ext/session dir for that purpose. ; NOTE 2: See the section on garbage collection below if you choose to ; use subdirectories for session storage session.save_path = /tmp ; Whether to use cookies. session.use_cookies = 1 ; This option enables administrators to make their users invulnerable to ; attacks which involve passing session ids in URLs; defaults to 0. ; session.use_only_cookies = 1 ; Name of the session (used as cookie name). session.name = PHPSESSID ; Initialize session on request startup. session.auto_start = 0 ; Lifetime in seconds of cookie or, if 0, until browser is restarted. session.cookie_lifetime = 0 ; The path for which the cookie is valid. session.cookie_path = / ; The domain for which the cookie is valid. session.cookie_domain = ; Handler used to serialize data. php is the standard serializer of PHP. session.serialize_handler = php ; Define the probability that the 'garbage collection' process is started ; on every session initialization. ; The probability is calculated by using gc_probability/gc_divisor, ; e.g. 1/100 means there is a 1% chance that the GC process starts ; on each request. session.gc_probability = 1 session.gc_divisor = 100 ; After this number of seconds, stored data will be seen as 'garbage' and ; cleaned up by the garbage collection process. session.gc_maxlifetime = 1440 ; NOTE: If you are using the subdirectory option for storing session files ; (see session.save_path above), then garbage collection does *not* ; happen automatically. You will need to do your own garbage ; collection through a shell script, cron entry, or some other method. ; For example, the following script would is the equivalent of ; setting session.gc_maxlifetime to 1440 (1440 seconds = 24 minutes): ; cd /path/to/sessions; find -cmin +24 | xargs rm ; PHP 4.2 and less have an undocumented feature/bug that allows you to ; to initialize a session variable in the global scope, albeit register_globals ; is disabled. PHP 4.3 and later will warn you, if this feature is used. ; You can disable the feature and the warning separately. At this time, ; the warning is only displayed, if bug_compat_42 is enabled. session.bug_compat_42 = 1 session.bug_compat_warn = 1 ; Check HTTP Referer to invalidate externally stored URLs containing ids. ; HTTP_REFERER has to contain this substring for the session to be ; considered as valid. session.referer_check = ; How many bytes to read from the file. session.entropy_length = 0 ; Specified here to create the session id. session.entropy_file = ;session.entropy_length = 16 ;session.entropy_file = /dev/urandom ; Set to {nocache,private,public,} to determine HTTP caching aspects ; or leave this empty to avoid sending anti-caching headers. session.cache_limiter = nocache ; Document expires after n minutes. session.cache_expire = 180 ; trans sid support is disabled by default. ; Use of trans sid may risk your users security. ; Use this option with caution. ; - User may send URL contains active session ID ; to other person via. email/irc/etc. ; - URL that contains active session ID may be stored ; in publically accessible computer. ; - User may access your site with the same session ID ; always using URL stored in browser's history or bookmarks. session.use_trans_sid = 0
  14. ok, so I noticed something that I think needs to be addressed. While working on my site I am seeing that my own customer test-account session never ends. The one for my admin session seems to end sporadically and only after a few days. Today I searched for a fix and found one, though I have not implemented it yet. Possibly for a future release, this should be something the store owner could control and it should not be set to last forever as default. So, my question is,.. is the solution in the link above the best one or is there a different fix for this issue? Thanks.
  15. @Tsimi Lambros, thanks man! I actually did all that except for the conditional statement. I'll add that now, thanks again. Demitry
  16. @Tsimi ok, ..what is was is that I renamed a variable and then uploaded all files with the changed variable name. After that, the admin panel was displaying an inputbox instead of a the choice to enable the divider. So, I uninstalled and re-installed both modules and that fixed it. However, the dividers are still not displaying in the XS menu... not sure why.
  17. @Tsimi hang on, let me fix something first before you mess with it. I made a change that is now causing that divider option not to show up in the admin panel. So let me fix that before you spend any time on it. Sorry about that. I'll let you know once I fix that piece and if the divider is still not displaying.. thanks man
  18. @Tsimi just tested it and it's not working. Thinking about it, ..the class files are for structuring the the dynamic categories menu list, but I had added more menu options to it and those had <li class="divider"></li> tags, which were not showing up. So, the class file missing that divider code was not the issue.
  19. @Tsimi yep, I found it, right after I made that last post. lol
  20. @Tsimi hey Lambros, I am almost finished with those two menu modules and my site header is looking really great! I'm having a problem with the divider not displaying in the XS version. I added the insert statement to function install() and the MODULE_CONTENT_HEADER_CATMENU_XS_DIVIDER to the function keys() array in /includes/modules/content/header/cm_header_catmenu_xs.php ..then checked in admin and it shows the divider as enabled. However, it is not displaying in the actual menu. Do you know what it could be? did I miss something? btw, I found this javascript fix for when the dropdown-menu goes off screen, ..in case you want to use it. I just added it to the script in /includes/modules/content/header/templates/catmenu.php bottom of page. // fix for when the dropdown menu goes off screen $(document).on('shown.bs.dropdown', function () { OffsetDropdown() $(window).on('resize.bs.dropdown', function () { OffsetDropdown() }) }) $(document).on('hide.bs.dropdown', function() { $(window).off('resize.bs.dropdown') }) var OffsetDropdown = function() { var dropdown = $('.open>.dropdown-menu') if (dropdown.length == 0) return var rightOffset = dropdown.offset().left + dropdown.width() var browserWidth = $('body').innerWidth() var neededLeftOffset = dropdown.position().left - (rightOffset - browserWidth) if (neededLeftOffset < 0) { dropdown.css({ left: neededLeftOffset - 3 }) } else { dropdown.css({ left: 0 }) } }
  21. @Tsimi Lambros, Thanks man! That really helps... I've modified the catmenu_xs.php templates to include the header buttons and a hamburger menu icon for tablets and mobile. For some reason I thought the end of the class file was the way to go because the list structure is defined there, but I'll def use the template files instead. Thanks again. Demitry
  22. @Tsimi Right, that's what I thought. I don't think it should be a problem. I think it's just adding some <li></li> links code towards the end of the related class files. I'll have to take a look and see.
  23. @Tsimi hey Lambros, How do I add pages to the menu for both modules? Pages like About Us, Contact, FAQ, etc., I looked for something in the admin area - kind of like WordPress has where you add pages and add them to the menu, but could not find it. Or do I need to hard code them into both modules? I should add that I will be using the menus for more than just categories.
  24. Ok, so I solved the issue of placing the header buttons module in the Horizontal Categories Menu module (for tablet screen size) ..by setting the sort-order higher for the header buttons module and then setting its margin-bottom to -34px (height of the button group) and bottom to -10px. See attached screenshot. I did not nest the modules, but just applied a CSS fix. However, I’d still like to hear from one of the experts, if there is a simple way to nest a module inside another? My new challenge is with including some of the sub-modules from the navigation bar in the Horizontal Categories Menu module as part of the menu.
  25. is there a simple way to nest a module inside another? I installed the Horizontal Categories Menu and want to use the header buttons module inside of it, but nothing seems to work. I tried including the template, and then added the code inside that menu module template, but this is just kicking back errors.
×