Jump to content

Demitry

Members
  • Content count

    291
  • Joined

  • Last visited

  • Days Won

    8

Demitry last won the day on December 28 2018

Demitry had the most liked content!

2 Followers

Profile Information

Recent Profile Visitors

9,788 profile views
  1. hi, I applied Gergely's solution and tested the same product_info page before and after. The one part I did not use from the solution, was the code changed for ht_grid_list_view.php file. For some reason the last line was causing an error in the application I am using and I decided not to use that particular change. I also used my own .htaccess DEFLATE script. The GTMetrix results are in the screenshot below. Shaving off two requests and 100+ms is Great! However, after the changes, the page loads where not smooth. I cleared the browser cache and every time I'd reload a page or load a new one, it would flash an "un-formatted" version of the page for like a split second and that made page-loading jumpy. After playing around for a while in trying to get an ideal order of resources being loaded to eliminate that jumpiness, I ended up reverting the changes for the /includes/template_top.php file, but kept some of the other ones. Just wanted to thank you for addressing the page loading speed issue and for providing a viable working solution. The test results prove that it works!
  2. @raiwa ok, Rainer,... thanks much!
  3. @raiwa hi Rainer, I wanted to download and install this addon, but am confused as to which version to get. I have BS Edge with BS3. Several of the more recent releases say, " Older versions, FROZEN, EDGE and Gold BS3, please use Discount_Codes_4.4.3_BS" However, there is no 4.4.3 BS,.. there is 4.4.2 BS and then there are 3 newer releases after that starting with 5.0.0. So, I assume I need the 4.4.2 BS? ..and then,.. do I need to manually transfer some of the newer changes from the 3 later releases?
  4. Demitry

    Header Tags SEO

    For the most part I agree, but I have custom image code that is not part of osC and it creates folders inside the catalog/image folder and uploads images to that folder. So, I have to figure out how to integrate that code with insert product and update product instead of using it for preview. Or keep the preview and possibly use localStorage for those fields. I'll figure something out, thanks.
  5. Demitry

    Header Tags SEO

    yeah, mine is the same. see below: } elseif ($action == 'new_product_preview') { if (tep_not_null($_POST)) { $pInfo = new objectInfo($_POST); $products_name = $_POST['products_name']; $products_description = $_POST['products_description']; $products_url = $_POST['products_url']; // BOF: Header Tags SEO $products_head_title_tag = $_POST['products_head_title_tag']; $products_head_title_tag_alt = $_POST['products_head_title_tag_alt']; $products_head_title_tag_url = $_POST['products_head_title_tag_url']; $products_head_desc_tag = $_POST['products_head_desc_tag']; $products_head_keywords_tag = $_POST['products_head_keywords_tag']; $products_head_breadcrumb_text = $_POST['products_head_breadcrumb_text']; $products_head_listing_text = $_POST['products_head_listing_text']; $products_head_sub_text = $_POST['products_head_sub_text']; $products_head_additional_words = $_POST['products_head_additional_words']; // EOF: Header Tags SEO I also thought that it might be in this block which is a bit further down for the preview page. Here I have one of the deprecated each() functions updated, but it makes no difference either way in terms of the issue at hand. reset($_POST); //while (list($key, $value) = each($_POST)) { foreach($_POST as $key => $value) { if (!is_array($_POST[$key])) { echo tep_draw_hidden_field($key, htmlspecialchars(stripslashes($value))); } } $languages = tep_get_languages(); for ($i = 0, $n = sizeof($languages); $i < $n; $i++) { echo tep_draw_hidden_field('products_name[' . $languages[$i]['id'] . ']', htmlspecialchars(stripslashes($products_name[$languages[$i]['id']]))); echo tep_draw_hidden_field('products_description[' . $languages[$i]['id'] . ']', htmlspecialchars(stripslashes($products_description[$languages[$i]['id']]))); // BOF: Header Tags SEO echo tep_draw_hidden_field('products_head_title_tag[' . $languages[$i]['id'] . ']', htmlspecialchars(stripslashes($products_head_title_tag[$languages[$i]['id']]))); echo tep_draw_hidden_field('products_head_title_tag_alt[' . $languages[$i]['id'] . ']', htmlspecialchars(stripslashes($products_head_title_tag_alt[$languages[$i]['id']]))); echo tep_draw_hidden_field('products_head_title_tag_url[' . $languages[$i]['id'] . ']', htmlspecialchars(stripslashes($products_head_title_tag_url[$languages[$i]['id']]))); echo tep_draw_hidden_field('products_head_desc_tag[' . $languages[$i]['id'] . ']', htmlspecialchars(stripslashes($products_head_desc_tag[$languages[$i]['id']]))); echo tep_draw_hidden_field('products_head_keywords_tag[' . $languages[$i]['id'] . ']', htmlspecialchars(stripslashes($products_head_keywords_tag[$languages[$i]['id']]))); echo tep_draw_hidden_field('products_head_breadcrumb_text[' . $languages[$i]['id'] . ']', htmlspecialchars(stripslashes($products_head_breadcrumb_text[$languages[$i]['id']]))); echo tep_draw_hidden_field('products_head_listing_text[' . $languages[$i]['id'] . ']', htmlspecialchars(stripslashes($products_head_listing_text[$languages[$i]['id']]))); echo tep_draw_hidden_field('products_head_sub_text[' . $languages[$i]['id'] . ']', htmlspecialchars(stripslashes($products_head_sub_text[$languages[$i]['id']]))); echo tep_draw_hidden_field('products_head_additional_words[' . $languages[$i]['id'] . ']', htmlspecialchars(stripslashes($products_head_additional_words[$languages[$i]['id']]))); // EOF: Header Tags SEO echo tep_draw_hidden_field('products_url[' . $languages[$i]['id'] . ']', htmlspecialchars(stripslashes($products_url[$languages[$i]['id']]))); } So,.. what I did was to replace the categories.php file with the one from the less than 2.3 version. And after replacing all the directory and filename definitions for a basic test run, I went through to the preview page and then clicked the Back button and the result was the same -- all of the fields for the header_tags_seo.php module were empty. I tried doing the same thing by swapping out the header_tags_seo.php module, which is where all the HT fields are coming up empty, with no change. I cannot seem to pin point it. Maybe it's something else that PHP7.2 doesn't like.
  6. Demitry

    Header Tags SEO

    Thanks Jack, I looked at that a number of times, but there is not much difference between the new BS Edge categories.php file, my older MS2.2 file and the Use_if_version_lessthan_2.3 folder file in regards to this section. The product preview code is the same (except for the custom images code I have). The issue is with keeping the text content value in the HT SEO fields when going back from the preview via the back button. That back button has a parameter of name="edit" ..I could not find anything related to that. So, could that be it? or is that parameter not utilized?
  7. Demitry

    Header Tags SEO

    @Jack_mcs yeah, I've been using a comparison tool to find this part in both my MS2.2 related file and the one in your addon package in the Use_if_version_lessthan_2.3 folder. I cannot seem to locate it.
  8. Demitry

    Header Tags SEO

    @Jack_mcs hi Jack, Question for you,.. I had to combine some code from my old MS2.2 admin/categories.php file and the new BS Edge version (on PHP 7.2). In doing this I came across a problem where some of the custom code I had did not work without the page preview option. So, the problem is with the Back button on that preview page. When I go back to the categories.php product update page, all fields contain their related data except the product name and all of the fields for the header tags. Those fields are all empty. I’ve been trying to find where this issue is located, but with no luck. My old MS2.2 site does not have this problem. I even changed all instances of the deprecated each() function in the BS Edge version and still cannot get those HT SEO fields to display any content when going back to the product update page from the preview. Any idea of what it can be or where I should look?
  9. Demitry

    Database Optimizer

    @MrPhil hi Phil, Thanks man,.. yeah, I usually check. I looked at the database.php file and it has mysqli_error() function return mysql_error() function. That's why I said that it probably did not make much difference.
  10. Demitry

    Database Optimizer

    @Jack_mcs hi Jack, I did a site search to find all instances of mysql_ to update them to mysqli_ where possible. I found 2 instances of mysql_error() in the following file, which I believe should be mysqli_error(). Though I don't know if it makes any difference. This is for BS Edge on PHP 7.2 /admin/includes/modules/database_optimizer_common.php Please let me know if these should be changed to mysqli_error() for the version I am running. Thanks.
  11. Demitry

    Header Tags SEO

    cool, thanks. I'll take action accordingly.
  12. Demitry

    Header Tags SEO

    @Jack_mcs hi Jack, Question for you about the purpose of the "currently viewing" link. I noticed that BS Edge product_info.php page has this same link for the product title and both, the "currently viewing" link and that product page title link reload the same page. This is confusing for the user, and for bots it sends them into a loop. That's something search engines don't like too much on either front. They already have this issue with the logo image link on the home page. Is there another purpose for these two links that I am not aware of?
  13. Demitry

    Header Tags SEO

    @Jack_mcs hi Jack, In this file there is a style tag inside of an inline style tag for the Additional Words field. /Use_if_version_BootStrap/catalog_only_new_files/admin/includes/modules/header_tags_seo.php And I rewrote that file for better formatting of the titles and fields. I used a table structure because the divs were messed up and frankly, it was easier to do it this way. File is attached and below is a screenshot of how it is formatted now. header_tags_seo.php
  14. Demitry

    Header Tags SEO

    more.... These files have no changes in them. /Use_if_version_BootStrap/catalog/includes/.htaccess /Use_if_version_BootStrap/catalog/includes/modules/content/index_nested/cm_in_category_description.php /Use_if_version_BootStrap/catalog/includes/modules/content/index_nested/cm_in_category_listing.php /Use_if_version_BootStrap/catalog_only_new_files/admin/header_tags_seo_popup_help.php - just calls the application_top file with no other code content. /Use_if_version_BootStrap/catalog/index.php - (int)$HTTP_GET_VARS['manufacturers_id'] should be (int)$ _GET ['manufacturers_id'] /Use_if_version_BootStrap/catalog/product_info.php - echo "<a name=\"\$header_tags_array['title']\"></a>"; has an extra back-slash before the variable and really should be: echo '<a name="' . $header_tags_array['title'] . '"></a>'; /Use_if_version_BootStrap/catalog_only_new_files/admin/includes/functions/header_tags.php - font-size:10ps; should be font-size:10px; (2 instances – lines 213 and 214)
  15. Demitry

    Header Tags SEO

    Also, in the /includes/header_tags.php file, you can combine the noodp and noydir meta tags into one. This should also reduce the related database configuration by one setting. So, ..from this: if ($defaultTags['meta_noodp']) echo '<meta name="robots" content="noodp" />' . "\n"; if ($defaultTags['meta_noydir']) echo '<meta name="slurp" content="noydir" />' . "\n"; to this: if ($defaultTags['meta_noodp']) echo '<meta name="robots" content="noodp,noydir" />' . "\n"; Reference article: https://www.seoworkers.com/seo-articles-tutorials/using-noodp-and-noydir.html
×