Jump to content

piernas

Members
  • Content count

    638
  • Joined

  • Last visited

  • Days Won

    14

Everything posted by piernas

  1. piernas

    ULTIMATE Seo Urls 5 - by FWR Media

    Thank you, then I uploaded the stock one. It should contain these lines, I'll fix it on the final upload: case 'write.php': $oscTemplate->addBlock('<link rel="canonical" href="' . tep_href_link($PHP_SELF, 'products_id=' . (int)$_GET['products_id'], 'SSL', false) . '" />' . PHP_EOL, $this->group); break;
  2. piernas

    ULTIMATE Seo Urls 5 - by FWR Media

    @omar the new ht_canonical should be slightly different. It adds canonical tags to write review (review.php) that is currently rewritten to review.html. It's not important as this page should not be indexed by spiders but I think I should also add it to noindex pages. I want to study the new pages system to see if it's good to add rewrite rules to it, too, so / info.php?pages_id=4 would become /slug.html
  3. piernas

    ULTIMATE Seo Urls 5 - by FWR Media

    Thank you, I'll take a look at those errors. Does the app work?
  4. piernas

    ULTIMATE Seo Urls 5 - by FWR Media

    I've almost finished this app. Still want to make a couple of tweaks and add proper instructions but all seems to work well. I've attached it in case someone wants to test it. No core changes, tested with Phoenix 1.0.7.10. Just upload the files and go to admin->configuration->Ultimate Seo Urls and enable the app. Feedback will be appreciated. USU3_beta.zip
  5. piernas

    ULTIMATE Seo Urls 5 - by FWR Media

    Hi @ecartz, I've found an issue with a core module (nb_shopping_cart.php). For constructing the URI the module uses this code: // nb_shopping_cart.php (line 19): echo sprintf(MODULE_NAVBAR_SHOPPING_CART_PRODUCT, $p['id'], $p['quantity'], $p['name']); // languages/english/modules/navbar/nb_shopping_cart.php: define('MODULE_NAVBAR_SHOPPING_CART_PRODUCT', '<a class="dropdown-item" href="' . tep_href_link('product_info.php', 'products_id=%s') . '">%s x %s</a>'); This means tep_href_link is called by the define before executing the sprintf command, so the llink is created literally as product_info.php?products_id=%s, avoiding the URL rewriter to be able to parse it correctly. To make it work code should at least generate the real link in the module itself instead of the language file: // language file: define('MODULE_NAVBAR_SHOPPING_CART_PRODUCT', '<a class="dropdown-item" href="%s">%s x %s</a>'); // module: echo sprintf(MODULE_NAVBAR_SHOPPING_CART_PRODUCT, tep_href_link('product_info.php', 'products_id=' .$p['id'] ), $p['quantity'], $p['name']); or even more logical and simpler: // Module: echo '<a class="dropdown-item" href="' . tep_href_link("product_info.php", 'products_id=' .$p['id']) . ' ">' . sprintf (MODULE_NAVBAR_SHOPPING_CART_PRODUCT, $p['quantity'], $p['name']) . "</a>'"; // Language file: define('MODULE_NAVBAR_SHOPPING_CART_PRODUCT', '%s x %s'); I'll still have to figure out how to modify this app to parse links with {X}Y after the product id.
  6. piernas

    ULTIMATE Seo Urls 5 - by FWR Media

    Hi @ecartz, I finally got a free day to check this contribution. I found your solution will not work because Usu_main has to be initialized after set_session_language and before ensure_navigation_history to work. If not, links are correctly generated but $_GET variable is not updated and Phoenix redirects to index in all pages that expects parameters, like product_info. I found its code could be placed in application.php inside the set_session_language function, or it could be loaded by creating an entry inside hooks table between those two functions (an startApplication method). But as far as I see it implies giving a non-consecutive numerical sort order to the table entry (something like _16B_start_SEO ) and it seems a bit dirty to me. Is there a cleaner way to do it? Another thing: I've seen fix_numeric_locale is being called twice (from a hook and inside set_session_language function. Is this needed or has the function call just been forgotten? Files outside ROOT seems to work now; I'm into fixing the ENABLE_SSL stuff. Is there any post where the changes introduced has been explained?
  7. piernas

    ULTIMATE Seo Urls 5 - by FWR Media

    That's correct for other SEO contribution. This is Ultimate SEO 5 and it's different, it needs a lot more tweaks. I wonder if the contribution name should be changed to avoid this kind of confusions.
  8. piernas

    ULTIMATE Seo Urls 5 - by FWR Media

    There's been deep changes that affect the way it is loaded. I also figured out a fix for files not in the main directory but I'll still have to test it deeply. I have to find some time to test it but currently I have no free time. I hope next month I'll find it.
  9. piernas

    ULTIMATE Seo Urls 5 - by FWR Media

    Thanks I'll do as soon as I have the time. I have to dig on how application_top is being processed to see where I must inject the code.
  10. piernas

    ULTIMATE Seo Urls 5 - by FWR Media

    This is not the same addon (Seo URLS 2.1 vs SEO Urls 5 Pro). I've had not much time lately but I was trying to adapt it to the latest phoenix. Its way to add code to the application is very different and I'll need more time to make it work without core code changes.
  11. piernas

    Ultimate Seo Urls 5 Pro

    I know, I've had problems with AJAX requests to /ext not being processed by the addon before. It's a complex addon and will take time for me to fix and test the issue but it's necessary for people like me with hundreds of already search engines indexed products and multilingual shops. Will try to find a better solution - if I'm able to fix it.
  12. piernas

    Ultimate Seo Urls 5 Pro

    I'm sorry I'm really busy these days. I'm not familiar with phoenix reviews - could you tell me how does it work? I cannot find the "write review" button to check how to add this to the addon. Where is it now?
  13. This is a admin sidebar that replaces the stock menu. It can be expanded or condensed on a column of icons. It also adds bootstrap framework to admin. Hope you enjoy it. Please comment here if you have any improvements or find any problem. Download: https://apps.oscommerce.com/ebjVY&admin-responsive-sidebar-with-bootstrap
  14. piernas

    Ultimate Seo Urls 5 Pro

    Fine I meant I fixed after uploading the file. Will update later.
  15. piernas

    Ultimate Seo Urls 5 Pro

    Did you see any page that should not have the tag? At first I cannot think of any...
  16. piernas

    Ultimate Seo Urls 5 Pro

    1. Language class has been fixed. USU 5 does not use $lng but its own class to handle languages. It was loading languages class file without setting $lng so the next part of code that tried to load the class triggered that error. I think it could be good to load the class in navbar core module by checking first if the file has been included already (as other modules like paypal does). What do you mean with "should be secured"? 2. I made the hook to load only if multilanguage is enabled for USU5, so no need to selective copy. 3. it's not throwing any errors here but I'll watch it . Where is cache object set? 4. I'll do on the next release.
  17. piernas

    Ultimate Seo Urls 5 Pro

    move HT module to Hook -> good idea change tpl_ file -> I have a problem because templates uses a $usu5_multi class not declared as global in the modules. Any ideas?
  18. piernas

    Ultimate Seo Urls 5 Pro

    It's ready. - Latest oscommerce (phoenix 1.0.3.0) compatible. - Fixed more cache issues. Now sqlite and memcache are only enabled if system supports the methods. - Moved admin edits to hooks. Now only two files on catalog needs to be modified. - Removed database table constants. - TODO: Allow to processs links outside root folder (ie. ext/directory). This is useful for addons like Twitter typeahead. Can someone test the atached files before uploading to addons? USU5_210.zip
  19. piernas

    Ultimate Seo Urls 5 Pro

    Almost everything is done but some of the content modules and product listings. I'll have to dig and see what happened to new products modules on index pages (I cannot find them in latest version). If someone has already ported those items it would save me some work.
  20. piernas

    Ultimate Seo Urls 5 Pro

    Thanks, I'll check and fix it. I shouldn't check things at late hours!
  21. piernas

    Ultimate Seo Urls 5 Pro

    Hola Rainer, I'm checking the code. Cache system is set by default to sqlite only if it's installed on the system: if ( !class_exists( 'SQLite3' ) ) { $standard_cache_strategy = 'file'; } else $standard_cache_strategy = 'sqlite'; Table definitions were already changed in earlier revisions, even before these were changed in oscommerce BS. I can't find any error related to USU 5 on a PHP73 server running live so (unless I changed something and forgot to update the addon) it's PHP 7.3 ready. Please, if someone that uses this addon could check error logs we'll be sure. I should change the "compare files" to match the current ones, but I'm not sure what version to use as I've seen some changes in the latest branch like product tabs on admin, removal of cache system... I've also noticed a new hook in categories.php: $OSCOM_Hooks->call('categories', 'productPreAction'); This hook, if it does what I think, could help avoiding part of the core changes, but it's still not in the current (1.0.28) version. I'll also update the modules from the shop side (navbar and boxes). I vagely remember reading that burt wants to deprecate boxes in the shop side but I've been suddenly banned from phoenix club without notice and cannot verify it. Do you know if there's some new feature that allows to inject code into application_top? If that last core edit could be injected this would be a 'drop and enjoy' addon
  22. piernas

    Ultimate Seo Urls 5 Pro

    @raiwa I''ll take a look at it. I'll have to install phoenix on a test server because I don't want to upgrade yet, so testing will be limited. Anyway latest uploaded version should work on php 7.3 - I'll check if I changed something and didn't update the files on the addons site.
  23. piernas

    Ultimate Seo Urls 5 Pro

    Can you post the error log file to fix it? I can't find any USU errors on mine. I don't have Phoenix installed and I won't install it for now, so can't say if there are differences, but for what I've seen it should work on it.
  24. Today I decided I got angry for the last time updating a table rate based module. Afer several tryouts to change the shipping rates just to see I had a typo in the values string -damned colons- and having to manually calculate the net prices for each row from the gross that came from the table provided by the courier... I had enough and modified the table rate module to show a real table where you can see what you're doing. Uses some javascript to update net/gross, add or remove rows and do some basic checks. It can be adapted to any other module that uses the same system. Note: The net pice is caclulated based on the tax class from the module. It will apply only to the countries in the module's zone and it's not savet to database but calculated on the fly. For this column to work you need to set up the tax rate first, save and enter the module configuration again. Here is the file: https://apps.oscommerce.com/wyYLv&sgipping-table-module-update @burt you can replace the stock one if you consider it fits the community project.
  25. I took some time to practice with modules and made this time-saver when configuring content modules: http://addons.oscommerce.com/info/9458 IMPROVED CONTENT MODULES ADMIN FOR 2.3.4 RESPONSIVE =================================================== This is a direct replacement for modules_content.php. - Each module group has his own tab, so no more inspecting huge lists in search of a content module. - You can see both installed and uninstalled modules in one group at once. - You can see module descriptions without clicking on each one. - You can check fast if a module is enabled or not without accessing his configuration. - You can enable or disable modules directly if the module has the appropiate methods (see below). I had the intention of adding a couple of improvements, like a graphical interface to move up/down modules and graphically change its width and position on the page, but currently there's not a standard for bootstrap module width property. One module can, for example, have a "half width/full width" property while another can offer the choice of "width=6/width=12". Also, to enable/disable them without accessing his configuration would require the module to expose public methods like these: <?php function isEnabled() { return $this->enabled; } function enable() { tep_db_query("update " . TABLE_CONFIGURATION . " set configuration_value = 'True' where configuration_key = 'MODULE_THIS_MODULE_STATUS'"); $this->enabled = (MODULE_THIS_MODULE_STATUS == 'True'); } function disable() { tep_db_query("update " . TABLE_CONFIGURATION . " set configuration_value = 'False' where configuration_key = 'MODULE_THIS_MODULE_STATUS'"); $this->enabled = (MODULE_THIS_MODULE_STATUS == 'True'); } ?> If these are not present, you can easily add them to a module by changing MODULE_THIS_MODULE_STATUS for the appropiate constant. If you do this or the module already suplies these methods, yoou will see the enable/disable button in this module.
×