Jump to content

piernas

Members
  • Content count

    697
  • Joined

  • Last visited

  • Days Won

    17

piernas last won the day on February 17

piernas had the most liked content!

7 Followers

Profile Information

  • Real Name
    Juanma
  • Gender
    Male
  • Location
    Madrid

Recent Profile Visitors

17,205 profile views
  1. piernas

    Shipping table is now a real table :)

    Thanks for testing. I'll update it.
  2. piernas

    ULTIMATE Seo Urls 5 - by FWR Media

    @marokech please download latest from here: https://apps.oscommerce.com/Imrlq&ultimate-seo-urls-rewritter-for-phoenix and please post any problem here:
  3. piernas

    Shipping table is now a real table :)

    I'll try to update the ones I've made in the past while I have some free time
  4. piernas

    ULTIMATE Seo Urls 5 - by FWR Media

    I don't have a frozen test site anymore and I changed the code for phoenix, so can't do that for now. I'll do once I finish other work in progress; anyway I found google defaults to english if x-default is not set so your site should be indexed already.
  5. piernas

    Shipping table is now a real table :)

    Updated for Phoenix: https://apps.oscommerce.com/2iSYY&editable-shipping-table-phoenix
  6. piernas

    ULTIMATE Seo Urls 5 - by FWR Media

    Yes you'll just have to add it to the $alternate variable.
  7. piernas

    ULTIMATE Seo Urls 5 - by FWR Media

    Hi David, I dodn't know about that tag - I'll add it in the future once the app has been tested.
  8. piernas

    ULTIMATE Seo Urls 5 - by FWR Media

    Final version for CE Phoenix 1.0.7.10+ attached. I will open a new topic (this one is very old and almost nothing relates to the currrent app due to the huge amount of changes and fixes). I will upload it to the addons page soon, too. I didn't receive any feedback other than from @Omar_one. Does nobody consider this app of interest anymore? @zeeshop yes it works on phoenix 1.0.7.12. Please download new package attached and see the readme included for instructions. Ultimate_SEO_Urls v3.0.0.zip
  9. piernas

    ULTIMATE Seo Urls 5 - by FWR Media

    Thank you, then I uploaded the stock one. It should contain these lines, I'll fix it on the final upload: case 'write.php': $oscTemplate->addBlock('<link rel="canonical" href="' . tep_href_link($PHP_SELF, 'products_id=' . (int)$_GET['products_id'], 'SSL', false) . '" />' . PHP_EOL, $this->group); break;
  10. piernas

    ULTIMATE Seo Urls 5 - by FWR Media

    @omar the new ht_canonical should be slightly different. It adds canonical tags to write review (review.php) that is currently rewritten to review.html. It's not important as this page should not be indexed by spiders but I think I should also add it to noindex pages. I want to study the new pages system to see if it's good to add rewrite rules to it, too, so / info.php?pages_id=4 would become /slug.html
  11. piernas

    ULTIMATE Seo Urls 5 - by FWR Media

    Thank you, I'll take a look at those errors. Does the app work?
  12. piernas

    ULTIMATE Seo Urls 5 - by FWR Media

    I've almost finished this app. Still want to make a couple of tweaks and add proper instructions but all seems to work well. I've attached it in case someone wants to test it. No core changes, tested with Phoenix 1.0.7.10. Just upload the files and go to admin->configuration->Ultimate Seo Urls and enable the app. Feedback will be appreciated. USU3_beta.zip
  13. piernas

    ULTIMATE Seo Urls 5 - by FWR Media

    Hi @ecartz, I've found an issue with a core module (nb_shopping_cart.php). For constructing the URI the module uses this code: // nb_shopping_cart.php (line 19): echo sprintf(MODULE_NAVBAR_SHOPPING_CART_PRODUCT, $p['id'], $p['quantity'], $p['name']); // languages/english/modules/navbar/nb_shopping_cart.php: define('MODULE_NAVBAR_SHOPPING_CART_PRODUCT', '<a class="dropdown-item" href="' . tep_href_link('product_info.php', 'products_id=%s') . '">%s x %s</a>'); This means tep_href_link is called by the define before executing the sprintf command, so the llink is created literally as product_info.php?products_id=%s, avoiding the URL rewriter to be able to parse it correctly. To make it work code should at least generate the real link in the module itself instead of the language file: // language file: define('MODULE_NAVBAR_SHOPPING_CART_PRODUCT', '<a class="dropdown-item" href="%s">%s x %s</a>'); // module: echo sprintf(MODULE_NAVBAR_SHOPPING_CART_PRODUCT, tep_href_link('product_info.php', 'products_id=' .$p['id'] ), $p['quantity'], $p['name']); or even more logical and simpler: // Module: echo '<a class="dropdown-item" href="' . tep_href_link("product_info.php", 'products_id=' .$p['id']) . ' ">' . sprintf (MODULE_NAVBAR_SHOPPING_CART_PRODUCT, $p['quantity'], $p['name']) . "</a>'"; // Language file: define('MODULE_NAVBAR_SHOPPING_CART_PRODUCT', '%s x %s'); I'll still have to figure out how to modify this app to parse links with {X}Y after the product id.
  14. piernas

    ULTIMATE Seo Urls 5 - by FWR Media

    Hi @ecartz, I finally got a free day to check this contribution. I found your solution will not work because Usu_main has to be initialized after set_session_language and before ensure_navigation_history to work. If not, links are correctly generated but $_GET variable is not updated and Phoenix redirects to index in all pages that expects parameters, like product_info. I found its code could be placed in application.php inside the set_session_language function, or it could be loaded by creating an entry inside hooks table between those two functions (an startApplication method). But as far as I see it implies giving a non-consecutive numerical sort order to the table entry (something like _16B_start_SEO ) and it seems a bit dirty to me. Is there a cleaner way to do it? Another thing: I've seen fix_numeric_locale is being called twice (from a hook and inside set_session_language function. Is this needed or has the function call just been forgotten? Files outside ROOT seems to work now; I'm into fixing the ENABLE_SSL stuff. Is there any post where the changes introduced has been explained?
  15. piernas

    ULTIMATE Seo Urls 5 - by FWR Media

    That's correct for other SEO contribution. This is Ultimate SEO 5 and it's different, it needs a lot more tweaks. I wonder if the contribution name should be changed to avoid this kind of confusions.
×