gregp

I've found if ajax is enabled and the comments field has more than 512 characters, the entire contents of the comments field gets dropped. I've traced it as far as the URL: http://www.yourstore.com/admin/edit_orders_ajax.php?action=update_comment&cID=COMMENT_ID_HERE&comment=COMMENT_HERE&oID=ORDER_ID_HERE Pulling the comment and order IDs from an existing order, if COMMENT_HERE has 512 characters they get saved to the database correctly. If I go to 513 characters an empty field is written to the database. I'm able to write more than 512 characters to that field through phpmyadmin and they got there in the first place when the order was placed so the issue isn't with the database. This is probably a server limitation caused by the suhosin patch but can someone rewrite this module so it doesn't use a GET process to write the information, and thereby hopefully fix this for the many people no doubt operating under this setup? Alternatively if that's NOT the problem, can someone else point me to the problem? Thanks!

Hi, I've got 5.0.9c installed on my shop and the only problem I find is that I have a few order total additions e.g. a surcharge for PayPal. Initially the order total all adds up correctly, but if I edit the order e.g. add another item, I then find that while the PayPal surcharge line remains visible, the amount for that doesn't get included in the recalculation of the order total. The only workaround is to add a second order total line and copy the paypal surcharge from the line above. It seems this second total DOES get included in subsequent calculations when edits are done, but why doesn't the original one? Thanks, Greg

This is the support thread for contribution http://addons.oscommerce.com/info/7513 This contribution displays the quantities of each product in the products listing categories.php of the admin interface. It is a very simple modification to make and means you can see all stock in a category without having to click on each one. If you have lots of products in a category this makes it easy to see at a glance what's getting low. Here's a screenshot...

Not sure I understand what's not working Lisa... I just went through your checkout procedure and everything worked up to the point I would have paid for my order within PayPal. But maybe you haven't added your changes yet... It's normal to receive that 'wait five seconds or click' message on completion of payment, a standard PayPal thing. As far as the 'code' for that message, you've got it right there, not sure what you're looking for? You can certainly change that wording if you need; the trick you MUST escape any apostrophes with a backslash, as you can see where I've put PayPal\'s. An apostrophe tells the system it's the end of the line, if you escape it it treats the following character as a literal character. Obviously leave everything as it is and just change the text between the apostrophe before Note and after procedure! Perhaps if that hasn't addressed it feel free to post back with some more details. Greg

Thanks for that feedback guys, I've added a section in the instructions about the above problems.

Great! Yeah I guess that's a risk if the payment modules you're using have non-standard names. Glad you sorted it out. I did think about the popup box but thought this would be easier to do (for me anyway). I do know that if you don't select a delivery method and try to proceed it pops up a box so it'd just be a matter of hacking that script for this page. I think this is a bit easier to control though in that you can have whatever wording / layout / style you want rather than being restricted by what the browser throws up.

Nice work JG... feel free to update the code in the repository with your modifications, particularly the code. If the code can be improved then so much the better. As you say the 'I understand' button is themed to your site, perhaps you could include that but retain the original text code in case some people want to just use a text link? Also did you find the formatting problems in v1.2? IE8 didn't play nicely with v1.0 or 1.1 but the 1.2 update fixed that for me. I like your wording too... not quite as 'pointed'! I guess I've put up with people not following more and more obvious instructions for so long now I have little patience for people who don't read the obvious! ;) Greg

Perhaps before I go any further, could you tell me the problem?? :) You've said it "doesn't work" but that's a pretty broad fault description. The only thing that stands out from what's below is that it's not the whole page source so I can't see if you've included the Javascript as per the readme.

Whoops my bad :(, yep it needs to go into english/images/buttons. I've updated the instructions, thanks! That line you quoted button_confirm_order is what needs to be replaced. Here's how my code looks: <td width="10"> </td> <td align="right" class="main"> <?php if (isset($$payment->form_action_url)) { $form_action_url = $$payment->form_action_url; } else { $form_action_url = tep_href_link(FILENAME_CHECKOUT_PROCESS, '', 'SSL'); } echo tep_draw_form('checkout_confirmation', $form_action_url, 'post'); if (is_array($payment_modules->modules)) { echo $payment_modules->process_button(); } ?> <style> #warningdiv {float:right; position:relative;} #confirmbutton {position:absolute; top:0; right:0; z-index:10;} #hideimage {position: absolute; top: 0; right: 0; z-index:20; border:2px solid #900; padding: 5px; background-color: #fff; color: #900; width: 500px;} .stopimage {float: right;} .stopimage img {border: none;} </style> <div id="warningdiv"> <div id="confirmbutton"> <?php if ($GLOBALS['payment'] == 'paypal') { echo tep_image_submit('button_pay_now.gif', IMAGE_BUTTON_PAY_NOW) . '</form></div>' . "\n"; print '<div id="hideimage"><span class="stopimage"><img src="images/stop.gif" /></span>' . TEXT_PAYPAL_WARNING . '<br /><a href="#" onClick="showDiv(\'hideimage\');return false;">'. TEXT_PAYPAL_WARNING_CONFIRM . '</a></div>'; } elseif ($GLOBALS['payment'] == 'paymate') { echo tep_image_submit('button_pay_now.gif', IMAGE_BUTTON_PAY_NOW) . '</form></div>' . "\n"; print '<div id="hideimage"><span class="stopimage"><img src="images/stop.gif" /></span>' . TEXT_PAYMATE_WARNING . '<br /><a href="#" onClick="showDiv(\'hideimage\');return false;">'. TEXT_PAYMATE_WARNING_CONFIRM . '</a></div>'; } else {echo tep_image_submit('button_confirm_order.gif', IMAGE_BUTTON_CONFIRM_ORDER) . '</form></div>' . "\n";} ?> </td> </tr> </table></td> </tr> <tr> <td><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></td> </tr> Not sure if I've entirely understood your question but hopefully that's assisted a bit? If not please advise. Greg

Hi Craig, In the readme I say to put button_pay_now.gif in /catalog/includes/languages/english/buttons/ but obviously if you use a different default images directory (or language) it would need to go there. You don't need to upload the .png version. Is that what you meant? When you say it's not working, what exactly is happening? The only requirement is that Javascript is enabled which is pretty safe to assume these days. Greg

Sure... ;)

Updated to v1.2 * fixed bug in IE where overlay would sit to the left of the 'Confirm Order' button * rewrote css into ids rather than classes * included code to change the 'Confirm Order' button to a 'Pay Now' button when using PayPal or PayMate, which more accurately indicates what clicking the button will actually do. Note you may need to redesign this button to suit your site's look and feel, this is just the one I use, but I have included a layered .png file which should allow you to do this. I used Adobe Fireworks for this but any image program like Photoshop or The Gimp should be able to do something similar.

Incidentally if the PayPal default text 'Return to <vendor>' annoys you as much as it does me for being utterly undescriptive of how important it is to click it, you can customise it to say whatever you want. In /catalog/includes/modules/payment/paypal.php, around line 90 where $process_button_string is being defined, add the following: tep_draw_hidden_field('cbt', 'Complete your order with YOURSTORENAME) . Or whatever you want to say. so the code snippet looks like this: tep_draw_hidden_field('currency_code', $my_currency) . tep_draw_hidden_field('cbt', 'Complete your order with YOURSTORENAME') . tep_draw_hidden_field('return', tep_href_link(FILENAME_CHECKOUT_PROCESS, '', 'SSL')) . Makes far more sense than just 'Return to YOURSTORENAME' as it more accurately describes the importance of the button.

This thread is for discussion on the module of the same title which can be found at http://addons.oscommerce.com/info/7326 This is not the only contribution of this nature but I think it deals with the problem more effectively than some others. Many people seem to have a problem with customers that pay with PayPal (and perhaps other payment modules) not returning to their website. When their customers do this, the store owner receives payment, but does not receive the order information. For a long time I've had an animated .gif on the checkout_confirmation.php page which flashes at the users but we'd still get some people who wouldn't read it. So I've taken it one step further and made a div layer with a warning message that actually sits ABOVE the Confirm Order button and disappears when clicked - so they can't actually get to the 'Confirm Order' button unless they've read the message! It might not stop everyone but at least you've got a mighty big stick to take to those customers who still don't follow the instructions! Installation is straightforward - an image goes into /images/, two lines of text into /catalog/includes/languages/english/checkout_confirmation.php language file, and finally two blocks of code go into /checkout_confirmation.php I'm no great coding expert so I'd welcome anyone to go through my work and revise it as they see fit. Hope it helps someone!

Great module thanks! One question; whenever I update an order and the email is sent out, the order number always comes up as 0 in the email subject. $oID works at least somewhere in edit_orders.php script as the html interface works faultlessly and <?php print $oID; ?> in the html returned the correct number. But not in the email. Any clues? I guess like any new contribution I don't know how the different files all work in together - I've been editing edit_orders.php as this is the page that the admin interface uses and contains lots of tep_mail commands; but I note edit_orders_ajax.php has some too; I have ajax enabled so maybe I should be hunting in there, but when I edit the order in the admin interface I'm still using edit_orders.php, not the ajax version. Regardless, if someone can point me in the right direction for the root cause of this problem I'd be most grateful. I do have the purchase without account module installed on the offchance that has anything to do with this. Update... I've just turned off ajax and found that edit_orders.php now gets used. The order number DOES display OK in this file, just not in the ajax one for some reason.

Actually part of the problem is that the order to product relationship is a one to many (one order may have multiple products), but the csv result is a one to one (i.e. one line per order containing all product and customer details). So field names are obvious for the customer details but once you get further across you'd have to have things like product1, product2, product3 and so on which aren't actual field names in the database. So not quite as simple as it initially looks (to me anyway).

Totally agree, that's actually why I'm here :( I'm not fussed (yet) about the column order but field names / column headings would be great!

http://www.oscommerce.com/forums/index.php?act...amp;pid=1167883 has the answer I've found.

Hi guys, I've done some searching but not found anything on this. osC's default behaviour is to adjust the available stock once an order is completed through checkout; but that allows a situation where two people could add the last unit of a particular product to their cart early in the visit, and whoever happens to checkout second suddenly finds it's already been bought. In a real-life shopping experience, this would be like fronting the cash register and having the bloke in front pull a can of spaghetti out of your trolley and purchase it for himself. Is there a contribution around, or an easy fix, to do these stock adjustments once a product is added to the cart, and not at checkout? Of course that introduces complications where someone could stick something in their cart and then log off and that would prevent others from buying it, but maybe a workaround exists if such a contribution is out there? Perhaps products with less than x units aren't retained in the cart after logout or something. Thanks.

If anyone else gets stuck with this, i.e. in the products_attributes screen in admin under Product Options where the information for Option Name is missing, here's the fix: in /catalog/admin/products_attributes.php, find the following around line 440: // EOF Product Option Type ?> <td align="center" class="smallText"> <?php echo $options_values["products_options_id"]; ?> </td> <!-- BOF Product Option Type --> The problem is the second cell is missing. Change it to this: // EOF Product Option Type ?> <td align="center" class="smallText"> <?php echo $options_values["products_options_id"]; ?> </td> <td class="smallText"><?php echo $options_values['products_options_name']; ?></td> <!-- BOF Product Option Type --> and it should all work! Greg

Just posted a minor fix: in customers.php, the text '<a href="' . tep_href_link(FILENAME_EXPORTORDERS, '', 'NONSSL') . '" class="menuBoxContentLink">' . BOX_CUSTOMERS_ORDERS . '</a>'); should be '<a href="' . tep_href_link(FILENAME_EXPORTORDERS, '', 'NONSSL') . '" class="menuBoxContentLink">' . BOX_CUSTOMERS_EXPORTORDERS . '</a>'); Fixes a small error in /catalog/admin/includes/boxes/customers.php which causes the word 'Orders' to be shown twice in the Customers/Orders panel, with the bottom one activating the Export Orders function. Replace // BOF Export Orders to CSV $contents[] = array('text' => '<a href="' . tep_href_link(FILENAME_CUSTOMERS, '', 'NONSSL') . '" class="menuBoxContentLink">' . BOX_CUSTOMERS_CUSTOMERS . '</a><br>' . '<a href="' . tep_href_link(FILENAME_ORDERS, '', 'NONSSL') . '" class="menuBoxContentLink">' . BOX_CUSTOMERS_ORDERS . '</a><br>' . '<a href="' . tep_href_link(FILENAME_EXPORTORDERS, '', 'NONSSL') . '" class="menuBoxContentLink">' . BOX_CUSTOMERS_ORDERS . '</a>'); // EOF Export Orders to CSV with // BOF Export Orders to CSV $contents[] = array('text' => '<a href="' . tep_href_link(FILENAME_CUSTOMERS, '', 'NONSSL') . '" class="menuBoxContentLink">' . BOX_CUSTOMERS_CUSTOMERS . '</a><br>' . '<a href="' . tep_href_link(FILENAME_ORDERS, '', 'NONSSL') . '" class="menuBoxContentLink">' . BOX_CUSTOMERS_ORDERS . '</a><br>' . '<a href="' . tep_href_link(FILENAME_EXPORTORDERS, '', 'NONSSL') . '" class="menuBoxContentLink">' . BOX_CUSTOMERS_EXPORTORDERS . '</a>'); // EOF Export Orders to CSV Nice contribution dlan!

Uh, the fix for the first problem was to upload ALL of the files in the contribution! B) Still no luck on the second one though... the admin table doesn't line up properly... but at least the basic contribution works. Thoughts?

Hi, I've hit a problem with this. I've got everything installed. In the products attributes screen in the admin panel, I can enter the field name, type and length OK and add that to the Product Options list OK; however how do I then assign this type of field to a particular product? If I go through the normal osC process for adding a field to a product, I have to select the product name I want to add it to in the Products Attributes area, then select an Option Name, all OK so far, but then I have to select an Option Value. Whether or not I choose something here, I end up with a combo box in my product listing even though I selected Text Box, which is exactly what I could achieve without this contribution. Am I missing something? Of lesser importance, but annoying, is in the Product Options list, the option name field is missing. The header row has ID, Option Name, Option Type, Length etc, however the actual data in the table has the values for ID in the ID column, but then option type appears under the Option Name column, Length under the Option Values column and so on. Can anyone point out firstly what I'm doing wrong about implementing this contribution (i.e. how I get the input text field into the product description), and secondly why the Option Name field isn't showing? Thanks!

I have the standard PayPal module installed and I downloaded the PayPal Fee Contribution http://www.oscommerce.com/community/contributions,3132/ some time ago. It installed OK but would not add the surcharge in checkout. I eventually discovered this was because the module appears to have been written for a PayPal IPN payment module not the regular payment module. This is important because the variable used for the regular module is 'paypal', whereas the variable for the IPN module appears to be 'paypal_ipn'. If you have the standard PayPal module and this contribution, here's what you need to do to fix this: * Open /catalog/includes/modules/order_total/ot_paypal_fee.php * Locate this function: function process() { global $order, $currencies, $paypal_fee; if (MODULE_ORDER_TOTAL_PAYPAL_STATUS == 'true') { //check if payment method is paypal. If yes, add fee. if ($GLOBALS['payment'] == 'paypal_ipn') { $paypal_fee = tep_round(((MODULE_ORDER_TOTAL_PAYPAL_FEE/100) * $order->info['total']), $currencies->currencies[DEFAULT_CURRENCY]['decimal_places']); * Change the following: if ($GLOBALS['payment'] == 'paypal_ipn') { to if ($GLOBALS['payment'] == 'paypal') { * That's it! Greg