Jump to content

241

Members
  • Content count

    6,148
  • Joined

  • Last visited

Posts posted by 241


  1. @Jack_mcs

    no worries these are not problems for me I have fixed, just thought to bring them to your attention in case you were unaware

    A thought that you may want to use is_countable for future php  (PHP 7 >= 7.3.0) it can be implemented in compatibility mode now  as a function will help with all your count()


  2. I also found I needed to modify the last part to

    	   if (empty($oInfo->customer_service_id)){
           $contents[] = array('text' => '<br>' . TEXT_INFO_CUSTOMER_SERVICE_ID . ' No ID.');  
    	   }else{
           $contents[] = array('text' => '<br>' . TEXT_INFO_CUSTOMER_SERVICE_ID . ' '  . $oInfo->customer_service_id);
    	   }

    though that may be because of the heavy modifications


  3. look at the end of the file in the section default I have a very heavily modified site but you should look for something starting like this

            $contents[] = array('align' => 'center', 'text' => tep_draw_button(IMAGE_ORDERS_DETAIL, 'document', tep_href_link('orders.php', tep_get_all_get_params(array('oID', 'action')) . 'oID=' . $oInfo->orders_id . '&action=edit')) . 

     


  4. @freakystreak

    I have this working without any Notice, Warning or Deprecated on php 7.36 spent a lot of time trawling through the code updating and modifying adding additional hint info, attributes, tax and shipping all working even spits out nice templated html emails

    edit_order_mod.gif


  5. @Jack_mcs

    No worries got a few more for you

    admin/header_tags_fill_tags.php
    Notice: Undefined variable: sleep in admin/header_tags_fill_tags.php on line 703
    Notice: Undefined variable: sleep in admin/header_tags_fill_tags.php on line 704

    missing initial declaration for the variable $sleep outside of action
    either
      $sleep = '';
    or
      $sleep = false;


    admin/header_tags_seo_keywords.php
    Notice: Undefined index: date in admin/header_tags_seo_keywords.php on line 371
    Notice: Undefined index: searches in admin/header_tags_seo_keywords.php on line 372
    Notice: Undefined index: google_last_position in admin/header_tags_seo_keywords.php on line 373

    admin/header_tags_seo_silo.php
    Notice: Undefined offset: 1 in admin/header_tags_seo_silo.php on line 152
    Notice: Undefined offset: 1 in admin/header_tags_seo_silo.php on line 156
    Notice: Undefined offset: 1 in admin/header_tags_seo_silo.php on line 162 Date
    Notice: Undefined offset: 1 in admin/header_tags_seo_silo.php on line 163 Name
    Notice: Undefined offset: 1 in admin/header_tags_seo_silo.php on line 164 Best Seller
    Notice: Undefined offset: 1 in admin/header_tags_seo_silo.php on line 165 Custom
    Notice: Undefined offset: 1 in admin/header_tags_seo_silo.php on line 171
    Notice: Undefined variable: selectedCats in admin/header_tags_seo_silo.php on line 174

    admin/header_tags_seo_social.php
    Notice: Undefined index: 24x24 in admin/header_tags_seo_social.php on line 245
    Notice: Undefined index: 32x32 in admin/header_tags_seo_social.php on line 245
    Notice: Undefined index: 48x48 in admin/header_tags_seo_social.php on line 245
    Notice: Undefined index: creator in admin/header_tags_seo_social.php on line 306


  6. admin/includes/functions/header_tags.php line 104

        if (($fileSaved && $cntNewFiles) || (! $fileSaved && (count($existingFiles) != $cntNewFiles))) {     

    count($existingFiles)

    Notice: Undefined variable: existingFiles

    Warning: count(): Parameter must be an array or an object that implements Countable

    $existingFiles is not an array or object


  7. you can use the free shipping admin > modules > Order Total > shipping

    set allow free shipping true and set the amount

    and for the other you just want to add a message stating that the costs vary and they will be contacted, so adapt the flat rate to fit


  8. is the original code in includes/modules/content/login/cm_paypal_login.php lines 212-220 correct

                  if (ACCOUNT_STATE == 'true') {
                    if ($ship_zone_id > 0) {
                      $sql_data_array['entry_zone_id'] = $ship_zone_id;
                      $sql_data_array['entry_state'] = '';
                    } else {
                      $sql_data_array['entry_zone_id'] = '0';
                      $sql_data_array['entry_state'] = $ship_zone;
                    }
                  }

    more so line 215

                      $sql_data_array['entry_state'] = '';

    if you have the ship_zone_id which is derived from the query based on PayPal response for country and zone being from region should the line not be

                      $sql_data_array['entry_state'] = $ship_zone;

    and line 218 be

                      $sql_data_array['entry_state'] = '';

     


  9. Couldn't edit my post

    In ext/modules/payment/paypal/express.php on line 281 I changed

    $paypal_express->_app->log('EC', 'CallbackResponse', 1, $log_sane, $params);

    to

    $paypal_express->_app->log('EC', 'CallbackResponse', 1, $log_sane, $params, (OSCOM_APP_PAYPAL_EC_STATUS == '1') ? 'live' : 'sandbox');

    This gave me the missing CallbackResponse in the PayPal log an got rid of the error messages in system logs.

    The 7th argument would be for IPN which could be set true but has default false.

    I was able to edit this post


  10. In ext/modules/payment/paypal/express.php on line 281 I changed

    $paypal_express->_app->log('EC', 'CallbackResponse', 1, $log_sane, $params);

    to

    $paypal_express->_app->log('EC', 'CallbackResponse', 1, $log_sane, $params, OSCOM_APP_PAYPAL_EC_STATUS);

    This gave me the missing CallbackResponse in the PayPal log an got rid of the error messages in system logs


  11. 2 hours ago, MrPhil said:

    Comparing all the ...->_app->log(... calls in Frozen, it looks like ext/modules/payment/paypal/express.php on line 281 is missing a sixth parameter: ,(OSCOM_APP_PAYPAL_PS_STATUS == '1') ? 'live' : 'sandbox' . Is that the only fix needed, or are there more? Can someone with a PayPal setup try it out?

    would that not be EC for express rather than PS for standard?


  12. Seeing error for too few arguments to function OSCOM_PayPal::log(), 5 passed in ext/modules/payment/paypal/express.php on line 281 and at least 6 expected in includes/apps/paypal/OSCOM_PayPal.php line 23

    ext/modules/payment/paypal/express.php on line 281 5 arguments

    $paypal_express->_app->log('EC', 'CallbackResponse', 1, $log_sane, $params);

    includes/apps/paypal/OSCOM_PayPal.php line 23 6 arguments. Argument 6 would be $server

    function log($module, $action, $result, $request, $response, $server, $is_ipn = false) {

     


  13. @burt what are you using for your line breaks?

    content-type: text/plain
    "\n" - move cursor to next line
    "\r" - move curser to beginning of the line
    "\n\r" - produces 2 new lines whereas "\n", "\r" and "\r\n" give single lines
    
    content-type: text/html
    <br> - single line break HTML
    <br /> - single line break XHTML
    HTML5 allows both but prefers <br>
    
    nl2br($str, boolean) - replace \n with <br> or <br />
    boolean - true/false default true
    nl2br($str, true) same as nl2br($str)

     


  14. I remember changing the curl calls for IPN

        curl_setopt($ch, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_1_1);
        curl_setopt($ch, CURLOPT_SSLVERSION, CURL_SSLVERSION_TLSv1_2);


    Paypal had a page about the changes required for TLS 1.2

×