Jump to content

Jack_mcs

Members
  • Content count

    29,682
  • Joined

  • Last visited

  • Days Won

    128

Reputation Activity

  1. Like
    Jack_mcs got a reaction from valquiria23 in Sitemap SEO   
    I don't know but probably not, at least completely. For any older addon that displays something on a page of the shop, a change is needed to properly work with BS4, though sometimes the page will load fine without it. But this addon would change too many core files so I wouldn't recommend using it until that has been changed. I don't know when that will be.
  2. Thanks
    Jack_mcs got a reaction from mhsuffolk in [CONTRIBUTION] Ultimate SEO URLs v2.1 - by Chemo   
    At line 1883 in the includes/classes/seo,class.php filem change
    continue; to
    continue 2;  
  3. Like
    Jack_mcs got a reaction from PiLLaO in Sitemap SEO   
    There was meant to be a file in admin/includes/languages/English/modules/boxes/ named sitemap_seo.php with those lines. Having the file there prevents the need to change an existing file. The way you added it will work too.
  4. Like
    Jack_mcs got a reaction from PiLLaO in Sitemap SEO   
    That file is no longer used so the boxes section won't work as in previous shops. That will be fixed in a future version, though I don't know when that will be. For this one, change this line
    $file = DIR_FS_CATALOG . $end . 'includes/filenames.php'; to
    return '';  
  5. Thanks
    Jack_mcs reacted to kgtee in Jssor Slider   
    I have been trying to figure out how to get the banner click count working. I just found the solution.
    In the template file tpl_cm_i_jssor.php:
    Now, the URL click counts are ticking too. 😄😂😊
  6. Like
    Jack_mcs got a reaction from valquiria23 in HoneyPot Captcha   
    A change was mentioned in Fake Accounts thread to check TOR IP's, which are often used by spammers and hackers. The code to make this change is below. I will add it to the next release once I have time to add a setting and package it. To use it now, open the includes/functions/honeypot.php file and find this line:
    $db_table = 'honeypot_track'; and add this above it:
    if (CheckTOR()) { return true; } Then at the end of the file, add this
    function CheckTOR() { $ips = file("https://check.torproject.org/cgi-bin/TorBulkExitList.py?ip=1.1.1.1"); $found = false; foreach ($ips as $ip) { if (strpos($ip, $_SERVER['REMOTE_ADDR']) !== FALSE) { $found = true; break; } } return $found; }  
  7. Like
    Jack_mcs got a reaction from fiodh in Fake accounts   
    @OzaHoney Pot will stop the majority of them.
  8. Like
    Jack_mcs got a reaction from pete2007 in Using PHP 7.1 with Osc 2.3.4 is it safe?   
    It's not a question of whether it is safe or not. The higher versions of php usually fix security holes in previous ones and shouldn't introduce any in the shop that weren't already there. The real question is if it works or not. You should thoroughly test all parts of the shop to make sure they work correctly, especially when it involves addons. If they do, then you can stay on 7.2.
  9. Like
    Jack_mcs got a reaction from ArtcoInc in Category Images   
    That addon only works in BS3 shops because it uses the "equal-height" class and that class is not used in BS4 (Phoenix). I haven't looked at the code in Phoenix to see how that problem is handled but the following should allow that addon to work. In the includes/modules/content/index/templates/category_images.php file, change this line
    <div class="card-body category-images-item"> to
    <div class="card-body equal-height category-images-item"> But to be clear, the main reason the two boxes are so different in height is because the second one is missing the image. If you add an image for it that might fix the problem. If you don't have an image for a particular category, creating one for a replacement, like "No Image Available" would be the best choice.
  10. Like
    Jack_mcs got a reaction from ArtcoInc in Category Images   
    Yes, that is correct. The "equal-height" added to the code is just a flag to tell the equal height module where to look. They are both required for it to work. You will also need to make the code change in the other template files for this addon as well if the problem is seen for them. That part of the code is the same in each so it should be easy to find.
    Thanks for posting that it worked.
  11. Like
    Jack_mcs got a reaction from JcMagpie in Purchase Quantity on Product Listing & info pages   
    For the product listing page, there are addons for that but they won't work as expected if the products have attributes. In that case, as far as I know, no one has coded that. For quantity on the product page, you can install this addon.
  12. Like
    Jack_mcs reacted to ammsimon in [CONTRIBUTION] Ultimate SEO URLs v2.1 - by Chemo   
    Hello
    Thank you for excusing my english
    Oscommerce 2.3.4 / ultimate seo url 2.2d18 / php7
    Rewriting Works very well, but I see the robots on the following urls
    /my-product-name-p-788.html?products_id=788 (for more products)
    For manufacturers too
    /my-manufacturer-name-m-32.html?manufacturers_id=32
    Is it normal ?
    Can someone help me
    thank you so much
  13. Thanks
    Jack_mcs got a reaction from Heatherbell in Category Images   
    A new version has been uploaded with these changes:
    Added a version for Phoenix. Added an option to allow controlling which categories are displayed. Added a module for sub-categories. Added a module for categories with product pages. Changed install text to mention the equal heights addon. Corrected mistake in the module that was storing some of the settings in the wrong place. Corrected mistake in the css that would prevent other css from working. Moved the css code from user.css to the ext/css/category_images,css file. Replaced unused variable with the correct code. Found by member @Moxamint.  
  14. Thanks
    Jack_mcs got a reaction from Heatherbell in Category Images   
    A new version has been uploaded with these changes:
    Added a version for Phoenix. Added an option to allow controlling which categories are displayed. Added a module for sub-categories. Added a module for categories with product pages. Changed install text to mention the equal heights addon. Corrected mistake in the module that was storing some of the settings in the wrong place. Corrected mistake in the css that would prevent other css from working. Moved the css code from user.css to the ext/css/category_images,css file. Replaced unused variable with the correct code. Found by member @Moxamint.  
  15. Thanks
    Jack_mcs got a reaction from Heatherbell in Category Images   
    A new version has been uploaded with these changes:
    Added a version for Phoenix. Added an option to allow controlling which categories are displayed. Added a module for sub-categories. Added a module for categories with product pages. Changed install text to mention the equal heights addon. Corrected mistake in the module that was storing some of the settings in the wrong place. Corrected mistake in the css that would prevent other css from working. Moved the css code from user.css to the ext/css/category_images,css file. Replaced unused variable with the correct code. Found by member @Moxamint.  
  16. Thanks
    Jack_mcs got a reaction from Heatherbell in Category Images   
    A new version has been uploaded with these changes:
    Added a version for Phoenix. Added an option to allow controlling which categories are displayed. Added a module for sub-categories. Added a module for categories with product pages. Changed install text to mention the equal heights addon. Corrected mistake in the module that was storing some of the settings in the wrong place. Corrected mistake in the css that would prevent other css from working. Moved the css code from user.css to the ext/css/category_images,css file. Replaced unused variable with the correct code. Found by member @Moxamint.  
  17. Thanks
    Jack_mcs got a reaction from Heatherbell in Category Images   
    A new version has been uploaded with these changes:
    Added a version for Phoenix. Added an option to allow controlling which categories are displayed. Added a module for sub-categories. Added a module for categories with product pages. Changed install text to mention the equal heights addon. Corrected mistake in the module that was storing some of the settings in the wrong place. Corrected mistake in the css that would prevent other css from working. Moved the css code from user.css to the ext/css/category_images,css file. Replaced unused variable with the correct code. Found by member @Moxamint.  
  18. Thanks
    Jack_mcs got a reaction from Heatherbell in Category Images   
    A new version has been uploaded with these changes:
    Added a version for Phoenix. Added an option to allow controlling which categories are displayed. Added a module for sub-categories. Added a module for categories with product pages. Changed install text to mention the equal heights addon. Corrected mistake in the module that was storing some of the settings in the wrong place. Corrected mistake in the css that would prevent other css from working. Moved the css code from user.css to the ext/css/category_images,css file. Replaced unused variable with the correct code. Found by member @Moxamint.  
  19. Like
    Jack_mcs got a reaction from kgtee in Jssor Slider   
    Thanks for mentioning this. The way I did it was place my javascript within code to wait for the script to load. It's in the module so there's not any changes to the core files.
    window.addEventListener('DOMContentLoaded', function() { //script goes here });  
  20. Thanks
    Jack_mcs got a reaction from kgtee in Jssor Slider   
    It shouldn't cause a problem with other code, that I can think of. But it is not the correct change since it will break should you ever update the core files. See my Message Box addon for the code change to allow it to work without changing the core files.
  21. Like
    Jack_mcs got a reaction from valquiria23 in What to do with .com and .co.uk   
    Pointing it to the .com site just does that. It won't gain you anything other than making sure anyone using that domain name ends up on the other one and you prevent a competitor from using it. Having the .co.uk point to .com may be useful for UK searches since google UK will return those due to location.
    Creating an information site can be useful for SEO purposes, if done correctly. You can use a link from it to the .com site, or vice versa. But not both if you end up with a duplicate site since google may punish for that. But don't expect anything useful from the search engines right away. They will usually delay ranking for many months to insure the site is real. Otherwise you could create a hundred shops today and point them all to one site in an attempt to help that site. But I think having a different site with a similar name might be confusing to your visitors. They may type in .co.uk by mistake and see that you don't have products and assume the site is no longer available for products. So you would want to make it clear the sites are related.
    Personally, I think the name is too similar to the original to be anything other than a pointer to the original. One exception might be if you want to target your UK visitors differently, like giving them a discount or location-specific options. The .co.uk site will generally be returned to UK searchers for the same search term over the .com, though that assumes the pages are setup for the same keywords.
  22. Like
    Jack_mcs got a reaction from alex121121 in Auto Update Currencies   
    First, check the php version you are using in admin->tools->Server Info, It has to be 5.3 or above. If it is, edit the admin/auto_update_currencies.php file and change
    if (! isset($_SERVER['HTTP_USER_AGENT'])) { //ran by cron require('includes/application_top.php'); } to
    require('includes/application_top.php'); Does that make a difference?
  23. Thanks
    Jack_mcs got a reaction from Heatherbell in Message Box   
    I'll try to get an update within the month. If there are other addons that are used, it is best to post the message in the support thread for it. I don't have time to run through all of my addons so, initially, I will only be doing the ones I or my clients use or when there is a request like yours.
  24. Like
    Jack_mcs got a reaction from ArtcoInc in Message Box   
    I think interest in it is high so I suspect addons will be converted more quickly than with the VS3 version. At least, I hope so. :)
  25. Thanks
    Jack_mcs reacted to Heatherbell in Message Box   
    @Jack_mcs Many thanks for this module - just loaded into a new Phoenix and works great.
×