Jump to content

Jack_mcs

Members
  • Content count

    29,682
  • Joined

  • Last visited

  • Days Won

    128

Jack_mcs last won the day on August 12

Jack_mcs had the most liked content!

Profile Information

Recent Profile Visitors

236,410 profile views
  1. I probably wasn't clear. I know how to use hooks. My confusion is with trying to understand what the purpose of that statement is for. For example, let's say I normally include a require('some file') statement after the html_output statement. That would take one line. If I have to register and call the hook, it is two lines. The count doesn't matter. The point is that there doesn't seem to be an advantage in using it at that point in the code. I assumed that adding the hook there would prevent changes to the core code but that doesn't seem to be the case. Is that correct? I could see it would be useful if I was adding a large block of code there but for one line changes, it probably isn't. I'm not criticizing it being there - just trying to make sure I understand it.
  2. @burtIn one of the upgrades you added a call to hooks in the aaplication_top after the require('includes/functions/html_output.php'); statement. I'm wondering if am missing something in my understanding of hooks. I thought you had to initialize and call them. Is that not correct? If I add a hook to the hooks/shop/ directory it doesn't get called. So am I doing something wrong or just not understanding the use?
  3. Jack_mcs

    Gift Vouchers Secure

    I've not ran across this problem. My guess is it has to do with the php version you are running. Those versions of oscommerce should run on php 5.4 without any issues to so I suggest making that change. I don't have a test shop here with this addon installed that will run with php 5.3 so I can't test it. But it might also be the version of the files you are using. The latest changes are only for shops that can load modules. Your 2.3.4.1 shop should be able to do that but not the 2.3.1. If you have used code from the non-CE versions in the package, you may have unfinished code since not all of that was updated, as I recall.
  4. Jack_mcs

    Frozen: tep_draw_button problem

    I think this will work echo tep_draw_button(IMAGE_BUTTON_CONTINUE, 'fa fa-angle-right', tep_href_link('index.php'), null, array('type'=>'button','newwindow'=>'1'), null );
  5. I suggest moving all of the box definitions in admin's english.php file into module files. The code is already in place for that and, to me, makes more sense to use it. The attached contains and edited english.php file and all of the files for the standard boxes. admin_boxes.zip
  6. Jack_mcs

    Automatically send data feed to Froogle

    If you have the SEO_ENABLED setting set to true, then you may need to change the tep_href_link to tep_catalog_href_link. If not, the only thing I can think of is that your shop is not set up to work fully with ssl. Be sure there is redirect code in the roots .htaccess file to redirect to https.
  7. Jack_mcs

    Header Tags SEO

    Yes, it will. The problem is that much of the code for the shop side needs to be changed to modules or hooks. I have done some already but it takes a lot of time so I'm not sure when it will be ready.
  8. Jack_mcs

    Information Pages SEO addon

    Yes, it will work. There are some problems with the released version that will still be there but they won't stop it from working. I'll release an update with those fixes but it might be a month or so.
  9. Jack_mcs

    Automatically send data feed to Froogle

    Thank you for posting the code. It may be useful to others.
  10. Jack_mcs

    Automatically send data feed to Froogle

    @Adam_MaynardSee my email. @bitit.itThe code tries to figure out which php version is being used. I looks like it thinks you are using a version that used MySQL. Try changing this line in the googlefeeder.php file $myfetch_mysql = ($use_mysqli ? mysqli_fetch_object : mysql_fetch_object); to $myfetch_mysql = mysqli_fetch_object;
  11. Jack_mcs

    Sitemap SEO

    I don't know but probably not, at least completely. For any older addon that displays something on a page of the shop, a change is needed to properly work with BS4, though sometimes the page will load fine without it. But this addon would change too many core files so I wouldn't recommend using it until that has been changed. I don't know when that will be.
  12. At line 1883 in the includes/classes/seo,class.php filem change continue; to continue 2;
  13. Jack_mcs

    Category Problem for update.

    @alexiscruz007You can ask your host to enable short tags in php. As @bonbec mentioned, it is not the best practice but it is a quick way around the problem if you don't know how to edit the code.
  14. Jack_mcs

    reviews

    @bitit.itThe code checks if the product in the review has an active status and if the review has an active status. Assuming your products are all enabled and active, the problem might be that your reviews don't have a reviews_status field. Older versions of oscommerce didn't have that field so you may need to add it to the table.
  15. Jack_mcs

    reviews

    There are many versions of oscommerce and they are not all coded the same way. When it isn't known what version is being used, I, and others, can only guess at what the problem might be. In Phoenix, there is a Reviews module in the Modules->Navbar modules section, Do you have that enabled?
×