Jump to content

Jack_mcs

Members
  • Content count

    29,671
  • Joined

  • Last visited

  • Days Won

    128

Everything posted by Jack_mcs

  1. Jack_mcs

    Google XML Sitemap SEO

    Yes, I think it would be helpful. It was requested for the google base feeder too. I added it to that addon and will to this one eventually but it will be quite a while before I can get to it.
  2. Jack_mcs

    Google XML Sitemap SEO

    Hi Valquiria . :) The sitemapimages.xml only contains the main image for the product. The main image is stored in the products table but any additional images are stored in the products_images table and the code in this addon doesn't access that table. It would be possible but would not be a simple code change.
  3. Jack_mcs

    I have no "main_page.tpl.php" file

    This one might work better for you.
  4. Jack_mcs

    Sitemap SEO

    @valquiria23I'm sorry but I don't understand your question. This addon doesn't have anything to do with images. Maybe you meant to ask in the google sitemap thread? If you meant this one, please explain in more detail.
  5. Jack_mcs

    Article Manager v1.0

    Those errors are caused by code Header Tags SEO, not this addon. Please post any problems for it in its support thread. With that said, you can change the code to the following and it might fix it (haven't tested it): if ($fillTagsCtr['categories'] == 0 && is_array($fillTagsErrors) && count($fillTagsErrors['categories']) == 0) { if ($fillTagsCtr['manufacturers'] == 0 && is_array($fillTagsErrors) && count($fillTagsErrors['manufacturers']) == 0) {
  6. Jack_mcs

    Article Manager v1.0

    A blank page, after a change like this one, is usually due to a mistake in the code being added. Bu I have tried it here and it is working fine. If you can't see a problem with the change, please paste the contents of that file here so I can copy and test it.
  7. Jack_mcs

    Article Manager v1.0

    To fix this, find this line in includes/modules/article_manager.php if (isset($_GET['articles_id'])) { and replace it with if (isset($_GET['articles_id']) && ENABLE_HEADER_TAGS_SEO == 'true') { Just so you know, or anyone else reading this, there's no reason to uninstall existing installations of this addon to install the latest one. There is an update file in the Docs directory that explains what is needed to upgrade.
  8. Jack_mcs

    Payment Method Not Showing in Checkout

    What happens if you disable all of the modules except COD? If it shows then something is wrong in the code of one of the other modules. If it still doesn't display, see if there is an error_log file in the shops root to see if any errors are occurring.
  9. Jack_mcs

    Article Manager v1.0

    And what does the error say?
  10. Jack_mcs

    Article Manager v1.0

    Which line would that be? The code you posted doesn't have the change I mentioned so it is unclear where you added it. Also, the code for BS4 is an afterthought since that is not a finished package. Article Manager should work in it but I don't have a BS4 shop setup that doesn't have Header Tags SEO installed so I can't say for sure. I do have a BS4 shop with Header Tags SEO installed and this addon works correctly in it but that doesn't help in your case.
  11. Jack_mcs

    Article Manager v1.0

    @Dnj1964You don't mention the version of your shop (please always do that) but I will assume Frozen since that is the only version that setting will work with. I just tried it here and it works as expected so I don't have an answer as to why it would fail. But here's a quick fix. Find this line in admin/articles.php $hts_status = (ENABLE_HEADER_TAGS_SEO != 'true' ? 'disabled="disabled" ' : ''); and add this below it if (false) .
  12. Jack_mcs

    Left Column - pushed to bottom on poduct page

    That usually happens due to an extra or missing div tag. Have you made any code changes? If not, it could be due to the product description. Add a new product without a description and see if it displays correctly or not. If it does, then the problem is in your product descriptions. If it doesn't, then some code that is only on the product page (assuming that is the only place it fails) is at fault.
  13. Jack_mcs

    Sitemap SEO

    You shouldn't have had to do that. No changes are needed in admin to install this addon. I know there is an english.php file in the files to be changed directory but that is just there because I forgot to delete it. It won't hurt anything to add to the english file but shouldn't be needed.
  14. Jack_mcs

    Auto set currency based on ip

    @alex121121The addon mentioned by @raiwawas meant for the purpose you want. However, it uses a third-party site to check the IP and if you go to that site (mentioned on the addon page), you will see it says closed. The site may still work but IP's won' be updated, from the looks of it. Also, if it does work, there is a limit in the code that only allows a certain number of checks for a certain period. That won't matter on slow sites but will on busier ones. There was also a problem with that other site, as I recall, that if it was busy or not responding, the calling site would set and wait. Any benefit of showing the currency would be lost if a customer has to wait. And one final point, IP's are not country-specific so the addon might report the wrong country. This is especially true in Europe where the countries are so close together.
  15. I'm not sure of the precedence order when a sprintf command is used for a function in a language file. I wouldn't code it that way. It might be that the link is being built before the text is added. If all else fails, I would re-code it so there aren't three things going on in one call. Other than that, the only other thing I can think of is if you are using Header Tags SEO and haven't enabled the option for it in this addon and/or not ran fill tags. For the url spaces, see this. The code would go before the rewrites for those of this addon.
  16. Jack_mcs

    Need help with a query

    If this is something that doesn't change and the sub-category is in the format of A_B..._Z, like 25_5, you would just use the last number, 5 in this case, in the statement instead of the 25. If it will change based on what you click on, then you need to add code to get the last category ID from the given category string.
  17. Try changing the $v['name'] to "test". If test shows up in the url, then the $v['name'] is not set. Also, to be clear, the url would not have the slash you show so it would be https://www.site.com.au/name-of-product-p-700.html . That was probably a typo but I thought I should mention it.
  18. Jack_mcs

    Need help with a query

    This might work $products = tep_db_query("select pd.products_name, p.products_id, p.products_model from products p left join products_description pd on pd.products_id = p.products_id left join products_to_categories p2c on p.products_id = p2c.products_id where p2c.categories_id = 25 and pd.language_id = '" . (int)$languages_id . "' and p.products_id <> " . (int)$_GET['pID'] . $where_str . " order by p.products_model");
  19. Jack_mcs

    Header Tags SEO

    I don't have an answer for you. There's no way for me to test pre-2.3 code with 7.2 short of setting up a special file for that purpose and that's beyond what I can do in a support thread. I think you would be better off figuring out how to get rid of the preview code. There's really no reason to have it that I can see. It just adds another step in managing the product.
  20. Jack_mcs

    All Products SEO

    This is the release of All Products SEO. It is really an update to my previous version, All Products with Images, but like so many contributions lately, that one has been damaged by all of the various changes. So I moved it to a new version and locked it to better control what gets "fixed." This version fixes some problems in my last version of that contribution as well as some introduced by others. It adds several options to admin to allow better control of the display and is setup ready to run with Header Tags SEO. Jack
  21. Jack_mcs

    Header Tags SEO

    Maybe you are looking at an edited file? The one included in V 3.3.5 has the following code: } elseif ($action == 'new_product_preview') { if (tep_not_null($HTTP_POST_VARS)) { $pInfo = new objectInfo($HTTP_POST_VARS); $products_name = $HTTP_POST_VARS['products_name']; $products_description = $HTTP_POST_VARS['products_description']; $products_head_title_tag = $HTTP_POST_VARS['products_head_title_tag']; $products_head_title_tag_alt = $HTTP_POST_VARS['products_head_title_tag_alt']; $products_head_title_tag_url = $HTTP_POST_VARS['products_head_title_tag_url']; $products_head_desc_tag = $HTTP_POST_VARS['products_head_desc_tag']; $products_head_keywords_tag = $HTTP_POST_VARS['products_head_keywords_tag']; $products_head_breadcrumb_text = $HTTP_POST_VARS['products_head_breadcrumb_text']; $products_head_listing_text = $HTTP_POST_VARS['products_head_listing_text']; $products_head_sub_text = $HTTP_POST_VARS['products_head_sub_text']; $products_head_additional_words = $HTTP_POST_VARS['products_head_additional_words']; $products_url = $HTTP_POST_VARS['products_url'];
  22. Jack_mcs

    All Products SEO

    Replace the above with foreach ($define_list as $column => $value) {
  23. Jack_mcs

    Product Quantity Box

    You're welcome. :)
  24. Jack_mcs

    Product Quantity Box

    Change the above to public static function execute() { Please let me know if it still fails.
  25. With regards to optimization to help reduce the load your host mentioned, absolutely, assuming indexes do not already exist. Adding them won't help with security in any way so if you are having security issues, those should be handled first.
×