www.in.no

Members
  • Content count

    361
  • Joined

  • Last visited

Community Reputation

7 Neutral

1 Follower

About www.in.no

Profile Information

  • Real Name
    Arild Evensen
  • Gender
    Male
  • Location
    Haugesund, Norway
  1. Not a pain, just pleasure :) admin/includes/configure.php includes/configure.php
  2. Normally in configuration files, but i don't know if HT SEO stores the path other places...
  3. I thought that most of your work was validating, otherwise i should think that your code never should work as good as i does :-)
  4. @@isysni Looks like the server path has changed. /home/kidditra/public_html/bluetoothit/ is not the same as /home/kidditra/public_html/www.bluetoothit.co.uk/
  5. I am aware of thet it is just an anchor name, but the output i get from the W3 validation show me what i think is a invalid link. I changed it to this and now it is working and showing a correct link. (Not concerned about the space, it validate anyway.) <a title="' . $header_tags_array['title'] . '" href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $product_info['products_id'], 'NONSSL') . '#' . $header_tags_array['title'] . '"> But the "/ made it not validate, and " should be paired, and in the original code the numbers of " was odd not even. So eighter there was one to little or one to much. And the validating is more for fun and have a quick check that i don't miss or add to many tags that break up the code. Many of the addons is not written for the latest OSC (2.3.3), and even if they claim to be 2.3 ready there are still some major changes after that.
  6. HTML is not case-sensitve, but validation at W3 looks like it is. :-)
  7. OK, but i think it is a little miss formatted. Shouldn't the " be removed in front of /# as there is 5 pcs. in that line and you also have a space after /# ', making the link also have space between and therefor not valid. Stock code echo '<a title="' . $header_tags_array['title'] . '" href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $product_info['products_id'], 'NONSSL') . '"/# ' . $header_tags_array['title'] . '">' . $header_tags_array['title'] . '</a>'; Changed if (HEADER_TAGS_DISPLAY_CURRENTLY_VIEWING == 'true') { echo '<div style="margin-top:5px;"><div style="text-align:center" class="smallText">' .TEXT_VIEWING . ' '; if (! tep_not_null($header_tags_array['title'])) $header_tags_array['title'] = $product_info['products_name']; echo '<a title="' . $header_tags_array['title'] . '" href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $product_info['products_id'], 'NONSSL') . '/#' . $header_tags_array['title'] . '">' . $header_tags_array['title'] . '</a>'; echo '</div></div>'; } /*** End Header Tags SEO ***/
  8. Is this code correct. Getting validation error on this, and it seems duplicated. " . '"/# ' . $header_tags_array['title'] . '">' . $header_tags_array['title'] . ' " Should it be " . '">' . $header_tags_array['title'] . ' " if (HEADER_TAGS_DISPLAY_CURRENTLY_VIEWING == 'true') { echo '<div style="margin-top:5px;"><div style="text-align:center" class="smallText">' .TEXT_VIEWING . ' '; if (! tep_not_null($header_tags_array['title'])) $header_tags_array['title'] = $product_info['products_name']; echo '<a title="' . $header_tags_array['title'] . '" href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $product_info['products_id'], 'NONSSL') . '"/# ' . $header_tags_array['title'] . '">' . $header_tags_array['title'] . '</a>';
  9. The /all-products.php file does also have some errors. There are used a uppercase </A> tag, And the tep_draw_form had wrong parameter order. It was <?php echo tep_draw_form('allproducts_cat', FILENAME_ALLPRODS_SEO, '', 'post') and should be <?php echo tep_draw_form('allproducts_cat', FILENAME_ALLPRODS_SEO, 'post', '') all-products.php
  10. There are one validating error in the code i made with moving all table to the all-products.php file.: There is need for one table in the /price_list.php file as the function is called upon itself inside /include/functions/all-products.php file <?php echo '<table width="100%" border="0" cellspacing="0" cellpadding="0">'; AP_GetGroup(0,0); echo '</table>'; ?> And the all-products.php file with indications on whitch line to remove, function AP_GetGroup($id_parent, $position){ global $languages_id; $groups_price_query = tep_db_query("select c.categories_id, cd.categories_name from " . TABLE_CATEGORIES . " c left join " . TABLE_CATEGORIES_DESCRIPTION . " cd on c.categories_id = cd.categories_id where c.parent_id = " . (int)$id_parent . " and cd.language_id = " . (int)$languages_id . " order by c.sort_order"); $titleShown = false; $cols = 2; if (ALL_PRODUCTS_SEO_PRICE_SHOW_MODEL == 'true') $cols++; if (ALL_PRODUCTS_SEO_PRICE_SHOW_PRICE == 'true') $cols++; if (ALL_PRODUCTS_SEO_PRICE_SHOW_QTY == 'true') $cols++; $width = floor(100/$cols); //CUT FROM HERE TABLE echo '<table width="100%" border="0" cellspacing="0" cellpadding="0">'; while ($groups_price = tep_db_fetch_array($groups_price_query)) { $catpad = ""; $catPad = str_replace(" ", " ", str_pad($catPad, ($position * 3), " ", STR_PAD_LEFT)); //pad str wont accept so prefill and replace if($position == 0 && ! $titleShown) { $titleShown = true; echo '<tr><td colspan="' . $cols . '" width="100%" class="allCategoryPriceSubHdr"><table border="0" cellpadding="0" cellspacing="0" width="100%"><tr>'; echo '<td align="left" width="' . $width . '%">' . PRICE_HEADING_CATEGORY . '</td>'; if (ALL_PRODUCTS_SEO_PRICE_SHOW_QTY == 'true') { echo '<td align="left" width="' . $width . '%"> ' . PRICE_HEADING_STOCK . '</td>'; } if (ALL_PRODUCTS_SEO_PRICE_SHOW_MODEL == 'true') { echo '<td align="left" width="' . $width . '%">' . PRICE_HEADING_MODEL . '</td>'; } echo '<td align="left" width="' . $width . '%">' . PRICE_HEADING_PRODUCT . '</td>'; if (ALL_PRODUCTS_SEO_PRICE_SHOW_PRICE == 'true') { echo '<td align="right" width="' . $width . '%">' . PRICE_HEADING_PRICE . ' </td>'; } echo '</tr></table></td></tr></table>'; } echo '<table border="0" cellpadding="0" cellspacing="0" width="100%">'; if (AP_CheckProducts($groups_price['categories_id']) || $position == 0){ echo '<tr><td colspan="' . $cols . '" width="100%" class="allproductPriceSubHdr">' . $catPad . $groups_price['categories_name'] . '</td></tr>'; AP_GetProducts($groups_price['categories_id'], $width); } AP_GetGroup($groups_price['categories_id'],$position+1); } //CUT END FROM HERE echo '</table>'; }
  11. Thanks, :) successfully checked as XHTML 1.0 Transitional You had used the closing tag for CHARSET, the rest was missing.
  12. FOR INFO: CSS error in styelsheet after validating. Missing px at end /*** Begin All Products SEO ***/ .allproductsBox { font-family: Verdana, Arial, sans-serif; font-size: 10px; color: #ffce00; padding:0px 3} should be /*** Begin All Products SEO ***/ .allproductsBox { font-family: Verdana, Arial, sans-serif; font-size: 10px; color: #ffce00; padding:0px 3px}
  13. i have just run W3 validating on my site and it got some errors with closing tags related to HT SEO Meta tags.. Would like to have cleaned out this errors, and have tried to search in the files where it is genereted from. Is it just to add selfclosing tag to the generated tags? Any quick info on witch file they are generated from or how to change? Thanks.
  14. Just a tip for the <nobr> tag used in the boxes. In case you havent already included it in next release use in code this <span class="nobr"> and add this to css. .nobr { white-space:nowrap; }
  15. SOME copy and past issues in the last one. Just a quick addon to the code posted with redesign. The code in bm_xxxxfiles must also be altered to remove the styles so it use stock osc style insted. Just so it is complete if someone want to change over. catalog/includes/modules/boxes/bm_categories.php /**** BEGIN ALL PRODUCTS SEO ****/ $categories_string .= '<div><a href="' . tep_href_link(FILENAME_ALLPRODS_SEO, '', 'NONSSL') . '" title="' . BOX_INFORMATION_ALLPRODS_SEO_CATEGORIES . '">' . BOX_INFORMATION_ALLPRODS_SEO_CATEGORIES . '</a></div>'; if (ALL_PRODUCTS_SEO == 'true' && ALL_PRODUCTS_SEO_DISPLAY_PRICE_LIST == 'true') { $categories_string .= '<div><a href="' . tep_href_link(FILENAME_ALLPRODS_SEO_PRICE_LIST, '', 'NONSSL') . '" title="' . BOX_INFORMATION_ALLPRODS_SEO_PRICE_LIST . '"><nobr>' . BOX_INFORMATION_ALLPRODS_SEO_PRICE_LIST . '</nobr></a></div>'; } /**** END ALL PRODUCTS SEO ****/ catalog/includes/modules/boxes/bm_specials.php /**** BEGIN ALL PRODUCTS SEO ****/ ' <div class="ui-widget-content infoBoxContents" style="text-align: center;"><a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $random_product["products_id"]) . '">' . tep_image(DIR_WS_IMAGES . $random_product['products_image'], $random_product['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT) . '</a><br /><a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $random_product['products_id']) . '">' . $random_product['products_name'] . '</a><br /><del>' . $currencies->display_price($random_product['products_price'], tep_get_tax_rate($random_product['products_tax_class_id'])) . '</del><br /><span class="productSpecialPrice">' . $currencies->display_price($random_product['specials_new_products_price'], tep_get_tax_rate($random_product['products_tax_class_id'])) . '</span>' . ' <a href="' . tep_href_link(FILENAME_SPECIALS, '', 'NONSSL') . '" title="' . BOX_INFORMATION_ALLPRODS_SEO_SPECIALS . '"><nobr>' . BOX_INFORMATION_ALLPRODS_SEO_SPECIALS . '</nobr></a></div>' . /**** END ALL PRODUCTS SEO ****/ catalog/includes/modules/boxes/bm_whats_new.php /**** BEGIN ALL PRODUCTS SEO ****/ ' <div class="ui-widget-content infoBoxContents" style="text-align: center;"><a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $random_product['products_id']) . '">' . tep_image(DIR_WS_IMAGES . $random_product['products_image'], $random_product['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT) . '</a><br /><a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $random_product['products_id']) . '">' . $random_product['products_name'] . '</a><br />' . $whats_new_price . ' <br><br><a href="' . tep_href_link(FILENAME_PRODUCTS_NEW) . '" title="' . BOX_INFORMATION_ALLPRODS_SEO_WHATSNEW . '"><nobr>' . BOX_INFORMATION_ALLPRODS_SEO_WHATSNEW .'</nobr></a></div>' . /**** END ALL PRODUCTS SEO ****/