Jump to content

akachan

Members
  • Content count

    12
  • Joined

  • Last visited

1 Follower

Profile Information

  • Real Name
    Jascha Becker
  • Gender
    Male
  • Location
    Stockholm
  1. Sweet contrib! Basic install works like a charm. Way less image loading time! I'll definetly install the extras ;> :thumbsup:
  2. akachan

    Header Tags SEO

    SJC, I suppose that you have Google Duplicate Content Manager installed. Jack, I am sorry for wasting your time. You where right the whole time! Though, I found why I get the extra titles with STS switched on but not if it was switched off. in catalog/includes/modules/sts_includes/headertags.php it says if ( file_exists(DIR_WS_INCLUDES . 'header_tags.php') ) { require(DIR_WS_FUNCTIONS . 'header_tags.php'); ob_start(); require(DIR_WS_INCLUDES . 'header_tags.php'); $preventDuplicates->checkTarget(ob_get_clean()); echo $preventDuplicates->finalMeta . "\udesn"; } whilst in catalog/index.php and catalog/product_info.php it says if ( file_exists(DIR_WS_INCLUDES . 'header_tags.php') ) { require(DIR_WS_INCLUDES . 'header_tags.php'); } the extra code in catalog/includes/modules/sts_includes/headertags.php is part of Google Duplicate Content Manager and my "problem" happens to be one of it's features See http://forums.oscommerce.com/index.php?showtopic=314234 for details Jack, I don't know what to say, I feel like a dumbass <_<
  3. akachan

    Header Tags SEO

    Hi SJC Yeah, that's confusing since I don't get the sort_Na, page_N, language_LC with STS turned off. However, it seems as if STS only catches the output of HT SEO. in STS $headertags is part of $headcontent and as far as I know $headertags is only a caption of the output from header_tags.php I will reinstall HT SEO and try to get a better understanding of the code while doing so. If I don't solve the problem this time I will give HT 4 Novices a chance. I will keep you posted on any progress Cheers Jascha
  4. akachan

    Header Tags SEO

    Sorry for shitting all over the forums but I think I found the problem When researching a bit about STS i found this note NOTE: Do not put <title>...</title> tags in your header. It will be added as part of the $headcontent variable, along with the Description and Keywords meta tags if you have the WebMakers.com's Header Tag Controller contribution installed. I know that this is not the WM HTC but I reckon that the problem lays within the $headcontent variable of STS rather than HT SEO. I turned off STS and made the change from step 1) in HT SEO CATALOG INSTALL This works like a charm and I am now 100% percent sure that the bug is in STS, not HT SEO When I have solved this problem, should I post the solution here or in the STS forums or both? Thanks Jack Cheers Jascha
  5. akachan

    Header Tags SEO

    The language, split_Page and products_listing_sort_order generates those strings, but for some reason HT SEO adds them to the title. The above mentioned strings should be named the way they are since osCommerce currently needs them to. I noticed that this problem occurs at ALL pages, not only the products_listing.php. ie. if you choose language while at product_info.php the title will say ... language_LC | -HT SEO GENERATED TITLE- language_LC (Language Code) plus the title generated by HT SEO Also the sort, page and language get added the keywords. First I thought that this problem might be caused by the $GET['vars'] but that can't be it since the c-path is not added. Oh well, i'll post the solution if I ever find one.
  6. akachan

    Header Tags SEO

    Thank you for the quick reply =) For me the name will work fine. I am well aware of that HT SEO has no control of the URL's, I even read the previous post regarding this problem. However, my problem is that the current sort, page and language get added to the title. I am fine with that they get added to the URL when Ultimate SEO Urls is enabled. Visit http://www.theacademyweb.com/squeakpic/haz...t=2a&page=3 to see the problem in action /Jascha
  7. akachan

    Header Tags SEO

    Hi Jack, I want to thank you for what you do, not only with this contrib but for your dedication in osCommerce. What's the paypal account? Though this contribution works fine there is a bug that I can't work out. I have spent hours searching the forums for a solution to my problem but without success. While doing so, I noticed that I was not the only one having trouble with the "Currently Viewing" with STS installed. I solved this by changing the link code to <?php echo '<a title="' . $products_name . '" href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $product_info['products_id'], 'NONSSL') . '"/# ' . $products_name . '">' . $products_name; ?></a> the change is "$products_name" as far as I know this should not affect anything regarding security, am I wrong or are there any other problems related to this change? That is not my "unsolvable" problem though. When the system shows the product_listing the title shows the Sort, Page and Language followed by the HTC SEO derived title Check <a href='http://www.theacademyweb.com/squeakpic/hazelkid/tshirts-white-c-23_28.html?page=3&sort=2a&language=en''>http://www.theacademyweb.com/squeakpic/hazelkid/tshirts-white-c-23_28.html?page=3&sort=2a&language=en' target='_blank'>http://www.theacademyweb.com/squeakpic/hazelkid/tshirts-white-c-23_28.html?page=3&sort=2a&language=en </a> for example. I have tried with disabling the URL SEO but that had no effect. What seems to be the lowest common denominator is Header Tags SEO and STS, to tell by googling for "sort_2a", "sort_3a", "page_"n + oscommerce. By nulling $HTTP_GET_VARS['sort'] I get rid of the Sort_Na, but that leaves me with sort function for products listings disabled since the function tep_create_sort_heading(); which creates the links needs $HTTP_GET_VARS['sort'] ... and this has no effect on the Page_N or language_LC I have searched the header_tags.php files for a reference to $HTTP_GET_VARS['sort'] Am I using wrong keywords when searching the forums or has this problem not yet been solved. I have reinstalled HT SEO but that did not solve the problem. Once again, thank you for this great contribution // Jascha Becker
  8. akachan

    Master Products - MS2

    I don' understand your Q Do you want a check box instead of a drop down list? The answer to that can be found in the forum =)
  9. akachan

    Master Products - MS2

    Oh, and I am using osCommerce Online Merchant v2.2 Release Candidate 1
  10. akachan

    Master Products - MS2

    Hi, I am using Master Products to sell music digitally but I also want to sell physical merchandise. The problem I am experiencing is that the slave downloads are not considered beeing virtual content once I check out. It works for the master attributes but not for the slaves. This is a problem since I want to have the cash on delivery module installed, and if I have it installed the slaves can be downloaded without paying. I am not that experienced with php, sql and oscommerce but at a first glance everything seems to be in its order. This is the code found in catalog/checkout_shipping.php // if the order contains only virtual products, forward the customer to the billing page as // a shipping address is not needed if ($order->content_type == 'virtual') { if (!tep_session_is_registered('shipping')) tep_session_register('shipping'); $shipping = false; $sendto = false; tep_redirect(tep_href_link(FILENAME_CHECKOUT_PAYMENT, '', 'SSL')); } $total_weight = $cart->show_weight(); $total_count = $cart->count_contents(); from there on I checked catalog/includes/classes/shopping_cart.php and found this code if ( (DOWNLOAD_ENABLED == 'true') && ($this->count_contents() > 0) ) { reset($this->contents); while (list($products_id, ) = each($this->contents)) { if (isset($this->contents[$products_id]['attributes'])) { reset($this->contents[$products_id]['attributes']); while (list(, $value) = each($this->contents[$products_id]['attributes'])) { $virtual_check_query = tep_db_query("select count(*) as total from " . TABLE_PRODUCTS_ATTRIBUTES . " pa, " . TABLE_PRODUCTS_ATTRIBUTES_DOWNLOAD . " pad where pa.products_id = '" . (int)$products_id . "' and pa.options_values_id = '" . (int)$value . "' and pa.products_attributes_id = pad.products_attributes_id"); $virtual_check = tep_db_fetch_array($virtual_check_query); if ($virtual_check['total'] > 0) { switch ($this->content_type) { case 'physical': $this->content_type = 'mixed'; return $this->content_type; break; default: $this->content_type = 'virtual'; break; } } else { switch ($this->content_type) { case 'virtual': $this->content_type = 'mixed'; return $this->content_type; break; default: $this->content_type = 'physical'; break; } } } } else { switch ($this->content_type) { case 'virtual': $this->content_type = 'mixed'; return $this->content_type; break; default: $this->content_type = 'physical'; break; } } } } else { $this->content_type = 'physical'; } return $this->content_type; } The virtual check query looks as I think it should, I checked the database tables and it all seems to be ok. I don't find anything regarding VIRTUAL in the product_info.php files maybe I missed something or I'm checking the wrong files. Please help out since this surely is not only my consern Thank you in advance /Jascha Becker jascha@squeak-music.com
  11. Thank you for your reply. I found the problem now. First I checked that the above lines where correct, and they where. So I had to find out what else could be wrong, so I tried a couple of different things, in the end I found out that I also had installed EXTRA IMAGES. I havnt used the shop for a while so I had forgotten about it. More pics seems far better than extra images =)
  12. Hi, I know almost nothing about codes. Anyway my problem is that I cant figure out how to add pictures with this contribution. I have read the documentation and pretty much of the forum. Please help me, is there some piece of code missing or what?
×