Jump to content

rudolfl

Members
  • Content count

    266
  • Joined

  • Last visited

  • Days Won

    5

Everything posted by rudolfl

  1. I should stop working late at night. Fix for mobile_create_account.php is to replace: <?php echo tep_draw_form('create_account', tep_mobile_link(FILENAME_CREATE_ACCOUNT, '', 'SSL'), 'post', 'onsubmit="return check_form(create_account);"') . tep_draw_hidden_field('action', 'process'); ?> with <?php echo tep_draw_form('create_account', tep_mobile_link(FILENAME_CREATE_ACCOUNT, '', 'SSL'), 'post', 'onsubmit="return check_form(create_account);"',true) . tep_draw_hidden_field('action', 'process'); ?> Rudolf
  2. Thank you for quick reply. I have fixed mobile_contact_us.php page by replacing: <?php echo tep_draw_form('contact_us', tep_mobile_link(FILENAME_MOBILE_CONTACT_US, 'action=send')); ?> with: <?php echo tep_draw_form('contact_us', tep_mobile_link(FILENAME_MOBILE_CONTACT_US, 'action=send'), 'post','',true); ?> "Normal" site uses same, so, i think, this is a correct fix. mobile_create_account.php is different. It can probably be fixed in same manner, but I do not think it is the right approach. I also do not think it is my SSL server, as I observed same behaviour running on my test server without any SSL. I tried to use tep_mobile_link2() as suggested and it fails, as there is undefined symbol FILENAME_MOBILE. I have not find where it is defined. I also noticed that internally tep_mobile_link() calls tep_href_link(). Will keep digging. I looked at the "normal" site create_account.php. I can not understand how drawing of a form created this hidden field 'formid'. It is present in "normal" site and is missing from mobile one, although underlaying code looks same. Rudolf
  3. Hi, It seems that creation of account fails every time. I am just being returned to the same account creation page. https://secure.hatsfromoz.com.au/catalog/mobile_create_account.php (This is a live site. If you create test account, use descriptive names so I can delete them later). It appears that form on mobile_create_account.php page is missing hidden field 'formid'. As a result, submission of form will fail as creation of account depends on this field. Any idea what is happening? Creation of account on normal site works fine. Just realised I have exactly same problem with mobile_contact_us.php as well. No 'formid' field causes return to same page when CONTINUE is pressed. I think, it is something to do with session hadling, but will have to dig really deep to sort this one out. Thanks, Rudolf
  4. Thank you, Rainer. Your changes work. There is just one minor problem -- mobile_checkout_payment.php <div id="messageStack"> <?php echo tep_output_string_protected($error['title']); ?> <?php echo tep_output_string_protected($error['error']); ?> </div> Should be: <div id="messageStackError"> <?php echo tep_output_string_protected($error['title']); ?> <?php echo tep_output_string_protected($error['error']); ?> </div> Otherwise white writing on white background is not very readable :-) Also, may I make a suggestion? First payment method should always be selected. Existing code loads the page, but none of the radio buttons are selected. Ideally, first one should be selected if no selection is made by the user and then user selection should be retained, but this is a lot of hassle for small gain. I would just set first one to be selected when page is loading. BTW, same issue exists in normal osc shop. Rudolf
  5. On the subject of payment page -- I am battling this one now. There is a problem as I see it. If payment method has multiple fields, those are not displayed correctly. In fact, each field in "$selection" is treated as a "sub-payment" method. I may be wrong, but those fields are normally just additional fields like input field for credit card number. They should be displayed "as is", not an attempt to make each one a radio button. I fixed this one for site I am working on and can supply changes if anyone is interested. On the subject of payment, is there a support for CCGV add-on? (Discount coupons and gift vouchers module) Thanks, Rudolf
  6. rudolfl

    Credit Class & Gift Vouchers (CCGV) for 2.3.1

    Cannot Redeclare Error FIXED. There is a bug in checkout_process.php introduced by CCGV. Find this code: /* CCGV - BEGIN */ if ($credit_covers) $payment=''; $payment_modules = new payment($payment); /* CCGV - END */ Replace with: /* CCGV - BEGIN */ if ($credit_covers){ $payment=''; $payment_modules = new payment($payment); } /* CCGV - END */ Rudolf
  7. rudolfl

    Credit Class & Gift Vouchers (CCGV) for 2.3.1

    Is that just me or there is a big problem in checkout_payment.php? I have 2 payment methods available. i think, problem will not exists if single method is in use. Actually, sometimes it works for two methods too, but thsi is purely by accident. Anyway, two payment methods exist. Select a method, click on "continue" and get a message "please select payment method". Close look revealed that clicking on radio button generates JS error "undefined......". And so does click on continue button. This is the code that causes issue: /* CCGV - BEGIN */ if (!document.checkout_payment.payment[0].disabled) { /* CCGV - END */ document.checkout_payment.payment does not exist. Put some debugging and realised that CCGV contribution added new form (the one where you can re-deem coupon). And this form is named "checkout_payment". Same as main form on payment page. JS can not find right entry in DOM and fails. For the test, I quickly renamed main form and adjusted JS to cope with new name. All seem to work. I iwll now go through CCGV code to fix the issue at the source, but this sort of error should be fixed in contribution. Rudolf
  8. rudolfl

    ULTIMATE Seo Urls 5 - by FWR Media

    I am trying to install the contribution, but have some issues. For some reason, I do not see the "Seo Urls 5" in admin->configuration. I am pretty sure I did the installation correctly. And I did not see anything in installation that inserts this value into DB. Am I missing something? May be it has something to do with the fact I had old SEO URLs installed? "SEO URLs" still exists in database, but when I go there I get an error: Warning: call_user_func(tep_reset_cache_data_seo_urls) [function.call-user-func]: First argument is expected to be a valid callback in /public_html/admin/includes/functions/general.php on line Well, this is expected as this function does not exist anymore. I can see that there is a database installation files, but when are they called? My original DB was done with SEO URLs addon for osCommerce MS-2.2. (I am converting shop from MS-2.2 to 2.3.3) Perhaps, it is not supported? Thanks, Rudolf
  9. rudolfl

    Header Tags SEO

    Thanks! That did the trick. Had to select index.php and allow category in there. Rudolf
  10. rudolfl

    Header Tags SEO

    Hi, all I just installed the Header Tags (converted from HTC). For some reason, categories do not show right title and meta data is not being filled in. Canonical links are present, so something is working. Product info is OK. I checked the category and tags are filled in. Any idea why category data is not being displayed? Thanks, Rudolf
  11. Thanks, Jim, That worked, but not the way expected -- as you hover through menu, page is changing to that category. The idea is to just expand the menu and not to change to it until clicked. Rudolf
  12. I still have the problem where first category is selected when on index page of the site. To fix, find line (in catalog/includes/modules/boxes/bm_categories_accordion.php) $category_active_id = 'false'; and replace with; $category_active_id = 0xFFFFFFFF; I am not 100% sure how it happens in JS, but in other languages, numeric code of 'false' is 0, so first category was selected by default. I set it to the really large number instead. Rudolf
  13. I tried your mouseover trick -- does not quite work as expected. If category has a subcategory, it does not expand. Basically, each menu item expands into empty box on mouseover But I like the idea -- will try to expand on it. Rudolf
  14. Yes, Sorry about that. Should of tested it on virgin install. I am converting my site from MS2 to 2.3.3 and had code to separate retail and wholesale catalog. Removing it should work. Rudolf
  15. Yes, Jim, you are right Removing empty <div>s did not help. Worked when I removed them in Chrome development tools, but not when I modified the code to generate the layout Back to drawing board :-( Rudolf
  16. Files are not missing -- there is an include for file that is not required. As for layout -- I fixed it (I think, I did) Just uploaded file with fix to the contribution: http://addons.oscommerce.com/info/7847 Rudolf
  17. OK, got it working. Almost to my liking too. Submitted fix to: http://addons.oscommerce.com/info/7847 What I also want/plan to do in the near future: -- Do not expand categories that are without sub-categories. Should be relatively simple -- those empty spaces are caused by empty <div> after <h3>. I also want to remove '+' for those categories. -- If user goes back to home page, all categories should show as non-active. In my case, for some reason, first one is set as active -- Links. Are there any reason all links are set to "#" and actual link is set in the onclick()? I think, for SEO puproses, actual link should be used instead of '#'. -- Styling of subcategories display should be improved. (Once user expands category that has subcategories) Rudolf
  18. Hi, Jim, Thank you for your response. 1. Regarding icons.txt file -- there is a small bug in bm_categories_accordion.php. Line 299. $file = '/ext/jquery/ui/icons.txt'; Should be: $file = DIR_FS_CATALOG . '/ext/jquery/ui/icons.txt'; 2. Regarding my fix for visual appearance -- this was something I quickly tried later at night. It is not a proper fix as I found. Seems that code emits extra </div> before it outputs any categories. With my fix, this is gone, but extra </div> appears at the end, causing some JS code to appear as part of menu. 3. Regarding appearance of categories without subcategories -- I'll try to look at it when I have chance. You are right -- it may be not as easy to implement. Thanks, Rudolf
  19. I think, I found the problem. bm_categories_accordion.php Line 239: $data = ' </div>' . PHP_EOL; $data .= $categories_string . PHP_EOL; Replace with: $data = $categories_string . PHP_EOL; $data .= ' </div>' . PHP_EOL; Basically, only put closing </div> AFTER you output the category, not before. I still have an issue where last menu item shows some Javascript code: $(function() { $( "#categoriesMenu" ).accordion({ autoHeight: false, icons: { 'header': 'ui-icon-plus', 'headerSelected': 'ui-icon-minus' }, active: 4 }); }); This is what appears on the last menu item. And a question/suggestion. If category does not have subcategories, it should not have '+' next to it. Also, clicking on it, should not open up an empty submenu. Rudolf
  20. Hi, Trying to install on "virgin" 2.3.3 1. Latest release is missing file icon_select.php I had to use one from previous release. This removes the error about missing file. (btw, ins tructions for this file are missing from readme as well). 2. Layout is all screwed up. Instead of being contained in the box, menu takes up whole screen. 3. Admin page. Drop down boxes for icon selection are empty. osCommerce 2.3.3. Browser Chrome and Firefox on Ubuntu 12.04 I am mainly concerned about point 2. Any ideas? Thanks, Rudolf P.S. Quick look reveals that somehow accordion box inserts itself OUTSIDE of left column. Basically, accordion box closes <div> of left column and then places itself there. Then it is taking whole page.
  21. rudolfl

    Official PayPal IPN Support Thread

    Hi, all Can someone help me? When I installed the mod, everything worked just fine. Then something happened and PayPal is no longer shows up in the list of available payment methods. I did not change anything and my "backup" server at home seem to work fine. I checked if PayPal IPN module is installed and it is. Then I tried to change the sort order and more weird things started to happen. I only accept Credit Cards and PayPal. Credit Card method is at sort order 0. Setting PayPal IPN to any number does not help and setting it to 1 causes Credit Card method to disappear. I have a feeling that it is something to do with hosting environment. It is running PHP 5.2.1. I have tried to uninstall and install the module through Admin control panel. Any help will be greatly appreciated. Sincerely, Rudolf Hats From Oz
  22. rudolfl

    CCGV question

    Hi, all I did not find the forum for the excellent CCGV contribution. If anyone is using it, I have a simle question -- how to delete the gift vouchers? I have couple of test ones and couple of error ones. I can go and delete them manually from database, but thought there is a "proper" way. Thanks, Rudolf
  23. I thought this happens "automagically". I am selling hats and, of course, they come in different colours and sizes. When customer adds a hat to shopping cart, they are selecting required attributes and hat is added. If they want exactly same hat, they will change the quantity. If they want one that has different attribute, they have to add it to cart again. Try it (www.hatsfromoz.com.au). What is your site address? Rudolf
  24. rudolfl

    Infoboxes on move?

    Hi, all Here is what I want to do: Infoboxes in right and left columns are stationery. If your page has a lot of information (for example large list of products), as people scroll down the page info boxes are dissapering from view. Is there a way for infoboxes to move as page is scrolled? If such a contribution does not exist, how would one implement such a feature? Any pointers will be greatly appreciated. Thanks, Rudolf
×