golfman2006

Issues with session variables and comments with fast easy checkout applied. Any help in this matter is greatly appreciated. I am running into two issues with the fast easy checkout, but I am not sure excatly which version was applied as we recently took over this website. Basically, when a customer puts in Order Comments on the checkout_payment page, those comments are not being recorded or updated anywhere. The operating system used is Linux web2.websitesource.net 2.4.21-32.0.1 and the webserver is Apache/1.3.34 (Unix) mod_ssl/2.8.25 OpenSSL/0.9.7a FrontPage/5.0.2.2635. We are using PHP version 4.4.1. Another issue I am noticing deals with the Discount Coupons contribution. With the install of version 1.3 Discount Coupons when a customer keys in the Coupon code on checkout_payment, then clicks continue to checkout_confirmation the discount is correctly applied. However, if customer goes back to checkout_payment and changes to another coupon code or even to take out the existing one, upon clicking continue and being taken to checkout_confirmation, the old discount still is visible. There appears to be no way to change or take out the coupon code that was initially keyed. Sent a note to the developer on the Discount Coupons module and here are there comments related to code pasted from our catalog/checkout_confirmation.php which seem to relate the issue to this fast easy checkout process: So at the top you have the Fast Easy checkout code: CODE//fast easy checkout start foreach ($_SESSION as $key => $val) { // print $key.' => '.$val.' - ';print_r($val);echo "<br>"; $HTTP_POST_VARS[$key] = $val; } What this code is doing is overwriting the POSTed variables with the existing session variables. So, first time through, you enter a coupon code and it is set to the session. Second time through, you enter a new coupon code, but it gets replaced by the 'existing' session variable value. The second coupon code is not written to the session until later in the code, after it can be validated. So at this exact point in the code, the coupon session variable is not the same as the POSTed coupon variable from the form. I haven't the faintest idea why on earth fast easy checkout is doing this. I would also suspect from looking at the code that you would have this same problem with the comments box as well. What happens when you go back and change the comments? Does that change hold? I'd suggest getting in touch with the developer of that contribution. He/she seems active and I think you might get a better answer. My first guess would be to prevent this code from happening to the coupon POST variable like so: CODE//fast easy checkout start foreach ($_SESSION as $key => $val) { // print $key.' => '.$val.' - ';print_r($val);echo "<br>"; //kgt - discount coupons //prevent the session value from overwriting the POST value if( $key != 'coupon' ) { $HTTP_POST_VARS[$key] = $val; } //$HTTP_POST_VARS[$key] = $val; //end kgt - discount coupons } But I don't know if that change would be appropriate due to the changes fast easy checkout makes to the checkout. The other thing I notice is line 309-312: CODEif (MODULE_ORDER_TOTAL_INSTALLED) { // $order_total_modules->process(); echo $order_total_modules->output(); } There's no comment I can see as to why the process() line has been commented out. As far as I know, this line is required to get the proper output(). I'm guessing there's some contribution you have that handles this differently, since you haven't complained that none of your order total lines show up! This was the only other thing I saw that differed significantly from stock OSC with discount coupon codes applied. Other changes appeared to be largely cosmetic in nature

Any help in this matter is greatly appreciated. I am running into two issues with the fast easy checkout, but I am not sure excatly which version was applied as we recently took over this website. Basically, when a customer puts in Order Comments on the checkout_payment page, those comments are not being recorded or updated anywhere. The operating system used is Linux web2.websitesource.net 2.4.21-32.0.1 and the webserver is Apache/1.3.34 (Unix) mod_ssl/2.8.25 OpenSSL/0.9.7a FrontPage/5.0.2.2635. We are using PHP version 4.4.1. Another issue I am noticing deals with the Discount Coupons contribution. With the install of version 1.3 Discount Coupons when a customer keys in the Coupon code on checkout_payment, then clicks continue to checkout_confirmation the discount is correctly applied. However, if customer goes back to checkout_payment and changes to another coupon code or even to take out the existing one, upon clicking continue and being taken to checkout_confirmation, the old discount still is visible. There appears to be no way to change or take out the coupon code that was initially keyed. Sent a note to the developer on the Discount Coupons module and here are there comments related to code pasted from our catalog/checkout_confirmation.php which seem to relate the issue to this fast easy checkout process: So at the top you have the Fast Easy checkout code: CODE//fast easy checkout start foreach ($_SESSION as $key => $val) { // print $key.' => '.$val.' - ';print_r($val);echo "<br>"; $HTTP_POST_VARS[$key] = $val; } What this code is doing is overwriting the POSTed variables with the existing session variables. So, first time through, you enter a coupon code and it is set to the session. Second time through, you enter a new coupon code, but it gets replaced by the 'existing' session variable value. The second coupon code is not written to the session until later in the code, after it can be validated. So at this exact point in the code, the coupon session variable is not the same as the POSTed coupon variable from the form. I haven't the faintest idea why on earth fast easy checkout is doing this. I would also suspect from looking at the code that you would have this same problem with the comments box as well. What happens when you go back and change the comments? Does that change hold? I'd suggest getting in touch with the developer of that contribution. He/she seems active and I think you might get a better answer. My first guess would be to prevent this code from happening to the coupon POST variable like so: CODE//fast easy checkout start foreach ($_SESSION as $key => $val) { // print $key.' => '.$val.' - ';print_r($val);echo "<br>"; //kgt - discount coupons //prevent the session value from overwriting the POST value if( $key != 'coupon' ) { $HTTP_POST_VARS[$key] = $val; } //$HTTP_POST_VARS[$key] = $val; //end kgt - discount coupons } But I don't know if that change would be appropriate due to the changes fast easy checkout makes to the checkout. The other thing I notice is line 309-312: CODEif (MODULE_ORDER_TOTAL_INSTALLED) { // $order_total_modules->process(); echo $order_total_modules->output(); } There's no comment I can see as to why the process() line has been commented out. As far as I know, this line is required to get the proper output(). I'm guessing there's some contribution you have that handles this differently, since you haven't complained that none of your order total lines show up! This was the only other thing I saw that differed significantly from stock OSC with discount coupon codes applied. Other changes appeared to be largely cosmetic in nature

Any help in this matter is greatly appreciated. I am running into two issues with the fast easy checkout, but I am not sure excatly which version was applied as we recently took over this website. Basically, when a customer puts in Order Comments on the checkout_payment page, those comments are not being recorded or updated anywhere. The operating system used is Linux web2.websitesource.net 2.4.21-32.0.1 and the webserver is Apache/1.3.34 (Unix) mod_ssl/2.8.25 OpenSSL/0.9.7a FrontPage/5.0.2.2635. We are using PHP version 4.4.1. Another issue I am noticing deals with the Discount Coupons contribution. With the install of version 1.3 Discount Coupons when a customer keys in the Coupon code on checkout_payment, then clicks continue to checkout_confirmation the discount is correctly applied. However, if customer goes back to checkout_payment and changes to another coupon code or even to take out the existing one, upon clicking continue and being taken to checkout_confirmation, the old discount still is visible. There appears to be no way to change or take out the coupon code that was initially keyed. Sent a note to the developer on the Discount Coupons module and here are there comments related to code pasted from our catalog/checkout_confirmation.php which seem to relate the issue to this fast easy checkout process: So at the top you have the Fast Easy checkout code: CODE//fast easy checkout start foreach ($_SESSION as $key => $val) { // print $key.' => '.$val.' - ';print_r($val);echo "<br>"; $HTTP_POST_VARS[$key] = $val; } What this code is doing is overwriting the POSTed variables with the existing session variables. So, first time through, you enter a coupon code and it is set to the session. Second time through, you enter a new coupon code, but it gets replaced by the 'existing' session variable value. The second coupon code is not written to the session until later in the code, after it can be validated. So at this exact point in the code, the coupon session variable is not the same as the POSTed coupon variable from the form. I haven't the faintest idea why on earth fast easy checkout is doing this. I would also suspect from looking at the code that you would have this same problem with the comments box as well. What happens when you go back and change the comments? Does that change hold? I'd suggest getting in touch with the developer of that contribution. He/she seems active and I think you might get a better answer. My first guess would be to prevent this code from happening to the coupon POST variable like so: CODE//fast easy checkout start foreach ($_SESSION as $key => $val) { // print $key.' => '.$val.' - ';print_r($val);echo "<br>"; //kgt - discount coupons //prevent the session value from overwriting the POST value if( $key != 'coupon' ) { $HTTP_POST_VARS[$key] = $val; } //$HTTP_POST_VARS[$key] = $val; //end kgt - discount coupons } But I don't know if that change would be appropriate due to the changes fast easy checkout makes to the checkout. The other thing I notice is line 309-312: CODEif (MODULE_ORDER_TOTAL_INSTALLED) { // $order_total_modules->process(); echo $order_total_modules->output(); } There's no comment I can see as to why the process() line has been commented out. As far as I know, this line is required to get the proper output(). I'm guessing there's some contribution you have that handles this differently, since you haven't complained that none of your order total lines show up! This was the only other thing I saw that differed significantly from stock OSC with discount coupon codes applied. Other changes appeared to be largely cosmetic in nature

Great contribution!...So far everything is working great in testing except the Max use by customer. I will await your fix on this forum for that as you seem to be working on the fix currently. One issue I am noticing with the install of version 1.3 is that when a customer keys in the Coupon code on checkout_payment, then clicks continue to checkout_confirmation the discount is correctly applied. However, if customer goes back to checkout_payment and changes to another coupon code or even to take out the existing one, upon clicking continue and being taken to checkout_confirmation, the old discount still is visible. There appears to be no way to change or take out the coupon code that was initially keyed. I have tried this on multiple computers as I was thinking it was a cache issue, but same issue occurs there also. The only way to get the coupon code out or to change to a new code and have calcuted in total, is if you delete cache for the browser or close all browsers and re-open. Any ideas what could be causing this?