Jump to content

Celluloid

Members
  • Content count

    18
  • Joined

  • Last visited

Profile Information

  • Real Name
    Celluloid
  1. artstyle, when you open a thread, please refrain from posting again about the same subject in another thread *without* pointing an url to it, especially if there is already a reply : http://forums.oscommerce.com/index.php?s=&...t&p=1241379 Cheers.
  2. Celluloid

    Header Tags SEO

    Minor problems : 1) Extra commas are present in header_tags_seo.php on lines : l.498 l.500 l.510 l.518 l.526 l.571 l.575 l.579 l.639 l.643 l.647 l.651 For instance l.498 : => Search for [", ] and replace by [" ] on the lines listed (it's usually behind a [name=<something&gt] ( [name="view_result",] for instance ). If it's any use to anybody, I would make a diff-patch file available (otherwise, I would spare me the trouble) 2) input type="input" used instead of input type="text" in header_tags_seo.php on lines : l.510 l.514 l.518 l.526 l.571 l.575 l.579 l.639 l.643 l.647 l.651 For instance l.510 : => Search for [input type=input] and replace by [input type=text] on the lines listed. Mild problems : the one mentionned in my messages above about the endless loop in header_tags_seo.php, but I let you double-check the idea and solution proposed (I admit I don't understand - yet - why the problem would not popup on some installs ...).
  3. Celluloid

    SEO URLS with Greek Language

    I would say you need to either get a transliteration module to convert your greek characters into ASCII-US, I don't think Ultimate SEO is aware of any "alphabet" beyond the ISO-latin family. For instance, that would "translate" : Γειά (hello) to "guelo" or "helo" (I don't know how is pronounced "Γ" in Greek). See http://en.wikipedia.org/wiki/Transliterati..._Latin_Alphabet I know there is a good transliteration module available for Drupal 5.x, you might be able to adapt it for Ultimate SEO. The other solution is to hack in the Ultimate SEO contrib and force it to output pure unicode urls (that is removing any extra conversion from UTF-8 to ASCII-US or ISO-Latin-1) but browsers support may vary and your hosting services need to be able to handle them, too.
  4. Celluloid

    Header Tags SEO

    Ok, cornered it. 1) function GetKey($fileList, $file) returns either a string value ( if $file equals to the text description of the first 3 items of $fileList ), which means the first 3 select options of the 'new_files' select : SELECT_A_FILE, SHOW_ALL_FILES, ADD_MISSING_PAGES string values. either a numerical value ( if $file equals any text description of a $fileList item beyond the first 3 items ). 2) Without a numerical value in $pageNumb, the " while ($pageNumb < count($newfiles) && ! $failedDupSort) " (l.89) loop is endless. 3) A numerical value is already enforced to $pageNumb if its value is (strictly) equal to the SHOW_ALL_FILES string value (l.86 and l.87) : if ($pageNumb === SHOW_ALL_FILES) $pageNumb = FIRST_PAGE_ENTRY; //skip over the selection options 4) Solution : enforce a numerical value for any other string value in $pageNumb : if ($pageNumb === SHOW_ALL_FILES) $pageNumb = FIRST_PAGE_ENTRY; //skip over the selection options else if ( is_string($pageNumb) ) { $pageNumb = FIRST_PAGE_ENTRY; } => No more endless loop and, for instance, the values entered for the title, description, keywords, etc of index.php and product_info.php are saved in the db. As the same behavior is reproduced latter in the file (l.265 and l.271, for "Get Live Keywords Box Checked") , the strap needs to be put there too. Jack> apart from that, would you like a diff file for the HTML typos on the extra commas and '<input type="input"'> in header_tags_seo.php ? (see several messages above).
  5. Celluloid

    Header Tags SEO

    Ok, forget this, $_POST['new_files'] can't be an array, it will be the option selected (well its value) from the <select name="new_files" ...>. But what puzzles me is that the loop behavior is bound to this value when one submits the form with the several text inputs title_, desc_, keyword_, logo_ etc (for instance, for index.php : title_3_1, desc_3_1, keyword_3_1, logo_3_1) ... which is always 'Select A File'. Let me get this straight : If $pageNumb is a (string) KEY of the table $newfiles, it doesn't make ANY SENSE in PHP to compare with count($newfiles). And it doesn't make ANY SENSE to treat it like a numerical value and trying to increment / decrement it. What would eventually make sense would be to compare $pageNumb (string) with the last (string) key of the $newfiles array, and (at the end of the while loop) to switch its values with next key in $newfiles (string) keys. Or to store in $pageNumb a numerical value (which is done if $pageNumb is === SHOW_ALL_FILES ).
  6. Celluloid

    Header Tags SEO

    Well if you could answer my questions below, that would help me understand what the code is supposed to do / what defined values aren't defined :) That would be : + what do the function AddMissingPages and GetFileList are supposed to return ? + what does the function GetKey($fileList, $file) is really supposed to do ? => I've the comment near the function definition : "return the key of the file array for the selected item", but the point is that in header_tags_seo.php the call (not far below the comment " /********************** CHECK THE INPUT **********************/ ": $pageNumb = GetKey($newfiles, $_POST['new_files']); gives the function which seems to be an array ($newfiles) and ... an array ... ($_POST['new_files']) As the compare operator is strict in GetKey ( " if ($fileList[$i]['text'] === $file) " ), that might be the problem ... Another lead I have is that the code in the function AddMissingPages makes suppositions on the lack of rename operations on the Oscommerce base filenames (which CAN be modified an redefined in filenames.php)... Cheers
  7. Celluloid

    Header Tags SEO

    Jack> could you explain me the logic behind the loop while ($pageNumb < count($newfiles) && ! $failedDupSort) in header_tags_seo.php ? $newfiles seems to be the array behind the input/select new_files, so it looks like one should iterate on this array, BUT there's a problem on my environment (Win 2K, PHP Version 5.2.3, Apache 2.x) with an endless loop somewhere in header_tags_seo.php Here's the result if I try to dump the content of $pageNumb in the loop : string 'Select A File' (length=13) string 'Select A Filf' (length=13) string 'Select A Filg' (length=13) string 'Select A Filh' (length=13) string 'Select A Fili' (length=13) string 'Select A Filj' (length=13) string 'Select A Filk' (length=13) string 'Select A Fill' (length=13) string 'Select A Film' (length=13) [...] string 'Select A Hifh' (length=13) string 'Select A Hifi' (length=13) [...] I would say there is either a problem in the initialization of the variable at those lines : $pageNumb = GetKey($newfiles, $_POST['new_files']); if ($pageNumb === SHOW_ALL_FILES) $pageNumb = FIRST_PAGE_ENTRY; //skip over the selection options or of a problem of a "not strict enough" compare condition in the loop control.
  8. Celluloid

    Header Tags SEO

    Damn, I'm tired... Of course the max_execution_time is hit at line 103, but that doesn't mean that it's where the vast majority of exec time was spent. Need ... to ... reinstall ... XDebug ... on ... Wamp. Oh dear. I'm too old for this :/
  9. Celluloid

    Header Tags SEO

    I have the same problem as misillsam , which is, on the Page Controll admin page (header_tags_seo.php), a php max_execution_time timeout ... My categories.php is heavilly modified, but it looks like I followed the steps very carefully (and anyway, what would categories.php have to do with a bug on categories.php ?) ... Any idea why I would timeout on this particular line (103) in header_tags_seo.php ? : $optionID[] = sprintf("option_%d_%d_%d", $z, $pageNumb, $languages[$i]['id']); ( Fatal error: Maximum execution time of 300 seconds exceeded in X:\you\can\not\fight\in\here\this\is\the\war\room\admin\header_tags_seo.php on line 103 ) Please note that I have this problem wether or not I put numerical values in the "sort order" fields. Besides, if I click on the checkbox "View result:" for the index.php page, I'm redirected to header_tags_seo.php without anything seeming to happen. Might it be due to these two typos ? (lines 497 to 500) : <th class="smallText" title="<?php echo $commonPopup['view']; ?>" class="popup" ><?php echo HEADING_TITLE_SEO_VIEW_RESULT; ?> </th> <th title="<?php echo $commonPopup['view']; ?>" class="popup" ><input type="checkbox" name="view_result", value="<?php echo $id_toggle; ?>" onClick="this.form.submit();" <?php echo $checked; ?> ></th> <th class="smallText" title="<?php echo $commonPopup['delete']; ?>" class="popup"><?php echo HEADING_TITLE_SEO_DELETE; ?> </th> <th title="<?php echo $commonPopup['delete']; ?>" class="popup"><input type="checkbox" name="delete_page", value="<?php echo $id_toggle; ?>" onClick="return confirmdelete(this.form, '<?php echo $newfiles[$x]['text']; ?>')" ></th> => Notice the extra comma ( , ) after each ' <input type="checkbox" name="..." ' Firefox/PHP/The leprechaun living in my PC might not appreciate (not tested on IE yet, 'cause I'm lazy). As this kind of typo can be found several other times in the file, this could be a lead ... I'll try to clean all the typos and keep you informed.
  10. You don't need to put it ON ... The previous link you gave DOES give (somehow) the reason why the images don't display ... What would be useful for ANYONE to help you (and not EXCLUSIVELY ME) would be to retrace your steps... That's LIGHT info : you have done all correct from ... ? The official installation procedure ? The hints that were given here and there ? There could be tons of reason why the module doesn't work ... Without any background, no one can help you ...
  11. The link you gave shows an image containing the full URL. I would look for a "echo $_SERVER['PHP_SELF'];" or a "echo $PHP_SELF;" or any kind of "echo /SOMETHING/;" in imagemagic.php an try to comment it ...
  12. Well if the only modifications you did was installing this contribution, there might be, indeed, a problem somewhere : have you followed the installation process carefully and checked errr... what needs to be checked ? (thumbnails generation directory, rights on this directory, etc) PS : I was tempted for a few secondes to answer you by a : " 'Welcome to the official support thread for the " 'Screw Image' Magic " contribution ! - oh damn ! I installed the wrong one ! "
  13. Have you checked this post just above ? : http://forums.oscommerce.com/index.php?s=&...st&p=903420
  14. Well, seems like the author is enjoying his summer like every sane people around here... So basically, if someone here DOES bother about losing all the files in the "catalog" directory, here's the patch : In imagemagic.php file, LOOK FOR (inside 'function modify_tn_path($file, $check_cache)') //clean up the cache if settings have changed if (CFG_CACHE_AUTO_CLEAN=="True" && $check_cache) { $cwd=getcwd(); chdir($create_path); foreach (glob("*.*") as $filename) { if (!is_dir($filename) && !strstr($filename,$append_hash)) { unlink($filename); } } chdir($cwd); } AND REPLACE BY //clean up the cache if settings have changed if (CFG_CACHE_AUTO_CLEAN=="True" && $check_cache) { $cwd=getcwd(); /* Just be SURE the chdir worked and that you are not STILL in the /catalog/ directory ... or the glob(*.*) will list your index.php file, your product_info.php file, etc and ... you will "unlink" (ie: DELETE) them : 'Woopsie Daisy !!'. */ if (chdir($create_path)) { foreach (glob("*.*") as $filename) { if (!is_dir($filename) && !strstr($filename,$append_hash)) { unlink($filename); } } chdir($cwd); } } Have fun.
  15. Had you clicked yourself on the link and you would have had your answer :) That's basic - basic - basic stuff in PHP : You have a error linked to the context of execution in your script => error ouput message written to the client (that is, your browser) Hence, you can't send any more headers. A header in the context of an HTTP request is a message the server sends to the user (or the user sends to the server) to inform him : + of the last time the file he requested was modified + of the file-type about to be sent + of the location to redirect the request. + ... many more PRIOR to sending any "real" output (things that are displayed in the browser or can be saved to a file or ... whatever). In the case of the ImageMagic contribution, they are many headers that could be sent, depending if you activated "browser-side cache", "server-side cache", etc ... But your image is not broken due to these headers missing. It's broken because of the initial errors and the following errors of the "headers couldn't be sent". Look here : Warning: Cannot modify header information - headers already sent by (output started at /home/content/s/s/f/ssforza/html/imagemagic.php:21) in /home/content/s/s/f/ssforza/html/imagemagic.php on line 181 ????JFIF?? See the JFIF amongst the weird characters ? It's the beginning of your image. So, get rid of your first error, you'll get rid of the subsequent headers errors, and you'll see the images. => The script can't make it to a directory, likely because it doesn't exists. So, either DIR_FS_CATALOG is not set in your includes/configure.php, either it's set to a wrong value. I would say it needs to be set to the value of "/home/content/s/s/f/ssforza/html/". It it's already set to this value, you have a serious problem :D Cheers.
×