Jump to content

Donovan

Members
  • Content count

    21
  • Joined

  • Last visited

1 Follower

About Donovan

  • Birthday 08/23/1972

Profile Information

  • Real Name
    Donovan Long
  • Location
    Halifax, NS Canada
  • Website
  1. Donovan

    [Contribution]Paypal IPN - Devosc

    Hey Bob, I've been following that thread too, what a bunch of wankers, with their "we don't care if your customers are upset, if you don't like it, get a real card card solution" style response. They know they're cheap and easier to setup and thus they know they can be rude pricks like that unfortunately... Personally, I'd start another thread and just post more customer complaints into it. Don't say anything to rile them, just post your actual customer comments. Surely there's no harm in that. Let us know if you start another thread... Maybe we need to start a petition :) ...Dono
  2. Donovan

    Master Products - MS2

    Ditto that, and a note that I tried to implement a fix from page 56 that was meant to let you click on a slave in your shopping cart and be taken to the master product page, but with no success... the codebase has changed a bit too much I think.
  3. Donovan

    [Contribution]Paypal IPN - Devosc

    <rant>I really dislike the rather limited time you are allowed to edit your posts on the forum here, less than 5 minutes it seems, assuming we are allowed to actually edit them, lol</rant> To expand my above message after some more research: The 1 cent difference is due to the primary currency being Canadian and doing a checkout in USD... osC is (presumably) keeping extra decimal places and coming up with a 2 qty item total of $2.91. PayPal is feed the per item price with two decimal places (presumably) with a qty of 2 and thus comes up with 2.90. :P If this really bothered someone that the invoice totals didn't match the purchase price exactly (perhaps extremely large quantities, lol), they can just use the aggregate method, which is passed the exact amounts as osC sees them. Cheers, ...Dono
  4. Donovan

    [Contribution]Paypal IPN - Devosc

    Hi, thanks for the quick response! Although I didn't see the solution above right away... I went to your code fix first, then figured out that I'd changed the currency code to CDN from CAD... then to further complicate things, my logged in osC session would show the prices as 0 when I'd made the change. I spent a long time trying to figure out where in the database they were storing CDN instead of it's ID, looking at code, etc., only to find out that it was just a session variable for the selected currency, once I reselected Canadian $ everything went back to normal. ARRAGH! :) So yes, PayPal is respecting the currency type now, thank you. Something else I've discovered is that the PayPal amounts need some tweaking. Of no real concern is that osC reports a product total of 22.97 and PayPal says it's 22.96 (yes, I was using the Itemized over Aggregate, as it looks more professional). No biggy, however PayPal is being told of a Shipping and Handling charge that does not include the tax on shipping (you probably don't use this?). I'm sure it's a small code change in paypal.php which I will look at in a little bit, just a heads up and I thank you for your help! ...Dono
  5. Donovan

    [Contribution]Paypal IPN - Devosc

    Hi everyone :) I have the contribution installed and seemingly working correctly in that there are no PHP or other scripting errors. Two things I encountered though: 1) With the PayPal module's "Transaction Currency" set to "Selected Currency", the PayPal page lists the equivalent amount in US Dollars but the customer was using Canadian $ and was shown this in the osCommerce shopping cart prior to the hand off to PayPal. I went into my PayPal profile online, and made my Primary account the Canadian $ one, yet it still happens. If I change the setting to "Only CAD", then PayPal presents an "Amount" field for the user to enter an amount of their choosing. Any pointers as to what is going wrong here? 2) When I used the Test IPN function (which only seemed to work the first time, and then no more), the Status that displays for all orders still says "Pending PayPal Notification". I noticed, however, that clicking on the particular order, the "Payment Status" on the right hand site in the osCommerce Orders had changed to "Completed", did I miss something here? A great contribution, just so many little things to go wrong I guess :) Thanks everyone.
  6. Donovan

    Protection of Configuration

    I've tried it on two machines (same site contents) and it doesn't want to work on either of them. Warning: chmod(): Operation not permitted in /var/www/localhost/htdocs/oscommerce-dev/admin/protection.php on line 19 Warning: Cannot modify header information - headers already sent by (output started at /var/www/localhost/htdocs/oscommerce-dev/admin/protection.php:19) in /var/www/localhost/htdocs/oscommerce-dev/admin/includes/functions/general.php on line 22 Rats. :mellow:
  7. Donovan

    Master Products - MS2

    PS: Note that the previous message does not give you the flexibility to do anything non-standard, you can just sort from smaller to greater or greater to smaller, not a customized arrangement, as this is the easiest to implement. To make it work, just choose names that will sort the way you want or deal with it :) As an example, in my store it sorts size in the order of Large, Medium, Small, XLarge, XXLarge.... to me this is fine, it almost seems to be deliberate on my part. PPS: I haven't added slaves to all the products in my non-live store yet, I'm working on an Admin modification to Copy-To to add slaves to masters automatically and to add the attributes as well. The only product that is fully setup can be found at here.
  8. Donovan

    Master Products - MS2

    In case anyone is still wondering about attributes sorting, I finally answered a private message about it and decided I would post a copy here as well in case it helps someone. File: includes/modules/master_listing.php $products_options = tep_db_query("select pov.products_options_values_id, pov.products_options_values_name, pa.options_values_price, pa.price_prefix from " . TABLE_PRODUCTS_ATTRIBUTES . " pa, " . TABLE_PRODUCTS_OPTIONS_VALUES . " pov where pa.products_id = '" . (int)$listing['products_id'] . "' and pa.options_id = '" . (int)$products_options_name_values['products_options_id'] . "' and pa.options_values_id = pov.products_options_values_id and pov.language_id = '" . (int)$languages_id . "' ORDER BY pa.options_values_price ASC, pov.products_options_values_name ASC"); If you compare that line to your own code, you'll note the end of the SQL command is different. In the code above, I'm sorting: First by the product's price (referenced by pa.options_values_price [where pa refers to the products attributes table]), in ASCending order... so lowest priced attributes appear first Secondly by the name of the attribute (refenced by pov.products_options_values [where pov is the product options values table], in ASCending, alphabetical order To change the sort priority, just rearrange the order of the ORDER BY attributes and/or use DESCending order instead of ASCending, etc. Any questions, just ask B) ...Dono http://quotacious.com
  9. Donovan

    Master Products - MS2

    Elwyn, I'm not sure what files are different on your store, it is hard to say. :( To doublecheck my solution, I took the code from the original instructions for step #3 for the master_list.php file, and completely overwrote that section in my file. I then did a search for that one snippet of text, and replaced it with the updated piece as I indicated above. Once again, it works as it should. Besides all changes in coding style and a new option or two, that is the only real difference between the two sets of code. I'm just glad it's working, between Master Products and the Attributes, this is perfect. I've added the sort back to the attributes so that the drop downs are sorted the way I want, otherwise they appear in whatever order they occurred in the database. To do this, I tacked on " ORDER BY pa.options_values_price ASC, pov.products_options_values_name ASC" to the end of the SQL command to have them sorted by increasing price and then alphabetically within that (similar to the old code). ...Donovan
  10. Donovan

    Master Products - MS2

    Thanks! Due to your locating the general area of the problem, I spent some time comparing the two rather than just overwriting the code... The solution to fix up the new code is rather simple. From the line of the latest code in contributions: $products_options = tep_db_query("select pov.products_options_values_id, pov.products_options_values_name, pa.options_values_price, pa.price_prefix from " . TABLE_PRODUCTS_ATTRIBUTES . " pa, " . TABLE_PRODUCTS_OPTIONS_VALUES . " pov where pa.products_id = '" . (int)$listing['products_id'] . "' and pa.options_id = '" . (int)$products_options_name['products_options_id'] . "' and pa.options_values_id = pov.products_options_values_id and pov.language_id = '" . (int)$languages_id . "'"); You want to edit this part: $products_options_name['products_options_id'] and add "_values" to the name, so that it is: $products_options_name_values['products_options_id'] That's all that was wrong :rolleyes: Enjoy!
  11. Donovan

    Master Products - MS2

    Well, I took the new, updated Attributes document, and gave it a whirl. Nothing happened at first of course, so I created an option of "Color" and added values to it. Next, I added all the colors to all the slaves of the one product in my store. :P The result shows a new dropdown box for Color, but there are no dropdown options. http://lucidity.homeip.net:64738/oscommerc...?products_id=30 What's wrong here? :) ...Dono
  12. Donovan

    Master Products - MS2

    Good idea, I can't see how that would be difficult to implement. I think one would just need to ensure that when any of the slaves are changed, via the osC admin or with one of those mass upload programs, that the master products' products_last_modified field (a date) is updated as well, that should flag it as being updated. ...Dono
  13. Donovan

    Master Products - MS2

    If I may be so rude, the new files will be ready when they're ready... An estimate will have no effect on that timeline aside from delaying the one person everyone has all their hopes on... ;) Since this is a completely free offering that Matti has been more than generous in supporting even though he is under absolutely no requirement to do so, the best thing we can all do is to be patient, for he doesn't owe us anything, and to offer him our respect and admiration when appropriate. :wub: The last thing we want to do is create a situation where the project is no longer fun for him... :wacko: even extraordinary patience has it's limits :) Take as long as you want Matti, it's your project... if we don't like it, then the challenge is set to make something better and faster on our own time B)
  14. Donovan

    Master Products - MS2

    Master Products requires a little work, but it is a great learning experience and a must-have contribution! :wub: I'd like to contribute back, just before v2 no doubt! :rolleyes: I wanted to use Ren? Reineke's code example to have the link for a slave product in the shopping cart link back to the master product... This is a great starting point, but it has a flaw in it's design -- the system will use the master product's stock levels, etc. For starters, if the master product stock has a quantity of zero, there will be a message displayed saying such, and I'm guessing the price listed would be the master product's price as well... To use my replacement solution, replace this (in shopping_cart.php around lines 120-130?): ? ? ?$products_name = '<table border="0" cellspacing="2" cellpadding="2">' . ? ? ? ? ? ? ? ? ? ? ? ' ?<tr>' . ? ? ? ? ? ? ? ? ? ? ? ' ? ?<td class="productListing-data" align="center"><a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $products[$i]['id']) . '">' . tep_image(DIR_WS_IMAGES . $products[$i]['image'], $products[$i]['name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT) . '</a></td>' . ? ? ? ? ? ? ? ? ? ? ? ' ? ?<td class="productListing-data" valign="top"><a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $products[$i]['id']) . '"><b>' . $products[$i]['name'] . '</b></a>'; with this: // Master Products (link back to master product from Shopping Cart) ? ? ? ? ? $master_prod = tep_db_query("select products_master, products_master_status ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? from " . TABLE_PRODUCTS . " ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? where products_id = '" . $products[$i]['id'] . "'"); ? ? $master_prod_values = tep_db_fetch_array($master_prod); ? ? ? ? if (($master_prod_values['products_master_status'] == 0) && ($master_prod_values['products_master'] != 0)) { ? ? ? $prod_link_id = $master_prod_values['products_master']; ? ? } else { $prod_link_id = $products[$i]['id']; } ? ? ?$products_name = '<table border="0" cellspacing="2" cellpadding="2">' . ? ? ? ? ? ? ? ? ? ? ? ' ?<tr>' . ? ? ? ? ? ? ? ? ? ? ? ' ? ?<td class="productListing-data" align="center"><a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $prod_link_id) . '">' . tep_image(DIR_WS_IMAGES . $products[$i]['image'], $products[$i]['name'], SMALL_IMAGE_WIDTH,SMALL_IMAGE_HEIGHT) . '</a></td>' . ? ? ? ? ? ? ? ? ? ? ? ' ? ?<td class="productListing-data" valign="top"><a href="' .tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $prod_link_id) . '"><b>' . $products[$i]['name'] . '</b></a>'; // Master Products EOF If there there is no master product for some reason, then the regular slave product info link will be used. Next up, showing master+slaves in the count for each category is the next thing I want to change. While there may be many variations (sizes, etcetera) for a product, I don't consider them as separate products. Cheers! B)
  15. Donovan

    Master Products - MS2

    Ah, it appears I missed a ton of changes in admin/categories.php somehow. And there is at least one change in there that is not identified by comments. Using xxdiff, hopefully I'll get everything fixed up :)
×