Jump to content

nubbin

Members
  • Content count

    52
  • Joined

  • Last visited

  1. Hi, I installed Ultimate SEO URLs v2.2d months ago and all seems to work fine. However, I've noticed if I change the manufacturer name I apparently get some duplicate pages with different URLs. 1) I changed a manufacturer's name in OSC Admin e.g. old name=oldwidgetmaker , new name =newwidgetmaker 2) I Reset SEO URLs Cache 3) Clicked manufacturer newwidgetmaker on the site, and that seems fine and has a new url www.mysite/newwidgetmaker-m12.html 4) The issue is the old url still works as well www.mysite/newwidgetmaker-m12.html 5) In fact, in my browser I can change parts of that URL and it still takes me to the manufacturer page but shows the incorrect url e.g www.mysite/garbage-m12.html Point #5 seems to imply it is the url rewriting that is causing this somehow. This looks like it will cause duplicate content penalties in google. So, I don't want the old URL to work. Is this a bug I should fix or is this just the way SEO URLs works? Cheers
  2. nubbin

    Google XML Sitemap SEO

    Hi Jack, Thanks very much for your work on this add on. I have version 1.4.1 installed and it seems to work ok. This (and your latest version 1.5) produces sitemaps tagged as <urlset xmlns="http://www.google.com/schemas/sitemap/0.84"> However, Google says that Sitemap Protocol 0.84 is now deprecated (see http://www.google.com/schemas/sitemap/0.84/ ). Google now adheres to Sitemap Protocol 0.9 as defined by sitemaps.org Are there plans to upgrade this add on to protocol 0.9? Also, is it essential I upgrade my version 1.4.1 to 1.5? In other words are there bugs in 1.4.1 render it obsolete? Cheers
  3. nubbin

    Google Analytics module

    Hi Minxmoggy, Thanks for your tip which I've used. At first I thought it worked perfectly with payments paid by Paypal. However, I just noticed that the Google Analytivs ecommerce tracking always misses one of the items in an order transaction. For example: -I put 3 products into my shopping cart, checkout and pay using Paypal. -The order emails correctly show 3 products were ordered and paid for - But Google Analytics/Ecommerce/Transactions only shows 2 of the products. The $ total for the transaction is correct, but the number of products is wrong. If I do the same order but use check payment instead of Paypal, the transacction is recorded perfectly. Did you (or anyone elese) have this problem? Cheers
  4. Hi, I installed this a few months ago and all seems to work fine. Today however I noticed if I change the manufacturer name I apparently get some duplicate pages with different URLs. 1) I changed a manufacturer's name in OSC Admin e.g. old name=oldwidgetmaker , new name =newwidgetmaker 2) I Reset SEO URLs Cache 3) Clicked manufacturer newwidgetmaker on the site, and that seems fine and has a new url www.mysite/newwidgetmaker-m12.html 4) The issue is the old url still works as well www.mysite/newwidgetmaker-m12.html 5) In fact, in my browser I can change parts of that URL and it still takes me to the manufacturer page but shows the incorrect url e.g www.mysite/garbage-m12.html Point #5 seems to imply it is the url rewriting that is causing this somehow. This looks like it will cause duplicate content penalties in google. So, I don't want the old URL to work. Is this a bug I should fix or is this just the way SEO URLs works? Cheers
  5. nubbin

    Article Manager v1.0

    Hi Jack, Using Add On KISS Error Handling and DEbugging I can see quite a lot of errors in my home being triggered in articles.php. These are normally suppressed so I wasn't aware of them Article Manager seems to be working on my site. (I also have Header Tags SEO v3.2.2 and Ultimate SEOs 2.29d installed) Do you know what may be triggering these errors? I'm worried I might have made a mistake installing Article Manager. Cheers Error: Undefined variable: tPath_array File: includes/boxes/articles.php Line: 123 Error: Undefined index: start File: includes/boxes/articles.php Line: 173 Error: Undefined index: stop File: includes/boxes/articles.php Line: 173 Error: Undefined index: string File: includes/boxes/articles.php Line: 173 Error: Undefined variable: articles_all_count File: includes/boxes/articles.php Line: 174 Error: Undefined index: start File: includes/boxes/articles.php Line: 182 Error: Undefined index: stop File: includes/boxes/articles.php Line: 182 Error: Undefined index: start File: includes/boxes/articles.php Line: 198 Error: Undefined index: stop File: includes/boxes/articles.php Line: 198 Error: Undefined index: string File: includes/boxes/articles.php Line: 198 Error: Undefined index: start File: includes/boxes/articles.php Line: 207 Error: Undefined index: stop File: includes/boxes/articles.php Line: 207 Error: Undefined index: start File: includes/boxes/articles.php Line: 218 Error: Undefined index: stop File: includes/boxes/articles.php Line: 218 Error: Undefined index: start File: includes/boxes/articles.php Line: 237 Error: Undefined index: stop File: includes/boxes/articles.php
  6. nubbin

    Header Tags SEO

    Hi Jack, Thanks for your great work on this. Whilst tidying up my site for W3C validation I found what looks like an error in the code added to product_info.php for Header Tags SEO 3.2.2 The HTML output from this code contains /# which causes an HTML validation problem as the / is interpreted as closing the opening <a tag. I have split it over the lines to make it easier to read: <td class="smallText" align="center">Currently viewing: <a title="my site - Software - Strategy - The Wheel Of Time" href="http://mysite.com/wheel-time-p-23.html" /# my site - Software - Strategy - The Wheel Of Time">my site - Software - Strategy - The Wheel Of Time </a> </td> The code from the install instructions that is creating the above is: <?php /*** Begin Header Tags SEO ***/ ?> <tr> <td><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></td> </tr> <tr> <td class="smallText" align="center"><?php echo TEXT_VIEWING; ?> <?php echo '<a title="' . $header_tags_array['title'] . '" href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $product_info['products_id'], 'NONSSL') . '"/# ' . $header_tags_array['title'] . '">' . $header_tags_array['title']; ?></a></td> </tr> <?php /*** End Header Tags SEO ***/ ?> I'm not sure what your intention was with this piece of code (especially the /#) so am unsure how to fix it so it validates. I'd appreciate your advice. Cheers.
  7. I've discovered the errors shown above are not caused by OSCThumb. But, I cannot work out which part of the code is creating this HTML and how the erroneous 1 is getting inserted. Please can someone explain where I should be looking for the bug. Thanks
  8. I installed OSCThumb v1.2 onto OSCrc2a a few weeks ago. I thought it was all working ok until I ran the home page through the W3C validator. I am getting nearly 150 validation errors when OSCThumb is switched on. Many are like this: # Line 43, column 126: "1" is not a member of a group specified for any attribute …g src="images/pixel_trans.gif" border="0" alt="" width="11" height="14" 1></td> # Line 50, column 85: "1" is not a member of a group specified for any attribute … src="images/pixel_trans.gif" border="0" alt="" width="100%" height="1" 1></td> # Line 56, column 85: "1" is not a member of a group specified for any attribute … src="images/pixel_trans.gif" border="0" alt="" width="100%" height="1" 1></td> It looks like the character 1 has somehow been mistakenly inserted near the end of each line I would really appreciate it if someone could help me track down where this error is occurring and how to fix it. Cheers
  9. nubbin

    Article Manager v1.0

    Duncan, look at my post above as I had the same problem and found a way of working around it for now. Cheers
  10. nubbin

    Article Manager v1.0

    Jack, I've done some digging and found out exactly what is causing this (from an admin user's perspective rather than a programmer's). The thing that causes this error is if you remove the tick then press save. If you leave the tick in place then press save, the link between the product and the article is removed from the database. Looks like it must be a little bug in the code that is triggered when the tick is unchecked. Cheers
  11. nubbin

    Article Manager v1.0

    Jack, thanks for the above post. I am testing the the cross-sell function, and getting the same SQL problem as Duncan (see his post above) when I attempt to remove a product I had added to an article. I get this error in admin/articles_xsell.php?add_related_article_ID=1&cPath=21 : Cross-Sell Articles to Products 1064 - You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 1 DELETE FROM articles_xsell WHERE articles_id = '1' and ) [TEP STOP] In fact the root cause may be occurring earlier than this module. In admin/articles_xsell.php I see a table containing one row showing link between article and product. When I click on link in table "Add/Remove", I am taken to admin/articles_xsell.php?add_related_article_ID=1 This screen just has a drop down box "Select a Category" containing the word "Top". I was surprised by that, I thought it would take me direct to the next step. I choose the category containing the product from that list and am taken to admin/articles_xsell.php?add_related_article_ID=1&cPath=21 I can see a tick next to the product. I remove the tick and click save resulting in the error 1064 described at top of this post. Any idea what the problem is? Cheers
  12. nubbin

    Article Manager v1.0

    Hi Jack, Near the end of the install instructions in readme.txt it says "In admin/includes/functions/header_tags.php (only for Header Tags SEO before version 3.2.3)..." However, the latest version of Header tags SEO is only 3.2.2. which I have installed. (See http://addons.oscommerce.com/info/5851 ). Is this a typo in readme.txt, or should I do the find and replace as instructed? Cheers
  13. nubbin

    [Contribution] oscThumb

    Sometimes resized images are generated with a one pixel wide black line on the side or bottom of them. Apparently this is due to a rounding error in the resizing maths in phpThumb (see http://www.webmasterworld.com/php/3851917.htm). I was unable to track down and fix this rounding error. However, I did discover a work around: Go to osc/admin/config/images and set Calculate Image Sizes = False For some reason that gets rid of the annoying black lines. My guess is this fixes it because if Calculate Image Size=True, the image width (or height) is set to the value specified in admin/config/images. However PphpThumb makes a mistake and provides an image 1 pixel too narrow. The difference between the two causes the black line. Perhaps someone who is good at php can have a go at tracking down the error in phpThumb. Cheers
  14. nubbin

    [Contribution] oscThumb

    Thanks for your tip. This fixes the problem of getting the Product Information Image Width & Product Information Image Height to change the product image BUT YOU NEED TO DO THIS CHANGE IN 2 PLACES. In catalog/product_info.php 1) find: $product_info['products_image'], $product_info['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT, and change it to: $product_info['products_image'], $product_info['products_name'], PRODUCT_INFO_IMAGE_WIDTH, PRODUCT_INFO_IMAGE_HEIGHT, 2) find <script language="javascript"><!-- document.write('<?php echo '<a href="javascript:popupWindow(\\\'' . tep_href_link(FILENAME_POPUP_IMAGE, 'pID=' . $product_info['products_id']) . '\\\')">' . tep_image(DIR_WS_IMAGES . $product_info['products_image'], addslashes($product_info['products_name']), SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT, 'hspace="5" vspace="5"') . '<br>' . TEXT_CLICK_TO_ENLARGE . '</a>'; ?>'); //--></script> and change it to <script language="javascript"><!-- document.write('<?php echo '<a href="javascript:popupWindow(\\\'' . tep_href_link(FILENAME_POPUP_IMAGE, 'pID=' . $product_info['products_id']) . '\\\')">' . tep_image(DIR_WS_IMAGES . $product_info['products_image'], addslashes($product_info['products_name']), PRODUCT_INFO_IMAGE_WIDTH, PRODUCT_INFO_IMAGE_HEIGHT, 'hspace="5" vspace="5"') . '<br>' . TEXT_CLICK_TO_ENLARGE . '</a>'; ?>'); //--></script> (My store is a clean install of OSC2.2rc2a with SEO URL v2-2.2d-9 and HeaderTags_SEO_V_3.2.2 installed).
  15. Did you solve this problem? I am having it now! Thanks
×