Leaderboard

https://github.com/gburton/Responsive-osCommerce/releases/tag/2341-Frozen There will be no further Code Changes. Issues will be immediately closed. What is broken, stays broken. PRs will be immediately closed. What is now there, is there. Thank You to all Shopowners and Developers who have supported the Project in the last 4 and a bit years. Personal Thanks go out to all those Shopowners who were able to support my 28d bits and pieces for 3 of those 4 years - it is you guys who have made it possible for the hundreds of other Shopowners to continue using osCommerce. A big Thank You and from me, I will not leave you guys high and dry - you have my support always, we are a Band Of Brothers. Onwards!

http://template.me.uk/frozen2bs4/index.php I still have some work to do (especially on the modules for index & index_nested & index_products). Always moving forward, even if in "hiding".

Hi All.. A quick progress update regarding what we've been working on recently. A new Community Team is being formed to help moderate community submitted content and to help with community relations and issues. This not only helps the developers in the team to focus more on code development and less on moderation, but also broadens the voice in the team when community related issues arise and are addressed. This new approach to the team is being ironed out and we'll be glad to invite more active users in the community to help out once everything is running smoothly again. For the curious, those we have initially invited can be seen on the forum staff page. An internal build of v2.3.5 has been in testing and this weekend will be spent fixing the known issues. A majority of reported issues and pull requests at Github have been addressed and will also make their way into v2.3.6 (the Community Bootstrap edition). These releases are planned to be the last in the v2.3.x release series to place all resources on v2.4/v3.0. Accommodations will be made if the community wish to continue working on v2.3.6 for future v2.3.x releases. More information about this will be announced with the releases. The next test builds will be made available to Ambassadors for a wider testing audience. Both releases will be officially pushed out this month. The forum software has been updated to the latest release series and introduces a new Clubs section to the forum. We've moved our partner announcements forum channels to the Clubs section where our partners can customize their own club sections further with logos and additional discussion channels. We're planning on adding multilingual Clubs in the near future, and also community requested clubs (eg, for community release editions). The upgrade of the forum software version was originally postponed due to changes made with user accounts and the integration we have with our main website. This also plays a role with the marketplace integration in v2.4 where user accounts are required. An online update for 2.4 will be pushed out soon to test the marketplace integration and user account logins/creations with. Release dates for v2.4 will be provided when the marketplace integration online update has been pushed out. Two new websites were planned to be launched in Q4 but are being pushed back to Q1 2018 to push our next releases out first. The new websites are for a proper commercial support inquiry / job marketplace website (to replace the not-so-user-friendly forum channel here in the forums), and a new user profile website (for Ambassadors) to highlight ones profile across all of our websites (submissions from our forums, live sites, and apps marketplace websites), with the focus on the person behind the screen name. Hope everyone has a great festive season!

As an addition to the community and 100% in the spirit of osCommerce ... i present you: https://oscompose.com Quickly build placeholders for : - cm_* modules (*** including Template file and Language file [english only]) - bm_* boxes (*** including Template file and Language file [english only]) - tp_* pages - action pages View the generated code instantly in the syntax Highlighter Just provide: - Module directory (for content modules). - Module name (all classes will get the same names AFTER it's prefix). - Module Description - Can view the generated code before download .... Have fun & Happy coding!!!!!!!!!!!!!!!!!!!!!!!! ps: find any glitches... let me know ... psssssssttt there is also a button generated if you wanna buy me a

In the last few weeks; index.php made more modular login.php made more modular checkout_success.php made more modular product_info.php made more modular + product info not found module as well product_schema module introduced introduced "actions" in application_top.php + new admin page for these actions category_tree class updated to pull more category data + most areas of code updated to use category_tree class template files renamed to help solve uploading problems hooks auto registered in each page Thanks to everyone who pitched in with ideas and code

Third installment of the 28d Project. I missed last year for reasons, but this year it's back. I'm running it slightly differently to previous versions, as this time there will be no option to buy each days package - that was frustratingly difficult to manage - sorry. Instead there will be a very simple "buy now" price for everything, and that will go up in price as February goes by, therefore those who can buy earlier...pay less...and those who buy later...pay more. Hit the [Follow] button in the right hand corner of this page as I shall be updating this post as the days go by. Should anyone wish to pre-buy...thank you for your consideration and support. PM me and we can arrange it. Don't know what the 28d Project is? I make code available during February (each year, usually). This is code that I have created or updated and make available for an all-in price. Had a couple of questions by PM; Edge Compatible: Yes Gold Compatible: Yes(ish), you might need to update some files to the Edge version, I will point these out in the individual "readme" for each. Certainly nothing to be worried about! PHP7 Compatible: Yes Official osCommerce Compatible: No, sorry Core Code Changes: Will be kept to an absolute minimum, you guys know I hate to change Core and I know you guys hate Core Code Changes...but sometimes, it is, unfortunately, unavoidable. Progress: I have 21 things coded and ready for finalised checking. 1 thing is being live tested by a shop. 6 or 7 things more to write; ideas would be welcomed for small to medium things Thanks for all the PMs and Feedback so far!

Convert via jQuery your osCommerce admin to bootstrap the easy way, tutorial below the video. Video updated to V8 https://youtu.be/7v7LvPLyRYQ admin/includes/stylesheet.css (back-up & Replace): /* $Id$ osCommerce, Open Source E-Commerce Solutions http://www.oscommerce.com Copyright (c) 2014 osCommerce Released under the GNU General Public License */ /* body { font-family: Verdana, "Helvetica Neue", Helvetica, Arial, sans-serif; font-size: 0.7em; } */ body { display: none; } /* links */ a { color: #000000; font-weight: normal; text-decoration: none; } a:hover { text-decoration: underline; } a.headerLink { color: #ffffff; font-weight: bold; text-decoration: none; } a.headerLink:hover { text-decoration: underline; } a.menuBoxHeadingLink { color: #616060; font-weight: bold; text-decoration: none; } a.menuBoxHeadingLink:hover { } a.menuBoxContentLink { color: #616060; font-weight: normal; text-decoration: none; } a.menuBoxContentLink:hover { text-decoration: underline; } a.splitPageLink { color: #0000FF; font-weight: normal; text-decoration: none; } a.splitPageLink:hover { text-decoration: underline; background-color: #FFFF33; } /* menu box */ .menuBoxHeading { color: #616060; background-color: #ffffff; } .menuBoxContent { color: #616060; } /* page */ /*body { background-color: #ffffff; color: #000000; margin: 0px; }*/ /*.headerBar { background-color: #B3BAC5; }*/ /*.headerBarContent { color: #ffffff; font-weight: bold; padding: 2px; }*/ /*.columnLeft { background-color: #F0F1F1; border-color: #999999; border-width: 1px; border-style: solid; padding: 2px; }*/ /*.pageHeading { font-size: 1.5em; color: #727272; font-weight: bold; }*/ /* data table .dataTableHeadingRow { background-color: #C9C9C9; } .dataTableHeadingContent { color: #ffffff; font-weight: bold; } .dataTableRow { background-color: #F0F1F1; } .dataTableRowSelected { background-color: #DEE4E8; } .dataTableRowOver { background-color: #FFFFFF; cursor: pointer; cursor: hand; } .dataTableContent { color: #000000; } */ /* info box .infoBoxHeading { color: #ffffff; background-color: #B3BAC5; } .infoBoxContent { color: #000000; background-color: #DEE4E8; } */ /* message box */ .messageBox { } .messageStackError, .messageStackWarning { background-color: #ffb3b5; } .messageStackSuccess { background-color: #99ff00; } /* forms CHECKBOX, INPUT, RADIO, SELECT, TEXTAREA, FILE { font-family: Verdana, "Helvetica Neue", Helvetica, Arial, sans-serif; } FORM { display: inline; } */ /* account .formArea { background-color: #f1f9fe; border-color: #7b9ebd; border-style: solid; border-width: 1px; } .formAreaTitle { font-family: Tahoma, Helveticy, Verdana, Arial, sans-serif; font-weight: bold; } */ /* attributes */ /*.attributes-odd { background-color: #f4f7fd; }*/ /*.attributes-even { background-color: #ffffff; }*/ /* miscellaneous */ .specialPrice { color: #ff0000; } .oldPrice { text-decoration: line-through; } .fieldRequired { color: #ff0000; } .errorText { color: #ff0000; } /* new messageStack styles .secInfo, .secSuccess, .secWarning, .secError { border: 1px solid; margin: 10px 0px; padding: 5px 10px 5px 50px; background-repeat: no-repeat; background-position: 10px center; border-radius: 10px; -moz-border-radius: 10px; -webkit-border-radius: 10px; } .secInfo { border-color: #00529B; background-image: url('../images/ms_info.png'); background: url('../images/ms_info.png') no-repeat 10px center, url('../images/ms_info_bg.png') repeat-x; background-color: #BDE5F8; } .secSuccess { border-color: #4F8A10; background-image: url('../images/ms_success.png'); background: url('../images/ms_success.png') no-repeat 10px center, url('../images/ms_success_bg.png') repeat-x; background-color: #DFF2BF; } .secWarning { border-color: #9F6000; background-color: #FEEFB3; background-image: url('../images/ms_warning.png'); background: url('../images/ms_warning.png') no-repeat 10px center, url('../images/ms_warning_bg.png') repeat-x; background-color: #FEEFB3; } .secError { border-color: #D8000C; background-image: url('../images/ms_error.png'); background: url('../images/ms_error.png') no-repeat 10px center, url('../images/ms_error_bg.png') repeat-x; background-color: #FFBABA; } .secInfo p, .secSuccess p, .secWarning p, .secError p { padding: 2px; } #adminAppMenu { float: left; width: 190px; padding: 5px; } #adminAppMenu h3 { } #adminAppMenu ul { list-style: none; margin: -5px 0 -5px -10px; padding: 0; } #contentText { margin-left: 200px; }*/ /* Custom jQuery UI */ .ui-widget { } .ui-dialog { min-width: 500px; } /* buttons .tdbLink a { } .tdbLink button { } */ .selectwidthauto{ width:auto !important; } in admin/includes/template_top.php : [Viewport] DIRECTLY AFTER: <head> ADD: <meta http-equiv="X-UA-Compatible" content="IE=edge"> <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no"> [bootstrap css] BEFORE: <link rel="stylesheet" type="text/css" href="includes/stylesheet.css"> ADD: <link href="../ext/bootstrap/css/bootstrap.min.css" rel="stylesheet"> [Font-awesome css] BEFORE: <script type="text/javascript" src="<?php echo tep_catalog_href_link('ext/flot/jquery.flot.min.js', '', 'SSL'); ?>"></script> ADD: <link href="//maxcdn.bootstrapcdn.com/font-awesome/4.7.0/css/font-awesome.min.css" rel="stylesheet" integrity="sha384-wvfXpqpZZVQGK6TAh5PVlGOfQNHSoD2xbE+QkPxCAFlNEevoEH3Sl0sibVcOQVnN" crossorigin="anonymous"> [Flot chart resize fix] AFTER: <script type="text/javascript" src="<?php echo tep_catalog_href_link('ext/flot/jquery.flot.time.min.js', '', 'SSL'); ?>"></script> ADD: <script type="text/javascript" src="<?php echo tep_catalog_href_link('ext/flot/jquery.flot.resize.min.js', '', 'SSL'); ?>"></script> OPTIONAL SUMMERNOTE WYSIWYG DIRECTLY ABOVE </head> ADD: <!-- include summernote css/js--> <link href="//cdnjs.cloudflare.com/ajax/libs/summernote/0.8.9/summernote.css" rel="stylesheet"> <script src="//cdnjs.cloudflare.com/ajax/libs/summernote/0.8.9/summernote.js"></script> admin/includes/template_bottom.php BEFORE: </body> ADD: <script> $(function() { //Prepare the DOM $(document).on("click", ".menu", function(){ osCMenu(this); }); $('body').prepend( "<div id='container-wrapper' class='container-fluid'><div class='row'></div></div>" ); columnLeft = $("<div class='col-md-2 menu-col'/>"); columnCenter = $("<div class='col-md-10 body-content-col'/>"); $('body .row').append(columnLeft, columnCenter); //Administrator Header Bar $('body').css('padding-top', '70px'); $('#adminAppMenu').appendTo('.menu-col'); //prepare table conversion $('table tbody tr.headerBar').parent().parent().addClass('table-2-nav'); //Convert logo to brand $('.table-2-nav a:first').addClass('navbar-brand'); $('.table-2-nav img:first').addClass('img-responsive').css('margin-top','-15px'); //wrap the logo and build the default nav $('.table-2-nav a:first').wrap( "<nav class='navbar navbar-default navbar-fixed-top'><div class='container-fluid'><div class='navbar-header'></div></nav>" ); //extend nav with toggle bar-button $('.navbar-header').prepend( "<button type='button' class='navbar-toggle collapsed' data-toggle='collapse' data-target='#bs-example-navbar-collapse-1' aria-expanded='false'><span class='sr-only'>Toggle navigation</span><span class='icon-bar'></span><span class='icon-bar'></span><span class='icon-bar'></span></button> "); //create the visible navigation menu $('nav div:first').append("<div class='collapse navbar-collapse' id='bs-example-navbar-collapse-1'><ul class='nav navbar-nav navbar-nav-left'></ul><ul class='nav navbar-nav navbar-nav-right pull-right'></ul></div>"); //collect links var navLeftLinks = $('#bs-example-navbar-collapse-1 ul.navbar-nav-left'); var navRightLinks = $('#bs-example-navbar-collapse-1 ul.navbar-nav-right'); $('.table-2-nav .headerBarContent:first a').each(function () { var $this = $(this); var list = $("<li/>"); list.append( $this ); navLeftLinks.append(list); }); navLeftLinks.prepend('<li><a href="#" class="menu"><i class="fa fa-caret-square-o-left" aria-hidden="true" data-toggle="tooltip" data-placement="bottom" title="Show/Hide menu"></i></a></li>'); var str = "<?php echo HEADER_TITLE_ADMINISTRATION; ?>"; var newhtml = $('ul.navbar-nav-left').html().replace(str, '<i class="fa fa-home" aria-hidden="true" data-toggle="tooltip" data-placement="bottom" title="'+str+'"></i>'); $('ul.navbar-nav-left').html(newhtml); var str = "<?php echo HEADER_TITLE_ONLINE_CATALOG; ?>"; var newhtml = $('ul.navbar-nav-left').html().replace(str, '<i class="fa fa-cart-arrow-down" aria-hidden="true" data-toggle="tooltip" data-placement="bottom" title="'+str+'"></i>'); $('ul.navbar-nav-left').html(newhtml); var str = "<?php echo HEADER_TITLE_SUPPORT_SITE; ?>"; var newhtml = $('ul.navbar-nav-left').html().replace(str, '<i class="fa fa-life-ring" aria-hidden="true" data-toggle="tooltip" data-placement="bottom" title="'+str+'"></i>'); $('ul.navbar-nav-left').html(newhtml); $('[data-toggle="tooltip"]').tooltip(); navLeftLinks.css('font-size','20px') //Collect log-in/-off link with Administrator name NavText = $('.table-2-nav .headerBarContent:nth-child(2)').html(); NavTextPlaceHolder = $("<p class='navbar-text navbar-right'>"); NavTextPlaceHolder.append( NavText ); navRightLinks.prepend(NavTextPlaceHolder); $('.navbar-text a:first').addClass('navbar-link'); //Show the Bootstrapped navigation bar $( "nav" ).insertBefore( $( ".table-2-nav" ) ); //Admin Language in navbar $("form[name=adminlanguage]").addClass('navbar-form navbar-right').prepend( "<div class='input-group language'></div>" ); $('select[name=language]').appendTo('.input-group.language'); $( "form[name=adminlanguage]" ).insertBefore( "nav ul.navbar-nav-right" ); //Convert osCommerce's page-headers to bootstrap $('table .pageHeading:first').contents().unwrap().wrap( "<div class='page-header'><h1></h1></div>"); $('.page-header').prependTo('.body-content-col').css('padding-bottom','0').css('margin','0'); //Search field in navbar $("form[name=search]").addClass('navbar-form navbar-search-form navbar-left').prepend( "<div class='input-group search'></div>" ); $('input[name=search]').before(function () { return $('<span class="input-group-addon search"/>', { for: this.name }).addClass('selectwidthauto').append(this.previousSibling); }).addClass('form-control selectwidthauto'); $("span.search").prependTo('.input-group.search'); $('input[name=search]').appendTo('.input-group.search'); $( "form[name=search]" ).insertAfter( "nav ul.navbar-nav-left" ); //Categories GoTo select in navbar $("form[name=goto]").addClass('navbar-form navbar-left').prepend( "<div class='input-group goto'></div>" ); $('select[name=cPath]').before(function () { return $('<span class="input-group-addon goto"/>', { for: this.name }).addClass('selectwidthauto').append(this.previousSibling); }).addClass('form-control selectwidthauto'); $("span.goto").prependTo('.input-group.goto'); $('select[name=cPath]').appendTo('.input-group.goto'); $( "form[name=goto]" ).insertAfter( "nav .navbar-search-form" ); //Orders Search field in navbar $("form[name=orders]").addClass('navbar-form navbar-search-form navbar-left').prepend( "<div class='input-group orders'></div>" ); $('input[name=oID]').before(function () { return $('<span class="input-group-addon orders"/>', { for: this.name }).addClass('selectwidthauto').append(this.previousSibling); }).addClass('form-control selectwidthauto'); $("span.orders").prependTo('.input-group.orders'); $('input[name=oID]').appendTo('.input-group.orders'); $( "form[name=orders]" ).append('<input type="hidden" name="action" value="edit">').insertAfter( "nav ul.navbar-nav-left" ); //Categories GoTo select in navbar $("form[name=status]").addClass('navbar-form navbar-left').prepend( "<div class='input-group status'></div>" ); $('select[name=status]').before(function () { return $('<span class="input-group-addon status"/>', { for: this.name }).addClass('selectwidthauto').append(this.previousSibling); }).addClass('form-control selectwidthauto'); $("span.status").prependTo('.input-group.status'); $('select[name=status]').appendTo('.input-group.status'); $( "form[name=status]" ).insertAfter( "nav .navbar-search-form" ); //Remove osCommerce's table-based navigation $('.table-2-nav').remove(); //Bootstrap the osCommerce's primary content table (center table) $('table tbody tr.dataTableHeadingRow').parent().parent().addClass('bootstrapped-table table table-responsive table-condensed table-hover table-striped table-bordered'); $('table tbody tr.dataTableRowSelected').addClass('warning') //Bootstrap the osCommerce's right table (edit data) $('table tbody tr.infoBoxHeading').parent().parent().addClass('infoBox-table info-table table table-responsive table-condensed table-bordered'); $('.info-table').next("table").addClass('infoBoxContent-table table table-responsive table-condensed table-bordered'); $('.info-table').next("form").addClass('form-table'); $('.form-table').children("table").addClass('info-table table table-responsive table-condensed table-bordered '); //Bootstrap the osCommerce's formArea tables (Customers edit) $( ".formArea table" ).addClass('table table-responsive table-condensed table-hover table-striped table-bordered') //Bootstrap jQuery-ui buttons $( "a.ui-button" ).removeAttr('class').addClass('btn btn-default').css({'margin-right': '4px'}); $( "button.ui-button" ).removeAttr('class').addClass('btn btn-primary').css({'margin-right': '4px'}); $( "#filters .btn" ).addClass('btn-sm') //jQuiry-UI button icons $( "span.ui-icon" ).addClass('pull-left'); //bootstrap pageNavigation links $( "form[name=pages]" ).addClass( "form-inline" ); $( ".splitPageLink" ).addClass('btn btn-default'); $( "select" ).addClass('form-control selectwidthauto'); //$( "input[type=radio]" ).wrap( "<div class='radio'><label></label></div>" ); //$( "input[type=checkbox]" ).wrap( "<div class='checkbox-inline'></div>" ); //build table headings $('.bootstrapped-table').each(function(){ $(this).prepend('<thead></thead>') $(this).find('thead').append($(this).find("tr:eq(0)")); }); $(".dataTableHeadingRow td").each(function() { $(this).replaceWith('<th>' + $(this).html() + '</th>'); }); $('.infoBox-table').each(function(){ $(this).prepend('<thead></thead>') $(this).find('thead').append($(this).find("tr:eq(0)")); }); //convert message tables to bootstrap //old message styles $('table tbody tr.messageStackSuccess').parent().parent().addClass('message-table table').insertAfter('.page-header'); $('table tbody tr.messageStackError').parent().parent().addClass('message-table table').insertAfter('.page-header'); $('table tbody tr.messageStackWarning').parent().parent().addClass('message-table table').insertAfter('.page-header'); //new message styles $('.secInfo').toggleClass('secInfo alert alert-info'); $('.secSuccess').toggleClass('secSuccess alert alert-success'); $('.secWarning').toggleClass('secWarning alert alert-warning'); $('.secError').toggleClass('secError alert alert-danger'); //add colspan to fist th on the orders section_products_content tab $('#section_products_content table tr th:first').attr('colspan', '2'); $('#section_products_content table').removeClass('table-bordered table-striped table-hover'); //Convert New Product to Bootstrap $("form[name=new_product] table table").addClass('table table-responsive table-condensed table-bordered'); //$("form[name=new_product] table table tr").removeAttr('bgcolor'); //Convert BannerManager to Bootstrap $("input[name=banners_title]").closest('table').addClass('table table-responsive table-condensed table-bordered'); //Convert osCommerce's footer to bootstrap $('table:last td').wrapInner( "<footer class='footer'><div class='container'><p class='text-muted text-center'></p></div></footer>" ); $('footer').insertAfter('body #container-wrapper'); //Put osCommerce's content to bootstrap column $('#contentText').appendTo('.body-content-col'); //clean-up tables $('.table') .removeAttr('border') .removeAttr('width') .removeAttr('height') .removeAttr('cellspacing') .removeAttr('cellpadding'); $("img[src='images/pixel_trans.gif']").remove(); $('td.pageHeading').remove(); $('fieldset').removeAttr('style'); $('legend').removeAttr('style'); $('tr').removeAttr('onmouseover').removeAttr('onmouseout'); $('table:last').remove(); //Convert inputs and textarea's $("input[type=text]").addClass('form-control selectwidthauto'); $("textarea").addClass('form-control'); //load summernote wysiwyg $("textarea[name^=categories_description]").addClass('summernote'); $("textarea[name^=products_description]").addClass('summernote'); $("textarea[name=comments]").addClass('summernote'); $("textarea[name=banners_html_text]").addClass('summernote'); //replace oscommerce's images with font-icons $("img[src='images/icon_up.gif']").replaceWith("<i class='fa fa-long-arrow-up' aria-hidden='true'></i>"); $("img[src='images/icon_down.gif']").replaceWith("<i class='fa fa-long-arrow-down' aria-hidden='true'></i>"); if (localStorage.getItem("adminToggleAppMenu") === null) { localStorage.setItem('adminToggleAppMenu', 1) } if (localStorage.getItem("adminToggleAppMenu") == 0) { $(".menu i").removeClass('fa-caret-square-o-left').addClass('fa-caret-square-o-right'); $(".menu-col").hide(); $("body .body-content-col").removeClass('col-md-10').addClass('col-md-12'); } if (localStorage.getItem("adminToggleAppMenu") == 1) { $(".menu i").removeClass('fa-caret-square-o-right').addClass('fa-caret-square-o-left');; $(".menu-col").show(); $("body .body-content-col").removeClass('col-md-12').addClass('col-md-10'); } if($('form[name=login]').length > 0){ $('.page-header').addClass('text-center'); $('table') .removeAttr('border') .removeAttr('width') .removeAttr('height') .removeAttr('cellspacing') .removeAttr('cellpadding'); $('table .infoBox-table').remove(); $('table .info-table').css({'width': '50%', 'margin': '0 auto', 'margin-top': '50px', 'margin-bottom': '50px'}); $('form[name=login]').insertAfter('#contentText'); $("input[type=password]").addClass('form-control selectwidthauto'); $(".body-content-col").toggleClass("col-md-10 col-md-12") columnLeft.remove(); } //convert jquery-ui accordion to bootstrap collapse $( "#adminAppMenu" ).accordion('destroy').addClass('panel-group').attr('role', 'tablist').attr('aria-multiselectable', 'true'); $('#adminAppMenu h3').each(function(i) { $(this).attr('id', 'page'+(i+1)).addClass('panel-title').find('a') .attr('role', 'button').attr('data-toggle', 'collapse') .attr('data-parent', '#adminAppMenu') .attr('href', '#collapse_'+(i+1)) .attr('aria-expanded', 'false') .attr('aria-controls', 'collapse_'+(i+1)) .parent().next() .attr('id', 'collapse_'+(i+1)).attr('class', 'panel-collapse collapse').attr('role','tabpanel').attr('aria-labelledby','heading_'+(i+1)); $(this).wrap('<div class="panel panel-default"><div class="panel-heading" role="tab" id="heading_'+(i+1)+'"></div></div>'); $('#collapse_'+(i+1)+' ul').addClass('list-group').find('li').addClass('list-group-item'); $('#collapse_'+(i+1)).insertAfter('#heading_'+(i+1)); }); //Keep state of collapse menu via localStorage var adminCollapseAppMenu = localStorage.getItem('adminCollapseAppMenu'); if (!adminCollapseAppMenu) { adminCollapseAppMenu = []; localStorage.setItem('adminCollapseAppMenu', JSON.stringify(adminCollapseAppMenu)); } else { adminCollapseAppMenuArray = JSON.parse(adminCollapseAppMenu); var arrayLength = adminCollapseAppMenuArray.length; for (var i = 0; i < arrayLength; i++) { var panel = '#'+adminCollapseAppMenuArray[i]; $(panel).addClass('in'); } } $('#adminAppMenu').on('shown.bs.collapse', '.panel-collapse', function() { adminCollapseAppMenu = JSON.parse(localStorage.getItem('adminCollapseAppMenu')); if ($.inArray($(this).attr('id'), adminCollapseAppMenu) == -1) { adminCollapseAppMenu.push($(this).attr('id')); }; localStorage.setItem('adminCollapseAppMenu', JSON.stringify(adminCollapseAppMenu)); }); $('#adminAppMenu').on('hidden.bs.collapse', '.panel-collapse', function() { adminCollapseAppMenu = JSON.parse(localStorage.getItem('adminCollapseAppMenu')); adminCollapseAppMenu.splice( $.inArray($(this).attr('id'), adminCollapseAppMenu), 1 ); localStorage.setItem('adminCollapseAppMenu', JSON.stringify(adminCollapseAppMenu)); }); }); //Prevent jQuery-UI's CSS showing up on pageLoad $(window).load(function() { // When the page has loaded $("body").fadeIn(100); }); </script> <?php if (tep_session_is_registered('admin')) { ?> <script> function osCMenu() { event.preventDefault(); if (localStorage.getItem("adminToggleAppMenu") == 1 ? localStorage.setItem('adminToggleAppMenu', 0) : localStorage.setItem('adminToggleAppMenu', 1)); if (localStorage.getItem("adminToggleAppMenu") == 1 ? $(".menu i").removeClass('fa-caret-square-o-right').addClass('fa-caret-square-o-left') : $(".menu i").removeClass('fa-caret-square-o-left').addClass('fa-caret-square-o-right')); if (localStorage.getItem("adminToggleAppMenu") == 1 ? $(".menu-col").show() : $(".menu-col").hide()); $(".body-content-col").toggleClass("col-md-10 col-md-12") } </script> <?php } ?> <script src="../ext/bootstrap/js/bootstrap.min.js"></script> OPTIONAL SUMMERNOTE WYSIWYG if you choose to want the wysiwyg: BEFORE <script src="../ext/bootstrap/js/bootstrap.min.js"></script> </body> </html> ADD: <script> $(function(){ //SUMMERNOTE WYSIWYG OPTIONAL: $('.summernote').summernote(); }); </script>

Here's what I want to get done to set the Community Version to a "Final" release; 1a. Modularisation of index COMPLETE Title Standardise Module Name and Template Name (each) 1b. Modularisation of index_nested COMPLETE Title Standardise Module Name and Template Name (each) 1c. Modularisation of index_products COMPLETE @BrockleyJohn has coded, thank you Title Description Products 2. Modularisation of product_info COMPLETE Strip Schema Schema Buttons Date Info Options Description Gallery Price Name Model Not Found Message Standardise Module Name and Template Name (each) 3. Bootstrap v4 CANCELLED Updating full shopside to BSv4 4. php7.0 COMPLETE Updating full shopside and full adminside to be 7.0 compliant. 5. getContent calls DISCUSSION Discussion needed 6. Hook calls COMPLETE @raiwa has coded, thank you Auto Register Hook for each page What I don't have plans for, so will not happen; Everything else Why go "Final" Too many shopowners and developers wanting a fixed release; almost all feedback tells me rolling updates are not welcome. After "Final" No further changes will be made. Date for "Final" I was hoping to get it done by the end of this Month, but that is not going to happen. Sorry Folks, it'll be as and when I have time.

A weeks worth of bonuses brings to a conclusion this years 28d project. A massive THANK YOU to the shopowners who were able to see what I've been trying to do and got behind me. Help and support is available for you guys as and when you need it. For the other hundreds (1000s?!?) of shopowners and developers who felt unable or unwilling to get involved, I say this;

28d Project comes to an official close, so nows the time to take a look and PM me if you want to see about getting all the code... Unofficially, there will be some bonus extras as I am waiting on testers to get back to me...as well have plans for at least 1 more GDPR module! PM me if interested, and a massive THANK YOU to all those who were able to join the Project already :)

https://apps.oscommerce.com/89uS9&modular-checkout-pages

Today I decided I got angry for the last time updating a table rate based module. Afer several tryouts to change the shipping rates just to see I had a typo in the values string -damned colons- and having to manually calculate the net prices for each row from the gross that came from the table provided by the courier... I had enough and modified the table rate module to show a real table where you can see what you're doing. Uses some javascript to update net/gross, add or remove rows and do some basic checks. It can be adapted to any other module that uses the same system. Note: The net pice is caclulated based on the tax class from the module. It will apply only to the countries in the module's zone and it's not savet to database but calculated on the fly. For this column to work you need to set up the tax rate first, save and enter the module configuration again. Here is the file: https://apps.oscommerce.com/wyYLv&sgipping-table-module-update @burt you can replace the stock one if you consider it fits the community project.

Wish everyone Happy Holidays and Merry Xmas... Best wishes for the coming year, hopefully 2018 will be the year for osCommerce to come alive again. Special thanks to all those who have supported the Community Version and very special thanks to all my clients, all of whom I consider friends. Cya on the flipside!

Massive changes in bootstrap structure between v3 and v4. If shopowner is using an unabused recentish Edge or Frozen... drop on the new files. When...soon. Where...undecided. To whom...people who I feel are supportive. Next two projects are lined up which will radically change osCommerce for the better.

Shop owners ... Developers ... osC junkies ... We need your help! As many of you know, @burt has been instrumental in pushing the community build of osC. We are the community. And right now, @burt needs our help! @burt does not get paid for his work on the community build! To finance all of his work, he puts out an incredible assortment of modules, such as his current 28 days bundle. The money he gets from these allow him the time to work on the community build core. He is very close to wrapping up Edge, making it a fixed base of code, with only future hotfixes as needed. But, he needs our help. We need about 10 people (shop owners, developers, osC junkies) to buy into the current 28 days bundle here: This is a great bargain, fantastic modules (just check out what he's released so far!), great code (most require NO core code changes), *plus*, he does offer support and customization! So please, let's help @burt help us! (otherwise, he'll have to take a day job <gasp!>, while we all wait for Edge to be finished)

Here is the next piece of the GDPR jigsaw puzzle. If you add up Article 20 and Recital 68...you (shopowner) have to give your customers a way to download their data. Good luck doing that - what a timesink - you are going to have to collate all of the customers data, create a file, tell them where it is, help them to download it etc. Bah, let's do all that automatically. Port My Data Module Clicking the Button allows the customer to download all of their data. Admin Side. Just turn it on. Once I get it fully tested in a live scenario, it'll go out to all and certainly prior to the 25th.

This is a admin sidebar that replaces the stock menu. It can be expanded or condensed on a column of icons. It also adds bootstrap framework to admin. Hope you enjoy it. Please comment here if you have any improvements or find any problem. Download: https://apps.oscommerce.com/ebjVY&admin-responsive-sidebar-with-bootstrap

Harald I can appreciate all the work you are doing behind the scenes to unify the osCommerce ecosystem, and I see that you have a vision. It's great that you are getting stuck back into it, lots of people were getting frustrated at a lack of progress so it will be great to shut down the negativity with these new releases (even tough they are more than long overdue!) Keep up the great work, it will be terrific to see things pick up again. I have to say that you owe @burt a big debt of gratitude, I hope you are going to do something special for him.

I don't expect this will be a publicly available thing; its a showcase of what the Responsive could (and should) have been had we got as far as Final. It will be available to some shopowners if they want it, but that will only be the handful of shopowners who are the diehard supporters of my efforts. Put simply; this is made to flatten my bsv4 learning curve.

Are you a shopowner? Help make the core osCommerce software better! This is the place where you can let the osCommerce team know about an idea (or ideas!) to improve the core software. First a definition: "core" osCommerce software is the package that is downloaded and installed by default. This isn't the place to write a wishlist of addons you'd like to see in the base osCommerce. Don't forget that lots of functionality is able to be added with addons that can easily be uploaded and turned on due to the modularity of osCommerce. The last thing we need is a bloated package full of "features" that will never be used by a large majority of shopowners. If you have an idea for an app, post it here. What is welcome here is ideas that can, for instance, make it even easier for addons to be installed. Perhaps you (or your developer) have found developing and adding a particular addon is too difficult because you need to dive into core code. In that case, let the developers know! Perhaps you can't find ways to turn things on or off. Or something you want to do is way too difficult because of the way the core code is structured. We as shopowners who deal with the day to day running of stores and have the knowledge as to how osCommerce can be improved for both us and our customers. This is our opportunity to have some input into the direction of the software. Anything to do with the core code that would make your life easier as a shopowner, let the team know by posting it here.

Bonus #6 - Video Tab New Tab that shows one video per product. Could be an unboxing video, or whatever. If you want to be the awesomest shopowner ever...it could be a video of the Red Woman from Game of Thrones. Admin Side New Page for assigning video to product. Works only with Youtube at this moment (see Question below). Admin Side New box and links for these helper pages Shop Side New Tab showing the Video Question Is Youtube enough, or should there be other video hosting options? Created in response to @bruyndoncx great idea, thank you. Delivery: Tomorrow

Need help? You've come to the right place. This post offers some general suggestions on how to get the help you need, quickly and efficiently. With over 1.6 million posts, your question has likely been asked and answered already so try searching the forums first. Using Google search generally produces the best results. In the Google search bar, just enter osCommerce and a description of the problem you are having or a likely topic for that problem and see what results are returned. You may get the help you need faster than you think. If you can't find the answer you need using Google Search then perhaps someone on the forums can help. Help is provided by volunteers, so please be considerate of their time, and provide as much information as possible. Here is a list of the information you should provide. Not all of it may be applicable to your particular situation, but providing as much detail as possible will result in a faster and more relevant reply. 1. Which version of osCommerce you are using? (you can find this at Admin > Tools > Version Checker). - Please provide the full version number, which is 3 or 4 digits ie 2.3.4.1 2. Also indicate whether you are using standard osCommerce or the Responsive (a.k.a. "Community Edition", "Community Supported") version. - If you are using version 2.3.4 or 2.3.4.1 and are not sure you can check whether your site is Responsive (mobile friendly) by entering your website address here. 3. Is this a new install or an existing store? - If this is a new install please be sure you are using the latest version of osCommerce which you can get here. 4. What version of PHP are you using? (you can determine this by looking at Admin > Tools > Server Info) - If your ISP has recently updated the version of PHP they are using, it can cause a variety of problems. Fortunately, recent versions of osCommerce have been updated to work with newer versions of PHP, so if you are experiencing issues with PHP, please consider updating your osCommerce software. 5. Now you are ready to provide a detailed description of the problem you are having, including if applicable, the steps needed to reproduce it. - Providing a link to the page where the problem can be seen or if you are receiving an error message, a screen shot or the exact text of the message displayed is extremely helpful. The more detailed information you can provide the better. Be sure to obscure (***-out) sensitive information such as your server account name. If you need to show your configure.php file(s), remove or obscure the database name, user, and password! Now that you've gathered the information needed, you'll need to decide where to post it. 1. If the problem relates to an add-on that you downloaded from the apps area please see if there is a support thread for that add-on, and if so post your help request there. Often the authors of the add-on monitor their support threads, and you'll get the quickest and most appropriate response there. 2. If your problem relates to a 3rd party product or template that you acquired elsewhere, then you should go back to the author or vendor of that 3rd party product and ask for help there. They will be in the best position to help. 3. All other requests for help should be posted to the General Support forum. Start your own thread instead of posting to an existing thread, even if they seem related to the problem you are having. Your problem or the version of osCommerce/PHP you are using may be different and only serve to confuse others who are seeking help with a similar problem. Ask a new question. If all else fails or you need help updating an older add-on, or perhaps creating a new one, commercial support is also available. Requests for commercial support can be posted here.

Day 01 - Better Stock Message This is a Content Module that sits on shopping_cart.php which displays a better stock message. Core Code Changes YES - 1 line of code on shopping_cart.php Existing New Module Admin

And here's some general usage: https://youtu.be/dLgiD1FoTj4

I suggest not reading any of those SEO "experts" and just focus on giving your customers a great experience. Repeat business is what you want, not a continual frenetic hunt for new clients through Google.

Slim-Checkout Common opinion is that the checkout process should be as "slim" as possible. This means to hide all page elements which are not strict necessary to show to the customer a simple clean layout, so nothing disturbs his attention from the purchase process. This add-on allows to do it by simple settings in a Header Tag module. Git Hub Repository: https://github.com/raiwa/Slim-Checkout/tree/master What it does: - allows to hide elements on checkout pages - optional hide on checkout pages (checkout_shipping.php, checkout_payment.phpheckout_confirmation.php and checkout_success) - optional hide also on shopping_cart.php - select each group to hide (navbar, header area, boxes, footer and footer suffix Installation: - copy all new files - install and adjust Slim Checkout Header Tag testing , Bug reports and suggestions very welcome. rgds Rainer

Addon is now available. Congratulations!

Edge is now mirrored to the recent v2.3.4.1

Thank You Frank. If it was not for you and a handful of other shopowners...I dread to think where osCommerce would be right now.

Visually, I think everything looks better. Functionally, the code is cleaner & faster.

As a store owner, I don't want to have to visit Github (or wherever) to see if there are any patches I need to apply to my live store(s). For me, I was very happy when Edge/Final/Frozen was 'finished'. That's not to say that there aren't any bugs still in it. That's the reason for this thread ... a place to document bugs, and hopefully fixes. I am also pleased that development is still happening. Keep it up, guys. Use this thread as a source of information to improve your forks. But please, for this thread, let's keep it just for Edge/Final/Frozen, ok?

Here we go, continued project: https://github.com/osc2nuke/oscommerce-2.3.4.1-CE issues: https://github.com/osc2nuke/oscommerce-2.3.4.1-CE/issues

It will happen only if Harald (who owns osC and this site) wishes for it to happen. He has given no indication that he does. Last August he promised a 2.3.5 upgrade release of some sort, and 2.3.6 (the CE version), within a few weeks, and it's been 8 months now. No one has heard from him in over 3 months, and we're starting to wonder if he's still above the grass. Anyone holding their breath, waiting for something to happen, is very blue by now. Most people have given up and are moving on to other projects. It's unfortunate, and even tragic (given the amount of work that he and others have put in), but he just does not know how to run a major project. You can not disappear for years at a time, crafting your solo personal project to perfection, and then suddenly present it for the world to ooh and aah over. The current offering has to be kept alive and updated and supported, and this just has not been happening.

Popup Style Hint: No Core Changes: Works on mobile/touch screen: Coming Soon to those who "get it"

Great, thank you. Will guarantee this goes into Core when you guys are ready to push it. We can also revisit the modular Cart (I will open a new discussion for that one in the next days).

Interesting debate ... As a shopower I learned myself the skills to maintain and develop code for osCommerce ... The past 14 years or so I have looked at different carts from time to time (Presta - Magento - osC V3 - Shopify - etc.). For most of them - started a test shop - looked into the code - and especially tried to make an analysis of the eco-system. Believe me - it doesn't get better! Off course the lack of a roadmap (time table) is killing oSC. If Harald just/only would share his direction and objectives - a lot of community members could do a vast amount of work to bring oSC to a higher level. THANKFULLY @burt started his community edition - he did a massive job. But - if I understood right - the lack of support from the community (donate money - test - give feedback etc) made Gary decide to stop further development. And that's a shame! As I said - it doesn't get better with a different cart. osCommerce is the only true Open Source Cart in my opinion/experience. Easy to maintain for different skill levels of coders. Compare this to Magento ... a nightmare in debugging ... You probably end up with a professional that's gonna cost you a lot of money. And they (also) went from V1 to V2 leaving all your extensions useless. So - off course it's important to look around and keep openminded for different carts. But as long as osC keeps developing - even at a slow / minimal pace - I prefer to stay with osC. Hope this helps to convince some people to donate @burt so maybe he will reconsider ... just look in Github what he @BrockleyJohn and @wHiTeHat Henry did the past days https://github.com/gburton/Responsive-osCommerce/pulls

Bonus #4 - Price Changing On The Fly Works in every currency. Lots of people wanted this... Core Code Changes None Video (watch the price as the select options are changed) This is one of the modules that was sent out for testing, and was late in coming back to me. This will be sent out later today or perhaps tomorrow.

It would be nice to allow shopowner to select which module should be selected? SQL: Use phpmyadmin or similar INSERT INTO configuration ( configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, set_function, date_added) values ( 'Set Default Shipping Method?', 'SHIPPING_DEFAULT_METHOD', '', 'This will make shipping selection default to the selected method.', '7', '5', 'tep_cfg_pull_down_shipping_methods(', now()); CODE: /includes/classes/shipping.php Find: return $cheapest; Add ABOVE it: if ( defined('SHIPPING_DEFAULT_METHOD') && (SHIPPING_DEFAULT_METHOD != '--none--') ) { $shipping_method = basename(SHIPPING_DEFAULT_METHOD, '.php') . '_' . basename(SHIPPING_DEFAULT_METHOD, '.php'); for ($i=0, $n=sizeof($rates); $i<$n; $i++) { if ($rates[$i]['id'] == $shipping_method) { $cheapest = $rates[$i]; } } } CODE: /admin/includes/functions/general.php Add: function tep_cfg_pull_down_shipping_methods($shipping_method, $key = '') { $name = (($key) ? 'configuration[' . $key . ']' : 'configuration_value'); $shipping_array = array(array('id' => TEXT_NONE, 'text' => TEXT_NONE)); $ship_array = explode(';', MODULE_SHIPPING_INSTALLED); foreach($ship_array as $k => $v) { $shipping_array[] = array('id' => $v, 'text' => $v); } return tep_draw_pull_down_menu($name, $shipping_array, $k); } Note: Untested, but should work. Feel free to optimise it to something more elegant. If it works, you should be able to go to admin > configuration > shipping/packaging and select which module should be used

Day 24 - More GDPR A few more Modules for the GDPR page... Core Code Changes NONE 1. Orders 2. Device Data (turn on if using a previous 28d that collects this data) 3. Reviews 4. Security Answers (turn on if using a previous 28d that asks for this data) 5. Cookies Also a "Forget Me" module for the GDPR bit of the account.php page which leads to a way for Customers to Nuke themselves. Summary A bunch more useful modules to try to cut down on YOUR workload shouhld you have EU customers who want to know their data. Over the coming months up until May, I expect shopowners will come up with more ideas of things that need to be shown, and these can be coded up as extra modules.

I am one of those who already receive Burt addons. To be honest, I was skeptical at first because I paid for addons "mystery" since we do not know the addons in advance. Well I can tell you that I do not regret it! It's well coded, it's clean, efficient and when needed, Burt is really available. Sincerely thanks Burt!

Day 22 - More Product Tabs I have some more Tabbed goodness for you, these are used with the 28d02 set of modules. Core Code Changes NONE Tabbed X-Sell Set up X-selling on a per product basis. Show the X-Sells in a Tab! Note: Requires a previous X-Sell system of mine, included. Tabbed Social Sharing Much better looking Social Share Icons shown in a Tab! Note: Requires a previous social modules of mine, included. Tabbed Gallery This one I particularly like as I found a way to add in more Images ... by changing 1 admin setting they can then be shown in a Tab In standard osC, you get a gallery looking like this: By turning on the Tabbed Gallery and changing 1 osC setting...it transforms into this: Summary Three useful additions to the Tabbed System! Note While coding up these modules, I did find a tiny bug in the main p_i module, this would not have shown itself with the original included modules. Bug Hotfix will also be sent tonight.

I just quote from google All what google says is they recommend or say it is good practice to make the URLs read-friendly so that customers/users can read or use the URL as link or navigation guide. It doesn't say one word that it will improve your SEO because of that. Google just says you should keep it organized. Another quote Again, no mention of SEO benefit. Visitor friendly does not equal better SEO or SEO results. Lastly, everyone can do what they want with their shop site it is their website and they should know what their customers might want. Look at Amazon, eBay or some other big shop they all have different URLs, some long, some short, some easier to read, some are super long and complicated. Important is that the "real" SEO stuff in your shop is working as it should then you'll end up getting good search results. So what @burt said isn't wrong at all. User friendly URLs have nothing to do with SEO.

Day 16 - Automated GDPR Does not matter where you, shopowner, are based in the World. It's all about your client, and if any of your clients are EU Citizens...you *must* offer them a way to see what personal details you hold about them, and offer them a way to delete out some of that data. Again...for 100% clarity...it does not matter if you are in Paris France, Paris Texas or China or Thailand or where-ever, if you sell into the EU...you must comply with EU Regulations. This new system helps to show what data you hold on logged in clients. This is a work in progress as I am hoping anyone who gets their hands on this, comes up with ideas for more modules (I can think of at least three more), but want to get feedback before more coding... Core Code Changes NONE New Link in account.php This link leads to a new modularised page. As this new page is modularised it is simple to code up more modules based on individual shopowners needs... For starters I have included four GDPR modules; Admin Side > Modules > Content Intro Just a block of text explaining what GDPR is etc. You can obviously change this to better suit your needs. Contact Details Personal Details Site Details All of the above are MODULES, so can be turned on/off from Admin. Summary A way for EU clients to view the Data you hold. This may very well be enough for their needs, thereby no need to request personal intervention from you, taking up your time. If you have guest accounts, you are stuffed. Ideas for more Modules I can think of at least a few more modules that can potentially be coded. But let's see what you guys have to say after you have this system.

This addon minifies the shops css file. If multiple files are selected, it will combine them all into one file. This can reduce the time it takes for the shop to load. Depending upon the size of the css file and how many there are, the page load speed can be reduced by several seconds. It works in any oscommerce shop. For the 2.3.4 shops (both official and Responsive versions), the installation just involves uploading files. For older shops, one change may be needed.

Grid List is remembered via Cookie. This means loading in this file; https://github.com/gburton/Responsive-osCommerce/blob/master/ext/jquery/cookie.js It's not a big file, but it can be got rid of as so; Change these two lines: https://github.com/gburton/Responsive-osCommerce/blob/master/includes/modules/header_tags/ht_grid_list_view.php#L46-L47 To: $grid_list_js = <<<EOD <script>$(function() { var cc = localStorage['list_grid']; if (cc == 'list') { $('#products .item').removeClass('grid-group-item').addClass('list-group-item'); } else { $('#products .item').removeClass('list-group-item').addClass('grid-group-item'); } $(document).ready(function() { $('#list').click(function(event){ event.preventDefault(); $('#products .item').addClass('list-group-item').removeClass('grid-group-item'); localStorage['list_grid'] = 'list'; }); $('#grid').click(function(event){ event.preventDefault(); $('#products .item').removeClass('list-group-item').addClass('grid-group-item'); localStorage['list_grid'] = 'grid'; });});});</script> EOD; $oscTemplate->addBlock($grid_list_js . PHP_EOL, $this->group); Save file and upload. You should see no change at all in functionality. HOwever your site is now loading faster as it does not have to load the cookie.js file. Thoughts and Feedback appreciated. And code changes. Etc and so on. Pitch in.

How about this for install instructions https://youtu.be/cwaid91cp1A

Looking to do a new 28days project so if anyone has an idea for a SMALL or MEDIUM sized piece of code, let me know...

@raiwa Well done! We appreciate all the hard work you put into your addons and projects but please do me a favor and don't work too much/hard. In the past I/we have lost 2 very good friends from this forum and the last thing I remember was, they were working hard on some addons/projects and it could have been just mere coincidence or just fact that they overworked themselfs till their body gave up. You maintain multiple addons, you work with me on the Point and Rewards module, Sloppy words cleaner and, and, and.... Long story short, watch your health and take enough rest so that we will be able to enjoy you and your work for many years to come. That goes for all of you out there. osC is nice and all but it won't bring you anything if you work yourself to death. Now back to work....

Hi All.. Both v2.3.5 and v2.3.6 were planend to be released today (end of August) however a few more days is needed. This topic will be updated on the weekend with the date next week when the releases will be pushed out. Kind regards,

This. Absolutely this. Even us "coders" do this. We find the nearest module that does something a bit similar, copy it, and then fanny about with it until it does what we want it to do.