Ok ... I solved it and it's working great!
For those people who also want/need to keep using popup_image.php with SEO url .... altough I recommend to upgrade OSC2.3 ...
- Copy the code and
save in folder /page_modules as popup_image.php
- The .htacces already has the line in it for rewriting the URL (if you have uri fromat rewrite in your admin settings) ... I only tested with rewrite!
- I changed the _GET key from pID to products_id in the javascript snippets:
<script type="text/javascript"><!--
document.write('<?php echo '<a href="javascript:popupWindow(\\\'' . tep_href_link(FILENAME_POPUP_IMAGE, 'products_id=' . $product_info['products_id'].'&image=1') . '\\\')">' . tep_image(DIR_WS_IMAGES . $product_info['products_image'], addslashes($product_info['products_name']), SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT, 'hspace="5" vspace="5"') . '<br />' . TEXT_CLICK_TO_ENLARGE . '</a>'; ?>');
//--></script>
- It also works for additional images
class Popup_Image_Page_Module extends aPage_Modules {
private static $_singleton = null;
/**
* Array of _GET key dependencies for this page
* - marker is the seo url replacement for the dependent _GET key ( e.g. -c- replaces cPath )
* - query is the query used to extract the link text from the database
* - to_replace is an array of texts that are to be replace with real values in the query
* @example protected $dependencies = array( 'cPath' => array( 'marker' => '-c-',
* @var array $dependencies
*/
protected $dependencies = array( 'products_id' => array( 'marker' => '-pi-',
'query' => "SELECT pd.products_name, m.manufacturers_name, cd.categories_name, p.products_model, p2c.categories_id FROM :TABLE_PRODUCTS_DESCRIPTION pd INNER JOIN :TABLE_PRODUCTS_TO_CATEGORIES p2c ON p2c.products_id = pd.products_id INNER JOIN :TABLE_PRODUCTS p ON pd.products_id = p.products_id LEFT JOIN :TABLE_MANUFACTURERS m ON m.manufacturers_id = p.manufacturers_id INNER JOIN :TABLE_CATEGORIES_DESCRIPTION cd ON p2c.categories_id = cd.categories_id AND cd.language_id=':languages_id' WHERE pd.products_id=':products_id' AND pd.language_id=':languages_id' LIMIT 1",
'to_replace' => array( ':TABLE_PRODUCTS_DESCRIPTION', ':TABLE_PRODUCTS_TO_CATEGORIES', ':TABLE_PRODUCTS', ':TABLE_MANUFACTURERS', ':TABLE_CATEGORIES_DESCRIPTION', ':languages_id', ':products_id' ) ) );
/**
* The current dependency key extracted from the incoming parameters
*
* @var string $key - dependency key
*/
protected $key = null;
/**
* extracts the key => value pairs from the querystring in order to build a unique cache name for the loaded page
*
* @var array $cache_name_builder
*/
protected $cache_name_builder = array( 'products_id' => 1, 'image'=> 1 ); // xxx = _GET key ( e.g. cPath ), you may want to add "page" if there are paging functions
/**
* Class constructor
* @access private
*/
private function __construct() {
} // end constructor
/**
* Returns a singleton instance of this object
*
* @access public
* @return Article_Info_Page_Module
*/
public static function i() {
if ( !self::$_singleton instanceof self ) {
self::$_singleton = new self;
}
return self::$_singleton;
} // end method
/**
* Retrieve the dependencies array for this page module
*
* @access public
* @return array $dependencies
*/
public function retrieveDependencies() {
return $this->dependencies;
}
/**
* Acquire an array of single or multiple link texts from the query
* this will be cached for later retrieval.
*
* @see Usu_Main::query()
* @uses trim()
*
* @access protected
* @return array array of link test
*/
protected function acquireLinkText() {
$result = Usu_Main::i()->query( $this->query );
$text_array = tep_db_fetch_array( $result );
tep_db_free_result( $result );
if ( false === $text_array ) {
return false;
}
$final_text_array = array();
foreach ( $text_array as $key => $text ) {
if ( tep_not_null( trim( $text ) ) ) {
$final_text_array[$key] = $text;
}
}
// We will cache this result
return $final_text_array;
}
/**
* The main method of this class that receives input needed to build a link
* then finally returns a fully built seo link if it has not previousluy returned false.
*
* @see Usu_Main::getVar()
* @see Usu_Main::setVar()
* @see aPage_Modules::stripPathToLastNumber()
* @see aPage_Modules::setQuery()
* @see aPage_Modules::unsetProperties()
* @see aPage_Modules::getDependencyKey()
* @see aPage_Modules::setAllParams()
* @see aPage_Modules::validRequest()
* @see aPage_Modules::returnFinalLink()
* @param string $page - valid osCommerce page name
* @param string $parameters - querystring parameters
* @param bool $add_session_id - true / false
* @param string $connection - NONSSL / SSL
* @param array $extract - array of _GET keys to remove from the querystring or bool false to do nothing
* @uses trigger_error()
* @throws - triggers an error of type E_USER_WARNING for an incorrect or inexistant dependency key
* @access public
* @return bool false - forces the system to return the standard osCommerce link wrapper
* @return string - fully built seo url
*/
public function buildLink( $page, $parameters, $add_session_id, $connection ) {
$extract = array( 'products_id' ); // xxx = _GET key ( e.g. cPath )
$this->setAllParams( $page, $parameters, $add_session_id, $connection, $extract );
if ( false === $this->validRequest() ) {
$this->unsetProperties();
return false;
}
$this->key = $this->getDependencyKey();
/**
* If the shop has issues it may pass in null values, in this case return false to force the standard osCommerce link wrapper
*/
if ( !array_key_exists( $this->key, $this->keys_index ) || !tep_not_null( $this->keys_index[$this->key] ) ) {
return false;
}
// Switch statement where the correct query and query marker replacements to use are selected via the _GET key detected
switch ( true ) {
case $this->key == 'products_id': // xxx = _GET key ( e.g. cPath )
// This array contains replacements for the to_replace array ( see the $dependencies array )
$this->setQuery( array( TABLE_PRODUCTS_DESCRIPTION, TABLE_PRODUCTS_TO_CATEGORIES, TABLE_PRODUCTS, TABLE_MANUFACTURERS, TABLE_CATEGORIES_DESCRIPTION, Usu_Main::i()->getVar( 'languages_id' ), $this->keys_index[$this->key] ) );
break;
default:
trigger_error( __CLASS__ . '::' . __FUNCTION__ . ' Incorrect or inexistant dependency key.', E_USER_WARNING );
break;
} // end switch
$link_text = $this->acquireLinkText();
// If the query returned false then we return nothing and set $page_not_found to true forcing a 404 page
Usu_Main::i()->setVar( 'page_not_found', false );
if ( false === $link_text ) {
Usu_Main::i()->setVar( 'page_not_found', true );
$this->unsetProperties();
return;
}
// Return a fully built seo url
return $this->returnFinalLink( Usu_Main::i()
->getVar( 'uri_modules', USU5_URLS_TYPE )
->createLinkString( $this->page, Usu_Main::i()
->getVar( 'uri_modules', USU5_URLS_TYPE )
->separateUriText( $this->linktext( $this->linkTextOrder( $link_text ) ) ), $this->dependencies[$this->key]['marker'], $this->keys_index[$this->key] ) );
} // end method
/**
* Like text options offered by b,c,m,p
*
* Builds the link text based on the settings chosen in admin .. products name must be present or the script adds it regardless.
*
* @uses array_key_exists()
* @uses stripos()
* @uses str_split()
* @uses array_flip()
* @uses array_intersect_key()
* @uses count()
* @param array $details - link text key=>value pairs
*
* @access private
* @return array $to_seperate - array of link text options in the correct order
*/
private function linkTextOrder( array $details = array() ) {
$text_types = array( 'p' => $details['products_name'], 'c' => $details['categories_name'], 'm' => $details['products_model'] );
// manufacturers_name is gained through a left join and may not exist
array_key_exists( 'manufacturers_name', $details ) ? $text_types['b'] = $details['manufacturers_name'] : null;
// Products name MUST be present, if not we force it to the end
if ( false === stripos( USU5_PRODUCTS_LINK_TEXT_ORDER, 'p' ) ) {
$admin_order = str_split( USU5_PRODUCTS_LINK_TEXT_ORDER . 'p' );
} else $admin_order = str_split( USU5_PRODUCTS_LINK_TEXT_ORDER );
// Split the string value entered in admin ( like mcp etc ) to an array
$text_order = array_flip( $admin_order ); // Flip key => value to value => key
$text_to_format = array_intersect_key( $text_types, $text_order ); // return only those key => value pairs that match the admin selection
$link_text_count = count( $admin_order );
$ordered_array = array();
for ( $i=0; $i<$link_text_count; $i++ ) {
if ( ( array_key_exists( $admin_order[$i], $text_to_format ) && tep_not_null( $text_to_format[$admin_order[$i]] ) ) ) { // If a value is empty then we don't want to add it to the link text
$to_seperate[] = $text_to_format[$admin_order[$i]]; // Create an array where the link text is in the same order as the admin selection
}
}
return $to_seperate;
} // End method
} // end class
Maybe Robert can comment on possible pitfalls!
Test first and use at own risk!
Cheers!
137
FWR Media, on 26 July 2011 - 01:04 PM, said:
