Jump to content



beerbee

Member Since 22 Jan 2006
OFFLINE Last Active Today, 08:51
-----

Posts I've Made

In Topic: Something little for shipping and payment adress

24 March 2017 - 13:06

This closing strong tag without opening is as found in my download of edge from January 17. So it seems to be core ;-).

 

If I return to the original there is nothing bold in the address data, that's the way I wanted it to be again after I noticed that label was turning everything there to bold.

 

Best regards

Christoph


In Topic: Something little for shipping and payment adress

24 March 2017 - 12:28

@John W

I know style is not a great idea should be in user css. With it I wanted to and did achieve that it isn't bold, it became all bold because of the label I introduced here. The effect of the label is that it is enough to touch the adress field to make it selected. But maybe this could be achieved in a better way.

 

Best regards

Christoph


In Topic: Something little for shipping and payment adress

24 March 2017 - 08:24

@John W  I think even only underscoring the words this form to make it look linkalike could do.

 

Another little thing I'd like to change additionally  is making the selection of existing addresses easier on touchscreens  by putting label there, so this is more a question than a suggestion. Are there more elegant ways (I'm pretty shure there are) to do it like this?

 

from this:

   <div class="col-sm-4">
        <div class="panel panel-<?php echo ($addresses['address_book_id'] == $sendto) ? 'primary' : 'default'; ?>">
          <div class="panel-heading"><?php echo tep_output_string_protected($addresses['firstname'] . ' ' . $addresses['lastname']); ?></strong></div>
          <div class="panel-body">
            <?php echo tep_address_format($format_id, $addresses, true, ' ', '<br />'); ?>
          </div>
          <div class="panel-footer text-center"><?php echo tep_draw_radio_field('address', $addresses['address_book_id'], ($addresses['address_book_id'] == $sendto)); ?></div>
        </div>
      </div>

to that:

 <div >
        <label class="col-sm-4" style="font-weight:normal;" >  <div class="panel panel-<?php echo ($addresses['address_book_id'] == $sendto) ? 'primary' : 'default'; ?>"></label>
           <div class="panel-heading"><?php echo tep_output_string_protected($addresses['firstname'] . ' ' . $addresses['lastname']); ?></strong></div>
          <div class="panel-body">
            <?php echo tep_address_format($format_id, $addresses, true, ' ', '<br />'); ?>
          </div>
          <div class="panel-footer text-center"><?php echo tep_draw_radio_field('address', $addresses['address_book_id'], ($addresses['address_book_id'] == $sendto)); ?></div>
        </div>
      </div>

font-weight:normal because label seems to make text bold. I couldn't find much info about labels used to extend selection areas.

 

I really don't want to encourage anyone to change core, so I hope I might be able get this little things done in way without having to do so.

 

Best regards

Christoph


In Topic: Something little for shipping and payment adress

24 March 2017 - 07:32

@Dan Cole sadly not for now, I'm just trying  to understand how hooks work and would be happy to do so soon. From what I understand now one can add and extend functionalities but how to replace parts of pages? Or have I simply overlooked something?

 

I've got the impression that in those cases modularized pages come into play, but again i might be totally wrong.

 

Best regards

Christoph


In Topic: Something little for shipping and payment adress

23 March 2017 - 15:51

Hi John W.,

 

I  thought the hand symbol and span button could be enough, but you are right a little bit of text would be nice too.

 

Best regards

Christoph