Freeman

Hi There,
not sure if this is also affecting 2.3.1 , if someone wanna try that'll be great.
ISSUE
If i select with the standard OT_SHIPPING order total module and set up to agree a free carriage for people who spend more than XXX the amount is being calculated INCLUDING the carriage cost and not EXCLUDING it.
Example scenario:
Free carriage over 100$
Flat shipping rate 10$
Goods Value 91$
The carriage will be given as FREE (it sums 91+10 = 101)
Proposed Fix

-Inside catalog/checkout_shipping.php

Change as below:
----------------------------START----------

$free_shipping = false;
//Fix to calculate the order total excluding carriage cost
// if ( ($pass == true) && ($order->info['total'] >= MODULE_ORDER_TOTAL_SHIPPING_FREE_SHIPPING_OVER) ) {
if ( ($pass == true) && ( ($order->info['total'] - $order->info['shipping_cost']) >= MODULE_ORDER_TOTAL_SHIPPING_FREE_SHIPPING_OVER) ) {
$free_shipping = true;

------------END-----------------

Hope this helps,
Regards
Fabrizio