Shadow-Lord

In includes\functions\html_output.php

	if ( (SEARCH_ENGINE_FRIENDLY_URLS == 'true') && ($search_engine_safe == true) ) {
	  $link = str_replace('?', '/', $link);
	  $link = str_replace('&', '/', $link);
	  $link = str_replace('=', '/', $link);
	} else {
	  $link = str_replace('&', '&', $link);
	}

This is breaking error reporting in some modules.

In Sage Pay the error url should be:

http://www.example.com/checkout_payment.php?payment_error=sage_pay_server&error=4000

but it is been changed to:

http://www.example.com/checkout_payment.php?payment_error=sage_pay_server&error=4000

So no error description is shown.

When the banner_statistics.php file opens, the Admin Tools Menu should stay open, but it resets and the Configuration Menu opens.

To fix this I added the below code to admin/includes/boxes/tools.php

	  array(
		'code' => FILENAME_BANNER_STATISTICS,
		'title' => '',
		'link' => ''
	  ),

The admin/includes/boxes/tools.php should now look like:

<?php
/*
  $Id$
  osCommerce, Open Source E-Commerce Solutions
  http://www.oscommerce.com
  Copyright (c) 2011 osCommerce
  Released under the GNU General Public License
*/
  $cl_box_groups[] = array(
	'heading' => BOX_HEADING_TOOLS,
	'apps' => array(
	  array(
		'code' => FILENAME_ACTION_RECORDER,
		'title' => BOX_TOOLS_ACTION_RECORDER,
		'link' => tep_href_link(FILENAME_ACTION_RECORDER)
	  ),
	  array(
		'code' => FILENAME_BACKUP,
		'title' => BOX_TOOLS_BACKUP,
		'link' => tep_href_link(FILENAME_BACKUP)
	  ),
	  array(
		'code' => FILENAME_BANNER_MANAGER,
		'title' => BOX_TOOLS_BANNER_MANAGER,
		'link' => tep_href_link(FILENAME_BANNER_MANAGER)
	  ),
	  array(
		'code' => FILENAME_BANNER_STATISTICS,
		'title' => '',
		'link' => ''
	  ),
	  array(
		'code' => FILENAME_CACHE,
		'title' => BOX_TOOLS_CACHE,
		'link' => tep_href_link(FILENAME_CACHE)
	  ),
	  array(
		'code' => FILENAME_MAIL,
		'title' => BOX_TOOLS_MAIL,
		'link' => tep_href_link(FILENAME_MAIL)
	  ),
	  array(
		'code' => FILENAME_NEWSLETTERS,
		'title' => BOX_TOOLS_NEWSLETTER_MANAGER,
		'link' => tep_href_link(FILENAME_NEWSLETTERS)
	  ),
	  array(
		'code' => FILENAME_SEC_DIR_PERMISSIONS,
		'title' => BOX_TOOLS_SEC_DIR_PERMISSIONS,
		'link' => tep_href_link(FILENAME_SEC_DIR_PERMISSIONS)
	  ),
	  array(
		'code' => FILENAME_SERVER_INFO,
		'title' => BOX_TOOLS_SERVER_INFO,
		'link' => tep_href_link(FILENAME_SERVER_INFO)
	  ),
	  array(
		'code' => FILENAME_VERSION_CHECK,
		'title' => BOX_TOOLS_VERSION_CHECK,
		'link' => tep_href_link(FILENAME_VERSION_CHECK)
	  ),
	  array(
		'code' => FILENAME_WHOS_ONLINE,
		'title' => BOX_TOOLS_WHOS_ONLINE,
		'link' => tep_href_link(FILENAME_WHOS_ONLINE)
	  )
	)
  );
?>

Hi,

I am using a Chinese language pack.
http://addons.oscommerce.com/info/7471

All product info shows correctly on the shop, and when added to the cart.

For example 快遞服務 is stored in the database as 快遞服務 but displays on the shop correctly as 快遞服務

When I go to the PayPal using PayPal Express it displays as 快遞服務

Is there a fix for this bug, please.