Jump to content



Latest News: (loading..)

cannuck1964

Member Since 15 Sep 2002
Offline Last Active Today, 01:09 AM
-----

Issues I've Posted

    PCI compliance

    Posted 4 Jan 2013

    Hi,

    I have found that the more resent releases of the 2.3.3 package have CVS folders throughout the fold directories.

    These folders will fail in a PCI compliance scan, I would suggest they are removed from the public distribution as it is a pain  to manually go through all to remove them, as well they generally do not serve any purpose to the average users in a shop set up.


    cheers

    Peter

    Type casting in currencies

    Posted 7 Dec 2012

    Hi,

    I have found on some websites that the function in the currency.php class

    function format($number, $calculate_currency_value = true, $currency_type = '', $currency_value = '')

    Type classes ther variable $number incorrectly.

    For example, the number 1,234.5600 when operated on by the function (multiplied by the $rate for example) would return 1.00 every time.

    This does not happen on all servers and was happening in conjuction when I was using the loyalty points contribution.

    A simple fix for this though would be to set it as a float prior to any operations on it and remove any characters that are not numerical..

    $number = floatval(preg_replace("|[^-0-9\.]|","",$number));

    prior to any actions being done on the variable.


    cheers

    Authorize.net AIM Failure

    Posted 1 May 2012

    When using the authorize.net_cc_aim module and the customer has an item like this in the cart :


    Energizer® Illumifold™ Flashlight Folding Fluorescent

    the special characters will create a failure on the payment with an item is invalid error.

    this comes from lines 173 - 175 :

    	  for ($i=0, $n=sizeof($order->products); $i<$n; $i++) {
    
    		$post_string .= '&x_line_item=' . urlencode($i+1) . '<|>' . urlencode(substr($order->products[$i]['name'], 0, 15)) . '<|>' . urlencode(substr($order->products[$i]['name'], 0, 255)) . '<|>' . urlencode($order->products[$i]['qty']) . '<|>' . urlencode($this->format_raw($order->products[$i]['final_price'])) . '<|>' . urlencode($order->products[$i]['tax'] > 0 ? 'YES' : 'NO');
    
    	  }
    

    The line is truncated first, then ulrencoded.

    This makes the resulting line longer then 31 characters and thus fails.  Fix is to urlencode first, then truncate to 31 characters.

    The SIM module may have this as an issue as well.

    cheers

    malformed url issue

    Posted 3 Aug 2011

    in the 2.3.1 release (maybe others)  

    file includes/functions/html_output.php

    function tep_href_link()  

    line number 69  

    currently there is :

    $link = str_replace( '&', '&amp;', $link);  

    this should be :
    $link = str_replace('&amp;', '&', $link);  

    the first adds into the url the &amp;amp; which then creates an issue (seen on the product_info.php page form tag creation) which then makes for a product not found when the returning url is the product info page verses the shopping cat page.  

    cheers

    Login on Admin

    Posted 20 Apr 2011

    Hi,

    I have now installed the 2.3.1 system several times.  I use the install script and enter a user name and password for the admin.

    In the five systems I have installed, I now have had 3 of them fail and will ot work on the login.  I keep it simple and still no luck.

    I am pretty sure this is not an issue with my server as some work, but not all.

    When I delete the rows from the DB recorder and administrators and re try to enter the user names etc, again it fails.

    cheers