Jump to content



mcmannehan

Member Since 24 Jan 2017
OFFLINE Last Active Yesterday, 05:18
****-

Posts I've Made

In Topic: Product Attributes should be Required

Yesterday, 05:16

@burt

 

Which is the more correct, and preferred option.  

Do it your way for your client if you wish, but it's not something I would do.

 

My code changes follow the "message system" of osC. That's my idea for that.


In Topic: Product Attributes should be Required

Yesterday, 05:12

@burt

I don't see attributes div based structure in your Fork or in your customers live site.

 

Assuming that we are talking about the same thing, please share that code changes...it will save me some time/effort and benefit the rest of the community.

 

My Fork at Github don't have this changes yet. And yes, thank you i saw, that the code (customer website) is missing. Funy stuff... 99.9% the people in front of the computer do wrong by them self. So me too.... Last update from the Server overwrite the local file by accident. The accident was? - me (w00t)

 

So thank you for the information, attributes div based structure will be in the code soon.


In Topic: Product Attributes should be Required

Yesterday, 05:07

@Jack_mcs

@mcmannehan I think the Must Select addon does what you did.

 

The add-on you recommand, is totally different code changes. The idea is the same, yes you right. But, please note, your recommand is for osC 2.2, the old one. May I talking about osC 2.3.4BS and osC 2.3.4BS-Responsive.


In Topic: Product Attributes should be Required

27 March 2017 - 09:41

@burt

this is my customer information at my "P" Version. Running in a production shop included with my WDW EasyTabs.


In Topic: Product Attributes should be Required

27 March 2017 - 08:45

@14steve14

@mcmannehan

 

Why not package it up as a module and release it as an addon. Being a module would make it compatible with the current thinking that is to make no core code changes. I personally do not add anything that has too many core code changes as it will make it so much harder to update in the future.

 

Without core hack it's impossible. Or do you have an idea how to do? Than you welcome. Attributes should be in core for to be requierd.