Jump to content



BrockleyJohn

Member Since 04 Aug 2008
OFFLINE Last Active Yesterday, 19:04
*****

#1754987 PHP 7

Posted by BrockleyJohn on 22 March 2017 - 23:01

Where we are right now is that we have a branch that should be php7-compliant but some bits are more thoroughly tested than others. When the changes were done I and others ran every one to prove the old code produced a deprecated notice and that the changed code didn't. (Plus the change to evaluation order - harder to spot).

 

However the branch we now have has been rebuilt manually and it's possible it doesn't include every single code change that it should so the more eyes we can get on it, the better.

 

We pretty much need to run every bit of code that there is in a php7 environment and check that it behaves as expected. If you have enough time to try to do that as well, including running the install - great, let me know and I can set you up with a folder and database to do it in.

 

If you have less time but still want to help I can give access to a system that's already set up, and it would be great if you can do one of the things that are less easy... if you use a payment method that's not cash, cheque or paypal standard it probably hasn't been tested all the way through placing an order. Most need a merchant account to be able to test them, some even to install.

 

So even if all you have time for is to log into admin on the test system and set up a payment method, then create a test user and place a test order, that would still be a really big help.

 

If you've time for a poke around to see if you can break anything while you're there, that'll be even better!

 

Just pm me and I'll send you an admin user.




#1754591 Equal height CSS for reviews page with bootstrap

Posted by BrockleyJohn on 14 March 2017 - 13:33

Hi,

 

Thanks for that trick but this don't work for me.
 

Is there css add to fix "list-group" from summer 2016 ?

 

Yes, it's in the updated custom.css

 

I have just added some fixes for Safari to this one on my test site: http://bromleybr.co....sgit/custom.css

 

Keep a copy of your old one if you replace it, in case the html on your site is out of step.

 

A safer approach might be to add the following to your user.css for now:

.list-group {display: -webkit-flex; -webkit-flex-wrap: wrap; -webkit-flex-flow: row wrap; display: flex; flex-flow: row wrap;} 
@media only screen and (max-width : 768px) {.list-group {flex-direction: column; }}
.list-group.container:after, .list-group.container:before, .list-group.row:after, .list-group.row:before{content:normal}



#1754580 Equal height CSS for reviews page with bootstrap

Posted by BrockleyJohn on 14 March 2017 - 08:05

Screenshots

Attached Files




#1754579 Equal height CSS for reviews page with bootstrap

Posted by BrockleyJohn on 14 March 2017 - 07:54

Here's a better answer than your best, even if I say so myself! What you need to achieve is to change this line in the html of the reviews page:

<div class="reviews">

to

<div class="reviews list-group">

at line 48 of reviews.php

 

To apply to other pages, you need that class on the container of the things you want to equalise. The osc class list-group already has the flex stuff you're looking for since summer 2016.




#1754564 [Addon] Store Times BS

Posted by BrockleyJohn on 13 March 2017 - 19:02

Download from addons: http://addons.oscommerce.com/info/9556

 

Pull from github: https://github.com/B..._store_times_bs




#1753854 Bootstrap 3 in 2.3.4 - Responsive from the Get Go

Posted by BrockleyJohn on 27 February 2017 - 08:13

PHP7: https://github.com/g...mmerce/pull/533

 

Please help with testing. If anyone would like to test but doesn't have access to a PHP7 environment, I can lend one. We should also be testing it's not broken on php5!

 

I think the biggest bit for proper testing is the payment modules, so I'd like particularly to ask for help from everyone to check the modules that they use all the way through a payment to an order ready for processing. The same applies for any core shipping modules.

 

The changes that were required to clear deprecated notices were tested quite extensively last year, but some things less so:

- paypal app (was introduced since) could do with a good thrashing

- moneybookers payment module can't be installed without an account (and they refused to give me one)

- most payment modules for specific merchant accounts were checked that they install are selectable as a choice of payment. I only tested paypal standard and cod all the way through a payment and back again. If you have access to a merchant account for one of the others (especially one with callback code in /ext), please take a payment all the way through to complete the lifecycle

- usps shipping module & associated email class (I couldn't get them to work & gave up when @kymation gave me the excuse that they've not worked for ages)

 

Plus, I may have made mistakes rebuilding this, though I have checked for deprecated notices in admin modules and security checks. The most likely mistakes are missing a merged edit (probably so that a class definition still has a class-name constructor) and overwriting a change where there was a conflict (probably $HTTP_GET_VARS['...'] overwriting $_GET['...']). I hope to have avoided this by applying each change individually but obviously can't be sure there are none.

 

Thanks




#1753813 Bootstrap 3 in 2.3.4 - Responsive from the Get Go

Posted by BrockleyJohn on 26 February 2017 - 20:23

Ok - the last set of commits introduced a conflict or two; I'll rebuild it and raise a PR




#1753397 2.4 Series

Posted by BrockleyJohn on 17 February 2017 - 08:40

@clustersolutions,
 

Sorry, I'm French and I'm not familiar with abbreviations. What means "LMK" ?
Thank you in advance.

 

@bonbec LMK = Let Me Know (tell me)




#1753273 Bootstrap 3 in 2.3.4 - Responsive from the Get Go

Posted by BrockleyJohn on 13 February 2017 - 18:13

So far as I recall, boxes are no longer created using the class file.  

Can anyone recall seeing any box in the shop side that still uses this:

 

https://github.com/g...mmerce/pull/529

 

I believe I took it out at one point of php7 changes without any ill effects on core code but @raiwa was keen to fix it for the sake of addon compatibility; not really your problem :)




#1751696 PHP7 Dynamic Class/Array Handling Gotcha

Posted by BrockleyJohn on 30 December 2016 - 07:06

Hello my fellow Oscommercers. Hope you had a good Christmas and are looking forward to the New Year. I'm a shop owner and to cut a long story short i've been forced to update PHP on my server, which you've guessed it, breaks my site. So rather than update the old girl yet again i'm putting her out to pasture and taking the plunge starting a new one. I've uploaded 2.3.4 edge onto my server and am in the process of working through all the php 7 warnings and errors. The shop side is error free for now and i'm working my way through the admin side only i have one issue that i'm unable to resolve and was hoping the community could help if possible please.
 
If i update the class constructor in object_info.php in the normal way it fixes the class warning put then throws up a fatal error Call to to undefined method objectInfo::objectInfo() in banner manager. The offending line in banner manager is:

$bInfo->objectInfo($banner);
I'm unsure whether the problem lies in my update of the class constructor or the line in banner manager. For reference this is how i updated object info:
 class objectInfo {

// class constructor
    function __construct($object_array) {
      reset($object_array);
      while (list($key, $value) = each($object_array)) {
        $this->$key = tep_db_prepare_input($value);
      }
    }
  }
Please could someone help me fix this issue so i can move forward. Thanks in advance.

 

 
If you are using Edge, you don't need to work through all the changes individually, follow the link in my signature below to get the full set of changes on in a branch on github, which is currently a little behind the latest Edge but can be merged with no conflicts.
 
Alternatively, you can download it all and use it as a reference for applying the changes yourself but be warned that there are a lot!
 
As of today the place that the link will lead you to download it is here but this will change next time I bring it up to date.
 
And the solution to your specific problem is that you need to keep a method with the class name and call it in the constructor like this:

  class objectInfo {
// class constructor
    function __construct($object_array) {
		  $this->objectInfo($object_array);
    }
    function objectInfo($object_array) {
      reset($object_array);
      while (list($key, $value) = each($object_array)) {
        $this->$key = tep_db_prepare_input($value);
      }
    }
  }



#1748637 Upgrading from 2.3.1 to 2.3.4

Posted by BrockleyJohn on 16 October 2016 - 18:51

I don't remember, on the Version Check sais osCommerce Online Merchant v2.3.4

if so, I guess I m having truble?

 

It looks to me that you've installed a commercial theme on top of standard osc 2.3.4

The theme uses bootstrap under the covers but it's not going to be compatible with the addons developed for 2.3.4BS. Nor will it be easy to get it onto 2.4

 

I think if you go live with that store, you will get stuck there. You will have much less pain if you change direction right now:

- start by choosing a template that you like from one of the developers / partners etc ON HERE and not off on themeforest, envato marketplace or wherever else. There's no list for you to look at but you can post to the Commercial Support Enquiries forum and ask there.

- make sure it's a template based on 2.3.4BS Gold or Edge so it will be easy to go to 2.4

- if you've already got a 2.3.4 version of your data, it's no big deal to get that side of it further. If your live data is still at a much earlier version, get your new template provider or another developer to advise on making it easy to redo the migration when your new store goes live. You can ask for quotes in the Commercial Support Enquiries forum too.

- as far as possible resist the temptation to change code in php files unless they are modules - and in which case make your own module. You now have a great deal of control over the appearance of your store in admin and by adding rules to user.css




#1748450 Upgrading from 2.3.1 to 2.3.4

Posted by BrockleyJohn on 12 October 2016 - 08:32

thank you all for your help on this procedure...it worked well

 

the only problem is that for some strange reason when I add products with "options" on the basket, the remove button is not working for them. For the other oroducts works like charm.

 

I noticed that this is happening on the old shop also wich means it is not a coding problem on file "shopping_cart.php"(I also test with original osc file)

 

Do you have any sujestions please??

 

What happens if you click in the basket on the product that has options? Does it take you properly to the product with its options or not?

 

Some people have hit problems relating to the character '#' in the urls needing encoding.due to security tightening on their servers.




#1747963 Paypal App - Payments Standard - GetTransactionDetails Error

Posted by BrockleyJohn on 29 September 2016 - 10:42

@vinyltom that's not for bootstrap but for all versions up to and including 2.3.4




#1747928 Paypal App - Payments Standard - GetTransactionDetails Error

Posted by BrockleyJohn on 28 September 2016 - 12:51

@vinyltom

 

Do you have SSL on your site. There was some talk a while ago about PayPal changing its security and requiring everyone to have ssl setup on their sites among other things. Do a search for PayPal SHA-256 on this forum and in google which may help. I think it all comes into effect around this time.

 

Actually it's not essential to have an SSL certificate for your own site, though it's a good idea anyway. What you absolutely do need to have are up-to-date protocols on your server so that the calls from your shop to Paypal are able to communicate at the new encryption level. What this means in practice varies a bit from one host to another, so check with your hosting company,

 

Your first step should be to use the Paypal app instead of the PP standard module - it's possible you won't need to do anything else.

 

It's likely that you've only just hit a problem now because Paypal have just withdrawn support for the old protocol. I think the date for the UK is/was sometime this week.




#1747124 Whos Online error correction question

Posted by BrockleyJohn on 30 August 2016 - 07:29

If you search the addon files, you should find a definition for this function; then you'll know. It looks like it's probably intended to keep the who's online view in admin closer to what's really happening in the store (when an existing user logs in you can get multiple sets of footprints).