Jump to content



BrockleyJohn

Member Since 04 Aug 2008
OFFLINE Last Active Today, 21:50
*****

Posts I've Made

In Topic: Bootstrap 3 in 2.3.4 - Responsive from the Get Go

Today, 16:17

Regarding equal height: Maybe I'm a little bit naive, but shouldn't have the space for images and products names have some predefined heights? You might have pictures of different height an also long product names which need a second line, well I couldn't help myself without doing the ultimate evil - changing core files - ad wrapped around a css class for  both of them.

I wanted for grid view: Equal height space for images, orientated to the bottom in that space, and centred within product holder.

Equal height for product names and centred along with the images..

For the images in product_listing.php wrapped them in:

<div class="center-block">

for which I ended up in my user.css with:

.grid-group-item .center-block {
  display: flex;
  height:310px;
  justify-content: center;
  align-items:flex-end;
  
}

where height could be some value maybe  defined per configuration of  SMALL_IMAGE_HEIGHT?

 

For the products name I added a class to h2 there like:

<h2 class="mumpel group inner list-group-item-heading">

which refers in my user.css to:

.grid-group-item .mumpel  {text-align:center;
display:block;height:45px;
}

Well it works at least with edge chrome and FF, I have no apples lying around here. But i confess I don't even know if I'm within the concept of responsive with that, so please kindly forgive me if that was worthless reading.

 

Best regards

Christoph

 

@beerbee I'm sorry I missed your post at the time... was busy battling with safari!

 

There's nothing responsively wrong with your approach - and I understand why you'd want to do it as the core solution makes the boxes fit into equal height rows but it doesn't make the actual box-shaped outlines the same height as each other.

 

I think, perhaps, that you could have avoided the cardinal sin and not made any changes to the core code, though.

 

You can assign height to an anchor tag if you change its display so it's not inline, so you could probably write your center-block rule for the first anchor tag in an equal height class, something like

.equal-height > a:first-child {...}

Incidentally, I think your version only works on grid pages with grid/list choice enabled.

 

I don't think your second rule needs the extra class, you could select using a combination of the existing classes and the tag.

 

Overall, though, it's a good approach for your own store where you know the heights of the images and the font size.


In Topic: Bootstrap 3 in 2.3.4 - Responsive from the Get Go

Today, 15:44

@MrPhil I think it's much better to hand it all off to a framework and live with whatever limitations it has.

 

Now if you're looking for input to a framework you're writing and giving out for free...

 

:D


In Topic: Also Purchased query performance problem

Today, 07:42

If you live in the UK, alligators are from across the pond. :lol:

 

Dan

 

and gaiters stop the rain and snow getting in the top of your boots


In Topic: PHP7 Dynamic Class/Array Handling Gotcha

Today, 07:35


Question

What is the minimum required PHP version for responsive oscommerce, 5.x ?

 

 

Install tests for

PHP_VERSION >= 5.3

In Topic: Bootstrap 3 in 2.3.4 - Responsive from the Get Go

Today, 07:14

Hello,

 

Can anyone confirm this, please?

 

I'm using "Free Shipping For Orders Over" from ot_shiping in order totals modules for amount over 50 € offer free shipping.

 

In checkout_shipping.php I choose the shipping method and go to checkout_payment.php, if I go back the "$order-info['total]" to check if free shipping is ok, get the amount of $order-info['shipping_cost'] and offers free shipping.

 

adding this

    if ($order->info['shipping_cost'] > 0) {
      $order->info['total'] = $order->info['total'] - $order->info['shipping_cost'];
    }

before this

    if ( ($pass == true) && ($order->info['total'] >= MODULE_ORDER_TOTAL_SHIPPING_FREE_SHIPPING_OVER) ) {
      $free_shipping = true;

works correctly for me.

 

But I would like to know if it happens to someone else.

 

Of course I tried a clean installation

 

Thanks in advance :)

 

Hi Gustavo,

 

I can see you could be fixing a free shipping case there, but without checking further in the code I can't see if you're breaking the case where shipping is charged.

 

You don't explain what issue you hit, but I infer from your code that the cost of shipping was included in the order total when calculating whether free shipping should be given. Is that what happened? That issue has a familiar sound to it, but I can't place it.

 

If it's an old issue, you'd think a store-owner would have picked up on it by now. Perhaps it's there in 234BS because it's carry-over code from the official non-responsive version, unchanged for the responsive front end and up till now NOP (not our problem).