Jump to content



Latest News: (loading..)

Issue Information

  • #000061

  • 0 - None Assigned

  • Fixed

  • 2.3

  • 2.3

Issue Confirmations

  • Yes (0)No (0)
Locked 
Photo

Suggest modification into box manufacturers

Posted by GniDhal on 18 October 2010 - 06:37 AM

Hello,
about this part I'm wondering about the line 25 of includes/boxes/manufacturers.php :
	  $manufacturers_list = substr($manufacturers_list, 0, -4);
It seems to crop the last '<br>' of the $manufacturers_list. But I suggest to modify the list using <ul><li> structure like this :
	  $manufacturers_list = '<ul>';
	  while ($manufacturers = tep_db_fetch_array($manufacturers_query)) {
		$manufacturers_name = ((strlen($manufacturers['manufacturers_name']) > MAX_DISPLAY_MANUFACTURER_NAME_LEN) ? substr($manufacturers['manufacturers_name'], 0, MAX_DISPLAY_MANUFACTURER_NAME_LEN) . '..' : $manufacturers['manufacturers_name']);
		if (isset($HTTP_GET_VARS['manufacturers_id']) && ($HTTP_GET_VARS['manufacturers_id'] == $manufacturers['manufacturers_id'])) $manufacturers_name = '<b>' . $manufacturers_name .'</b>';
		$manufacturers_list .= '<li><a href="' . tep_href_link(FILENAME_DEFAULT, 'manufacturers_id=' . $manufacturers['manufacturers_id']) . '">' . $manufacturers_name . '</a></li>';
	  }

//	  $manufacturers_list = substr($manufacturers_list, 0, -4);
	  $manufacturers_list .= '</ul>';
changed lines : 17, 21 25; added line 26

I think is better to use css keys for this list

Updating status to: In Progress

Will take a look into this

Updating status to: Fixed
Issue fixed in: 2.3

Thanks for the report. This has been fixed with the following commit:

https://github.com/osCommerce/oscommerce2/commit/99094ac832a050ba4e92c7885c758c18c597ffd6

Kind regards,