Jump to content



Issue Information

  • #000348

  • 0 - None Assigned

  • New

  • 3.0.2

  • -

Issue Confirmations

  • Yes (0)No (0)
Photo

Inoperant line break with internet explorer 7 & 8

Posted by foxp2 on 26 August 2011 - 03:36 PM

hi harald,

page : index.php?Admin&Configuration&id=1   -> Store Address and Phone :

with internet explorer 9 et firefox 5, display is correct :

[img]http://img27.imageshack.us/img27/2444/goodlinebreakie9ff5.jpg[/img]

but not with internet explorer 7 and 8 :

[img]http://img51.imageshack.us/img51/3274/inoperantlinebreakie78.jpg[/img]


fixed with the following commit : https://github.com/foxp2/oscommerce/commit/5bb6f22d0cb926b33bc41c1041aeee2a2fccea0c

imo, it's better to use .append() than .text() jquery function in this case.

regards.

this syntax is correct too :

newCell.innerHTML = htmlSpecialChars(record.configuration_value.replace(/([^>]?)\r\n/g,"$1<br />\n")); // nl2br() in javascript

with the .append() function, but the 'replace' function must be inside the htmlSpecialChars function :rolleyes:

(refactoring) javascript linebreak for language definition.
file : osCommerce\OM\Core\Site\Admin\Application\Languages\pages\definitions.php

added in this following commit : https://github.com/foxp2/oscommerce/commit/7db210c99aa9d5382c0acc8b87ee6cb70ea57a48