125 replies to this topic

[falconpilot]

VJ,

No I have not installed any other mods but yours which is great by the way. This is exactly what I have been looking for. I will try your advice on deleting stray characters and see if that helps. The attributes problem may not be related to your contribution, I was just wondering if anyone else who has installed this mod has experienced it. Thanks for your help.

falconpilot

[falconpilot]

This is the error I am getting:

Warning: Cannot add header information - headers already sent by (output started at /home/propilot/public_html/includes/application_top.php:490) in /home/propilot/public_html/includes/functions/general.php on line 29

Does anyone have an idea what it is telling me. Why does it think I am adding header information. I also dont understand why it even looking in my public_html directory as that is not even the active directory from which my site is even running. thanks in advance.

falconpilot

[VJ]

Quote

This is the error I am getting:

Warning: Cannot add header information - headers already sent by (output started at /home/propilot/public_html/includes/application_top.php:490) in /home/propilot/public_html/includes/functions/general.php on line 29

Well, did you notice this error occurs in a different file, from the one you got earlier. I guess this means you'd have to repeat what you'd done to the english.php file to this file too.

VJ

[falconpilot]

VJ,

Thanks for your input. It was some spaces at the bottom of two files. Thanks.

falconpilot

[Snowman]

VJ with your permission im going to rework your module and make it multi level and incorporate a few other functions, such as hit tracking, featured site and an Admin site resolver.

[VJ]

Quote

VJ with your permission im going to rework your module and make it multi level and incorporate a few other functions, such as hit tracking, featured site and an Admin site resolver.

Oh yes, you're most welcome to do it . And, I'd be glad to be of any help too.

VJ

[scottymcloo]

Hello

I have made an addition to VJ's great contribution to allow reciprocal links to be verified.

It is very much beta (alpha???) code just now, so I have not submitted as a contribution until:

1/ I get feedback that is is something that is wanted

2/ It works!

You can get it http://www.fitnessireland.ie/checklinks/ for the moment.

Please let me know how you get on, if its any use and if it works!

Thanks VJ - your contribution is excellent!!

Graeme

[VJ]

Hi Graeme,

Nice addition :-).

I gave it a try at my local osc installation... seems to work fine.

Thank you,
VJ

http://www.nebao.com

[ibandyop]

Quote

Hello


You can get it http://www.fitnessireland.ie/checklinks/ for the moment.

Graeme

scottymcloo,
I really like your fitness website site.
Which contribution (if any) are you using for the articles.
e.g.,
Dieting (5)
Fitness (11)

I could really use that.
Thanks in advance,
-ibandyop
PS: The links checker works great. Looking at how I customize the errors.

[picman]

Hi VJ,

I think you have done a great job with this mod, however I have a bit of a problem that I hope you or one of the other viewers can help me with.

When clicking on a link I get an error page with this type of message:

Error 404: /catalog/www.glynne-court-hotel.co.uk is not found at this location

of course the '/catalog/' in-front of the web address is what is causing the error. Any idea how I fix it?

Help as always is very much appreciated.

Oh! and by the way, on your site your category links in a larger font and a different colour. Can you tell me how this was done?

Picman

[VJ]

Hi Picman,

Can you post the code that you use to display links? I *think* you use the osc URL wrapper function tep_href_link to display links.

Ah, and I made the font/color changes at the stylesheet file.

This is the code I use to display links (/catalog/exchange_links.php),

      echo '                <td align="left" class="smallText" style="width: ' . $width . '" valign="top"><br> &raquo; <a href="' . $link_links_data['link_url'] . '" class="exLinkTitle" target="_blank">' . $link_links_data['link_title'] . '</a><br><div align="justify">' . $link_links_data['link_description'] . '</div><a href="' . $link_links_data['link_url'] . '" class="exLinkURL" target="_blank">' . $link_links_data['link_url'] . '</a></td>' . "n";

and here's the stylesheet code I used,

    A.exLinkTitle {

      font-size: 12 px;

      color: #0000CC;

      font-weight: bold;

    }



    A.exLinkURL {

      font-size: 10 px;

      color: #000099;

      font-weight: bold;

    }

HTH,
VJ

[picman]

Hi VJ,

Thanks for the prompt reply.

Here is the code you asked for from /catalog/exchange_links.php, as far as I can see it is exactly the same as yours.

      echo '                <td align="left" class="smallText" style="width: ' . $width . '" valign="top"><br> &raquo; <a href="' . $link_links_data['link_url'] . '" class="exLinkTitle" target="_blank">' . $link_links_data['link_title'] . '</a><br><div align="justify">' . $link_links_data['link_description'] . '</div><a href="' . $link_links_data['link_url'] . '" class="exLinkURL" target="_blank">' . $link_links_data['link_url'] . '</a></td>' . "n";

Picman
ps. I will try the css code today

[picman]

Hi VJ,
Well..

Something strange?

I had already installed the style-sheet code as your original instructions. For some reason the page is not using that information, any ideas?

The following link is in the /catalog/exchange_links.php file.

<link rel="stylesheet" type="text/css" href="stylesheet.css">

Picman

[VJ]

Hi Picman,

I just remembered the cause of that problem you're experiencing. It's a problem with faling to include the "http://" before the url. Actually, this issue has been discussed before here at the forums, http://forums.oscommerce.com/viewtopic.php...p=178683#178683.

Sorry, I somehow couldn't remember that last night :shock:.

I'm pretty sure the css code will work, once you've managed to fix this url issue.

HTH :-),
VJ

[picman]

Hi VJ,

I found the other post and tried pasting the code as written, but Ho Hum.. I now get:

Quote

Parse error:  parse error in /www.1stsouvenirs.com/catalog/includes/modules/link_submit_details.php on line 55

The two pieces of code from the other post are here. I am new to all this perhaps you can see something wrong?

if ($is_read_only == true) { 

     echo $submit_link['link_address']; 

   } elseif ($error == true) { 

     if ($entry_url_error == true) { 

       echo tep_draw_input_field('url') . ' ' . ENTRY_LINKS_ADDRESS_ERROR; 

     } else { 

       echo $url . tep_draw_hidden_field('url'); 

     } 

   } else { 

     echo tep_draw_input_field('url', 'http://' . $submit_link['link_address']) . ' ' . ENTRY_LINKS_ADDRESS_TEXT; 

   }

And:

if ($is_read_only == true) { 

     echo $submit_link['link_reciprocal']; 

   } elseif ($error == true) { 

     if ($entry_reciprocal_error == true) { 

       echo tep_draw_input_field('reciprocal') . ' ' . ENTRY_LINKS_RECIPROCAL_PAGE_ERROR; 

     } else { 

       echo $reciprocal . tep_draw_hidden_field('reciprocal'); 

     } 

   } else { 

     echo tep_draw_input_field('reciprocal', 'http://' . $submit_link['link_reciprocal']) . ' ' . ENTRY_LINKS_RECIPROCAL_PAGE_TEXT; 

   }

When I type 'http://' in-front of the url in admin the link does work, so you're on the right track.

Picman

[Whitelancer]

On the contributions page, I couldn't get Werner's upload working, but I did get the original (plus the small update you posted) to work on MS2 by changing any tep_array_merge() function calls to array_merge() calls. Everything else seemed to be ok, as far as I can tell.

You can find two calls to tep_array_merge ... both in the files in the admin folder. I think it's exchange_links_categories.php and exchange_links_links.php, if I remember right.

I like having the links ability here; some other ideas to add to this might be with the submission process; add into the admin panel some configuration options, such as where you want the links sent to, etc. Just some config options in general would be kinda useful.

It looks good though, so keep up your great work. It's complicated trying to dissect other people's code, like osC, with no comments! Ahh!

[picman]

Hi VJ,

Problem 1 solved..

As described in my last message I did copy and paste your code and the got the parse error message. I tried fiddling with the code, checking and double checking things, but alas no joy. I even tried Whitelancer's idea, that didn't work.
Then, one last try, I put the old code back and added:(exactly where indicated in your original fix)

 'http://' .

And it worked... Hooray

I don't know if it was a problem with spaces or what, I'm just glad it's sorted.

Thanks again for all the help

And now if someone could help with the following.

If you visit http://www.1stsouvenirs.com/catalog/exchange_links.php you will see the link categories on the page.
My question is how can I get the links to display larger and in colour similar to those at http://www.salehut.com/exchange_links.php and reduce the columns to three or four giving more space to the category text making the page more tidy?

Thanks in advance for any suggestions.

Picman

[loxly]

~~Tangent!~~

Are you the owner/operator of 1stsouveniers? If so can you email me at dc@loxly.com ? Thanks!

[VJ]

Quote

On the contributions page, I couldn't get Werner's upload working, but I did get the original (plus the small update you posted) to work on MS2 by changing any tep_array_merge() function calls to array_merge() calls. Everything else seemed to be ok, as far as I can tell.

You can find two calls to tep_array_merge ... both in the files in the admin folder. I think it's exchange_links_categories.php and exchange_links_links.php, if I remember right.

Ah, good! I was thinking about setting up this links program at my new site that runs on MS2. Your tips would come in handy, surely... Thanks!

Quote

I like having the links ability here; some other ideas to add to this might be with the submission process; add into the admin panel some configuration options, such as where you want the links sent to, etc. Just some config options in general would be kinda useful.

It looks good though, so keep up your great work. It's complicated trying to dissect other people's code, like osC, with no comments! Ahh!

Yes, there's still lots more that can be done. I'd been thinking about changing the DB schema to make it multi-lingual, first. Just got to find some time to work on that.

Oh, (constructive) comments/suggestions are always welcome. Just keep them coming :-).

VJ

[VJ]

Quote

And it worked... Hooray

I don't know if it was a problem with spaces or what, I'm just glad it's sorted.

Good! Those strings can sometimes get tricky to handle. I think it was the quotes.

Quote

If you visit http://www.1stsouvenirs.com/catalog/exchange_links.php you will see the link categories on the page.
My question is how can I get the links to display larger and in colour similar to those at http://www.salehut.com/exchange_links.php and reduce the columns to three or four giving more space to the category text making the page more tidy?

This is the code I use to display link categories at my site.

    $width = (int)(100 / MAX_DISPLAY_CATEGORIES_PER_ROW) . '%';

    echo '                <td align="left" class="smallText" style="width: ' . $width . '" valign="top"><br> &raquo; <a href="' . tep_href_link(FILENAME_EXCHANGE_LINKS, 'lPath=' . $link_category_data['link_category_id']) . '" class="subCatLinks">' . $link_category_data['link_category_name'] . '</a>&nbsp;(' . $link_count . ')' . '<br>' . $link_category_data['link_category_description'] . '</td>' . "n";

    if ((($rows / MAX_DISPLAY_CATEGORIES_PER_ROW) == floor($rows / MAX_DISPLAY_CATEGORIES_PER_ROW)) && ($rows != tep_db_num_rows($link_category_query))) {

      echo '              </tr>' . "n";

      echo '              <tr>' . "n";

    }

You'll be able to change the no. of columns by changing MAX_DISPLAY_CATEGORIES_PER_ROW (at the OSC Admin). Its the same definition that controls the product categories description. You can even use a new definition. Like for example,

Add to /catalog/application_top.php,

define('MAX_DISPLAY_LINK_CATEGORIES_PER_ROW', '4');

And, substitute MAX_DISPLAY_CATEGORIES_PER_ROW in /catalog/exchange_links.php with the new definition variable.

Ah, and you can change the display style using stylesheet definitions.

HTH,
VJ