4 replies to this topic

[tcpinhead]

I find it somewhat annoying to have the link to click to enlarge if I don't have a larger picture. With a simple check I was able to skip the enlarge if it didn't exist.

In product_info I changed:

<?php

    $image = $product_info_values['products_image'];

    $bimage = $product_info_values['products_image'];

    if ($product_info_values['products_mimage'] != '') $image = $product_info_values['products_mimage']; 

    if ($product_info_values['products_bimage'] != '') $bimage = $product_info_values['products_bimage']; 

    if ($image != '') {

?>

          <tr>

            <td align="center" class="smallText">

<script language="javascript"><!--

document.write('<?php echo '<a href="javascript:popupWindow('' . tep_href_link(FILENAME_POPUP_IMAGE, 'pID=' . $product_info_values['products_id']) . '')">' . tep_image(DIR_WS_IMAGES . $image, addslashes($product_info_values['products_name']), MEDIUM_IMAGE_WIDTH, MEDIUM_IMAGE_HEIGHT, 'hspace="5" vspace="5"') . '<br>' . TEXT_CLICK_TO_ENLARGE . '</a>'; ?>');

//--></script>

<noscript>

<?php echo '<a href="' . tep_href_link(DIR_WS_IMAGES . $bimage) . '">' . tep_image(DIR_WS_IMAGES . $image, $product_info_values['products_name'], MEDIUM_IMAGE_WIDTH, MEDIUM_IMAGE_HEIGHT, 'hspace="5" vspace="5"') . '<br>' . TEXT_CLICK_TO_ENLARGE . '</a>'; ?>

</noscript>

            </td>

          </tr>

<?php

    }

?>

to

<?php

    $image = $product_info_values['products_image'];

    $bimage = $product_info_values['products_image'];

    if ($product_info_values['products_mimage'] != '') $image = $product_info_values['products_mimage']; 

    if ($product_info_values['products_bimage'] != '') $bimage = $product_info_values['products_bimage']; 

    if ($image != '') {

?>

          <tr>

          <?php if ($bimage = $image) {

          ?>

	<td><?php echo tep_image(DIR_WS_IMAGES . $image, $product_info_values['products_name'], MEDIUM_IMAGE_WIDTH, MEDIUM_IMAGE_HEIGHT, 'hspace="5" vspace="5"') . '<br>'; ?>

<?php

	} else {

	?>

            <td align="center" class="smallText">

<script language="javascript"><!--

document.write('<?php echo '<a href="javascript:popupWindow('' . tep_href_link(FILENAME_POPUP_IMAGE, 'pID=' . $product_info_values['products_id']) . '')">' . tep_image(DIR_WS_IMAGES . $image, addslashes($product_info_values['products_name']), MEDIUM_IMAGE_WIDTH, MEDIUM_IMAGE_HEIGHT, 'hspace="5" vspace="5"') . '<br>' . TEXT_CLICK_TO_ENLARGE . '</a>'; ?>');

//--></script>

<noscript>

<?php echo '<a href="' . tep_href_link(DIR_WS_IMAGES . $bimage) . '">' . tep_image(DIR_WS_IMAGES . $image, $product_info_values['products_name'], MEDIUM_IMAGE_WIDTH, MEDIUM_IMAGE_HEIGHT, 'hspace="5" vspace="5"') . '<br>' . TEXT_CLICK_TO_ENLARGE . '</a>'; ?>

</noscript>

	<?php

	}

	?>

            </td>

          </tr>

<?php

    }

?>

Now I only present the click to enlarge if there is a big image to show. If a medium image exists without the big image then I don't show click to enlarge.

I am rather new at this but It seems to work. If I have done anything terribly wrong, please let me know.

Add to this the better popups code code from Jeremy and you should have some smart and clean popups.

Thanks
Terral

[tcpinhead]

oops it isn't working now. At least it was until I tried to take into account mimage.

have a fix in a second

[tcpinhead]

This is working better:

<?php

    $image = $product_info_values['products_image'];

    $bimage = $product_info_values['products_image'];

    if ($product_info_values['products_mimage'] != '') $image = $product_info_values['products_mimage']; 

    if ($product_info_values['products_bimage'] != '') $bimage = $product_info_values['products_bimage']; 

    if ($image != '') {

?>

          <tr>

          <?php if ($product_info_values['products_bimage'] != '') {

          ?>

            <td align="center" class="smallText">

<script language="javascript"><!--

document.write('<?php echo '<a href="javascript:popupWindow('' . tep_href_link(FILENAME_POPUP_IMAGE, 'pID=' . $product_info_values['products_id']) . '')">' . tep_image(DIR_WS_IMAGES . $image, addslashes($product_info_values['products_name']), MEDIUM_IMAGE_WIDTH, MEDIUM_IMAGE_HEIGHT, 'hspace="5" vspace="5"') . '<br>' . TEXT_CLICK_TO_ENLARGE . '</a>'; ?>');

//--></script>

<noscript>

<?php echo '<a href="' . tep_href_link(DIR_WS_IMAGES . $bimage) . '">' . tep_image(DIR_WS_IMAGES . $image, $product_info_values['products_name'], MEDIUM_IMAGE_WIDTH, MEDIUM_IMAGE_HEIGHT, 'hspace="5" vspace="5"') . '<br>' . TEXT_CLICK_TO_ENLARGE . '</a>'; ?>

</noscript>

<?php

	} else {

	?>

	<td><?php echo tep_image(DIR_WS_IMAGES . $image, $product_info_values['products_name'], MEDIUM_IMAGE_WIDTH, MEDIUM_IMAGE_HEIGHT, 'hspace="5" vspace="5"') . '<br>'; ?>

	<?php

	}

	?>

            </td>

          </tr>

<?php

    }

?>

[Ajeh]

Might make a note that this is only with the image add-ons using those settings.

Good tip, however!

[tcpinhead]

So it works this way:

small image        med image        big image        Show click to enlarge

    no                no                no                no

    yes               no                no                no

    yes               yes               no                no

    yes               yes               yes               yes