Jump to content



Photo
- - - - -

PayPal App for osCommerce Online Merchant


  • Please log in to reply
130 replies to this topic

#121   mattjt83

mattjt83
  • Members
  • 517 posts
  • Real Name:Matt Toste
  • Gender:Male
  • Location:CA, USA

Posted 10 March 2017 - 16:52

@greasemonkey

 

Mine is no longer aligned right. Is there a setting for this? I can't seem to find one.


Matt


#122   greasemonkey

greasemonkey
  • Members
  • 1,053 posts
  • Real Name:Scott
  • Gender:Male

Posted 10 March 2017 - 17:01

@mattjt83 I can't find a setting for it and nothing I try in css will move it right.... It seems to be delivered in an iframe (which is beyond me...how Harald made that work...lol) and I can't tell if it this iframe moving it left or if it is the below script (or something else);

<script src="https://www.paypalobjects.com/api/checkout.js"></script>

We will have to wait until @Harald Ponce de Leon replies I think....

 

There are a couple other things I'm waiting on a well until I move it to my live store.



#123   mattjt83

mattjt83
  • Members
  • 517 posts
  • Real Name:Matt Toste
  • Gender:Male
  • Location:CA, USA

Posted 10 March 2017 - 17:19

@greasemonkey

 

You can float the span that holds the iframe right but then you have to clear the float. I'd rather not try and code around the issue though since it is a pain and will likely get overwritten soon anyway.


Matt


#124   Harald Ponce de Leon

Harald Ponce de Leon

    Healthy Giraffe

  • Core Team
  • 5,346 posts
  • Real Name:Harald Ponce de Leon
  • Gender:Male
  • Location:Solingen, Germany

Posted 11 March 2017 - 14:08

Has the hardcoded admin issue been resolved? I was planning to run my update this morning. Thanks

 

v5.016 has just been pushed out which includes a properly packaged admin/paypal.php file. The online update routine will correctly copy this to your custom admin directory.


:heart: , osCommerce


#125   Harald Ponce de Leon

Harald Ponce de Leon

    Healthy Giraffe

  • Core Team
  • 5,346 posts
  • Real Name:Harald Ponce de Leon
  • Gender:Male
  • Location:Solingen, Germany

Posted 11 March 2017 - 14:17

I'm having a hell of a time trying to get the checkout with PayPal button to align right - anyone else?

 

This affects BS and is due to the Bootstrap "text-right" class being assigned to the block element in the shopping cart page. I'm looking into it.


:heart: , osCommerce


#126   Harald Ponce de Leon

Harald Ponce de Leon

    Healthy Giraffe

  • Core Team
  • 5,346 posts
  • Real Name:Harald Ponce de Leon
  • Gender:Male
  • Location:Solingen, Germany

Posted 11 March 2017 - 14:41

@greasemonkey @mattjt83 could you please confirm if the following fixes the positioning for you:

 

in catalog/includes/modules/payment/paypal_express.php, on line 207 change from:

 

<span id="ppECButton"></span>

 

to:

 

<span id="ppECButton" style="display: inline-block;"></span>

 

(A better approach is to add a custom css file to the PayPal App)


:heart: , osCommerce


#127   mattjt83

mattjt83
  • Members
  • 517 posts
  • Real Name:Matt Toste
  • Gender:Male
  • Location:CA, USA

Posted 11 March 2017 - 16:33

@Harald Ponce de Leon

 

That corrects the alignment issue for me :)


Matt


#128   greasemonkey

greasemonkey
  • Members
  • 1,053 posts
  • Real Name:Scott
  • Gender:Male

Posted 11 March 2017 - 17:22

@Harald Ponce de Leon downloading now.... I'll check it later this aft....



#129   greasemonkey

greasemonkey
  • Members
  • 1,053 posts
  • Real Name:Scott
  • Gender:Male

Posted 11 March 2017 - 17:42

@greasemonkey @mattjt83 could you please confirm if the following fixes the positioning for you:

 

in catalog/includes/modules/payment/paypal_express.php, on line 207 change from:

<span id="ppECButton"></span>

to:

<span id="ppECButton" style="display: inline-block;"></span>

(A better approach is to add a custom css file to the PayPal App)

 

yep that works....



#130   Harald Ponce de Leon

Harald Ponce de Leon

    Healthy Giraffe

  • Core Team
  • 5,346 posts
  • Real Name:Harald Ponce de Leon
  • Gender:Male
  • Location:Solingen, Germany

Posted 12 March 2017 - 02:17

v5.018 has just been pushed out with the support for a custom stylesheet file to be loaded on the shopping cart page. This will only be loaded if the file exists (it does not as part of the PayPal App package) and will never be modified by the App's online update routine.

 

Documentation for the available id's and the location and filename for the custom stylesheet file can be found at:

 

https://library.osco...xpress_checkout


:heart: , osCommerce


#131   mattjt83

mattjt83
  • Members
  • 517 posts
  • Real Name:Matt Toste
  • Gender:Male
  • Location:CA, USA

Posted 12 March 2017 - 03:03

Thank you for the update to fix the alignment @Harald Ponce de Leon


Matt