128 replies to this topic

[burt]

WebSource 5, on 13 June 2013 - 11:17 PM, said:

My thoughts exactly, ~ just reversed

HOw does this grab you, can you optimise?

function osc_split_mini_description($products_precis) {
	$content = strip_tags($products_precis, '<br>');
	if (strlen($content) > 155) {
	  $shorten = strpos($content, ' ', 150);
	  return substr($content, 0, $shorten) . '...';
	}
	else {
	  return $content;
	}
  }

  function osc_get_mini_description($products_id) {
	global $languages_id;

	$product_query = tep_db_query(" select coalesce(products_mini_description, products_seo_description, LEFT(products_description, 300)) as products_precis from " . TABLE_PRODUCTS_DESCRIPTION . " where products_id = '" . (int)$products_id . "' and language_id = '" . (int)$languages_id . "'");
	$product = tep_db_fetch_array($product_query);

	return osc_split_mini_description($product['products_precis']);
  }

[WebSource 5]

burt, on 14 June 2013 - 10:20 AM, said:

HOw does this grab you, can you optimise?

Awesome, I like how coalesce does all the work without the need to create a mile long function.

I set this up on a test site, and got it to work as needed, but had to add NULLIF or it would not retrieve further than the first requested column. I double checked to make sure my columns were NULL as default, as from what I found on coalesce shows it is made to work on columns set to null, not empty. They were, but anyhow, check this out:

  function osc_split_mini_description($products_precis) {
	$content= strip_tags($products_precis);   
	  if (strlen($content) > 156 ) {
		$content = substr($content, 0, strpos($content, ' ', 156));
	  }
	  return $content;
  }
  
  function osc_get_mini_description($products_id) {
	global $languages_id;
	$product_query = tep_db_query(" select coalesce(NULLIF(products_mini_description,'') , NULLIF(products_seo_text,'') , NULLIF(LEFT(products_description, 300),'') ,'". TAG_LINE ."') as products_precis from " . TABLE_PRODUCTS_DESCRIPTION . " where products_id = '" . (int)$products_id . "' and language_id = '" . (int)$languages_id . "'");
	$product = tep_db_fetch_array($product_query);
	$products_precis = $product['products_precis'];
	return osc_split_mini_description($products_precis);
  }

I added TAG_LINE to be the default throw back. If it is set in the stores configurations options then it can be used in the rare case that none of the 3 exist.

I noticed earlier in this thread you had microformats in mind. I have been studying these a while now, and I feel that this exact function should also be used for microformating the description itemscope. It would keep the description consistant anywhere that the product id presented, IE: a product infoBox or the product listing or product info page. The character length is just fine and there would be no chance for one product display presenting different content than the same product being presented elsewhere.

Another good thing, this function could be duplicated, osc_get_meta_description and just switch the first 2 column lookups around for a failsafe meta description output.

[WebSource 5]

Query should have read "products_seo_description" above, I had different field names already existing

[burt]

Yep, I am also working on microformatting some bits, I know you've done this on some areas, so if you can advise (or link me to yours) I'm all ears

If the columns are set to be null (or have content), we shouldn't need the nullif...
Do we really need a default throwback?  I don't want to take all the work away from the shop owner

[WebSource 5]

burt, on 15 June 2013 - 07:23 AM, said:

If the columns are set to be null (or have content), we shouldn't need the nullif...

That was my understanding of it as well, but no matter how I tried without NULLIF it would only load if I had a mini description set, otherwise it just died. My columns are set to null, so my only conclusion was it must b the over all server set up?

No real need for a throw bak, oter than its nice to be able to do it. If the query runs that far and does not find content, theres really no point anyhow.

I can help set up some microformats, I'm currently wrapping some up on a test 2.3 site. They are everywhere, my code had changed a lot, but the general idea is there. I'll update when I get wrappedup, I have some ideas for writing a few new functions now

[burt]

Just a couple of microdata bits to code up in the first round of changes :

http://forums.oscommerce.com/topic/392853-open-discussion-on-seo/page__st__100#entry1673255

Edited by burt, 17 June 2013 - 10:01 PM.

[burt]

Been doing a load of research on meta keywords, including an experiment on a live site.

I've come to the conclusion that meta keywords are unused by most search engines.  

The only one I can find definitely ARE used on is:

Baidu

Do I leave the module in, or rip the module right out?  

--

Instead of completely nuking it, how about have the keywords admin as a "tagging" system for products.  
And make the advanced_search_result page also search these tags to return products that match the search.
So, you could have common mis-spellings of your product, EG:  "creme egg" (and in the tagging system have "cream egg")

Edited by burt, Yesterday, 12:19 PM.

[kymation]

Leave the module in, or you'll get tons of complaints from people who insist they need it. Been there, done that.

I like the idea of making the search engine use it for alternate terms. That would be useful.

Regards
Jim

[MrPhil]

There's no harm in leaving in the <meta> keywords system, at least so long as you aren't doing anything that Search Engines might penalize as black hat SEO (keyword stuffing, keyword hijacking, etc.). Worst case, they ignore it; best case, it might help a little. Let implementers turn it off/not install it by their choice, if they really think it might be harming them.