12 replies to this topic

[optipack]

I am trying to add tax to my products but I have an error message where you insert a new product and a drop down box isn't appearing anywhere

The error message:

. ' ' . tep_draw_pull_down_menu('products_tax_class_id', $tax_class_array, $pInfo->products_tax_class_id, 'onchange="updateGross()"'); ?>


My settings for the tax zones, tax classes and tax rates are as follows:
Locations/Taxes
Tax Zones:
UK >> United Kingdom

Tax Classes:
Taxable Goods

Tax Rates:
Priority - 1, Tax Class - Taxable Goods, Zone - UK, Tax Rate - 20.00%

Could anyone help and tell me what I am doing wrong and how to fix it please?

Thanks

[kenkja]

@optipack

Futher to our conversation earlier today, I deleted a country from my tax zones, it didn't replicate your issue.

So my guess is your problem is nothing to do, countries not being a tax zone

ken

[germ]

It's not an error, it's raw php code displaying because of a syntactical error in the source.

Find the line in the source file and post the code 10 lines on either side.

[optipack]

@germ

<?php
	for ($i=0, $n=sizeof($languages); $i<$n; $i++) {
?>
		  <tr>
			<td class="main"><?php if ($i == 0) echo TEXT_PRODUCTS_NAME; ?></td>
			<td class="main"><?php echo tep_image(DIR_WS_CATALOG_LANGUAGES . $languages[$i]['directory'] . '/images/' . $languages[$i]['image'], $languages[$i]['name']) . '&nbsp;' . tep_draw_input_field('products_name[' . $languages[$i]['id'] . ']', (isset($products_name[$languages[$i]['id']]) ? stripslashes($products_name[$languages[$i]['id']]) : tep_get_products_name($pInfo->products_id, $languages[$i]['id']))); ?></td>
		  </tr>
<?php
	}
?>
		  <tr>
			<td colspan="2"><?php echo tep_draw_separator('pixel_trans.gif', '1', '10'); ?></td>
		  </tr>
		  <tr bgcolor="#ebebff">
	<td class="main"><?php echo TEXT_PRODUCTS_PRICE_COST; ?></td>
	<td class="main"><?php echo tep_draw_separator('pixel_trans.gif', '24', '15') . '&nbsp;' . tep_draw_input_field('products_cost', $pInfo->products_cost, ''); ?></td>
  </tr>
  <tr bgcolor="#ebebff">
	<td class="main"><?php echo TEXT_PRODUCTS_PRICE_NET; ?></td>
	<td class="main"><?php echo tep_draw_separator('pixel_trans.gif', '24', '15') . '&nbsp;' . tep_draw_input_field('products_price', $pInfo->products_price, 'onkeyup="updateGross()"'); ?></td>
  </tr> . '&nbsp;[color=#ff0000]'[b] . tep_draw_pull_down_menu('products_tax_class_id', $tax_class_array, $pInfo->products_tax_class_id, 'onchange="updateGross()"'); ?></td>
		  </tr>
		  <tr bgcolor="#ebebff">
			<td class="main"><?php echo TEXT_PRODUCTS_PRICE_NET; ?></td>
			<td class="main"><?php echo tep_draw_separator('pixel_trans.gif', '24', '15') . '&nbsp;' . tep_draw_input_field('products_price', $pInfo->products_price, 'onkeyup="updateGross()"'); ?></td>
		  </tr>
		  <tr bgcolor="#ebebff">
			<td class="main"><?php echo TEXT_PRODUCTS_PRICE_GROSS; ?></td>
			<td class="main"><?php echo tep_draw_separator('pixel_trans.gif', '24', '15') . '&nbsp;' . tep_draw_input_field('products_price_gross', $pInfo->products_price, 'onkeyup="updateNet()"'); ?></td>
		  </tr>
		  <tr>
			<td colspan="2"><?php echo tep_draw_separator('pixel_trans.gif', '1', '10'); ?></td>
		  </tr>
<script type="text/javascript"><!--
updateGross();
//--></script>
<?php
	for ($i=0, $n=sizeof($languages); $i<$n; $i++) {
?>
		  <tr>
			<td class="main" valign="top"><?php if ($i == 0) echo TEXT_PRODUCTS_DESCRIPTION; ?></td>
			<td><table border="0" cellspacing="0" cellpadding="0">
			  <tr>
				<td class="main" valign="top"><?php echo tep_image(DIR_WS_CATALOG_LANGUAGES . $languages[$i]['directory'] . '/images/' . $languages[$i]['image'], $languages[$i]['name']); ?>&nbsp;</td>
				<td class="main"><?php echo tep_draw_textarea_field('products_description[' . $languages[$i]['id'] . ']', 'soft', '70', '15', (isset($products_description[$languages[$i]['id']]) ? stripslashes($products_description[$languages[$i]['id']]) : tep_get_products_description($pInfo->products_id, $languages[$i]['id']))); ?></td>
			  </tr>
			</table></td>
		  </tr>
<?php
	}
?>

Can someone have a look at what is wrong and let me know how to fix it please?

Thanks

Edited by optipack, 17 July 2012 - 08:53 AM.

[germ]

This code:

</tr> . ' ' . tep_draw_pull_down_menu('products_tax_class_id', $tax_class_array, $pInfo->products_tax_class_id, 'onchange="updateGross()"'); ?> </td>

Should be:

</tr><?php echo ' ' . tep_draw_pull_down_menu('products_tax_class_id', $tax_class_array, $pInfo->products_tax_class_id, 'onchange="updateGross()"'); ?> </td>

[optipack]

@germ

I have just tried changing the code you suggested, however, I am still getting the same section of raw code that was there before.

Do you have any other ideas?

Thanks for your help so far

[germ]

Be sure the changed file is on the server where you think it is.

Hold the <Ctrl> key down and do a page referesh in the browser to force it to reload the new page.

[optipack]

I have refreshed the page and still getting the same :/

The code now looks like:

<?php
	}
?>
		  <tr>
			<td colspan="2"><?php echo tep_draw_separator('pixel_trans.gif', '1', '10'); ?></td>
		  </tr>
		  <tr bgcolor="#ebebff">
	<td class="main"><?php echo TEXT_PRODUCTS_PRICE_COST; ?></td>
	<td class="main"><?php echo tep_draw_separator('pixel_trans.gif', '24', '15') . '&nbsp;' . tep_draw_input_field('products_cost', $pInfo->products_cost, ''); ?></td>
  </tr>
  <tr bgcolor="#ebebff">
	<td class="main"><?php echo TEXT_PRODUCTS_PRICE_NET; ?></td>
	<td class="main"><?php echo tep_draw_separator('pixel_trans.gif', '24', '15') . '&nbsp;' . tep_draw_input_field('products_price', $pInfo->products_price, 'onkeyup="updateGross()"'); ?></td>
  </tr><?php echo ' ' . tep_draw_pull_down_menu('products_tax_class_id', $tax_class_array, $pInfo->products_tax_class_id, 'onchange="updateGross()"'); ?> </td>
		  </tr>
		  <tr bgcolor="#ebebff">
			<td class="main"><?php echo TEXT_PRODUCTS_PRICE_NET; ?></td>
			<td class="main"><?php echo tep_draw_separator('pixel_trans.gif', '24', '15') . '&nbsp;' . tep_draw_input_field('products_price', $pInfo->products_price, 'onkeyup="updateGross()"'); ?></td>
		  </tr>
		  <tr bgcolor="#ebebff">
			<td class="main"><?php echo TEXT_PRODUCTS_PRICE_GROSS; ?></td>
			<td class="main"><?php echo tep_draw_separator('pixel_trans.gif', '24', '15') . '&nbsp;' . tep_draw_input_field('products_price_gross', $pInfo->products_price, 'onkeyup="updateNet()"'); ?></td>
		  </tr>
		  <tr>
			<td colspan="2"><?php echo tep_draw_separator('pixel_trans.gif', '1', '10'); ?></td>
		  </tr>
<script type="text/javascript"><!--
updateGross();
//--></script>
<?php
	for ($i=0, $n=sizeof($languages); $i<$n; $i++) {
?>
		  <tr>
			<td class="main" valign="top"><?php if ($i == 0) echo TEXT_PRODUCTS_DESCRIPTION; ?></td>
			<td><table border="0" cellspacing="0" cellpadding="0">
			  <tr>
				<td class="main" valign="top"><?php echo tep_image(DIR_WS_CATALOG_LANGUAGES . $languages[$i]['directory'] . '/images/' . $languages[$i]['image'], $languages[$i]['name']); ?>&nbsp;</td>
				<td class="main"><?php echo tep_draw_textarea_field('products_description[' . $languages[$i]['id'] . ']', 'soft', '70', '15', (isset($products_description[$languages[$i]['id']]) ? stripslashes($products_description[$languages[$i]['id']]) : tep_get_products_description($pInfo->products_id, $languages[$i]['id']))); ?></td>
			  </tr>
			</table></td>
		  </tr>
<?php
	}
?>

Thanks

[14steve14]

What happens if you copy the code section from a standard install file of oscommerce and replace yours. Does it then work. If not try replacing the whole of the categories file with a standard file and see what happens.

[optipack]

I have sorted it!

Used the code that @germ suggested and now it's working

</tr><?php echo ' ' . tep_draw_pull_down_menu('products_tax_class_id', $tax_class_array, $pInfo->products_tax_class_id, 'onchange="updateGross()"'); ?> </td>

Thanks for your hep! Much appreciated!

[optipack]

OK, so I have got rid of that raw code now. But how do I display the products to show tax?

[14steve14]

Log in to your admin are and in configuration my store set display prices with tax to true

[optipack]

Just figured that out! Thanks