Jump to content



Photo
* * * * * 1 votes

KissIT Image Thumnailer


  • Please log in to reply
291 replies to this topic

#281   Mort-lemur

Mort-lemur
  • Members
  • 2,257 posts
  • Real Name:Heather
  • Gender:Female
  • Location:UK

Posted 11 July 2015 - 21:00

@raiwa Thank you


Now running on a fully modded 2.3.4 Store with the Excellent MTS installed - See my profile for the mods installed ..... So much thanks for all the help given along the way by forum members.


#282   cdetdi

cdetdi
  • Members
  • 11 posts
  • Real Name:Corey

Posted 16 July 2015 - 13:40

Suggestion for future:

 

PHP is horribly inefficient in creating thumbs, so there is a max filesize that can be handled.  While no one should be uploading 2MB photos, the code still should protect against this secenario.  Right now, if creating a thumbnail maxes out the memory limit it just crashes the page. 

 

Suggestion - limit filesize in tep_image, if too large escape to temp image.

 

if(!file_exists($src)){
$src = '/images/pending.gif';
} elseif (filesize($src) > 2000000){
$src = '/images/pending.gif';
}


#283   dculley

dculley
  • Members
  • 445 posts
  • Real Name:Dean Culley
  • Gender:Male
  • Location:North Charleston, SC (USA)

Posted 18 July 2015 - 16:00

@Mort-lemur

 

I went to update 14 to 15.  1 problem with "1a";  When I change the line (or remove the dot after $image) my "Carousel" banner stops working.  "1b" update seems to be fine.

 

Also step 2 instructions says to go to [catalog]/includes/product_info.php.  It should read [catalog]/product_info.php. 



#284   raiwa

raiwa
  • Community Sponsor
  • 884 posts
  • Real Name:Rainer Schmied
  • Gender:Male
  • Location:Sant Iscle de Vallalta, Barcelona, Spain

Posted 19 July 2015 - 14:24

Hello Dean @dculley,

 

Thank you for the report. Just uploaded r16 with your fixes.

 

regards

Rainer



#285   Roaddoctor

Roaddoctor
  • Members
  • 1,184 posts
  • Real Name:David Jennings
  • Gender:Not Telling
  • Location:Texas

Posted 25 July 2015 - 03:10

@raiwa

updating from ancient version, now using latest version R16 for 2.3.4 standard I noticed a bug

 

in admin - configuration - images :  the "reset Thumbs" clears the thumbs directory at: catalog\includes\modules\kiss_image_thumbnailer\thumbs\...

 

R16 had me set up catalog\images\thumbs\...

which does not get cleared upon reset....

 

How would you suggest sorting that?


Edited by Roaddoctor, 25 July 2015 - 03:11.

-Dave

#286   raiwa

raiwa
  • Community Sponsor
  • 884 posts
  • Real Name:Rainer Schmied
  • Gender:Male
  • Location:Sant Iscle de Vallalta, Barcelona, Spain

Posted 26 July 2015 - 11:22

Hello David @Roaddoctor,

 

There is no "reset Thumbs" included in the KissIT configuration setup neither any function included in the scripts to do so. Thumbs must be cleared by hand (delete them).

May be you have these setting there from a different thumbmail add-on.

 

regards

Rainer



#287   Roaddoctor

Roaddoctor
  • Members
  • 1,184 posts
  • Real Name:David Jennings
  • Gender:Not Telling
  • Location:Texas

Posted 26 July 2015 - 14:32

@raiwa

 

ahhh your right - found it here  if anyone would like to add the function - needs tweaking first to match the folder directory you use

 

 


-Dave

#288   raiwa

raiwa
  • Community Sponsor
  • 884 posts
  • Real Name:Rainer Schmied
  • Gender:Male
  • Location:Sant Iscle de Vallalta, Barcelona, Spain

Posted 26 July 2015 - 14:58

Hello David @Roaddoctor,

 

Didn't know this post, I'll have a look and maybe add it.

The Thumb directory is defined in the tep_image function:

                                      'thumbs_dir_path'       => DIR_WS_IMAGES . 'thumbs/',

So the thumb directory in Gelgely's function should be softcoded.

 

Thanks' for the push and

kind regards

Rainer



#289   Roaddoctor

Roaddoctor
  • Members
  • 1,184 posts
  • Real Name:David Jennings
  • Gender:Not Telling
  • Location:Texas

Posted 26 July 2015 - 14:58

working fine in concept

run sql

INSERT INTO `configuration` (`configuration_title`, `configuration_key`, `configuration_value`, `configuration_description`, `configuration_group_id`, `sort_order`, `last_modified`, `date_added`, `use_function`, `set_function`) VALUES
('Reset thumbs', 'RESET_IMAGE_THUMBS', 'false', 'Reset thumbs cache', 4, 9, '2013-02-20 19:36:26', '2013-01-29 17:11:10', 'tep_cfg_reset_thumbs_cache', 'tep_cfg_select_option(array(''reset'', ''false''),');

add to admin/includes/functions/general.php

// Function to reset KISSit image thumbs cache entries
// Gergely Toth
  function tep_cfg_reset_thumbs_cache( $action = 'false' ) {
        if ($action == 'reset' ) {
          $mask = "../images/thumbs/*.jpg";
          array_map( "unlink", glob( $mask ) );
          $mask = "../images/thumbs/*.gif";
          array_map( "unlink", glob( $mask ) );
          $mask = "../images/thumbs/*.png";
          array_map( "unlink", glob( $mask ) );
          tep_db_query( "UPDATE " . TABLE_CONFIGURATION . " SET configuration_value='false' WHERE configuration_key='RESET_IMAGE_THUMBS'" );
        }
  }


Edited by Roaddoctor, 26 July 2015 - 15:01.

-Dave

#290   raiwa

raiwa
  • Community Sponsor
  • 884 posts
  • Real Name:Rainer Schmied
  • Gender:Male
  • Location:Sant Iscle de Vallalta, Barcelona, Spain

Posted 27 July 2015 - 09:48

Hello David @Roaddoctor,

 

Just uploaded r17 which includes the cache reset. (No softcode for the directory possible, needs to be hardcoded like you posted :) )

 

regards

Rainer



#291   gvv

gvv
  • Members
  • 52 posts
  • Real Name:GVV
  • Gender:Male

Posted 28 July 2015 - 20:36

@raiwa

Hello!

I have latest update of KissIT. 

I checked installation, reinsalled the addon step by step few times. 

there is a problem that not all product photos are thumbnailed and product listing page doesnt looks well (some image are smaller, but some - larger..)...

Yoy can see live example here:

http://vaciesuuznemu...urvis-c-23.html

 

 

"<img src="images/koka_durvis_pildini_8a.JPG" alt="Beicētas Iekšdurvis (Osis)" title="Beicētas Iekšdurvis (Osis)" width="210" height="210" class="img-responsive">"

 

and working example:

<img width="210" height="210" src="images/thumbs/210x210_ieksdurvis_finieretas_amazaque.JPG" title="Iekšdurvis (Amazaque)" alt="Iekšdurvis (Amazaque)" class=" img-responsive thumbnail group list-group-image">

 

what should I do and how to fix that?


Edited by gvv, 28 July 2015 - 20:36.


#292   raiwa

raiwa
  • Community Sponsor
  • 884 posts
  • Real Name:Rainer Schmied
  • Gender:Male
  • Location:Sant Iscle de Vallalta, Barcelona, Spain

Posted Yesterday, 07:28

Hello @gvv,

 

Please check if you have image width AND height specified in:

Admin => Configuration => Images => Small Image, Heading Image and Subcategory Image

 

Then the smaller images are smaller than the requested image size, so KissIT puts them in the original size over a white background area which has the requested image size.

if you wish to upsize the images which are smaller than the requested size, switch "KissIT Disable Image Upsize" to "false".

But this can produce "unsharp, pixelised" images, it would be better to use images with at least the requested image size.

Please see also the info in the instructions:

Configuration Settings in Admin

 

regards

Rainer


Edited by raiwa, Yesterday, 07:30.