Jump to content



Latest News: (loading..)

- - - - -

listened to everyones advice


  • Please log in to reply
34 replies to this topic

#1 ONLINE   ianhaney

ianhaney
  • Members
  • 851 posts
  • Real Name:Ian Haney
  • Gender:Male

Posted 30 May 2012 - 03:19 PM

Hi

I have listened to everyones advice and trying to improve my website, to be honest made me feel bit rubbish as felt like I was being told I was rubbish but still am trying to improve the website

I have made my infoboxes have rounded edges

First though, I have a blue long rectangle bar just above the breadcrumb, just wondering if any one knows how to get rid of it

I looked in my header.php file but not sure what could be causing it

Second

How do I make a gap between each infobox - I have solved this problem

Thank you

Ian

Edited by ianhaney, 30 May 2012 - 03:27 PM.


#2   joli1811

joli1811
  • Community Sponsor
  • 777 posts
  • Real Name:john dunlop
  • Gender:Male
  • Location:Ireland

Posted 30 May 2012 - 03:56 PM

View Postianhaney, on 30 May 2012 - 03:19 PM, said:

I have listened to everyones advice and trying to improve my website, to be honest made me feel bit rubbish as felt like I was being told I was rubbish but still am trying to improve the website

I have made my infoboxes have rounded edges

First though, I have a blue long rectangle bar just above the breadcrumb, just wondering if any one knows how to get rid of it

I looked in my header.php file but not sure what could be causing it

Second

How do I make a gap between each infobox - I have solved this problem

Thank you

Ian

Hi

,What is this code for in header.php ???

<div class="ui-widget-header infoBoxHeading">
  <style>
* {
margin: 0;
padding:0;
}

ul {
list-style-type: none;
height: 0px;
width: 1250px;
margin-left: 5px;
}
li {
float: left;
}
</style>
</div>
</div>


John

Edited by joli1811, 30 May 2012 - 03:56 PM.


#3 ONLINE   ianhaney

ianhaney
  • Members
  • 851 posts
  • Real Name:Ian Haney
  • Gender:Male

Posted 30 May 2012 - 03:58 PM

Hi John

I can't remember what it was in there for now

I am going to take that part out and see what it does

Ian

#4 ONLINE   ianhaney

ianhaney
  • Members
  • 851 posts
  • Real Name:Ian Haney
  • Gender:Male

Posted 30 May 2012 - 04:06 PM

I took out that part of coding and it caused the navigation menu with Home and New Products etc to be messed up

But it is the part that is making that blue bar appear

#5   joli1811

joli1811
  • Community Sponsor
  • 777 posts
  • Real Name:john dunlop
  • Gender:Male
  • Location:Ireland

Posted 30 May 2012 - 04:25 PM

View Postianhaney, on 30 May 2012 - 04:06 PM, said:

I took out that part of coding and it caused the navigation menu with Home and New Products etc to be messed up

But it is the part that is making that blue bar appear

Hi,
No rubbish now site looks good maybe change the width to 960 in case it messes something up later

which one was it??
John

#6 ONLINE   ianhaney

ianhaney
  • Members
  • 851 posts
  • Real Name:Ian Haney
  • Gender:Male

Posted 30 May 2012 - 04:28 PM

what change the site width to 960 you mean

I think it is isn't it?

One thing I did notice though, you know if you hover over the nav menu it goes blue, in IE9 it does not do that, any ideas?

Thank you for the help John

#7   joli1811

joli1811
  • Community Sponsor
  • 777 posts
  • Real Name:john dunlop
  • Gender:Male
  • Location:Ireland

Posted 30 May 2012 - 04:30 PM

Bad news in IE it is now all messed up take a look

Edited by joli1811, 30 May 2012 - 04:31 PM.


#8 ONLINE   ianhaney

ianhaney
  • Members
  • 851 posts
  • Real Name:Ian Haney
  • Gender:Male

Posted 30 May 2012 - 04:34 PM

I noticed a couple of things

The first is the nav menu not having the blue when hovered over

The second is the categories menu on the left, its in bold

Ahh the biggest one though just seen is the product info pages are all messed up layout wise

Any ideas?

And the buttons and boxes are square and not rounded like in chrome and firefox

Edited by ianhaney, 30 May 2012 - 04:35 PM.


#9   joli1811

joli1811
  • Community Sponsor
  • 777 posts
  • Real Name:john dunlop
  • Gender:Male
  • Location:Ireland

Posted 30 May 2012 - 05:11 PM

Hi,

Have you got all this css in your header and not in stylesheet.css???

Internet explorer is not recognising the css at all

John

#10 ONLINE   ianhaney

ianhaney
  • Members
  • 851 posts
  • Real Name:Ian Haney
  • Gender:Male

Posted 30 May 2012 - 05:13 PM

yeah the css is in the header and not the stylesheet

I am guessing I should move it to the stylesheet.css

#11   joli1811

joli1811
  • Community Sponsor
  • 777 posts
  • Real Name:john dunlop
  • Gender:Male
  • Location:Ireland

Posted 30 May 2012 - 05:33 PM

well it is a bit hard to see what is going on with all that stuff in the header.
Internet explorer  is reacting like a div was missing or maybe one to many but as i said hard to see because of the R :-  in header so I would try to get the styles moved to stylesheet including the moz-border-radius stuff as well if possible it will be easier to see what is going on can't be much just a missing div or something.

John

#12 ONLINE   ianhaney

ianhaney
  • Members
  • 851 posts
  • Real Name:Ian Haney
  • Gender:Male

Posted 30 May 2012 - 05:34 PM

Ok one sec

I will move it all to the sylesheet.css

One sec

#13 ONLINE   ianhaney

ianhaney
  • Members
  • 851 posts
  • Real Name:Ian Haney
  • Gender:Male

Posted 30 May 2012 - 05:37 PM

I have moved it all the stylesheet.css now

I thought it would be a missing div or one too many but cant see it

Shall I paste my header.php coding in here, will that help

#14 ONLINE   ianhaney

ianhaney
  • Members
  • 851 posts
  • Real Name:Ian Haney
  • Gender:Male

Posted 30 May 2012 - 05:45 PM

The coding in my header.php is below

<?php
/*
  $Id$
  osCommerce, Open Source E-Commerce Solutions
  http://www.oscommerce.com
  Copyright (c) 2010 osCommerce
  Released under the GNU General Public License
*/
  if ($messageStack->size('header') > 0) {
	echo '<div class="grid_24">' . $messageStack->output('header') . '</div>';
  }
?>
<div id="header" class="grid_24">
  <div id="roundedone">All Prices Include VAT</div><div id="image"><img src="images/logonine.png" alt="Irh Media" title="Irh Media" /></div><div id="roundedtwo">Call us today 01268 420854 or click on the green live chat button below on the right hand side</div>
  <br />
   <?php echo tep_draw_form('search', tep_href_link(FILENAME_ADVANCED_SEARCH_RESULT, '', 'NONSSL', false), 'get') . tep_draw_hidden_field('search_in_description','1') . tep_draw_input_field('keywords', '', 'size="10" maxlength="30" style="width: ' . (BOX_WIDTH+150) . 'px"') . ' ' . tep_hide_session_id() .'<input type="submit" name="Submit" value="Search our Website"> ' . '</form>'; ?>
  <div id="headerShortcuts">
<?php
  echo tep_draw_button(HEADER_TITLE_CART_CONTENTS . ($cart->count_contents() > 0 ? ' (' . $cart->count_contents() . ')' : ''), 'cart', tep_href_link(FILENAME_SHOPPING_CART)) .
	   tep_draw_button(HEADER_TITLE_CHECKOUT, 'triangle-1-e', tep_href_link(FILENAME_CHECKOUT_SHIPPING, '', 'SSL')) .
	   tep_draw_button(HEADER_TITLE_MY_ACCOUNT, 'person', tep_href_link(FILENAME_ACCOUNT, '', 'SSL'));
  if (tep_session_is_registered('customer_id')) {
	echo tep_draw_button(HEADER_TITLE_LOGOFF, null, tep_href_link(FILENAME_LOGOFF, '', 'SSL'));
  }
?>
  </div>
<table width="75%" border="0" cellpadding="10">
<td align="left">
</td>
<td align="center">
</td>
</table>
  <table border="0" width="100%" cellspacing="0" cellpadding="0">
  <br>
<tr class="header">
<td valign="middle" rowspan="2"><?php //echo '<a href="' . tep_href_link(FILENAME_DEFAULT) . '">' . tep_image(DIR_WS_IMAGES . 'oscommerce.gif', 'osCommerce') . '</a>'; ?></td>
<td align="right" valign="middle" bgcolor="#99D9EA">
</td>
</tr>
</table>
<script type="text/javascript">
  $("#headerShortcuts").buttonset();
</script>
</div>
<div class="spotlightmenu grid_24">
<ul>
<li><a href="http://www.irhmedia.co.uk"><span>Home</span></a></li>
<li><a href="http://www.irhmedia.co.uk/products_new.php"><span>New Products</span></a></li>
<li><a href="http://www.irhmedia.co.uk/faq.php"><span>FAQ's</span></a></li>
<li><a href="http://www.irhmedia.co.uk/shipping.php"><span>Shipping</span></a></li>
<li><a href="http://www.irhmedia.co.uk/privacy.php"><span>Privacy</span></a></li>
<li><a href="http://www.irhmedia.co.uk/conditions.php"><span>Terms and Conditions</span></a></li>
<li><a href="http://www.irhmedia.co.uk/contact_us.php"><span>Contact Us</span></a></li>
<li><a href="http://www.irhmedia.co.uk/testimonials.php"><span>Testimonials</span></a></li>
<li><a href="http://www.irhmedia.co.uk/login.php"><span>Login/Register</span></a></li>
<li><a href="http://www.irhmedia.co.uk/gift_vouchers.php"><span>Gift Vouchers</span></a></li>
</ul>
</div>
  <div class="grid_24 ui-widget infoBoxContainer">
  <div class="ui-widget-header ui-corner-top ui-corner-bottom infoBoxHeading">
  <?php echo '&nbsp;&nbsp;' . $breadcrumb->trail(' &raquo; '); ?></div>
</div>
<?php
  if (isset($HTTP_GET_VARS['error_message']) && tep_not_null($HTTP_GET_VARS['error_message'])) {
?>
<table border="0" width="100%" cellspacing="0" cellpadding="2">
  <tr class="headerError">
	<td class="headerError"><?php echo htmlspecialchars(stripslashes(urldecode($HTTP_GET_VARS['error_message']))); ?></td>
  </tr>
</table>
<?php
  }
  if (isset($HTTP_GET_VARS['info_message']) && tep_not_null($HTTP_GET_VARS['info_message'])) {
?>
<table border="0" width="100%" cellspacing="0" cellpadding="2">
  <tr class="headerInfo">
	<td class="headerInfo"><?php echo htmlspecialchars(stripslashes(urldecode($HTTP_GET_VARS['info_message']))); ?></td>
  </tr>
</table>
<table border="0" width="100%" cellspacing="0" cellpadding="0">
<tr class="headerNavigation" valign="middle" align="left">
<?php
$info_box_contents = array();
$info_box_contents[] = array('form' => tep_draw_form('advanced_search', tep_href_link(FILENAME_ADVANCED_SEARCH_RESULT, '', 'NONSSL', false), 'get'),
'align' => 'center',
'text' => BOX_SEARCH_TEXT . tep_draw_hidden_field('search_in_description','1') . tep_draw_hidden_field('inc_subcat', '1', true) . tep_draw_input_field('keywords','','size="10" maxlength="30" class="searchForm" style="width: ' . (BOX_WIDTH-10) . 'px"') .' '. tep_draw_pull_down_menu('categories_id', tep_get_categories(array(array('id' => '', 'text' => TEXT_ALL_CATEGORIES)))) . tep_hide_session_id() .' '. tep_image_submit('go.jpg', IMAGE_BUTTON_SEARCH));
new infoBox($info_box_contents);
?>
</td>
</tr>
</table>
// START  advanced search header  script insertion
//
//
?>
<?php
if ( (!strstr($_SERVER['PHP_SELF'],'checkout.php')) and (!strstr($_SERVER['PHP_SELF'],'create_account.php')) and (!strstr($_SERVER['PHP_SELF'],'shopping_cart.php')) and (!strstr($_SERVER['PHP_SELF'],'advanced_search.php')) and !tep_session_is_registered('customer_id') )  {
?>
<table align="center" border="0" width="100%" cellspacing="0" cellpadding="1">
  <tr>
	<td align="center" class="headerNavigation">
<table border="0" width="100%" cellspacing="0" cellpadding="0">
<tr>
<td class="infoBoxContents" valign="middle" colspan="0">
  <?php echo tep_draw_form('advanced_search', tep_href_link(FILENAME_ADVANCED_SEARCH_RESULT, '', 'NONSSL', false), 'get"') ?>
<table border="0" width="50%" cellspacing="0" cellpadding="1" align="center">
<tr>
<td class="infoBoxContents" valign="middle" colspan="3">&nbsp;</td>
<td class="infoBoxContents" valign="middle" colspan="3"><?php echo tep_draw_hidden_field('search_in_description','1') . tep_draw_input_field('keywords', '', 'size="10" maxlength="30" style="width: ' . (BOX_WIDTH+100) . 'px"')  ?></td>
<td class="infoBoxContents" valign="top" colspan="3">&nbsp;</td>
<td class="infoBoxContents" valign="middle" colspan="3"><?php echo BOX_ADVSEARCH_CAT ?></td>
<td class="infoBoxContents" valign="middle" colspan="3"><?php echo tep_draw_pull_down_menu('categories_id', tep_get_categories(array(array('id' => '', 'text' => BOX_ADVSEARCH_ALLCAT)))) ?></td>
<td class="infoBoxContents" valign="top" colspan="3">&nbsp;</td>
<td class="infoBoxContents" valign="middle" colspan="3"><center><?php echo tep_image_submit('button_search.gif', BOX_HEADING_ADVSEARCH); ?></center></td>
</tr>
<?php } ?>
<?php
//
// END advanced search header script insertion
  }
?>


#15 ONLINE   ianhaney

ianhaney
  • Members
  • 851 posts
  • Real Name:Ian Haney
  • Gender:Male

Posted 30 May 2012 - 05:47 PM

Just noticed, in Firefox, the nav menu has messed up now, its going down in rows and not in one line

#16   joli1811

joli1811
  • Community Sponsor
  • 777 posts
  • Real Name:john dunlop
  • Gender:Male
  • Location:Ireland

Posted 30 May 2012 - 05:55 PM

looks ok to me in firefox but ie9 totally messed up going down in rows but not in firefox anyway i done a quick test install in a

http://www.demo3.osc-design.com/

so the code is fine works in both browsers will have a look at your header  and see if i can spot anything

John

#17 ONLINE   ianhaney

ianhaney
  • Members
  • 851 posts
  • Real Name:Ian Haney
  • Gender:Male

Posted 30 May 2012 - 06:04 PM

I don't get that in your firefox works ok and mine don't

Below is the link to my firefox screen to see what mine looks like

www.irhmedia.co.uk/ffproblem.png

#18   joli1811

joli1811
  • Community Sponsor
  • 777 posts
  • Real Name:john dunlop
  • Gender:Male
  • Location:Ireland

Posted 30 May 2012 - 06:13 PM

probably the version Ijust installed new windows (computer crash) so latest browser etc.

think I found a div to many and tables at the bottom of the file that have not been closed, think actually one table is redundant.
John

Attached Files


Edited by joli1811, 30 May 2012 - 06:14 PM.


#19 ONLINE   ianhaney

ianhaney
  • Members
  • 851 posts
  • Real Name:Ian Haney
  • Gender:Male

Posted 30 May 2012 - 06:21 PM

I couldnt find the one too many divs

I sorted the tables I think

The coding is below

<?php
/*
  $Id$
  osCommerce, Open Source E-Commerce Solutions
  http://www.oscommerce.com
  Copyright (c) 2010 osCommerce
  Released under the GNU General Public License
*/
  if ($messageStack->size('header') > 0) {
	echo '<div class="grid_24">' . $messageStack->output('header') . '</div>';
  }
?>
<div id="header" class="grid_24">
  <div id="roundedone">All Prices Include VAT</div><div id="image"><img src="images/logonine.png" alt="Irh Media" title="Irh Media" /></div><div id="roundedtwo">Call us today 01268 420854 or click on the green live chat button below on the right hand side</div>
  <br />
   <?php echo tep_draw_form('search', tep_href_link(FILENAME_ADVANCED_SEARCH_RESULT, '', 'NONSSL', false), 'get') . tep_draw_hidden_field('search_in_description','1') . tep_draw_input_field('keywords', '', 'size="10" maxlength="30" style="width: ' . (BOX_WIDTH+150) . 'px"') . ' ' . tep_hide_session_id() .'<input type="submit" name="Submit" value="Search our Website"> ' . '</form>'; ?>
  <div id="headerShortcuts">
<?php
  echo tep_draw_button(HEADER_TITLE_CART_CONTENTS . ($cart->count_contents() > 0 ? ' (' . $cart->count_contents() . ')' : ''), 'cart', tep_href_link(FILENAME_SHOPPING_CART)) .
	   tep_draw_button(HEADER_TITLE_CHECKOUT, 'triangle-1-e', tep_href_link(FILENAME_CHECKOUT_SHIPPING, '', 'SSL')) .
	   tep_draw_button(HEADER_TITLE_MY_ACCOUNT, 'person', tep_href_link(FILENAME_ACCOUNT, '', 'SSL'));
  if (tep_session_is_registered('customer_id')) {
	echo tep_draw_button(HEADER_TITLE_LOGOFF, null, tep_href_link(FILENAME_LOGOFF, '', 'SSL'));
  }
?>
  </div>
<table width="75%" border="0" cellpadding="10">
<td align="left">
</td>
<td align="center">
</td>
</table>
  <table border="0" width="100%" cellspacing="0" cellpadding="0">
  <br>
<tr class="header">
<td valign="middle" rowspan="2"><?php //echo '<a href="' . tep_href_link(FILENAME_DEFAULT) . '">' . tep_image(DIR_WS_IMAGES . 'oscommerce.gif', 'osCommerce') . '</a>'; ?></td>
<td align="right" valign="middle" bgcolor="#99D9EA">
</td>
</tr>
</table>
<script type="text/javascript">
  $("#headerShortcuts").buttonset();
</script>
</div>
<div class="spotlightmenu grid_24">
<ul>
<li><a href="http://www.irhmedia.co.uk"><span>Home</span></a></li>
<li><a href="http://www.irhmedia.co.uk/products_new.php"><span>New Products</span></a></li>
<li><a href="http://www.irhmedia.co.uk/faq.php"><span>FAQ's</span></a></li>
<li><a href="http://www.irhmedia.co.uk/shipping.php"><span>Shipping</span></a></li>
<li><a href="http://www.irhmedia.co.uk/privacy.php"><span>Privacy</span></a></li>
<li><a href="http://www.irhmedia.co.uk/conditions.php"><span>Terms and Conditions</span></a></li>
<li><a href="http://www.irhmedia.co.uk/contact_us.php"><span>Contact Us</span></a></li>
<li><a href="http://www.irhmedia.co.uk/testimonials.php"><span>Testimonials</span></a></li>
<li><a href="http://www.irhmedia.co.uk/login.php"><span>Login/Register</span></a></li>
<li><a href="http://www.irhmedia.co.uk/gift_vouchers.php"><span>Gift Vouchers</span></a></li>
</ul>
</div>
  <div class="grid_24 ui-widget infoBoxContainer">
  <div class="ui-widget-header ui-corner-top ui-corner-bottom infoBoxHeading">
  <?php echo '&nbsp;&nbsp;' . $breadcrumb->trail(' &raquo; '); ?></div>
</div>
<?php
  if (isset($HTTP_GET_VARS['error_message']) && tep_not_null($HTTP_GET_VARS['error_message'])) {
?>
<table border="0" width="100%" cellspacing="0" cellpadding="2">
  <tr class="headerError">
	<td class="headerError"><?php echo htmlspecialchars(stripslashes(urldecode($HTTP_GET_VARS['error_message']))); ?></td>
  </tr>
</table>
<?php
  }
  if (isset($HTTP_GET_VARS['info_message']) && tep_not_null($HTTP_GET_VARS['info_message'])) {
?>
<table border="0" width="100%" cellspacing="0" cellpadding="2">
  <tr class="headerInfo">
	<td class="headerInfo"><?php echo htmlspecialchars(stripslashes(urldecode($HTTP_GET_VARS['info_message']))); ?></td>
  </tr>
</table>
<table border="0" width="100%" cellspacing="0" cellpadding="0">
<tr class="headerNavigation" valign="middle" align="left">
<?php
$info_box_contents = array();
$info_box_contents[] = array('form' => tep_draw_form('advanced_search', tep_href_link(FILENAME_ADVANCED_SEARCH_RESULT, '', 'NONSSL', false), 'get'),
'align' => 'center',
'text' => BOX_SEARCH_TEXT . tep_draw_hidden_field('search_in_description','1') . tep_draw_hidden_field('inc_subcat', '1', true) . tep_draw_input_field('keywords','','size="10" maxlength="30" class="searchForm" style="width: ' . (BOX_WIDTH-10) . 'px"') .' '. tep_draw_pull_down_menu('categories_id', tep_get_categories(array(array('id' => '', 'text' => TEXT_ALL_CATEGORIES)))) . tep_hide_session_id() .' '. tep_image_submit('go.jpg', IMAGE_BUTTON_SEARCH));
new infoBox($info_box_contents);
?>
</td>
</tr>
</table>
<?php
if ( (!strstr($_SERVER['PHP_SELF'],'checkout.php')) and (!strstr($_SERVER['PHP_SELF'],'create_account.php')) and (!strstr($_SERVER['PHP_SELF'],'shopping_cart.php')) and (!strstr($_SERVER['PHP_SELF'],'advanced_search.php')) and !tep_session_is_registered('customer_id') )  {
?>
<table align="center" border="0" width="100%" cellspacing="0" cellpadding="1">
  <tr>
	<td align="center" class="headerNavigation">
	</td>
	</tr>
	</table>
<table border="0" width="100%" cellspacing="0" cellpadding="0">
<tr>
<td class="infoBoxContents" valign="middle" colspan="0">
  <?php echo tep_draw_form('advanced_search', tep_href_link(FILENAME_ADVANCED_SEARCH_RESULT, '', 'NONSSL', false), 'get"') ?>
  </td>
  </tr>
  </table>
<table border="0" width="50%" cellspacing="0" cellpadding="1" align="center">
<tr>
<td class="infoBoxContents" valign="middle" colspan="3">&nbsp;</td>
<td class="infoBoxContents" valign="middle" colspan="3"><?php echo tep_draw_hidden_field('search_in_description','1') . tep_draw_input_field('keywords', '', 'size="10" maxlength="30" style="width: ' . (BOX_WIDTH+100) . 'px"')  ?></td>
<td class="infoBoxContents" valign="top" colspan="3">&nbsp;</td>
<td class="infoBoxContents" valign="middle" colspan="3"><?php echo BOX_ADVSEARCH_CAT ?></td>
<td class="infoBoxContents" valign="middle" colspan="3"><?php echo tep_draw_pull_down_menu('categories_id', tep_get_categories(array(array('id' => '', 'text' => BOX_ADVSEARCH_ALLCAT)))) ?></td>
<td class="infoBoxContents" valign="top" colspan="3">&nbsp;</td>
<td class="infoBoxContents" valign="middle" colspan="3"><center><?php echo tep_image_submit('button_search.gif', BOX_HEADING_ADVSEARCH); ?></center></td>
</tr>
</table>
<?php } ?>
<?php
//
// END advanced search header script insertion
  }
?>


#20   joli1811

joli1811
  • Community Sponsor
  • 777 posts
  • Real Name:john dunlop
  • Gender:Male
  • Location:Ireland

Posted 30 May 2012 - 06:38 PM

hi
take a look again at the test site i done it is nearly looking ok except a bit of styling but is working in explorer and firefox so

what if the problem is somewhere else?? (maybe template top.php)

do not understand why it should work nearly except styling by me and by you it messes the tables up??

John

Ps will remove the site logos etc  later later this evening

I counted 2 x </table>
</table>   but maybe I was wrong your right about the divs

Edited by joli1811, 30 May 2012 - 06:42 PM.