Jump to content


Corporate Sponsors


Latest News: (loading..)

coding taps space linefeed


11 replies to this topic

#1 emikeu

  • Community Member
  • 14 posts
  • Real Name:Emile

Posted 27 December 2011, 11:58

Hello,

I was looking through all files from osComerce package 2.3.1.-27 (from Github)
Noticed some files were coded in an other standard than UNIX/UTF-8.
Some files make use of tabs, Some have empty space after the end of lines and some files do not have a last linefeed.
I do not know if it's a big thing, but at least maybe interesting for coding consistancy.
Only three files I could not convert to UTF-8 (x). LF(-) has an extra linefeed at the end of the file.


osCommerce-v2.3.1-27 CHANGELOG   Space
osCommerce-v2.3.1-27 LICENSE DOS\Windows/UTF-8  
osCommerce-v2.3.1-27 STANDARD   Space
osCommerce-v2.3.1-27\catalog account_history_info.php   Space
osCommerce-v2.3.1-27\catalog account_password.php   Space
osCommerce-v2.3.1-27\catalog checkout_confirmation.php   Space
osCommerce-v2.3.1-27\catalog checkout_process.php   Space
osCommerce-v2.3.1-27\catalog checkout_shipping.php   Space
osCommerce-v2.3.1-27\catalog create_account.php   Space
osCommerce-v2.3.1-27\catalog download.php   Space
osCommerce-v2.3.1-27\catalog stylesheet.css  Tabs Space
osCommerce-v2.3.1-27\catalog\admin currencies.php UNIX/ANSI  
osCommerce-v2.3.1-27\catalog\admin geo_zones.php   Space
osCommerce-v2.3.1-27\catalog\admin products_attributes.php  Tabs Space
osCommerce-v2.3.1-27\catalog\admin\ext\modules\payment\sofortueberweisung install.php  Tabs
osCommerce-v2.3.1-27\catalog\admin\images .htaccess	LF
osCommerce-v2.3.1-27\catalog\admin\includes application_bottom.php	LF
osCommerce-v2.3.1-27\catalog\admin\includes configure.php	LF
osCommerce-v2.3.1-27\catalog\admin\includes header.php	LF
osCommerce-v2.3.1-27\catalog\admin\includes\classes currencies.php  Tabs
osCommerce-v2.3.1-27\catalog\admin\includes\classes mime.php   Space
osCommerce-v2.3.1-27\catalog\admin\includes\classes passwordhash.php  Tabs
osCommerce-v2.3.1-27\catalog\admin\includes\classes payment_module_info.php	LF
osCommerce-v2.3.1-27\catalog\admin\includes\classes phplot.php  Tabs Space
osCommerce-v2.3.1-27\catalog\admin\includes\classes rss.php   Space LF
osCommerce-v2.3.1-27\catalog\admin\includes\classes shopping_cart.php   Space
osCommerce-v2.3.1-27\catalog\admin\includes\functions database.php   Space
osCommerce-v2.3.1-27\catalog\admin\includes\functions general.php  Tabs Space LF
osCommerce-v2.3.1-27\catalog\admin\includes\functions html_graphs.php   Space
osCommerce-v2.3.1-27\catalog\admin\includes\functions languages.php	LF
osCommerce-v2.3.1-27\catalog\admin\includes\functions validations.php	LF
osCommerce-v2.3.1-27\catalog\admin\includes\javascript calendar.css DOS\Windows/UTF-8 Tabs  LF
osCommerce-v2.3.1-27\catalog\admin\includes\javascript calendarcode.js UNIX/ANSI  Space
osCommerce-v2.3.1-27\catalog\admin\includes\javascript\spiffyCal spiffyCal_v2_1.css  Tabs Space
osCommerce-v2.3.1-27\catalog\admin\includes\javascript\spiffyCal spiffyCal_v2_1.js UNIX/ANSI Tabs Space LF (-)
osCommerce-v2.3.1-27\catalog\admin\includes\languages\english action_recorder.php	LF
osCommerce-v2.3.1-27\catalog\admin\includes\languages\english banner_statistics.php	LF
osCommerce-v2.3.1-27\catalog\admin\includes\languages\english configuration.php	LF
osCommerce-v2.3.1-27\catalog\admin\includes\languages\english newsletters.php	LF
osCommerce-v2.3.1-27\catalog\admin\includes\languages\english orders_status.php	LF
osCommerce-v2.3.1-27\catalog\admin\includes\languages\english products_attributes.php	LF
osCommerce-v2.3.1-27\catalog\admin\includes\languages\english products_expected.php	LF
osCommerce-v2.3.1-27\catalog\admin\includes\languages\english reviews.php	LF
osCommerce-v2.3.1-27\catalog\admin\includes\languages\english server_info.php	LF
osCommerce-v2.3.1-27\catalog\admin\includes\languages\english stats_customers.php	LF
osCommerce-v2.3.1-27\catalog\admin\includes\languages\english stats_products_purchased.php	LF
osCommerce-v2.3.1-27\catalog\admin\includes\languages\english stats_products_viewed.php	LF
osCommerce-v2.3.1-27\catalog\admin\includes\languages\english store_logo.php	LF
osCommerce-v2.3.1-27\catalog\admin\includes\languages\english tax_classes.php	LF
osCommerce-v2.3.1-27\catalog\admin\includes\languages\english version_check.php	LF
osCommerce-v2.3.1-27\catalog\admin\includes\languages\english whos_online.php	LF
osCommerce-v2.3.1-27\catalog\admin\includes\languages\english zones.php	LF
osCommerce-v2.3.1-27\catalog\admin\includes\languages\english\modules\newsletters newsletter.php	LF
osCommerce-v2.3.1-27\catalog\admin\includes\languages\english\modules\newsletters product_notification.php	LF
osCommerce-v2.3.1-27\catalog\admin\includes\modules\dashboard d_reviews.php	LF
osCommerce-v2.3.1-27\catalog\ext\960gs 960.css	LF
osCommerce-v2.3.1-27\catalog\ext\960gs 960_24_col.css	LF
osCommerce-v2.3.1-27\catalog\ext\960gs rtl_960.css	LF
osCommerce-v2.3.1-27\catalog\ext\960gs rtl_960_24_col.css	LF
osCommerce-v2.3.1-27\catalog\ext\flot API.txt   Space
osCommerce-v2.3.1-27\catalog\ext\flot excanvas.js   Space
osCommerce-v2.3.1-27\catalog\ext\flot excanvas.min.js	LF
osCommerce-v2.3.1-27\catalog\ext\flot jquery.colorhelpers.js   Space
osCommerce-v2.3.1-27\catalog\ext\flot jquery.colorhelpers.min.js	LF
osCommerce-v2.3.1-27\catalog\ext\flot jquery.flot.crosshair.js   Space
osCommerce-v2.3.1-27\catalog\ext\flot jquery.flot.crosshair.min.js	LF
osCommerce-v2.3.1-27\catalog\ext\flot jquery.flot.image.js   Space
osCommerce-v2.3.1-27\catalog\ext\flot jquery.flot.image.min.js	LF
osCommerce-v2.3.1-27\catalog\ext\flot jquery.flot.js   Space
osCommerce-v2.3.1-27\catalog\ext\flot jquery.flot.min.js	LF
osCommerce-v2.3.1-27\catalog\ext\flot jquery.flot.navigate.js   Space
osCommerce-v2.3.1-27\catalog\ext\flot jquery.flot.navigate.min.js	LF
osCommerce-v2.3.1-27\catalog\ext\flot jquery.flot.selection.js   Space
osCommerce-v2.3.1-27\catalog\ext\flot jquery.flot.selection.min.js	LF
osCommerce-v2.3.1-27\catalog\ext\flot jquery.flot.stack.js   Space
osCommerce-v2.3.1-27\catalog\ext\flot jquery.flot.stack.min.js	LF
osCommerce-v2.3.1-27\catalog\ext\flot jquery.flot.threshold.js   Space
osCommerce-v2.3.1-27\catalog\ext\flot jquery.flot.threshold.min.js	LF
osCommerce-v2.3.1-27\catalog\ext\jquery\bxGallery jquery.bxGallery.1.1.min.js	LF
osCommerce-v2.3.1-27\catalog\ext\jquery\fancybox jquery.easing-1.3.pack.js   Space
osCommerce-v2.3.1-27\catalog\ext\jquery\fancybox jquery.fancybox-1.3.4.css DOS\Windows/UTF-8 Tabs Space LF
osCommerce-v2.3.1-27\catalog\ext\jquery\fancybox jquery.fancybox-1.3.4.pack.js   Space LF
osCommerce-v2.3.1-27\catalog\ext\jquery\fancybox jquery.mousewheel-3.0.4.pack.js	LF
osCommerce-v2.3.1-27\catalog\ext\jquery\ui jquery-ui-1.8.6.min.js  Tabs  LF
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-af.js UNIX/UTF-8 (with BOM) Tabs
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-ar.js UNIX/UTF-8 (with BOM) Tabs  LF
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-az.js UNIX/UTF-8 (with BOM) Tabs  LF
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-bg.js UNIX/UTF-8 (with BOM) Tabs
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-bs.js UNIX/UTF-8 (with BOM) Tabs Space LF
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-ca.js  Tabs  LF
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-cs.js UNIX/UTF-8 (with BOM) Tabs
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-da.js UNIX/UTF-8 (with BOM) Tabs
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-de.js UNIX/UTF-8 (with BOM) Tabs
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-el.js UNIX/UTF-8 (with BOM) Tabs  LF
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-en-GB.js UNIX/UTF-8 (with BOM) Tabs
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-eo.js UNIX/UTF-8 (with BOM) Tabs
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-es.js  Tabs  LF
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-et.js UNIX/UTF-8 (with BOM) Tabs Space LF
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-eu.js UNIX/UTF-8 (with BOM) Tabs  LF
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-fa.js UNIX/UTF-8 (with BOM) Tabs  LF
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-fi.js  Tabs
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-fo.js UNIX/UTF-8 (with BOM) Tabs
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-fr.js UNIX/UTF-8 (with BOM) Tabs  LF
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-fr-CH.js UNIX/UTF-8 (with BOM) Tabs  LF
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-gl.js  Tabs  LF
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-he.js UNIX/UTF-8 (with BOM) Tabs
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-hr.js UNIX/UTF-8 (with BOM) Tabs  LF
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-hu.js  Tabs
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-hy.js  Tabs  LF
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-id.js  Tabs  LF
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-is.js  Tabs  LF
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-it.js  Tabs
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-ja.js UNIX/UTF-8 (with BOM) Tabs  LF
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-ko.js  Tabs  LF
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-kz.js  Tabs
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-lt.js  Tabs  LF
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-lv.js  Tabs  LF
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-ms.js  Tabs  LF
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-nl.js UNIX/UTF-8 (with BOM) Tabs  LF
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-no.js  Tabs
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-pl.js  Tabs
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-pt.js  Tabs  LF
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-pt-BR.js  Tabs  LF
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-ro.js UNIX/UTF-8 (with BOM) Tabs
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-ru.js  Tabs  LF
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-sk.js  Tabs
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-sl.js  Tabs
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-sq.js UNIX/UTF-8 (with BOM) Tabs
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-sr.js UNIX/UTF-8 (with BOM) Tabs
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-sr-SR.js UNIX/UTF-8 (with BOM) Tabs
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-sv.js UNIX/UTF-8 (with BOM) Tabs
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-ta.js UNIX/UTF-8 (with BOM) (x) Tabs
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-th.js UNIX/UTF-8 (with BOM)(x) Tabs  LF
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-tr.js  Tabs  LF
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-uk.js  Tabs  LF
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-vi.js UNIX/UTF-8 (with BOM) Tabs
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-zh-CN.js  Tabs
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-zh-HK.js  Tabs
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-zh-TW.js UNIX/UTF-8 (with BOM) Tabs
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\redmond jquery-ui-1.8.6.css  Tabs Space LF
osCommerce-v2.3.1-27\catalog\ext\modules\payment\inpay inpay_functions.php DOS\Windows/UTF-8 Tabs Space
osCommerce-v2.3.1-27\catalog\ext\modules\payment\inpay pb_handler.php DOS\Windows/UTF-8 Tabs Space
osCommerce-v2.3.1-27\catalog\ext\modules\payment\sofortueberweisung callback.php UNIX/ANSI  
osCommerce-v2.3.1-27\catalog\images .htaccess	LF
osCommerce-v2.3.1-27\catalog\includes general.js   Space
osCommerce-v2.3.1-27\catalog\includes version.php	LF
osCommerce-v2.3.1-27\catalog\includes\classes cc_validation.php	LF
osCommerce-v2.3.1-27\catalog\includes\classes http_client.php   Space LF
osCommerce-v2.3.1-27\catalog\includes\classes mime.php   Space
osCommerce-v2.3.1-27\catalog\includes\classes order.php  Tabs
osCommerce-v2.3.1-27\catalog\includes\classes order_total.php	LF
osCommerce-v2.3.1-27\catalog\includes\classes passwordhash.php  Tabs
osCommerce-v2.3.1-27\catalog\includes\classes payment.php   Space
osCommerce-v2.3.1-27\catalog\includes\classes shopping_cart.php   Space
osCommerce-v2.3.1-27\catalog\includes\functions compatibility.php	LF
osCommerce-v2.3.1-27\catalog\includes\functions database.php   Space
osCommerce-v2.3.1-27\catalog\includes\functions general.php   Space
osCommerce-v2.3.1-27\catalog\includes\functions password_funcs.php	LF
osCommerce-v2.3.1-27\catalog\includes\functions specials.php	LF
osCommerce-v2.3.1-27\catalog\includes\functions validations.php	LF
osCommerce-v2.3.1-27\catalog\includes\languages\english account.php	LF
osCommerce-v2.3.1-27\catalog\includes\languages\english checkout_process.php	LF
osCommerce-v2.3.1-27\catalog\includes\languages\english checkout_success.php	LF
osCommerce-v2.3.1-27\catalog\includes\languages\english conditions.php	LF
osCommerce-v2.3.1-27\catalog\includes\languages\english contact_us.php	LF
osCommerce-v2.3.1-27\catalog\includes\languages\english info_shopping_cart.php	LF
osCommerce-v2.3.1-27\catalog\includes\languages\english password_forgotten.php	LF
osCommerce-v2.3.1-27\catalog\includes\languages\english privacy.php	LF
osCommerce-v2.3.1-27\catalog\includes\languages\english product_reviews.php	LF
osCommerce-v2.3.1-27\catalog\includes\languages\english product_reviews_info.php	LF
osCommerce-v2.3.1-27\catalog\includes\languages\english products_new.php	LF
osCommerce-v2.3.1-27\catalog\includes\languages\english reviews.php	LF
osCommerce-v2.3.1-27\catalog\includes\languages\english shipping.php	LF
osCommerce-v2.3.1-27\catalog\includes\languages\english shopping_cart.php	LF
osCommerce-v2.3.1-27\catalog\includes\languages\english\modules\order_total ot_loworderfee.php	LF
osCommerce-v2.3.1-27\catalog\includes\languages\english\modules\order_total ot_shipping.php	LF
osCommerce-v2.3.1-27\catalog\includes\languages\english\modules\order_total ot_subtotal.php	LF
osCommerce-v2.3.1-27\catalog\includes\languages\english\modules\order_total ot_tax.php	LF
osCommerce-v2.3.1-27\catalog\includes\languages\english\modules\order_total ot_total.php	LF
osCommerce-v2.3.1-27\catalog\includes\languages\english\modules\payment cod.php	LF
osCommerce-v2.3.1-27\catalog\includes\languages\english\modules\payment inpay.php DOS\Windows/UTF-8 Tabs Space LF
osCommerce-v2.3.1-27\catalog\includes\languages\english\modules\payment pm2checkout.php	LF
osCommerce-v2.3.1-27\catalog\includes\languages\english\modules\payment psigate.php	LF
osCommerce-v2.3.1-27\catalog\includes\languages\english\modules\payment sofortueberweisung_direct.php UNIX/ANSI  
osCommerce-v2.3.1-27\catalog\includes\modules\boxes bm_currencies.php   Space
osCommerce-v2.3.1-27\catalog\includes\modules\header_tags\ht_mailchimp_360 mc360.php   Space
osCommerce-v2.3.1-27\catalog\includes\modules\header_tags\ht_mailchimp_360 MCAPI.class.php  Tabs Space LF
osCommerce-v2.3.1-27\catalog\includes\modules\payment authorizenet_cc_aim.php   Space
osCommerce-v2.3.1-27\catalog\includes\modules\payment inpay.php DOS\Windows/UTF-8 Tabs Space
osCommerce-v2.3.1-27\catalog\includes\modules\payment ipayment_cc.php   Space
osCommerce-v2.3.1-27\catalog\includes\modules\payment moneyorder.php   Space
osCommerce-v2.3.1-27\catalog\includes\modules\payment paypal_express.php   Space
osCommerce-v2.3.1-27\catalog\includes\modules\payment pm2checkout.php   Space
osCommerce-v2.3.1-27\catalog\includes\modules\payment psigate.php   Space
osCommerce-v2.3.1-27\catalog\includes\modules\payment sage_pay_direct.php   Space
osCommerce-v2.3.1-27\catalog\includes\modules\payment sofortueberweisung_direct.php UNIX/ANSI Tabs
osCommerce-v2.3.1-27\catalog\includes\modules\shipping usps.php  Tabs
osCommerce-v2.3.1-27\catalog\includes\modules\shipping zones.php   Space
osCommerce-v2.3.1-27\catalog\install\ext\niftycorners nifty.js	LF
osCommerce-v2.3.1-27\catalog\install\ext\niftycorners niftyCorners.css	LF
osCommerce-v2.3.1-27\catalog\install\includes\functions general.php	LF
osCommerce-v2.3.1-27\catalog\install\templates\pages install_4.php	LF
osCommerce-v2.3.1-27\catalog\pub .htaccess	LF (-)
osCommerce-v2.3.1-27\extras update-20060817.txt   Space
osCommerce-v2.3.1-27\extras upgrade-22rc1.html UNIX/Windows-1252 (x)  
osCommerce-v2.3.1-27\extras upgrade-22rc2a.html   Space


#2 acidvertigo

  • Community Member
  • 140 posts
  • Real Name:Luca
  • Gender:Male
  • Location:Roma

Posted 27 December 2011, 18:57

I have the same problem when uploading to github oscommerce 2 because I' m using Aptana editor on windows. I find this plugin for eclipse to convert linefeeds and tab to spaces http://andrei.gmxhome.de/anyedit/index.html Anyedit I don't know if it can help.

Edited by acidvertigo, 27 December 2011, 18:58.


#3 emikeu

  • Community Member
  • 14 posts
  • Real Name:Emile

Posted 27 December 2011, 23:08

For sure there isn't much difference between the official release and the github (oscsparky (mark evans)) version (whitch I think it's a better version?). Therefore I have not looked and can't be sure about the official release. But some files I do have compared show the same coding tabs spaces LF etc.

#4 acidvertigo

  • Community Member
  • 140 posts
  • Real Name:Luca
  • Gender:Male
  • Location:Roma

Posted 28 December 2011, 07:34

Yes, github version has some bug fixes resolved

Edited by acidvertigo, 28 December 2011, 07:35.


#5 acidvertigo

  • Community Member
  • 140 posts
  • Real Name:Luca
  • Gender:Male
  • Location:Roma

Posted 28 December 2011, 11:01

I convertd all my github repository to UNIX space and converted tabs to spaces with anyupdate. You can check here: https://github.com/acidvertigo/oscommerce2/commit/608f1e61f718a203eb7f386b2f4d35192d503c7d

#6 acidvertigo

  • Community Member
  • 140 posts
  • Real Name:Luca
  • Gender:Male
  • Location:Roma

Posted 28 December 2011, 11:50

Opss i have done also for javascripts broking the code. Here the new commit https://github.com/acidvertigo/oscommerce2/commit/9baa0e40d1971754aa01d9a6f9e73415e138e57e

#7 emikeu

  • Community Member
  • 14 posts
  • Real Name:Emile

Posted 30 December 2011, 12:28

One file can be changed to UTF-8 by simply edit the third line and change the encoding to utf-8:
osCommerce-v2.3.1-27\extras upgrade-22rc1.html

Two files are probably corrupted, but to be really sure someone has to check them with a text editor or rewrite the files:

osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-ta.js
osCommerce-v2.3.1-27\catalog\ext\jquery\ui\i18n jquery.ui.datepicker-th.js
(this also applies to the latest jquery package (1.8.16) then also check: jquery.ui.datepicker-ml.js and jquery-ui-i18n.js)

#8 emikeu

  • Community Member
  • 14 posts
  • Real Name:Emile

Posted 31 December 2011, 13:50

I was a little hasty.

I use Notepad++, while I also tested Notepad, Bluefish, Geany.
While NPP struggles with the ta and th datepickers bluefish and Geany only struggles with the th datepicker.

I have now tested the file currencies.php.
Converted it to utf-8 while in ANSI, now the file is changed for good.
What I had to do was change the coding to utf-8, than replace the Thai symbol with the utf-8 value
Now I save close reopen and NPP shows the correct encoding .
(I guess that also counts for the datepicker files)

Is it a fault from NPP recognising the file as ANSI?

#9 acidvertigo

  • Community Member
  • 140 posts
  • Real Name:Luca
  • Gender:Male
  • Location:Roma

Posted 02 January 2012, 18:35

I think is a NPP issue... on Github jquery UI the file looks ok https://github.com/jquery/jquery-ui/blob/master/ui/i18n/jquery.ui.datepicker-th.js Also in aptana the same. I tried to open it with npp but it says that is in ANSI

#10 emikeu

  • Community Member
  • 14 posts
  • Real Name:Emile

Posted 02 January 2012, 18:52

Yes, I'm now convinced that NPP has a problem with thai malay and tamil characters. NPP shows the right characters if you change the encoding to utf-8.
And than you can also safe the file, nothing bad will happen.

The following file is thus UTF-8 encoded (not ANSI)

osCommerce-v2.3.1-27\catalog\admin currencies.php

#11 acidvertigo

  • Community Member
  • 140 posts
  • Real Name:Luca
  • Gender:Male
  • Location:Roma

Posted 02 January 2012, 19:00

I think that this is another npp fail, my version is encoded well https://github.com/acidvertigo/oscommerce2/blob/master/catalog/admin/currencies.php

#12 emikeu

  • Community Member
  • 14 posts
  • Real Name:Emile

Posted 02 January 2012, 21:53

Maybe I was not clear enough

The file currencies.php, that comes with the oscommerce package, is utf-8 encoded (nothing has to bechanged).



(currencies.php contains a thai character, so NPP showed it as ANSI encoded)