258 replies to this topic

[kymation]

This appears to be a bug in a Wish List addon. It has nothing to do with the PDF Datasheet. I suggest you ask in the support forum for the Wish List addon that you used.

Regards
Jim

[herbsandhelpers]

I have thank you.

There's also a problem with the images if I have Description module installed then for some products the image shows fine and PDF but for others get this error message:

Notice: getimagesize() url="http://s381732156.websitehome.co.uk/23435676shop/function.getimagesize"]function.getimagesize: Read error! in shop/includes/modules/pdf_datasheet/pd_description.php on line 54

TCPDF ERROR: Unable to get image: images/

Very strange! Looked in database and Product area in Admin can't see a difference in those that work and those that don't.

Lorraine

Edited by herbsandhelpers, 28 April 2013 - 06:11 PM.

[kymation]

Do you have a large image uploaded for all of your products? Check the products_images table for the products that are getting the error message.

Regards
Jim

[herbsandhelpers]

This is what I can't understand. For the products I tested I made sure that all settings were the same in Products info in Admin and in products_images in database. They had large images each ... So weird!

This doesn't work:

     row(s) starting from record #  
in                  horizontal                 horizontal (rotated headers)                 vertical              mode and repeat headers after  cells    [img]https://phpmyadmin.1and1.co.uk/themes/1und1/img/s_fulltext.png[/img] id products_id image htmlcontent sort_order [img]https://phpmyadmin.1and1.co.uk/themes/1und1/img/b_edit.png[/img] [img]https://phpmyadmin.1and1.co.uk/themes/1und1/img/b_drop.png[/img] 1004 1057 TEAPIC.jpg NULL 0
  [img]https://phpmyadmin.1and1.co.uk/themes/1und1/img/arrow_ltr.png[/img] Check All  /  Uncheck All   With selected: [img]https://phpmyadmin.1and1.co.uk/themes/1und1/img/b_edit.png[/img] [img]https://phpmyadmin.1and1.co.uk/themes/1und1/img/b_drop.png[/img] [img]https://phpmyadmin.1and1.co.uk/themes/1und1/img/b_tblexport.png[/img]



Products Image:
Main Image (100 x 80px)
TEAPIC.jpg |

• Large Image
  
  TEAPIC.jpg
  
  HTML Content (for popup)

This does:

     row(s) starting from record #  
in                  horizontal                 horizontal (rotated headers)                 vertical              mode and repeat headers after  cells    [img]https://phpmyadmin.1and1.co.uk/themes/1und1/img/s_fulltext.png[/img] id products_id image htmlcontent sort_order [img]https://phpmyadmin.1and1.co.uk/themes/1und1/img/b_edit.png[/img] [img]https://phpmyadmin.1and1.co.uk/themes/1und1/img/b_drop.png[/img] 21 601 BMLOGOWEB.jpg 1   [img]https://phpmyadmin.1and1.co.uk/themes/1und1/img/arrow_ltr.png[/img] Check All  /  Uncheck All   With selected: [img]https://phpmyadmin.1and1.co.uk/themes/1und1/img/b_edit.png[/img] [img]https://phpmyadmin.1and1.co.uk/themes/1und1/img/b_drop.png[/img] [img]https://phpmyadmin.1and1.co.uk/themes/1und1/img/b_tblexport.png[/img]


Main Image (100 x 80px)
BMLOGOWEB.jpg |

• Large Image
  
  BMLOGOWEB.jpg
  
  HTML Content (for popup)

Spot the difference!?!?!

Lorraine

[kymation]

Your images are returning an authorization error so I can't check them directly. It appears that your small image and large image are the same, which is always a bad idea. However, that should not cause an error in the PDF Datasheet code. Did you check that the images actually exist on the server and can be retrieved by a web browser?

Edit: I just spotted it: The image that does not work has a sort_order of 0. The sort_order must be 1 for this image to work.

Regards
Jim

Edited by kymation, 28 April 2013 - 07:56 PM.

[herbsandhelpers]

Fixed! It worked! I just changed the sort order as you suggested and away it goes!

Just the wishlist array thing to go!

Where is the Product Specifications add on? If I install as a module still says it's not there ...

Thanks!

Lorraine

[herbsandhelpers]

Found it! Saw it in your add ons list!

Doooh!

[herbsandhelpers]

Wish List Work Around:

Okay I've got this to work by un-installing the wishlist box and creating a new link to the Wish List in account.php

This allows PDF datasheet to work and maintains the Wish List function. The only drawback is no nice display as a box. Not a coder best I can do ....

Lorraine

[herbsandhelpers]

Formatting Description: in PDF data sheet all my product descriptions are rendering as one block of text all the <br> spacing and bold lost. I've got Echo Tabs installed. However is there a way to influence how the Description displays?

I've successfully altered the Product Link using inline CSS. However can't work out what to do on Description wouldn't mind just ul tags. Would rather not have to install Product Specifications as well is there another way?

Lorraine

[kymation]

The Description module attempts to render HTML in the product description. The rendering engine is rather simple, so it will break if the HTML is too complex, invalid, or relies on external CSS. I suggest checking for valid HTML first.

Regards
Jim

[herbsandhelpers]

Okay the HTML within the div is rather simple mainly <br>, <b>, <i> etc. with closing tags. However the div is calling the button CSS so maybe that's why it fails ...

Where is the page text rendered in the footer please. I'd like to alter it. Also I'm getting half a line on last page.

Thanks for your quick responses.

Lorraine

[kymation]

The buttons should be outside the description so they wouldn't make a difference. Do you have a link so I could look at the page?

The footer is automatically generated by the TCPDF library. It's possible to override the header and footer, but I didn't write a module to do that since it's really complex and most people wouldn't use it.

There is no orphan/widow control, so a single line on the second page is quite possible. There's no fix for that.

Regards
Jim

[herbsandhelpers]

Sorry for development my test site is locked off however here is the description:

<div id="tabs">
			<ul>
			<li><a href="#tabs-0">Description</a></li>
			</ul>
			<div id="tabs-0">
			<b>TOTAL TRACEABILITY AND STOCK MANAGEMENT AUTOMATICALLY AS YOU WORK!<br />
			<br />
			PRACTICE MANAGEMENT TOOL FOR HERBALISTS, NATUROPATHS, ETC.</b><br />
			<br />
			<i>'Everything you need to do as a herbalist should be covered'</i><br />
			<br />
			<b>NEW RELEASE! - New features:</b><br />
			<br />
			There are sooooooooo many new features that have been added the best thing is to just try it! You can read about it here:<br />
			<br />
			Goes to Batch Master Support Centre click 'Batch Master Support Forum'. <a href="/batchmaster/" target="_blank"><u>Click here to go to the Batch Master Support Forum and read about latest release</u>.</a><br />
			<br />
			<b>Installation:</b><br />
			<br />
			On Windows Vista, Windows 7 and Windows 8 opens/runs from the desktop shortcut once you have set this to 'Run as Administrator' <br />
			<br />
			On Windows XP use the shortcut on the Batch Master PRO program menu to open. You can right click, copy and paste this onto your desktop if you prefer.<br />
			<br />
			&#9679; New Update released Batch Master PRO Heaven:<br />
			<br />
			&#9679; A new installer means one click starts the installation and cleans up after, leaving Batch Master PRO ready to use after RESTART. Installation can take 10-15 minutes in total to complete.<br />
			<br />
			&#9679; Batch Master PRO works fully on Windows XP, Windows Vista, Windows 7 and Windows 8 from standard user accounts. On first time use right click Batch Master PRO desktop shortcut and set to 'Run as Administrator' for Windows Vista, Windows 7 and Windows 8, this stops 'Cannot create a file when that file already exists error' and ensures Batch Master PRO always opens from desktop shortcut from now on. On Windows XP use the shortcut on the Batch Master PRO program menu to open. You can right click, copy and paste this onto your desktop if you prefer.<br />
			<br />
			&#9679; On Windows Vista, Windows 7 and Windows 8 you may need to allow Batch Master PRO permission using your anti virus and firewall programs, but not always.<br />
			<br />
			&#9679; No Microsoft Office or Access needed unless you want to export contact data to Microsoft Outlook. Batch Master PRO is compatible with all Office and Access applications that you may have installed.<br />
			<br />
			&#9679; Context sensitive, screenshot rich Help File (Press F1 anytime in Batch Master PRO) or use the Online Batch Master support centre 24/7.<br />
			<br />
			<b>INSTRUCTIONS:</b>(Follow this procedure carefully!)<br />
			<br />
			<b>1)</b> At the end of the order process, scroll down and press the blue DOWNLOAD button. When the dialog box appears choose Save. Save to a location on your computer e.g. Desktop, My Documents etc.<br />
			<br />
			<b>2)</b> Please TURN YOUR FIREWALL OFF for installation ONLY, reactivate on reboot! Please note some firewalls may stop installation giving a Code 5, Access is denied, Windows error, permissions error. Batch Master installation files have been scanned using Kaspersky 2012 Internet Security, please scan again using your own anti-virus if you prefer. After restart/reboot Batch Master PRO should run okay with firewall activated, give it permission if needed.<br />
			<br />
			<b>3)</b> Locate and double click the BatchMaster.exe installation file (can take a couple of minutes to start running) and follow on screen prompts, installation takes about 10-15 minutes to complete. Wait for the Updates to install at the end of installation before REBOOTING/RESTARTING your computer, it can take 5-10 minutes after main install finished before updates finish installing and you see updates complete notice.<br />
			<br />
			<b>4)</b> Once your computer has restarted. Batch Master PRO should now be ready to use. Windows Vista, Windows 7 and Windows 8 users right click desktop shortcut and set to 'Run as Administrator' (In Vista click Properties then Advanced, check/tick Run as Administrator box, click OK and Apply). On Windows XP use the shortcut on the Batch Master PRO program menu to open. You can right click, copy and paste this onto your desktop if you prefer. The best way to set up is follow the Ten Simple Setup Steps, once complete you're ready to go. Press F1 for help at anytime. (If you prefer you can use Herbs and Helpers set up service listed in shop.) <br />
			<br />
			<b>5)</b> If you get any problems then go into the Batch Master PRO programs menu (Click Start then All programs) and press Verify Runtime Installation, allow it to finish. Then press Verify Updates Installation and let it finish. No need to restart after. Help on all the above in README and INSTALL notices during installation. <br />
			<br />
			PLEASE NOTE: You should also REGISTER in the Batch Master Support Centre on this site for further free updates, installation support etc. This is the latest version of Batch Master PRO. <br />
			<br />
			If you are a previous Batch Master customer then you will need to do a complete uninstall and reinstall first. DON'T FORGET TO MAKE A FEW SAFE COPIES OF YOUR DATA FILE FIRST! Before you uninstall your current version get a <b>Removal Code</b> so you can re-license for free.<br />
			<br />
			<b>FEATURE LIST</b><br />
			<br />
			You can read about Batch Master PRO here: <a href="/Pages/batchmaster.htm" target="_blank"><u>Click here to go to the Batch Master features pages and read ALL about it</u>.</a> </div>
			</div>

[kymation]

I tried that on my test site, and I'm getting encoding errors on the spaces at the beginning of most of the lines. Check that your editor is set up to use UTF8, or just delete the indents.

Regards
Jim

[herbsandhelpers]

Thanks ill try that. It displays fine on Product Info page also goes through to PDF data sheet okay BUT all formatting lost comes out as a one solid block!

[herbsandhelpers]

I'm going to have to leave it. Nothing I try helps ...

[herbsandhelpers]

Scratch that! I've fixed it! All I've got to do is clear any white space (spare line) and put a couple <br> in! This restores all the line breaks. Just a lot of work...

All done!

Lorraine

[kymation]

Sounds like encoding errors. That can mess up more than just the PDF, although the PDF library is particularly sensitive to anything that is not UTF-8. Glad to hear that you got it figured out.

Regards
Jim

[srirahandcraft]

Hi Jim,

I've installed the following addon:

http://addons.oscommerce.com/info/8560/v,23 (Protected images for osc2.3.3

Now I'm trying to get the pdf-datasheet to be compatible with this addon.
I think, I'm quite far in the right direction but as I'm not a coder, I'm not sure wether this is correct,
I checked the new image route, this is correct, but I still get the following error message:

TCPDF ERROR: [Image] Unable to get image: images/1

The changed code is as follows:

function execute() {
global $PHP_SELF, $pdf, $products_id, $languages_id, $currencies, $current_y, $image_folder;

if( basename( $PHP_SELF ) == 'pdf_datasheet.php' && isset( $products_id ) && $products_id > 0 ) {
// Get the product name
$product_info_query_raw = "
select
pd.products_description,
pi.image,
p.image_folder,
p.image_display
from
" . TABLE_PRODUCTS . " p ,
" . TABLE_PRODUCTS_DESCRIPTION . " pd left join
" . TABLE_PRODUCTS_IMAGES . " pi
on (pi.products_id = pd.products_id
and pi.sort_order = '1')
where
pd.products_id = '" . $products_id . "'
and pd.language_id = '" . ( int )$languages_id . "'
";
$product_info_query = tep_db_query( $product_info_query_raw );
$product_info = tep_db_fetch_array( $product_info_query );

// BOF Protected Images for osCommerce 2.3.3
$image_size = '';
if ($product_info['image_display'] == 1) { // use "No Picture Available" image
$image_size = tep_image(DIR_WS_LANGUAGES . $language . '/images/' . 'no_picture.gif', TEXT_NO_PICTURE, SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT, 'hspace="5" vspace="5" style="float: right;"');
} elseif (($product_info['image_display'] != 2) && (tep_not_null($product_info['image']))) { // show product images
// EOF Protected Images for osCommerce 2.3.3

// Get the image information
$image_size = getimagesize(DIR_WS_IMAGES_PROD . $product_info['image_folder'] . $product_info['image']);

I probably need to change more files, but I tried this one as a start.

I hope you've got some time to help me out,
Thanks,

Gerhard