Jump to content



Photo
- - - - -

[Addon] PDF Datasheet

2.3.1 pdf

  • Please log in to reply
354 replies to this topic

#341   masterpiece

masterpiece
  • Members
  • 17 posts
  • Real Name:Dustin
  • Gender:Male

Posted 03 April 2014 - 13:06

Hi Jim,

I have update the language file in the directory but there will come a bunch of errors. When is solved the other errors there come more errors. So unfortunately i have to decide to delete the PDF datasheet from our server. To much time to edit all errors.

If you have a clean module for OSC 2.3 please let us know

Sorry for now

#342   kymation

kymation

    Code Monkey

  • Community Sponsor
  • 8,756 posts
  • Real Name:Jim Keebaugh
  • Gender:Male
  • Location:Aberdeen WA USA

Posted 03 April 2014 - 15:26

This addon is clean. The errors are in other additions that you have made. Clean up your own mess first.

Regards
Jim

My Addons

Banners Box 2.3+ Support
Categories Accordion Box 2.3+ Support
Closest Shipper 2.2x Support
Document Manager 2.2x Support
Generic Box 2.3+ Support
Get 1 Free 2.2x & 2.3.x & BS Support Bootstrapped
Modular Front Page 2.3+ Support
Modular SEO Header Tags 2.3+ Support
Multi-Vendor Shipping (MVS) 2.2x & 2.3.x Support
PDF Datasheet 2.3+ Support
Price in Cart Only / MAPP 2.3+ Support
Price Updater 2.2x
Products Specifications 2.3.x Development Version Support Bugs/Suggestions
Request a Review All Versions Support
Shopping List 2.3+ Support !
Specials Image Overlay 2.3+ Support
Superfish Categories Box 2.3+ & BS Support Bootstrapped
Theme Switcher 2.3+ & BS Support  Bootstrapped


#343   joli1811

joli1811

    Anybody seen this leprechaun say yeah !!

  • Community Sponsor
  • 2,384 posts
  • Real Name:john dunlop
  • Gender:Male
  • Location:Ireland

Posted 09 September 2014 - 23:45

Hi Jim,

 

Yes, I forgot to mention that the current version of TCPDF has the language files in the wrong place. Sorry about that.

The PDF library is incredibly picky. You cannot have any PHP errors, not even warnings, or it will flake out. If you have added something that has errors, you have to go fix all of those first. It's a pain, but at least you get rid of all those errors that shouldn't be in the code anyway.

Regards
Jim

 

 

installed 2.3.4 working great but is indeed picky noticed one real  error

 

 

I had to create a directory called cache in public_html/ext/tcpdf/cache/


[07-Sep-2014 05:59:07 America/New_York] PHP Warning:  imagepng() [<a href='function.imagepng'>function.imagepng</a>]: Unable to open '/home/xxxx/public_html/xxx/ext/tcpdf/cache/__tcpdf_imgmask_alpha_7a3b12971cd0a899c65b8777882e8544' for writing: No such file or directory in /home/xxxx/public_html/xxxx/ext/tcpdf/tcpdf.php on line 7333

few errors with info manager this post of yours solved

post #5

http://forums.oscommerce.com/topic/358471-notice-undefined-variable-child-information-error/

/public_html/xxx/includes/modules/boxes/bm_information.php on line ?

Plus had a few scrolling boxes which I had to  change as they were giving errors but better ones available

 

It really is a bug hunter :D had a few language defines duplicated and it picked up right away

 

Working great now

 

Thanks

 

John


Edited by joli1811, 09 September 2014 - 23:49.

To improve is to change; to be perfect is to change often.

#344   kymation

kymation

    Code Monkey

  • Community Sponsor
  • 8,756 posts
  • Real Name:Jim Keebaugh
  • Gender:Male
  • Location:Aberdeen WA USA

Posted 09 September 2014 - 23:50

The cache directory used to be in the TCPDF package as well. That's one more thing I need to mention.

 

At least you got rid of all those ugly bugs. As you said, this is a good thing.

 

Regards

Jim


My Addons

Banners Box 2.3+ Support
Categories Accordion Box 2.3+ Support
Closest Shipper 2.2x Support
Document Manager 2.2x Support
Generic Box 2.3+ Support
Get 1 Free 2.2x & 2.3.x & BS Support Bootstrapped
Modular Front Page 2.3+ Support
Modular SEO Header Tags 2.3+ Support
Multi-Vendor Shipping (MVS) 2.2x & 2.3.x Support
PDF Datasheet 2.3+ Support
Price in Cart Only / MAPP 2.3+ Support
Price Updater 2.2x
Products Specifications 2.3.x Development Version Support Bugs/Suggestions
Request a Review All Versions Support
Shopping List 2.3+ Support !
Specials Image Overlay 2.3+ Support
Superfish Categories Box 2.3+ & BS Support Bootstrapped
Theme Switcher 2.3+ & BS Support  Bootstrapped


#345   joli1811

joli1811

    Anybody seen this leprechaun say yeah !!

  • Community Sponsor
  • 2,384 posts
  • Real Name:john dunlop
  • Gender:Male
  • Location:Ireland

Posted 10 September 2014 - 13:14

Found another mini bug may be useful for other users who do not have error reporting turned on products with specials price

[10-Sep-2014 08:19:52 America/New_York] PHP Notice:  Use of undefined constant TEXT_YOU_SAVE - assumed 'TEXT_YOU_SAVE' in /home/xxxx/public_html/includes/modules/pdf_datasheet/pd_image_price.php on line 265
[10-Sep-2014 08:19:52 America/New_York] PHP Notice:  Use of undefined constant TEXT_SALE_PRICE - assumed 'TEXT_SALE_PRICE' in /home/xxxx/public_html/includes/modules/pdf_datasheet/pd_image_price.php on line 284

just add to catalog/includes/languages/english.php

define('TEXT_SALE_PRICE', 'Price: ');
define('TEXT_YOU_SAVE', 'Special Price You Save:');

Regards

John


To improve is to change; to be perfect is to change often.

#346   kymation

kymation

    Code Monkey

  • Community Sponsor
  • 8,756 posts
  • Real Name:Jim Keebaugh
  • Gender:Male
  • Location:Aberdeen WA USA

Posted 10 September 2014 - 15:31

Thanks for the bug report. I'll add those defines to the master.

 

Regards

Jim


My Addons

Banners Box 2.3+ Support
Categories Accordion Box 2.3+ Support
Closest Shipper 2.2x Support
Document Manager 2.2x Support
Generic Box 2.3+ Support
Get 1 Free 2.2x & 2.3.x & BS Support Bootstrapped
Modular Front Page 2.3+ Support
Modular SEO Header Tags 2.3+ Support
Multi-Vendor Shipping (MVS) 2.2x & 2.3.x Support
PDF Datasheet 2.3+ Support
Price in Cart Only / MAPP 2.3+ Support
Price Updater 2.2x
Products Specifications 2.3.x Development Version Support Bugs/Suggestions
Request a Review All Versions Support
Shopping List 2.3+ Support !
Specials Image Overlay 2.3+ Support
Superfish Categories Box 2.3+ & BS Support Bootstrapped
Theme Switcher 2.3+ & BS Support  Bootstrapped


#347   joli1811

joli1811

    Anybody seen this leprechaun say yeah !!

  • Community Sponsor
  • 2,384 posts
  • Real Name:john dunlop
  • Gender:Male
  • Location:Ireland

Posted 01 November 2014 - 08:01

Hi Jim

 

Getting a few errors from site lock with their SQL Injection Scan

 

18 in all coming from pdf_datasheet.php

 

to do with products_id=XXX

URL:http://www.xxxxxx.com/pdf_datasheet.php?products_id=101&language=english
Description:Injection point: GET; Injection parameter: products_id; Injection type: stringsingle 

Any ideas

 

Regards

Joli


Edited by joli1811, 01 November 2014 - 08:01.

To improve is to change; to be perfect is to change often.

#348   joli1811

joli1811

    Anybody seen this leprechaun say yeah !!

  • Community Sponsor
  • 2,384 posts
  • Real Name:john dunlop
  • Gender:Male
  • Location:Ireland

Posted 01 November 2014 - 08:32

been putting (int)  everywhere I see ...... (int)$_GET['products_id']

 

but as always not really sure what I a doing haha (w00t)

 

Regards

Joli


To improve is to change; to be perfect is to change often.

#349   joli1811

joli1811

    Anybody seen this leprechaun say yeah !!

  • Community Sponsor
  • 2,384 posts
  • Real Name:john dunlop
  • Gender:Male
  • Location:Ireland

Posted 01 November 2014 - 09:53

Hi Jim

 

got rid of the  https://secure.sitelock.com/dashboard/   (errors SQL Injection Scan) by adding (int) in a few places

 

of course not sure if correct but must have done something right 

 

because the errors are gone and site has passed the scan test

 

and even better the PDF is still working fine :D

 

attached is the file you can take a look sometime and correct if needed

 

Regards

Joli

 

 

Attached Files


To improve is to change; to be perfect is to change often.

#350   kymation

kymation

    Code Monkey

  • Community Sponsor
  • 8,756 posts
  • Real Name:Jim Keebaugh
  • Gender:Male
  • Location:Aberdeen WA USA

Posted 01 November 2014 - 17:07

@joli1811  Thanks for the code. I'll take a lok at this as soon as I can get the time.

 

Regards

Jim


My Addons

Banners Box 2.3+ Support
Categories Accordion Box 2.3+ Support
Closest Shipper 2.2x Support
Document Manager 2.2x Support
Generic Box 2.3+ Support
Get 1 Free 2.2x & 2.3.x & BS Support Bootstrapped
Modular Front Page 2.3+ Support
Modular SEO Header Tags 2.3+ Support
Multi-Vendor Shipping (MVS) 2.2x & 2.3.x Support
PDF Datasheet 2.3+ Support
Price in Cart Only / MAPP 2.3+ Support
Price Updater 2.2x
Products Specifications 2.3.x Development Version Support Bugs/Suggestions
Request a Review All Versions Support
Shopping List 2.3+ Support !
Specials Image Overlay 2.3+ Support
Superfish Categories Box 2.3+ & BS Support Bootstrapped
Theme Switcher 2.3+ & BS Support  Bootstrapped


#351   joli1811

joli1811

    Anybody seen this leprechaun say yeah !!

  • Community Sponsor
  • 2,384 posts
  • Real Name:john dunlop
  • Gender:Male
  • Location:Ireland

Posted 05 November 2014 - 22:56

/includes/functions/information.php is not a part of the PDF Datasheet or of stock osCommerce. It must be something else you've added. Try the support thread for that Addon, or ask in the general support forum.

Regards
Jim

 

For any one using information pages unlimited together with PDF Datasheet

 

attached is the include/functions/information.php  .

 

The file should correct any errors when they are used together

 

Regards

Joli

Attached Files


To improve is to change; to be perfect is to change often.

#352   herbsandhelpers

herbsandhelpers
  • Members
  • 105 posts
  • Real Name:Lorraine Hodgkinson
  • Gender:Female

Posted 23 February 2015 - 22:45

Can anyone suggest a fix for this? Tried in the Wish List 3.0 forum with no success. If I remove the Wish List box both PDF datasheet and Wish List work well however I need to have the Wishlist box ...

Fatal error: Call to a member function count_contents() on a non-object in /homepages/xx/xxxx/htdocs/clickandbuilds/xxxxx/xxxx/xxxx/includes/modules/boxes/bm_wishlist.php on line 37

Thanks again,

 

Lorraine



#353   kymation

kymation

    Code Monkey

  • Community Sponsor
  • 8,756 posts
  • Real Name:Jim Keebaugh
  • Gender:Male
  • Location:Aberdeen WA USA

Posted 23 February 2015 - 23:22

That's really a problem with your Wishlist install and not this one. I would start by checking that this code got added to application_top.php per the instructions:

// wishlist data
  if(!tep_session_is_registered('wishList')) {
  	tep_session_register('wishList');
  	$wishList = new wishlist;
  }

Regards

Jim


My Addons

Banners Box 2.3+ Support
Categories Accordion Box 2.3+ Support
Closest Shipper 2.2x Support
Document Manager 2.2x Support
Generic Box 2.3+ Support
Get 1 Free 2.2x & 2.3.x & BS Support Bootstrapped
Modular Front Page 2.3+ Support
Modular SEO Header Tags 2.3+ Support
Multi-Vendor Shipping (MVS) 2.2x & 2.3.x Support
PDF Datasheet 2.3+ Support
Price in Cart Only / MAPP 2.3+ Support
Price Updater 2.2x
Products Specifications 2.3.x Development Version Support Bugs/Suggestions
Request a Review All Versions Support
Shopping List 2.3+ Support !
Specials Image Overlay 2.3+ Support
Superfish Categories Box 2.3+ & BS Support Bootstrapped
Theme Switcher 2.3+ & BS Support  Bootstrapped


#354   herbsandhelpers

herbsandhelpers
  • Members
  • 105 posts
  • Real Name:Lorraine Hodgkinson
  • Gender:Female

Posted 24 February 2015 - 16:51

Hi Jim,

 

Thanks again, yeap triple yep I've checked this and reuploaded my application_top.php and everything is the exactly the same the error message as above. If I remove the wishlist box PDF datasheet works fine and account link to wishlist but I need the box ... I think I'll have to remove PDF datasheet sadly ...

 

Lorraine



#355   kymation

kymation

    Code Monkey

  • Community Sponsor
  • 8,756 posts
  • Real Name:Jim Keebaugh
  • Gender:Male
  • Location:Aberdeen WA USA

Posted 24 February 2015 - 18:53

The PDF datasheet addon has nothing to do with this problem. It's just telling you that you have an error in your Wishlist addon. Errors are always displayed in the PDF since the PDF generator is sensitive to error messages.

 

Regards

Jim


My Addons

Banners Box 2.3+ Support
Categories Accordion Box 2.3+ Support
Closest Shipper 2.2x Support
Document Manager 2.2x Support
Generic Box 2.3+ Support
Get 1 Free 2.2x & 2.3.x & BS Support Bootstrapped
Modular Front Page 2.3+ Support
Modular SEO Header Tags 2.3+ Support
Multi-Vendor Shipping (MVS) 2.2x & 2.3.x Support
PDF Datasheet 2.3+ Support
Price in Cart Only / MAPP 2.3+ Support
Price Updater 2.2x
Products Specifications 2.3.x Development Version Support Bugs/Suggestions
Request a Review All Versions Support
Shopping List 2.3+ Support !
Specials Image Overlay 2.3+ Support
Superfish Categories Box 2.3+ & BS Support Bootstrapped
Theme Switcher 2.3+ & BS Support  Bootstrapped