kymation, on 02 October 2011, 01:43, said:
Sorry it took me so long to get to this. I've made a few minor changes to the instructions, plus I moved the install SQL into the module's install method to avoid having to manually modify the database. Please test this out and see what you think. It works on my test server, but I've never been able to see the language bug, so yours is clearly different.
Here's the file.
Regards
Jim
Hi Jim,
no problem. Thanks. This will work. Two constant parameter missing.
I inserted plus defines for test working into execute() function and works without SQL errors.
} else {
define('MAX_DISPLAY_BANNER_ROTATOR', 4);
define('BANNER_ORDER', 5);
//banner rotator
It would be appreciate to insert these parameters into database install. I don1t do it because if others like to use the same banner rotator JS code in modular frontpage or header footer modules can be conflict. I think we have to rename this constant names before.
MAX_DISPLAY_BANNER_ROTATOR to
MODULE_BOXES_BANNER_ROTATOR_MAX_DISPLAY
BANNER_ORDER to
MODULE_BOXES_BANNER_ROTATOR_ORDER
This prevents conflicts with other modules and can set in module box by admin configurations.
Regards,
Gergely
Edited by Gergely, 02 October 2011, 14:08.